208511 2020-03-03 06:26:52 -0800 [GTK][WPE] Use restore view icon for exit fullscreen button in media controls 2020-03-04 00:56:22 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply calvaris eric.carlson ews-watchlist glenn jer.noble joepeck philipj sergio oldest_to_newest 1625026 0 cgarcia 2020-03-03 06:26:52 -0800 We currently use view fullscreen for both entering and leaving. 1625027 1 392269 cgarcia 2020-03-03 06:28:30 -0800 Created attachment 392269 Patch 1625449 2 cgarcia 2020-03-04 00:56:22 -0800 Committed r257837: <https://trac.webkit.org/changeset/257837> 392269 2020-03-03 06:28:30 -0800 2020-03-03 07:53:56 -0800 Patch wk-media-controls-exit-fullscreen.diff text/plain 5455 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NGFjODEwMTE5OTMuLmJlNzVmYzUwMzhhMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE5IEBACisyMDIwLTAzLTAzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIFVzZSByZXN0b3JlIHZpZXcgaWNvbiBm b3IgZXhpdCBmdWxsc2NyZWVuIGJ1dHRvbiBpbiBtZWRpYSBjb250cm9scworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4NTExCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgY3VycmVudGx5IHVzZSB2aWV3 IGZ1bGxzY3JlZW4gZm9yIGJvdGggZW50ZXJpbmcgYW5kIGxlYXZpbmcuCisKKyAgICAgICAgKiBN b2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Fkd2FpdGEuY3NzOgorICAgICAgICAo dmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtZnVsbHNjcmVlbi1idXR0b24uZXhpdCk6Cisg ICAgICAgIChhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1mdWxsc2NyZWVuLWJ1dHRvbiwp OiBEZWxldGVkLgorICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtZnVsbHNj cmVlbi1idXR0b24uaGlkZGVuLCk6IERlbGV0ZWQuCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNv bnRyb2xzL21lZGlhQ29udHJvbHNBZHdhaXRhLmpzOgorICAgICAgICAoQ29udHJvbGxlci5wcm90 b3R5cGUuaGFuZGxlRnVsbHNjcmVlbkNoYW5nZSk6CisKIDIwMjAtMDMtMDMgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFVzZSAtd2Vi a2l0LXN5c3RlbS1mb250IGluc3RlYWQgb2YgLXdlYmtpdC1zbWFsbC1jb250cm9sIGluIG1lZGlh IGNvbnRyb2xzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJv bHMvbWVkaWFDb250cm9sc0Fkd2FpdGEuY3NzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YWNvbnRyb2xzL21lZGlhQ29udHJvbHNBZHdhaXRhLmNzcwppbmRleCAxZjdiOGM3NjU3MWMuLjVi YjQxOWE1M2ViMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRy b2xzL21lZGlhQ29udHJvbHNBZHdhaXRhLmNzcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Fkd2FpdGEuY3NzCkBAIC00MTEsNyArNDExLDYg QEAgdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtY2xvc2VkLWNhcHRpb25zLWNvbnRhaW5l ciBsaS5zZWxlY3RlZCB7CiAgICAgYmFja2dyb3VuZC1jb2xvcjogcmdiYSgyMzAsIDIzMCwgMjMw LCAwLjE1KTsKIH0KIAotYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtZnVsbHNjcmVlbi1i dXR0b24sCiB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1mdWxsc2NyZWVuLWJ1dHRvbiB7 CiAgICAgZGlzcGxheTogZmxleDsKICAgICBmbGV4OiBub25lOwpAQCAtNDM4LDcgKzQzNywxOSBA QCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1mdWxsc2NyZWVuLWJ1dHRvbiB7CiAgICAg ICAgIDwvc3ZnPiIpOwogfQogCi1hdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1mdWxsc2Ny ZWVuLWJ1dHRvbi5oaWRkZW4sCit2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1mdWxsc2Ny ZWVuLWJ1dHRvbi5leGl0IHsKKyAgICBiYWNrZ3JvdW5kLWltYWdlOiB1cmwoImRhdGE6aW1hZ2Uv c3ZnK3htbDt1dGYtOCwgXAorICAgICAgICA8c3ZnIHhtbG5zPSdodHRwOi8vd3d3LnczLm9yZy8y MDAwL3N2Zycgd2lkdGg9JzE2LjAxNCcgaGVpZ2h0PScxNi4wMSc+IFwKKyAgICAgICAgICA8ZyBj b2xvcj0nIzAwMCcgZmlsbD0nI0ZGRkZGRic+IFwKKyAgICAgICAgICAgIDxwYXRoIGQ9J00xMiAx LjAwNmwtMiAuMDA4LjAxOCA0Ljk5NkgxNXYtMmgtMi45OXonIHN0eWxlPSdsaW5lLWhlaWdodDpu b3JtYWw7Zm9udC12YXJpYW50LWxpZ2F0dXJlczpub3JtYWw7Zm9udC12YXJpYW50LXBvc2l0aW9u Om5vcm1hbDtmb250LXZhcmlhbnQtY2Fwczpub3JtYWw7Zm9udC12YXJpYW50LW51bWVyaWM6bm9y bWFsO2ZvbnQtdmFyaWFudC1hbHRlcm5hdGVzOm5vcm1hbDtmb250LWZlYXR1cmUtc2V0dGluZ3M6 bm9ybWFsO3RleHQtaW5kZW50OjA7dGV4dC1hbGlnbjpzdGFydDt0ZXh0LWRlY29yYXRpb24tbGlu ZTpub25lO3RleHQtZGVjb3JhdGlvbi1zdHlsZTpzb2xpZDt0ZXh0LWRlY29yYXRpb24tY29sb3I6 IzAwMDt0ZXh0LXRyYW5zZm9ybTpub25lO3RleHQtb3JpZW50YXRpb246bWl4ZWQ7c2hhcGUtcGFk ZGluZzowO2lzb2xhdGlvbjphdXRvO21peC1ibGVuZC1tb2RlOm5vcm1hbDttYXJrZXI6bm9uZScg Zm9udC13ZWlnaHQ9JzQwMCcgZm9udC1mYW1pbHk9J3NhbnMtc2VyaWYnIHdoaXRlLXNwYWNlPSdu b3JtYWwnIG92ZXJmbG93PSd2aXNpYmxlJy8+IFwKKyAgICAgICAgICAgIDxwYXRoIGQ9J00xNC45 NzkgMGExIDEgMCAwIDAtLjY4OC4zMDVsLTMuOTg0IDRhMSAxIDAgMSAwIDEuNDE2IDEuNDFsMy45 ODYtNEExIDEgMCAwIDAgMTQuOTc5IDB6TTEuMDE0IDYuMDFhMSAxIDAgMCAwLTEgMXY4YTEgMSAw IDAgMCAxIDFoOGExIDEgMCAwIDAgMS0xdi04YTEgMSAwIDAgMC0xLTF6bTEgMmg2djZoLTZ6JyBz dHlsZT0nbGluZS1oZWlnaHQ6bm9ybWFsO2ZvbnQtdmFyaWFudC1saWdhdHVyZXM6bm9ybWFsO2Zv bnQtdmFyaWFudC1wb3NpdGlvbjpub3JtYWw7Zm9udC12YXJpYW50LWNhcHM6bm9ybWFsO2ZvbnQt dmFyaWFudC1udW1lcmljOm5vcm1hbDtmb250LXZhcmlhbnQtYWx0ZXJuYXRlczpub3JtYWw7Zm9u dC1mZWF0dXJlLXNldHRpbmdzOm5vcm1hbDt0ZXh0LWluZGVudDowO3RleHQtYWxpZ246c3RhcnQ7 dGV4dC1kZWNvcmF0aW9uLWxpbmU6bm9uZTt0ZXh0LWRlY29yYXRpb24tc3R5bGU6c29saWQ7dGV4 dC1kZWNvcmF0aW9uLWNvbG9yOiMwMDA7dGV4dC10cmFuc2Zvcm06bm9uZTt0ZXh0LW9yaWVudGF0 aW9uOm1peGVkO3NoYXBlLXBhZGRpbmc6MDtpc29sYXRpb246YXV0bzttaXgtYmxlbmQtbW9kZTpu b3JtYWw7bWFya2VyOm5vbmUnIGZvbnQtd2VpZ2h0PSc0MDAnIGZvbnQtZmFtaWx5PSdzYW5zLXNl cmlmJyB3aGl0ZS1zcGFjZT0nbm9ybWFsJyBvdmVyZmxvdz0ndmlzaWJsZScvPiBcCisgICAgICAg ICAgICA8cGF0aCBkPSdNMS4wMTQgOC4wMWExIDEgMCAxIDAgMCAyaDhhMSAxIDAgMSAwIDAtMnon IHN0eWxlPSdsaW5lLWhlaWdodDpub3JtYWw7Zm9udC12YXJpYW50LWxpZ2F0dXJlczpub3JtYWw7 Zm9udC12YXJpYW50LXBvc2l0aW9uOm5vcm1hbDtmb250LXZhcmlhbnQtY2Fwczpub3JtYWw7Zm9u dC12YXJpYW50LW51bWVyaWM6bm9ybWFsO2ZvbnQtdmFyaWFudC1hbHRlcm5hdGVzOm5vcm1hbDtm b250LWZlYXR1cmUtc2V0dGluZ3M6bm9ybWFsO3RleHQtaW5kZW50OjA7dGV4dC1hbGlnbjpzdGFy dDt0ZXh0LWRlY29yYXRpb24tbGluZTpub25lO3RleHQtZGVjb3JhdGlvbi1zdHlsZTpzb2xpZDt0 ZXh0LWRlY29yYXRpb24tY29sb3I6IzAwMDt0ZXh0LXRyYW5zZm9ybTpub25lO3RleHQtb3JpZW50 YXRpb246bWl4ZWQ7c2hhcGUtcGFkZGluZzowO2lzb2xhdGlvbjphdXRvO21peC1ibGVuZC1tb2Rl Om5vcm1hbDttYXJrZXI6bm9uZScgZm9udC13ZWlnaHQ9JzQwMCcgZm9udC1mYW1pbHk9J3NhbnMt c2VyaWYnIHdoaXRlLXNwYWNlPSdub3JtYWwnIG92ZXJmbG93PSd2aXNpYmxlJyBmaWxsLXJ1bGU9 J2V2ZW5vZGQnLz4gXAorICAgICAgICAgICAgPHBhdGggZD0nTTE1IDUuMDFoMXYxaC0xek0xMCAu MDFoMXYxaC0xek05LjAxNCAxNS4wMWgxdjFoLTF6TS4wMTQgMTUuMDFoMXYxaC0xeicgc3R5bGU9 J21hcmtlcjpub25lJyBvdmVyZmxvdz0ndmlzaWJsZScvPiBcCisgICAgICAgICAgICA8cGF0aCBk PSdNMTEgLjAxYy41NTQgMCAxIC40NDYgMSAxcy0uNDQ2IDEtMSAxLTEtLjQ0Ni0xLTEgLjQ0Ni0x IDEtMXpNMTUgNC4wMWMuNTU0IDAgMSAuNDQ2IDEgMXMtLjQ0NiAxLTEgMS0xLS40NDYtMS0xIC40 NDYtMSAxLTF6JyBzdHlsZT0nbWFya2VyOm5vbmUnIG92ZXJmbG93PSd2aXNpYmxlJy8+IFwKKyAg ICAgICAgICA8L2c+IFwKKyAgICAgICAgPC9zdmc+Iik7Cit9CisKIHZpZGVvOjotd2Via2l0LW1l ZGlhLWNvbnRyb2xzLWZ1bGxzY3JlZW4tYnV0dG9uLmhpZGRlbiB7CiAgICAgZGlzcGxheTogbm9u ZSAhaW1wb3J0YW50OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YWNvbnRyb2xzL21lZGlhQ29udHJvbHNBZHdhaXRhLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBZHdhaXRhLmpzCmluZGV4IDk5ZjNkZTVjNjdj Ny4uNGViMDNhOWJmN2Q2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh Y29udHJvbHMvbWVkaWFDb250cm9sc0Fkd2FpdGEuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBZHdhaXRhLmpzCkBAIC00OSw2ICs0OSw3 IEBAIENvbnRyb2xsZXIucHJvdG90eXBlID0gewogICAgIH0sCiAgICAgSGlkZUNvbnRyb2xzRGVs YXk6IDQgKiAxMDAwLAogICAgIENsYXNzTmFtZXM6IHsKKyAgICAgICAgZXhpdDogJ2V4aXQnLAog ICAgICAgICBoaWRkZW46ICdoaWRkZW4nLAogICAgICAgICBoaWRpbmc6ICdoaWRpbmcnLAogICAg ICAgICBtdXRlQm94OiAnbXV0ZS1ib3gnLApAQCAtNTY5LDkgKzU3MCwxMSBAQCBDb250cm9sbGVy LnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy51cGRhdGVDb250cm9scygpOwogCiAgICAgICAg IGlmICh0aGlzLmlzRnVsbFNjcmVlbigpKSB7CisgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLmZ1 bGxzY3JlZW5CdXR0b24uY2xhc3NMaXN0LmFkZCh0aGlzLkNsYXNzTmFtZXMuZXhpdCk7CiAgICAg ICAgICAgICB0aGlzLmNvbnRyb2xzLmZ1bGxzY3JlZW5CdXR0b24uc2V0QXR0cmlidXRlKCdhcmlh LWxhYmVsJywgJ0V4aXQgRnVsbCBTY3JlZW4nKTsKICAgICAgICAgICAgIHRoaXMuaG9zdC5lbnRl cmVkRnVsbHNjcmVlbigpOwogICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgdGhpcy5jb250 cm9scy5mdWxsc2NyZWVuQnV0dG9uLmNsYXNzTGlzdC5yZW1vdmUodGhpcy5DbGFzc05hbWVzLmV4 aXQpOwogICAgICAgICAgICAgdGhpcy5jb250cm9scy5mdWxsc2NyZWVuQnV0dG9uLnNldEF0dHJp YnV0ZSgnYXJpYS1sYWJlbCcsICdEaXNwbGF5IEZ1bGwgU2NyZWVuJyk7CiAgICAgICAgICAgICB0 aGlzLmhvc3QuZXhpdGVkRnVsbHNjcmVlbigpOwogICAgICAgICB9Cg==