208445 2020-03-02 05:56:32 -0800 Fix JSC 32bit alignment increase gcc warning 2020-03-02 11:47:19 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pmatos pmatos benjamin cdumez cmarcelo commit-queue ews-watchlist keith_miller mark.lam msaboff saam ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1624514 0 pmatos 2020-03-02 05:56:32 -0800 Fix JSC 32bit alignment increase gcc warning 1624515 1 392136 pmatos 2020-03-02 05:58:29 -0800 Created attachment 392136 Patch 1624531 2 392136 ticaiolima 2020-03-02 07:08:45 -0800 Comment on attachment 392136 Patch LGTM! 1624615 3 392136 ysuzuki 2020-03-02 11:01:27 -0800 Comment on attachment 392136 Patch r=me 1624648 4 392136 commit-queue 2020-03-02 11:47:00 -0800 Comment on attachment 392136 Patch Clearing flags on attachment: 392136 Committed r257721: <https://trac.webkit.org/changeset/257721> 1624649 5 commit-queue 2020-03-02 11:47:02 -0800 All reviewed patches have been landed. Closing bug. 1624650 6 webkit-bug-importer 2020-03-02 11:47:19 -0800 <rdar://problem/59960776> 392136 2020-03-02 05:58:29 -0800 2020-03-02 11:47:00 -0800 Patch bug-208445-20200302145828.patch text/plain 7172 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx ZDJmZjI2NmYyMTU5MzYzZTc4NmJkMWFhYzM5MjY1MDM2NDdiM2M3Li45Nzk5NWQ1YTRmN2E0Mzg0 ZTcyZDk5MjFlODQzMjNhZmE3YjIyZDdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wMy0wMiAgUGF1bG8gTWF0b3MgIDxwbWF0b3NAaWdhbGlhLmNvbT4K KworICAgICAgICBGaXggSlNDIDMyYml0IGFsaWdubWVudCBpbmNyZWFzZSBnY2Mgd2FybmluZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4NDQ1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHJlaW50 ZXJwcmV0X2Nhc3RfcHRyPD4oKSBpbnN0ZWFkIG9mIHJlaW50ZXJwcmV0X2Nhc3Q8PigpIHRvCisg ICAgICAgIGF2b2lkIEdDQyB3YXJuaW5nIGFib3V0IGluY3JlYXNlIGluIGFsaWdubWVudCByZXF1 aXJlbWVudCBmb3IgY2FzdAorICAgICAgICB0YXJnZXQgdHlwZS4KKworICAgICAgICAqIGRmZy9E RkdPU1JFeGl0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpPU1JFeGl0Ojpjb21waWxlRXhpdCk6 CisKIDIwMjAtMDMtMDEgIENoYXJsZXMgVHVybmVyICA8Y3R1cm5lckBpZ2FsaWEuY29tPgogCiAg ICAgICAgIHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYEpTQzo6RXhlY3V0YWJsZUJhc2U6Omhhc0pJ VENvZGVGb3JDYWxsKCkgY29uc3QnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBi L1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQ1MGMzN2UyZmE3MjNiMjRjOTBhYWYzZmMwYTU1 ZjQyMzBlNzdjZGIuLjFhODFhNTYwNzhjODkyMzk4ODIxYmI3Y2E1MGExNTEyZjA0MmZiOTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMjYgQEAKKzIwMjAtMDMtMDIgIFBhdWxvIE1hdG9zICA8cG1hdG9zQGlnYWxp YS5jb20+CisKKyAgICAgICAgRml4IEpTQyAzMmJpdCBhbGlnbm1lbnQgaW5jcmVhc2UgZ2NjIHdh cm5pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw ODQ0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVz ZSByZWludGVycHJldF9jYXN0X3B0cjw+KCkgaW5zdGVhZCBvZiByZWludGVycHJldF9jYXN0PD4o KSB0bworICAgICAgICBhdm9pZCBHQ0Mgd2FybmluZyBhYm91dCBpbmNyZWFzZSBpbiBhbGlnbm1l bnQgcmVxdWlyZW1lbnQgZm9yIGNhc3QKKyAgICAgICAgdGFyZ2V0IHR5cGUuCisKKyAgICAgICAg KiB3dGYvSGFzaFRhYmxlLmg6CisgICAgICAgIChXVEY6Okhhc2hUYWJsZTo6dGFibGVTaXplIGNv bnN0KToKKyAgICAgICAgKFdURjo6SGFzaFRhYmxlOjpzZXRUYWJsZVNpemUgY29uc3QpOgorICAg ICAgICAoV1RGOjpIYXNoVGFibGU6OnRhYmxlU2l6ZU1hc2sgY29uc3QpOgorICAgICAgICAoV1RG OjpIYXNoVGFibGU6OnNldFRhYmxlU2l6ZU1hc2spOgorICAgICAgICAoV1RGOjpIYXNoVGFibGU6 OmtleUNvdW50IGNvbnN0KToKKyAgICAgICAgKFdURjo6SGFzaFRhYmxlOjpzZXRLZXlDb3VudCBj b25zdCk6CisgICAgICAgIChXVEY6Okhhc2hUYWJsZTo6ZGVsZXRlZENvdW50IGNvbnN0KToKKyAg ICAgICAgKFdURjo6SGFzaFRhYmxlOjpzZXREZWxldGVkQ291bnQgY29uc3QpOgorICAgICAgICAo V1RGOjpLZXlUcmFpdHM+OjphbGxvY2F0ZVRhYmxlKToKKyAgICAgICAgKFdURjo6S2V5VHJhaXRz Pjo6ZGVhbGxvY2F0ZVRhYmxlKToKKwogMjAyMC0wMi0yOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1 a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBzdGQ6OmxvY2tfZ3VhcmQKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXQuY3BwCmluZGV4IDgzNGI2ODcwMTEzNTQwMzk5NmJk NzNjZWU2OGQwYjRhZDQwY2U1OTkuLjIzZWJlMGQ3YmM3OWVhNWE5OTZjMjA3MjA3ZjgyMzlhNmVm ZTVjZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0LmNwcApAQCAtNjUx LDcgKzY1MSw3IEBAIHZvaWQgT1NSRXhpdDo6Y29tcGlsZUV4aXQoQ0NhbGxIZWxwZXJzJiBqaXQs IFZNJiB2bSwgY29uc3QgT1NSRXhpdCYgZXhpdCwgY29uc3QKICAgICAgICAgICAgICAgICAgICAg Y29udGludWU7CiAKICAgICAgICAgICAgICAgICBhdXRvKiBpbmxpbmVDYWxsRnJhbWUgPSBjb2Rl T3JpZ2luLT5pbmxpbmVDYWxsRnJhbWUoKTsKLSAgICAgICAgICAgICAgICBhZGRTaWRlU3RhdGUo cmVpbnRlcnByZXRfY2FzdDxDYWxsRnJhbWUqPihyZWludGVycHJldF9jYXN0PGNoYXIqPihjYWxs RnJhbWUpICsgaW5saW5lQ2FsbEZyYW1lLT5yZXR1cm5QQ09mZnNldCgpIC0gc2l6ZW9mKENQVVJl Z2lzdGVyKSksIGNhbGxCeXRlY29kZUluZGV4LCBpbmxpbmVDYWxsRnJhbWUtPnRtcE9mZnNldCk7 CisgICAgICAgICAgICAgICAgYWRkU2lkZVN0YXRlKHJlaW50ZXJwcmV0X2Nhc3RfcHRyPENhbGxG cmFtZSo+KHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGNhbGxGcmFtZSkgKyBpbmxpbmVDYWxsRnJh bWUtPnJldHVyblBDT2Zmc2V0KCkgLSBzaXplb2YoQ1BVUmVnaXN0ZXIpKSwgY2FsbEJ5dGVjb2Rl SW5kZXgsIGlubGluZUNhbGxGcmFtZS0+dG1wT2Zmc2V0KTsKICAgICAgICAgICAgIH0KIAogICAg ICAgICAgICAgaWYgKCFjb2RlT3JpZ2luKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvSGFz aFRhYmxlLmggYi9Tb3VyY2UvV1RGL3d0Zi9IYXNoVGFibGUuaAppbmRleCBjZWIxNjJkZmJiZmVl ZWU1N2Q2MjUxMGE4YTczZGQ4MGI1NGJiYTQ4Li5kMjBkYzFiN2UwYzRkM2VkN2UyY2MzMDU3OWIx ZWRjOTFkYWNhNzgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoVGFibGUuaAorKysg Yi9Tb3VyY2UvV1RGL3d0Zi9IYXNoVGFibGUuaApAQCAtNTgwLDE0ICs1ODAsMTQgQEAgREVDTEFS RV9BTExPQ0FUT1JfV0lUSF9IRUFQX0lERU5USUZJRVIoSGFzaFRhYmxlKTsKICAgICAgICAgc3Rh dGljIGNvbnN0ZXhwciBpbnQgZGVsZXRlZENvdW50T2Zmc2V0ID0gLTQ7CiAgICAgICAgIHN0YXRp YyBjb25zdGV4cHIgdW5zaWduZWQgbWV0YWRhdGFTaXplID0gNCAqIHNpemVvZih1bnNpZ25lZCk7 CiAKLSAgICAgICAgdW5zaWduZWQgdGFibGVTaXplKCkgY29uc3QgeyByZXR1cm4gbV90YWJsZSA/ IHJlaW50ZXJwcmV0X2Nhc3Q8dW5zaWduZWQqPihtX3RhYmxlKVt0YWJsZVNpemVPZmZzZXRdIDog MDsgfQotICAgICAgICB2b2lkIHNldFRhYmxlU2l6ZSh1bnNpZ25lZCBzaXplKSBjb25zdCB7IEFT U0VSVChtX3RhYmxlKTsgcmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZCo+KG1fdGFibGUpW3RhYmxl U2l6ZU9mZnNldF0gPSBzaXplOyB9Ci0gICAgICAgIHVuc2lnbmVkIHRhYmxlU2l6ZU1hc2soKSBj b25zdCB7IEFTU0VSVChtX3RhYmxlKTsgcmV0dXJuIG1fdGFibGUgPyByZWludGVycHJldF9jYXN0 PHVuc2lnbmVkKj4obV90YWJsZSlbdGFibGVTaXplTWFza09mZnNldF0gOiAwOyB9Ci0gICAgICAg IHZvaWQgc2V0VGFibGVTaXplTWFzayh1bnNpZ25lZCBtYXNrKSB7IEFTU0VSVChtX3RhYmxlKTsg cmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZCo+KG1fdGFibGUpW3RhYmxlU2l6ZU1hc2tPZmZzZXRd ID0gbWFzazsgfQotICAgICAgICB1bnNpZ25lZCBrZXlDb3VudCgpIGNvbnN0IHsgcmV0dXJuIG1f dGFibGUgPyByZWludGVycHJldF9jYXN0PHVuc2lnbmVkKj4obV90YWJsZSlba2V5Q291bnRPZmZz ZXRdIDogMDsgfQotICAgICAgICB2b2lkIHNldEtleUNvdW50KHVuc2lnbmVkIGNvdW50KSBjb25z dCB7IEFTU0VSVChtX3RhYmxlKTsgcmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZCo+KG1fdGFibGUp W2tleUNvdW50T2Zmc2V0XSA9IGNvdW50OyB9Ci0gICAgICAgIHVuc2lnbmVkIGRlbGV0ZWRDb3Vu dCgpIGNvbnN0IHsgQVNTRVJUKG1fdGFibGUpOyByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDx1bnNp Z25lZCo+KG1fdGFibGUpW2RlbGV0ZWRDb3VudE9mZnNldF07IH0KLSAgICAgICAgdm9pZCBzZXRE ZWxldGVkQ291bnQodW5zaWduZWQgY291bnQpIGNvbnN0IHsgQVNTRVJUKG1fdGFibGUpOyByZWlu dGVycHJldF9jYXN0PHVuc2lnbmVkKj4obV90YWJsZSlbZGVsZXRlZENvdW50T2Zmc2V0XSA9IGNv dW50OyB9CisgICAgICAgIHVuc2lnbmVkIHRhYmxlU2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fdGFi bGUgPyByZWludGVycHJldF9jYXN0X3B0cjx1bnNpZ25lZCo+KG1fdGFibGUpW3RhYmxlU2l6ZU9m ZnNldF0gOiAwOyB9CisgICAgICAgIHZvaWQgc2V0VGFibGVTaXplKHVuc2lnbmVkIHNpemUpIGNv bnN0IHsgQVNTRVJUKG1fdGFibGUpOyByZWludGVycHJldF9jYXN0X3B0cjx1bnNpZ25lZCo+KG1f dGFibGUpW3RhYmxlU2l6ZU9mZnNldF0gPSBzaXplOyB9CisgICAgICAgIHVuc2lnbmVkIHRhYmxl U2l6ZU1hc2soKSBjb25zdCB7IEFTU0VSVChtX3RhYmxlKTsgcmV0dXJuIG1fdGFibGUgPyByZWlu dGVycHJldF9jYXN0X3B0cjx1bnNpZ25lZCo+KG1fdGFibGUpW3RhYmxlU2l6ZU1hc2tPZmZzZXRd IDogMDsgfQorICAgICAgICB2b2lkIHNldFRhYmxlU2l6ZU1hc2sodW5zaWduZWQgbWFzaykgeyBB U1NFUlQobV90YWJsZSk7IHJlaW50ZXJwcmV0X2Nhc3RfcHRyPHVuc2lnbmVkKj4obV90YWJsZSlb dGFibGVTaXplTWFza09mZnNldF0gPSBtYXNrOyB9CisgICAgICAgIHVuc2lnbmVkIGtleUNvdW50 KCkgY29uc3QgeyByZXR1cm4gbV90YWJsZSA/IHJlaW50ZXJwcmV0X2Nhc3RfcHRyPHVuc2lnbmVk Kj4obV90YWJsZSlba2V5Q291bnRPZmZzZXRdIDogMDsgfQorICAgICAgICB2b2lkIHNldEtleUNv dW50KHVuc2lnbmVkIGNvdW50KSBjb25zdCB7IEFTU0VSVChtX3RhYmxlKTsgcmVpbnRlcnByZXRf Y2FzdF9wdHI8dW5zaWduZWQqPihtX3RhYmxlKVtrZXlDb3VudE9mZnNldF0gPSBjb3VudDsgfQor ICAgICAgICB1bnNpZ25lZCBkZWxldGVkQ291bnQoKSBjb25zdCB7IEFTU0VSVChtX3RhYmxlKTsg cmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3RfcHRyPHVuc2lnbmVkKj4obV90YWJsZSlbZGVsZXRlZENv dW50T2Zmc2V0XTsgfQorICAgICAgICB2b2lkIHNldERlbGV0ZWRDb3VudCh1bnNpZ25lZCBjb3Vu dCkgY29uc3QgeyBBU1NFUlQobV90YWJsZSk7IHJlaW50ZXJwcmV0X2Nhc3RfcHRyPHVuc2lnbmVk Kj4obV90YWJsZSlbZGVsZXRlZENvdW50T2Zmc2V0XSA9IGNvdW50OyB9CiAKICAgICAgICAgVmFs dWVUeXBlKiBtX3RhYmxlIHsgbnVsbHB0ciB9OwogCkBAIC0xMjA3LDkgKzEyMDcsOSBAQCBERUNM QVJFX0FMTE9DQVRPUl9XSVRIX0hFQVBfSURFTlRJRklFUihIYXNoVGFibGUpOwogICAgICAgICAv LyB3b3VsZCB1c2UgYSB0ZW1wbGF0ZSBtZW1iZXIgZnVuY3Rpb24gd2l0aCBleHBsaWNpdCBzcGVj aWFsaXphdGlvbnMgaGVyZSwgYnV0CiAgICAgICAgIC8vIGdjYyBkb2Vzbid0IGFwcGVhciB0byBz dXBwb3J0IHRoYXQKICAgICAgICAgaWYgKFRyYWl0czo6ZW1wdHlWYWx1ZUlzWmVybykKLSAgICAg ICAgICAgIHJldHVybiByZWludGVycHJldF9jYXN0PFZhbHVlVHlwZSo+KHN0YXRpY19jYXN0PGNo YXIqPihIYXNoVGFibGVNYWxsb2M6Onplcm9lZE1hbGxvYyhtZXRhZGF0YVNpemUgKyBzaXplICog c2l6ZW9mKFZhbHVlVHlwZSkpKSArIG1ldGFkYXRhU2l6ZSk7CisgICAgICAgICAgICByZXR1cm4g cmVpbnRlcnByZXRfY2FzdF9wdHI8VmFsdWVUeXBlKj4oc3RhdGljX2Nhc3Q8Y2hhcio+KEhhc2hU YWJsZU1hbGxvYzo6emVyb2VkTWFsbG9jKG1ldGFkYXRhU2l6ZSArIHNpemUgKiBzaXplb2YoVmFs dWVUeXBlKSkpICsgbWV0YWRhdGFTaXplKTsKIAotICAgICAgICBWYWx1ZVR5cGUqIHJlc3VsdCA9 IHJlaW50ZXJwcmV0X2Nhc3Q8VmFsdWVUeXBlKj4oc3RhdGljX2Nhc3Q8Y2hhcio+KEhhc2hUYWJs ZU1hbGxvYzo6bWFsbG9jKG1ldGFkYXRhU2l6ZSArIHNpemUgKiBzaXplb2YoVmFsdWVUeXBlKSkp ICsgbWV0YWRhdGFTaXplKTsKKyAgICAgICAgVmFsdWVUeXBlKiByZXN1bHQgPSByZWludGVycHJl dF9jYXN0X3B0cjxWYWx1ZVR5cGUqPihzdGF0aWNfY2FzdDxjaGFyKj4oSGFzaFRhYmxlTWFsbG9j OjptYWxsb2MobWV0YWRhdGFTaXplICsgc2l6ZSAqIHNpemVvZihWYWx1ZVR5cGUpKSkgKyBtZXRh ZGF0YVNpemUpOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc2l6ZTsgaSsrKQog ICAgICAgICAgICAgaW5pdGlhbGl6ZUJ1Y2tldChyZXN1bHRbaV0pOwogICAgICAgICByZXR1cm4g cmVzdWx0OwpAQCAtMTIxOCw3ICsxMjE4LDcgQEAgREVDTEFSRV9BTExPQ0FUT1JfV0lUSF9IRUFQ X0lERU5USUZJRVIoSGFzaFRhYmxlKTsKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBLZXksIHR5cGVu YW1lIFZhbHVlLCB0eXBlbmFtZSBFeHRyYWN0b3IsIHR5cGVuYW1lIEhhc2hGdW5jdGlvbnMsIHR5 cGVuYW1lIFRyYWl0cywgdHlwZW5hbWUgS2V5VHJhaXRzPgogICAgIHZvaWQgSGFzaFRhYmxlPEtl eSwgVmFsdWUsIEV4dHJhY3RvciwgSGFzaEZ1bmN0aW9ucywgVHJhaXRzLCBLZXlUcmFpdHM+Ojpk ZWFsbG9jYXRlVGFibGUoVmFsdWVUeXBlKiB0YWJsZSkKICAgICB7Ci0gICAgICAgIHVuc2lnbmVk IHNpemUgPSByZWludGVycHJldF9jYXN0PHVuc2lnbmVkKj4odGFibGUpW3RhYmxlU2l6ZU9mZnNl dF07CisgICAgICAgIHVuc2lnbmVkIHNpemUgPSByZWludGVycHJldF9jYXN0X3B0cjx1bnNpZ25l ZCo+KHRhYmxlKVt0YWJsZVNpemVPZmZzZXRdOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAw OyBpIDwgc2l6ZTsgKytpKSB7CiAgICAgICAgICAgICBpZiAoIWlzRGVsZXRlZEJ1Y2tldCh0YWJs ZVtpXSkpCiAgICAgICAgICAgICAgICAgdGFibGVbaV0uflZhbHVlVHlwZSgpOwo=