208442 2020-03-02 04:20:52 -0800 [GTK][WPE] Fix current time and duration formatting in media controls 2020-03-03 07:28:27 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply calvaris eric.carlson ews-watchlist glenn jer.noble joepeck philipj sergio oldest_to_newest 1624496 0 cgarcia 2020-03-02 04:20:52 -0800 We are always using mm:ss for current time and duration. We should use different amount of digits depending on the duration: m:ss <- duration < 10 minutes mm:ss <- duration < 1 hour h:mm:ss <- duration < 10 hours hh:mm:ss <- duration >= 10 hours 1624497 1 392128 cgarcia 2020-03-02 04:25:47 -0800 Created attachment 392128 Patch 1624536 2 392128 calvaris 2020-03-02 07:24:27 -0800 Comment on attachment 392128 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392128&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:411 > + else if (duration < 10 * 60) /* Ten minutes */ > + this.timeDigitsCount = 3; I personally dislike having this on a time display. I would strongly recommend you remove this or run it thru more people who can give an opinion on this. 1624978 3 cgarcia 2020-03-03 01:12:06 -0800 (In reply to Xabier Rodríguez Calvar from comment #2) > Comment on attachment 392128 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392128&action=review > > > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:411 > > + else if (duration < 10 * 60) /* Ten minutes */ > > + this.timeDigitsCount = 3; > > I personally dislike having this on a time display. I would strongly > recommend you remove this or run it thru more people who can give an opinion > on this. What do you mean? You don't like m:ss and h:mm:ss? 1624993 4 calvaris 2020-03-03 03:48:07 -0800 (In reply to Carlos Garcia Campos from comment #3) > (In reply to Xabier Rodríguez Calvar from comment #2) > > Comment on attachment 392128 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=392128&action=review > > > > > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:411 > > > + else if (duration < 10 * 60) /* Ten minutes */ > > > + this.timeDigitsCount = 3; > > > > I personally dislike having this on a time display. I would strongly > > recommend you remove this or run it thru more people who can give an opinion > > on this. > > What do you mean? You don't like m:ss and h:mm:ss? I don't like m:ss but I don't mind h:mm:ss. That was the design choice and I don't see a reason why it should not be respected now as well. 1625000 5 cgarcia 2020-03-03 05:06:33 -0800 (In reply to Xabier Rodríguez Calvar from comment #4) > (In reply to Carlos Garcia Campos from comment #3) > > (In reply to Xabier Rodríguez Calvar from comment #2) > > > Comment on attachment 392128 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=392128&action=review > > > > > > > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:411 > > > > + else if (duration < 10 * 60) /* Ten minutes */ > > > > + this.timeDigitsCount = 3; > > > > > > I personally dislike having this on a time display. I would strongly > > > recommend you remove this or run it thru more people who can give an opinion > > > on this. > > > > What do you mean? You don't like m:ss and h:mm:ss? > > I don't like m:ss but I don't mind h:mm:ss. That was the design choice and I > don't see a reason why it should not be respected now as well. For consistency with other browsers, GNOME and some other popular video players. 1625040 6 cgarcia 2020-03-03 07:28:27 -0800 Committed r257778: <https://trac.webkit.org/changeset/257778> 392128 2020-03-02 04:25:47 -0800 2020-03-02 07:24:27 -0800 Patch wcore-media-controls-current-time.diff text/plain 3639 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZDc4NmU0MjY2ZC4uNjUyOWNjZTg0Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMC0wMy0wMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBGaXggY3VycmVudCB0aW1lIGFuZCBkdXJh dGlvbiBmb3JtYXR0aW5nIGluIG1lZGlhIGNvbnRyb2xzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg0NDIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBhcmUgYWx3YXlzIHVzaW5nIG1tOnNzIG9yIGho Om1tOnNzIGZvciBjdXJyZW50IHRpbWUgYW5kIGR1cmF0aW9uLiBXZSBzaG91bGQgdXNlIGRpZmZl cmVudCBhbW91bnQgb2YgZGlnaXRzCisgICAgICAgIGRlcGVuZGluZyBvbiB0aGUgZHVyYXRpb24g KG06c3MsIG1tOnNzLCBoOm1tOnNzIG9yIGhoOm1tOnNzKS4KKworICAgICAgICAqIE1vZHVsZXMv bWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQWR3YWl0YS5qczoKKyAgICAgICAgKENvbnRyb2xs ZXIucHJvdG90eXBlLnVwZGF0ZUR1cmF0aW9uKTogU2V0IHRoZSBhbW91bnQgb2YgZGlnaXRzIGZv ciBjdXJyZW50IGR1cmF0aW9uLgorICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUucHJlcGVu ZFplcm9JZk5lZWRlZCk6IEhlbHBlciB0byBwcmVwZW5kIDAgZm9yIHZhbHVlcyBsZXNzIHRoYW4g MTAuCisgICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS5mb3JtYXRUaW1lKTogRm9ybWF0IHRo ZSB0aW1lIGRlcGVuZGluZyBvbiB0aGUgbnVtYmVyIG9mIGRpZ2l0cyByZXF1aXJlZC4KKwogMjAy MC0wMy0wMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS11bV1BFXSBTdG9wIHVzaW5nIG1lZGlhQ29udHJvbHNCYXNlLmpzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Fk d2FpdGEuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250 cm9sc0Fkd2FpdGEuanMKaW5kZXggZTE4YzdlMjZmY2YuLjAxOTUxNjAwMTQ3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Fkd2Fp dGEuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29u dHJvbHNBZHdhaXRhLmpzCkBAIC00MDUsMjIgKzQwNSw0NCBAQCBDb250cm9sbGVyLnByb3RvdHlw ZSA9IHsKICAgICAgICAgdGhpcy5zZXRJc0xpdmUoZHVyYXRpb24gPT09IE51bWJlci5QT1NJVElW RV9JTkZJTklUWSk7CiAgICAgICAgIHRoaXMuY29udHJvbHMudGltZWxpbmUubWluID0gMDsKICAg ICAgICAgdGhpcy5jb250cm9scy50aW1lbGluZS5tYXggPSB0aGlzLmlzTGl2ZSA/IDAgOiBkdXJh dGlvbjsKKyAgICAgICAgaWYgKHRoaXMuaXNMaXZlIHx8IGlzTmFOKGR1cmF0aW9uKSkKKyAgICAg ICAgICAgIHRoaXMudGltZURpZ2l0c0NvdW50ID0gNDsKKyAgICAgICAgZWxzZSBpZiAoZHVyYXRp b24gPCAxMCAqIDYwKSAvKiBUZW4gbWludXRlcyAqLworICAgICAgICAgICAgdGhpcy50aW1lRGln aXRzQ291bnQgPSAzOworICAgICAgICBlbHNlIGlmIChkdXJhdGlvbiA8IDYwICogNjApIC8qIE9u ZSBob3VyICovCisgICAgICAgICAgICB0aGlzLnRpbWVEaWdpdHNDb3VudCA9IDQ7CisgICAgICAg IGVsc2UgaWYgKGR1cmF0aW9uIDwgMTAgKiA2MCAqIDYwKSAvKiBUZW4gaG91cnMgKi8KKyAgICAg ICAgICAgIHRoaXMudGltZURpZ2l0c0NvdW50ID0gNTsKKyAgICAgICAgZWxzZQorICAgICAgICAg ICAgdGhpcy50aW1lRGlnaXRzQ291bnQgPSA2OwogICAgIH0sCiAKICAgICBmb3JtYXRUaW1lOiBm dW5jdGlvbih0aW1lKQogICAgIHsKICAgICAgICAgaWYgKGlzTmFOKHRpbWUpKQotICAgICAgICAg ICAgdGltZSA9IDA7Ci0gICAgICAgIHZhciBhYnNUaW1lID0gTWF0aC5hYnModGltZSk7Ci0gICAg ICAgIHZhciBpbnRTZWNvbmRzID0gTWF0aC5mbG9vcihhYnNUaW1lICUgNjApLnRvRml4ZWQoMCk7 Ci0gICAgICAgIHZhciBpbnRNaW51dGVzID0gTWF0aC5mbG9vcigoYWJzVGltZSAvIDYwKSAlIDYw KS50b0ZpeGVkKDApOwotICAgICAgICB2YXIgaW50SG91cnMgPSBNYXRoLmZsb29yKGFic1RpbWUg LyAoNjAgKiA2MCkpLnRvRml4ZWQoMCk7Ci0gICAgICAgIHZhciBzaWduID0gdGltZSA8IDAgPyAn LScgOiBTdHJpbmcoKTsKKyAgICAgICAgICAgIHJldHVybiAnMDA6MDAnOworCisgICAgICAgIGNv bnN0IGFic1RpbWUgPSBNYXRoLmFicyh0aW1lKTsKKyAgICAgICAgY29uc3Qgc2Vjb25kcyA9IE1h dGguZmxvb3IoYWJzVGltZSAlIDYwKS50b0ZpeGVkKDApOworICAgICAgICBjb25zdCBtaW51dGVz ID0gTWF0aC5mbG9vcigoYWJzVGltZSAvIDYwKSAlIDYwKS50b0ZpeGVkKDApOworICAgICAgICBj b25zdCBob3VycyA9IE1hdGguZmxvb3IoYWJzVGltZSAvICg2MCAqIDYwKSkudG9GaXhlZCgwKTsK IAotICAgICAgICBpZiAoaW50SG91cnMgPiAwKQotICAgICAgICAgICAgcmV0dXJuIHNpZ24gKyBp bnRIb3VycyArICc6JyArIFN0cmluZygnMDAnICsgaW50TWludXRlcykuc2xpY2UoLTIpICsgIjoi ICsgU3RyaW5nKCcwMCcgKyBpbnRTZWNvbmRzKS5zbGljZSgtMik7CisgICAgICAgIGZ1bmN0aW9u IHByZXBlbmRaZXJvSWZOZWVkZWQodmFsdWUpIHsKKyAgICAgICAgICAgIGlmICh2YWx1ZSA8IDEw KQorICAgICAgICAgICAgICAgIHJldHVybiBgMCR7dmFsdWV9YDsKKyAgICAgICAgICAgIHJldHVy biBgJHt2YWx1ZX1gOworICAgICAgICB9CiAKLSAgICAgICAgcmV0dXJuIHNpZ24gKyBTdHJpbmco JzAwJyArIGludE1pbnV0ZXMpLnNsaWNlKC0yKSArICI6IiArIFN0cmluZygnMDAnICsgaW50U2Vj b25kcykuc2xpY2UoLTIpCisgICAgICAgIHN3aXRjaCAodGhpcy50aW1lRGlnaXRzQ291bnQpIHsK KyAgICAgICAgY2FzZSAzOgorICAgICAgICAgICAgcmV0dXJuIG1pbnV0ZXMgKyAnOicgKyBwcmVw ZW5kWmVyb0lmTmVlZGVkKHNlY29uZHMpOworICAgICAgICBjYXNlIDQ6CisgICAgICAgICAgICBy ZXR1cm4gcHJlcGVuZFplcm9JZk5lZWRlZChtaW51dGVzKSArICc6JyArIHByZXBlbmRaZXJvSWZO ZWVkZWQoc2Vjb25kcyk7CisgICAgICAgIGNhc2UgNToKKyAgICAgICAgICAgIHJldHVybiBob3Vy cyArICc6JyArIHByZXBlbmRaZXJvSWZOZWVkZWQobWludXRlcykgKyAnOicgKyBwcmVwZW5kWmVy b0lmTmVlZGVkKHNlY29uZHMpOworICAgICAgICBjYXNlIDY6CisgICAgICAgICAgICByZXR1cm4g cHJlcGVuZFplcm9JZk5lZWRlZChob3VycykgKyAnOicgKyBwcmVwZW5kWmVyb0lmTmVlZGVkKG1p bnV0ZXMpICsgJzonICsgcHJlcGVuZFplcm9JZk5lZWRlZChzZWNvbmRzKTsKKyAgICAgICAgfQog ICAgIH0sCiAKICAgICB1cGRhdGVUaW1lOiBmdW5jdGlvbihmb3JjZVVwZGF0ZSkK