20844 2008-09-14 16:40:04 -0700 Speed up parseInt for numbers 2008-09-14 18:10:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam webkit-unassigned oldest_to_newest 91151 0 sam 2008-09-14 16:40:04 -0700 If the global function parseInt is used to convert a double to an int (as it seems is done in the function(p,a,c,k,e,d) code packer), it is inefficient to convert the value to a string and then back to an integer. 91152 1 23425 sam 2008-09-14 16:41:50 -0700 Created attachment 23425 patch 91153 2 23425 zwarich 2008-09-14 16:44:07 -0700 Comment on attachment 23425 patch r=me 91162 3 sam 2008-09-14 18:10:38 -0700 Fixed in r36410. 23425 2008-09-14 16:41:50 -0700 2008-09-14 16:44:07 -0700 patch fasterParseInt.diff text/plain 1586 sam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM2NDA4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDkt MTQgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXRjaCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwODQ0CisgICAgICAgIFNwZWVkIHVwIHBhcnNlSW50IGZvciBu dW1iZXJzCisKKyAgICAgICAgU3Vuc3BpZGVyIHJlcG9ydHMgdGhpcyBhcyAxLjAyOXggYXMgZmFz dCBvdmVyYWxsIGFuZCAxLjM3eCBhcyBmYXN0IG9uIHN0cmluZy11bnBhY2stY29kZS4KKyAgICAg ICAgTm8gY2hhbmdlIG9uIHRoZSB2OCBzdWl0ZS4KKworICAgICAgICAqIGtqcy9KU0dsb2JhbE9i amVjdEZ1bmN0aW9ucy5jcHA6CisgICAgICAgIChKU0M6Omdsb2JhbEZ1bmNQYXJzZUludCk6IERv bid0IGNvbnZlcnQgbnVtYmVycyB0byBzdHJpbmdzIGp1c3QgdG8KKyAgICAgICAgY29udmVydCB0 aGVtIGJhY2sgdG8gbnVtYmVycy4KKwogMjAwOC0wOS0xNCAgQ2FtZXJvbiBad2FyaWNoICA8Y3d6 d2FyaWNoQHV3YXRlcmxvby5jYT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4K SW5kZXg6IGtqcy9KU0dsb2JhbE9iamVjdEZ1bmN0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2pz L0pTR2xvYmFsT2JqZWN0RnVuY3Rpb25zLmNwcAkocmV2aXNpb24gMzY0MDIpCisrKyBranMvSlNH bG9iYWxPYmplY3RGdW5jdGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTQsNyArMjk0LDEz IEBAIEpTVmFsdWUqIGdsb2JhbEZ1bmNFdmFsKEV4ZWNTdGF0ZSogZXhlYywKIAogSlNWYWx1ZSog Z2xvYmFsRnVuY1BhcnNlSW50KEV4ZWNTdGF0ZSogZXhlYywgSlNPYmplY3QqLCBKU1ZhbHVlKiwg Y29uc3QgQXJnTGlzdCYgYXJncykKIHsKLSAgICByZXR1cm4ganNOdW1iZXIoZXhlYywgcGFyc2VJ bnQoYXJncy5hdChleGVjLCAwKS0+dG9TdHJpbmcoZXhlYyksIGFyZ3MuYXQoZXhlYywgMSktPnRv SW50MzIoZXhlYykpKTsKKyAgICBKU1ZhbHVlKiB2YWx1ZSA9IGFyZ3MuYXQoZXhlYywgMCk7Cisg ICAgaW50MzJfdCByYWRpeCA9IGFyZ3MuYXQoZXhlYywgMSktPnRvSW50MzIoZXhlYyk7CisKKyAg ICBpZiAodmFsdWUtPmlzTnVtYmVyKCkgJiYgKHJhZGl4ID09IDAgfHwgcmFkaXggPT0gMTApKQor ICAgICAgICByZXR1cm4ganNOdW1iZXIoZXhlYywgdmFsdWUtPnRvSW50MzIoZXhlYykpOworCisg ICAgcmV0dXJuIGpzTnVtYmVyKGV4ZWMsIHBhcnNlSW50KHZhbHVlLT50b1N0cmluZyhleGVjKSwg cmFkaXgpKTsKIH0KIAogSlNWYWx1ZSogZ2xvYmFsRnVuY1BhcnNlRmxvYXQoRXhlY1N0YXRlKiBl eGVjLCBKU09iamVjdCosIEpTVmFsdWUqLCBjb25zdCBBcmdMaXN0JiBhcmdzKQo=