208439 2020-03-02 03:12:02 -0800 JSC 32bits broken in debug mode by r257399 2020-03-04 10:22:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 208048 1 pmatos pmatos clopez commit-queue ews-watchlist keith_miller mark.lam msaboff saam ticaiolima tzagallo webkit-bug-importer oldest_to_newest 1624483 0 pmatos 2020-03-02 03:12:02 -0800 Commit 257399 (bug 207522) breaks 32bit builds in debug mode due to assert calling JSC::JSValueRegs::gpr() ../../Source/JavaScriptCore/bytecode/AccessCase.cpp:1945:41: error: no matching function for call to ‘JSC::JSValueRegs::gpr()’ ASSERT(baseGPR != valueRegs.gpr()); 1624502 1 392131 pmatos 2020-03-02 04:49:38 -0800 Created attachment 392131 Patch 1624533 2 392131 ticaiolima 2020-03-02 07:15:38 -0800 Comment on attachment 392131 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392131&action=review LGTM > Source/JavaScriptCore/bytecode/AccessCase.cpp:1947 > + ASSERT(!valueRegs.uses(scratchGPR)); Nice catch. 1625469 3 pmatos 2020-03-04 02:51:46 -0800 ping! 1625607 4 392131 commit-queue 2020-03-04 10:21:54 -0800 Comment on attachment 392131 Patch Clearing flags on attachment: 392131 Committed r257856: <https://trac.webkit.org/changeset/257856> 1625608 5 commit-queue 2020-03-04 10:21:55 -0800 All reviewed patches have been landed. Closing bug. 1625609 6 webkit-bug-importer 2020-03-04 10:22:16 -0800 <rdar://problem/60045082> 392131 2020-03-02 04:49:38 -0800 2020-03-04 10:21:54 -0800 Patch bug-208439-20200302134937.patch text/plain 1794 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx ZDJmZjI2NmYyMTU5MzYzZTc4NmJkMWFhYzM5MjY1MDM2NDdiM2M3Li4xYjRmNjM3ZTNmMzZlZTcy YmRjNGEyNWRmNzE0MzQ3OWUyZTkyZmUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wMy0wMiAgUGF1bG8gTWF0b3MgIDxwbWF0b3NAaWdhbGlhLmNvbT4K KworICAgICAgICBKU0MgMzJiaXRzIGJyb2tlbiBpbiBkZWJ1ZyBtb2RlIGJ5IHIyNTczOTkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODQzOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB1c2VzKCkg bWV0aG9kIGNhbGwgaW5zdGVhZCBvZiBncHIoKSBvbiBhc3NlcnQgdG8gdGhhdCBpdAorICAgICAg ICB3b3JrcyBmb3IgYm90aCA2NCBhbmQgMzIgYml0cy4KKworICAgICAgICAqIGJ5dGVjb2RlL0Fj Y2Vzc0Nhc2UuY3BwOgorICAgICAgICAoSlNDOjpBY2Nlc3NDYXNlOjpnZW5lcmF0ZUltcGwpOgor CiAyMDIwLTAzLTAxICBDaGFybGVzIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KIAogICAg ICAgICB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBKU0M6OkV4ZWN1dGFibGVCYXNlOjpoYXNKSVRD b2RlRm9yQ2FsbCgpIGNvbnN0JwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL0FjY2Vzc0Nhc2UuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0Fj Y2Vzc0Nhc2UuY3BwCmluZGV4IDdjYWI5YzFiMDNiOTUzNmEwZWNlNzI3ZDZjNTEzNjIyN2FhYzg3 ZDAuLjExNGMyM2M1MjgzYjdiZDNhMGQ3MGJiY2Y0YjUyZWNiMTUyMWMxOGYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9BY2Nlc3NDYXNlLmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQWNjZXNzQ2FzZS5jcHAKQEAgLTE5NDIsOSArMTk0 Miw5IEBAIHZvaWQgQWNjZXNzQ2FzZTo6Z2VuZXJhdGVJbXBsKEFjY2Vzc0dlbmVyYXRpb25TdGF0 ZSYgc3RhdGUpCiAgICAgICAgIGFsbG9jYXRvci5sb2NrKHNjcmF0Y2hHUFIpOwogICAgICAgICBB U1NFUlQoc3RydWN0dXJlKCktPnRyYW5zaXRpb25XYXRjaHBvaW50U2V0SGFzQmVlbkludmFsaWRh dGVkKCkpOwogICAgICAgICBBU1NFUlQobmV3U3RydWN0dXJlKCktPmlzUHJvcGVydHlEZWxldGlv blRyYW5zaXRpb24oKSk7Ci0gICAgICAgIEFTU0VSVChiYXNlR1BSICE9IHZhbHVlUmVncy5ncHIo KSk7CiAgICAgICAgIEFTU0VSVChiYXNlR1BSICE9IHNjcmF0Y2hHUFIpOwotICAgICAgICBBU1NF UlQodmFsdWVSZWdzLmdwcigpICE9IHNjcmF0Y2hHUFIpOworICAgICAgICBBU1NFUlQoIXZhbHVl UmVncy51c2VzKGJhc2VHUFIpKTsKKyAgICAgICAgQVNTRVJUKCF2YWx1ZVJlZ3MudXNlcyhzY3Jh dGNoR1BSKSk7CiAKICAgICAgICAgU2NyYXRjaFJlZ2lzdGVyQWxsb2NhdG9yOjpQcmVzZXJ2ZWRT dGF0ZSBwcmVzZXJ2ZWRTdGF0ZSA9CiAgICAgICAgICAgICBhbGxvY2F0b3IucHJlc2VydmVSZXVz ZWRSZWdpc3RlcnNCeVB1c2hpbmcoaml0LCBTY3JhdGNoUmVnaXN0ZXJBbGxvY2F0b3I6OkV4dHJh U3RhY2tTcGFjZTo6Tm9FeHRyYVNwYWNlKTsK