208431 2020-03-01 13:42:31 -0800 Many tests in canvas and fast/canvas are asserting after r257677 2020-03-01 17:53:59 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh commit-queue dino sabouhallawa simon.fraser thorton webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1624409 0 wenson_hsieh 2020-03-01 13:42:31 -0800 :( 1624410 1 wenson_hsieh 2020-03-01 13:42:57 -0800 E.g. stderr: SHOULD NEVER BE REACHED /Volumes/Data/slave/ios-simulator-13-debug/build/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackend.cpp(83) : std::unique_ptr<ImageBuffer> WebKit::RemoteRenderingBackend::createImageBuffer(const WebCore::FloatSize &, WebCore::RenderingMode, float, WebCore::ColorSpace) 1 0x6b35b1889 WTFCrash 2 0x6a00a629b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x6a12a8afc WebKit::RemoteRenderingBackend::createImageBuffer(WebCore::FloatSize const&, WebCore::RenderingMode, float, WebCore::ColorSpace) 4 0x6a143b4a3 WebKit::WebChromeClient::createImageBuffer(WebCore::FloatSize const&, WebCore::RenderingMode, float, WebCore::ColorSpace) const 5 0x6a143b62a WebKit::WebChromeClient::createImageBuffer(WebCore::FloatSize const&, WebCore::ShouldAccelerate, WebCore::ShouldUseDisplayList, WebCore::RenderingPurpose, float, WebCore::ColorSpace) const 6 0x6bbb4d778 WebCore::Chrome::createImageBuffer(WebCore::FloatSize const&, WebCore::ShouldAccelerate, WebCore::ShouldUseDisplayList, WebCore::RenderingPurpose, float, WebCore::ColorSpace) const 7 0x6bbfc7678 WebCore::ImageBuffer::create(WebCore::FloatSize const&, WebCore::ShouldAccelerate, WebCore::ShouldUseDisplayList, WebCore::RenderingPurpose, float, WebCore::ColorSpace, WebCore::HostWindow const*) 8 0x6bb2c5cdb WebCore::HTMLCanvasElement::createImageBuffer() const 9 0x6bb25e6f5 WebCore::CanvasBase::buffer() const 10 0x6bb25e669 WebCore::CanvasBase::drawingContext() const 11 0x6bb4d3ada WebCore::CanvasRenderingContext2DBase::drawingContext() const 12 0x6bb4d99f2 WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasStyle) 13 0x6bb4dc6b7 WebCore::CanvasRenderingContext2DBase::setFillColor(WTF::String const&, WTF::Optional<float>) 14 0x6bb4ff600 WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_9::operator()(WTF::String const&) const 15 0x6bb4ff52d void WTF::__visitor_table<WTF::Visitor<WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_9, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_10, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_11>, WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >::__trampoline_func<WTF::String>(WTF::Visitor<WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_9, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_10, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_11>&, WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&) 16 0x6bb4ff470 WTF::__visitor_return_type<WTF::Visitor<WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_9, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_10, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_11>, WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >::__type WTF::visit<WTF::Visitor<WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_9, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_10, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_11>, WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >(WTF::Visitor<WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_9, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_10, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_11>&&, WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&) 17 0x6bb4e1df2 decltype(WTF::visit(makeVisitor(std::forward<WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_9>(fp0), std::forward<WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_10>(fp0), std::forward<WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_11>(fp0)), std::forward<WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&>(fp))) WTF::switchOn<WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_9, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_10, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_11>(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_9&&, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_10&&, WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::DumbPtrTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::DumbPtrTraits<WebCore::CanvasPattern> > >&&)::$_11&&) 1624411 2 wenson_hsieh 2020-03-01 13:44:55 -0800 Followup to <rdar://problem/59911910> 1624413 3 392103 wenson_hsieh 2020-03-01 13:51:16 -0800 Created attachment 392103 Patch 1624418 4 392103 commit-queue 2020-03-01 15:13:50 -0800 Comment on attachment 392103 Patch Clearing flags on attachment: 392103 Committed r257693: <https://trac.webkit.org/changeset/257693> 1624419 5 commit-queue 2020-03-01 15:13:52 -0800 All reviewed patches have been landed. Closing bug. 392103 2020-03-01 13:51:16 -0800 2020-03-01 15:13:50 -0800 Patch bug-208431-20200301135115.patch text/plain 2581 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFiMWQxZDViMzQ5ZGRkZGM1 YTRlMTQyZTIxMmNkNTZmOGI1YTU1MzYuLmFjYWI3ZDJkNDFhNDA1NWEzZWU0NmE0YTJlMjc5N2Ew ZDU5YWNlM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDMtMDEgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgTWFueSB0ZXN0cyBpbiBj YW52YXMgYW5kIGZhc3QvY2FudmFzIGFyZSBhc3NlcnRpbmcgYWZ0ZXIgcjI1NzY3NworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4NDMxCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS81OTkxMTkxMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZW1vdGVSZW5kZXJpbmdCYWNrZW5kIGFzc2VydHMgdGhhdCBp dCBzaG91bGQgbmV2ZXIgYmUgY3JlYXRlZCB3aXRoIGEgUmVuZGVyaW5nTW9kZSB0aGF0IGlzbid0 IGVpdGhlcgorICAgICAgICBSZW1vdGVBY2NlbGVyYXRlZCBvciBSZW1vdGVVbmFjY2VsZXJhdGVk LiBUaGlzIHdhcyBwcmV2aW91c2x5IHRoZSBjYXNlIGJlZm9yZSByMjU3Njc3LCBiZWNhdXNlCisg ICAgICAgIEltYWdlQnVmZmVyOjpjcmVhdGUoKSB3b3VsZCBvbmx5IGNhbGwgaW50byB0aGUgaG9z dCB3aW5kb3cgKGkuZS4gdGhlIGNocm9tZSBhbmQsIGluIHR1cm4sIGNocm9tZSBjbGllbnQpIHRv CisgICAgICAgIGNyZWF0ZSB0aGUgcmVtb3RlIGltYWdlIGJ1ZmZlciBpZiB0aGUgcmVuZGVyaW5n IG1vZGUgaXMgUmVtb3RlQWNjZWxlcmF0ZWQgb3IgUmVtb3RlVW5hY2NlbGVyYXRlZC4gSG93ZXZl ciwgc2luY2UKKyAgICAgICAgd2Ugd2FudCB0byBtb3ZlIGF3YXkgZnJvbSBhbnkgcmVmZXJlbmNl cyB0byBSZW1vdGVBY2NlbGVyYXRlZCBvciBSZW1vdGVVbmFjY2VsZXJhdGVkIHJlbmRlcmluZyBt b2RlcyBpbiBXZWJDb3JlLAorICAgICAgICB3ZSBzaG91bGQgaW5zdGVhZCBmaXggdGhpcyBieSBh ZGRpbmcgYSBzaW1pbGFyIGNoZWNrIGluIHRoZSBjbGllbnQgKFdlYktpdCkgbGF5ZXIuCisKKyAg ICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYkNocm9tZUNsaWVudDo6Y3JlYXRlSW1hZ2VCdWZmZXIgY29uc3Qp OgorCisgICAgICAgIERvbid0IGJvdGhlciBjcmVhdGluZyBhIFJlbW90ZVJlbmRlcmluZ0JhY2tl bmQgYW5kIHRlbGxpbmcgaXQgdG8gY3JlYXRlIGFuIGltYWdlIGJ1ZmZlciwgaWYgdGhlIGdpdmVu CisgICAgICAgIFJlbmRlcmluZ01vZGUgaXNuJ3Qgb25lIG9mIFJlbW90ZUFjY2VsZXJhdGVkIG9y IFJlbW90ZVVuYWNjZWxlcmF0ZWQuCisKIDIwMjAtMDItMjkgIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgc3RkOjpsb2NrX2d1YXJkCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xp ZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJv bWVDbGllbnQuY3BwCmluZGV4IGQ0MmMyNGFjOTlmMzBjZTI3ODkzODA4MGJmYzgyMzQ5MTEwYWE0 MGMuLjYzMzllNGRjZWI2Nzk2OWZjMmU4ZDlmMGI4NGIzMjI1NmJhNTU5ZjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJv bWVDbGllbnQuY3BwCkBAIC04OTMsNiArODkzLDkgQEAgUmVmUHRyPERpc3BsYXlSZWZyZXNoTW9u aXRvcj4gV2ViQ2hyb21lQ2xpZW50OjpjcmVhdGVEaXNwbGF5UmVmcmVzaE1vbml0b3IoUGxhdGYK IAogc3RkOjp1bmlxdWVfcHRyPEltYWdlQnVmZmVyPiBXZWJDaHJvbWVDbGllbnQ6OmNyZWF0ZUlt YWdlQnVmZmVyKGNvbnN0IEZsb2F0U2l6ZSYgc2l6ZSwgUmVuZGVyaW5nTW9kZSByZW5kZXJpbmdN b2RlLCBmbG9hdCByZXNvbHV0aW9uU2NhbGUsIENvbG9yU3BhY2UgY29sb3JTcGFjZSkgY29uc3QK IHsKKyAgICBpZiAocmVuZGVyaW5nTW9kZSAhPSBSZW5kZXJpbmdNb2RlOjpSZW1vdGVBY2NlbGVy YXRlZCAmJiByZW5kZXJpbmdNb2RlICE9IFJlbmRlcmluZ01vZGU6OlJlbW90ZVVuYWNjZWxlcmF0 ZWQpCisgICAgICAgIHJldHVybiBudWxscHRyOworCiAgICAgaWYgKCFtX3JlbW90ZVJlbmRlcmlu Z0JhY2tlbmQpCiAgICAgICAgIG1fcmVtb3RlUmVuZGVyaW5nQmFja2VuZCA9IFJlbW90ZVJlbmRl cmluZ0JhY2tlbmQ6OmNyZWF0ZSgpOwogICAgIHJldHVybiBtX3JlbW90ZVJlbmRlcmluZ0JhY2tl bmQtPmNyZWF0ZUltYWdlQnVmZmVyKHNpemUsIHJlbmRlcmluZ01vZGUsIHJlc29sdXRpb25TY2Fs ZSwgY29sb3JTcGFjZSk7Cg==