208416 2020-02-29 09:23:10 -0800 Regression r257645: Windows build broken 2020-02-29 10:05:53 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208358 InRadar P2 Normal --- 1 aakash_jain simon.fraser aakash_jain ap simon.fraser thorton webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1624291 0 aakash_jain 2020-02-29 09:23:10 -0800 Windows build seems to be broken by r257645. e.g.: Source\WebKitLegacy\win\FullscreenVideoController.cpp(212,52): error C2039: 'platformCALayer': is not a member of 'WebCore::PlatformCALayer' WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore\PlatformCALayer.h(50): message : see declaration of 'WebCore::PlatformCALayer' Source\WebKitLegacy\win\FullscreenVideoController.cpp(212,67): error C3861: 'platformCALayer': identifier not found Source\WebKitLegacy\win\FullscreenVideoController.cpp(293,52): error C2039: 'platformCALayer': is not a member of 'WebCore::PlatformCALayer' r257644 passed in https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Build%29/builds/10778 r257647 failed in https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Build%29/builds/10779 EWS also indicated this failure in the corresponding bug https://bugs.webkit.org/show_bug.cgi?id=208358 1624293 1 webkit-bug-importer 2020-02-29 09:23:56 -0800 <rdar://problem/59919739> 1624299 2 simon.fraser 2020-02-29 10:01:17 -0800 Actually: C:\cygwin\worker\win10-release\build\Source\WebKitLegacy\win\WebView.cpp(7274,65): error C2039: 'platformCALayer': is not a member of 'WebCore::PlatformCALayer' [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] C:\cygwin\worker\win10-release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/PlatformCALayer.h(50): message : see declaration of 'WebCore::PlatformCALayer' [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] C:\cygwin\worker\win10-release\build\Source\WebKitLegacy\win\WebView.cpp(7274,80): error C3861: 'platformCALayer': identifier not found [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] 1624300 3 simon.fraser 2020-02-29 10:05:53 -0800 https://trac.webkit.org/changeset/257684/webkit