208407 2020-02-29 01:07:09 -0800 [GTK] WebKit fails to build when Wayland target is disabled 2020-03-01 19:20:50 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lantw44 webkit-unassigned berto bugs-noreply cgarcia commit-queue darin ews-watchlist gustavo oldest_to_newest 1624244 0 lantw44 2020-02-29 01:07:09 -0800 Values in the enum WebCore::PlatformDisplay::Type are only defined when their corresponding platform targets are enabled, so we need #if checks around uses of them. Please add this patch to webkit-2.28 branch if it is accepted. 1624245 1 392052 lantw44 2020-02-29 01:08:45 -0800 Created attachment 392052 Patch 1624246 2 ews-watchlist 2020-02-29 01:09:36 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1624455 3 392052 commit-queue 2020-03-01 19:20:48 -0800 Comment on attachment 392052 Patch Clearing flags on attachment: 392052 Committed r257700: <https://trac.webkit.org/changeset/257700> 1624456 4 commit-queue 2020-03-01 19:20:50 -0800 All reviewed patches have been landed. Closing bug. 392052 2020-02-29 01:08:45 -0800 2020-03-01 19:20:48 -0800 Patch bug-208407-20200229170820.patch text/plain 3675 lantw44 U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM3NGM0YzI3N2E2Yjk0ODhl MmE1MDRlNjM2MzEzNmJiNTM5MTY1MTcuLmZkYjMzMDEwMjRlNjAwZGU2ZmRjNzlmZmNmZDhlYzk0 MjExOWEwMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDItMjkgIFRpbmctV2Vp IExhbiAgPGxhbnR3NDRAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCB0aGUgYnVpbGQg d2hlbiBXYXlsYW5kIHRhcmdldCBpcyBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4NDA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVmFsdWVzIGluIHRoZSBlbnVtIFdlYkNvcmU6OlBsYXRm b3JtRGlzcGxheTo6VHlwZSBhcmUgb25seSBkZWZpbmVkIHdoZW4KKyAgICAgICAgdGhlaXIgY29y cmVzcG9uZGluZyBwbGF0Zm9ybSB0YXJnZXRzIGFyZSBlbmFibGVkLCBzbyB3ZSBuZWVkICNpZiBj aGVja3MKKyAgICAgICAgYXJvdW5kIHVzZXMgb2YgdGhlbS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZ2xpYi9XZWJLaXRQcm90b2NvbEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJLaXRQcm90b2NvbEhhbmRsZXI6OmhhbmRsZUdQVSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9nbGliL1dlYktpdFVJQ2xpZW50LmNwcDoKKyAgICAgICAgKFVJQ2xpZW50Ojp3aW5kb3dDb25m aWd1cmVFdmVudENhbGxiYWNrKToKKwogMjAyMC0wMi0yOCAgUGVuZyBMaXUgIDxwZW5nLmxpdTZA YXBwbGUuY29tPgogCiAgICAgICAgIFtNZWRpYSBpbiBHUFUgcHJvY2Vzc10gSW1wbGVtZW50IHRo ZSB2aWRlbyBmdWxsc2NyZWVuIGFuZCBQaWN0dXJlLWluLVBpY3R1cmUgc3VwcG9ydApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0UHJvdG9jb2xIYW5k bGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFByb3RvY29s SGFuZGxlci5jcHAKaW5kZXggMGE2MzdiNWJkYWVlYWIyYjVlNWZlM2I2YjdmNTkwZjk5NDI0NTJi My4uNDFiZTRmYzdmMmI3NDUxZGY2Yjc5NjQ1YzlmZDVlMTEzODViMWRmNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0UHJvdG9jb2xIYW5kbGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRQcm90b2NvbEhh bmRsZXIuY3BwCkBAIC0yODYsNyArMjg2LDE0IEBAIHZvaWQgV2ViS2l0UHJvdG9jb2xIYW5kbGVy OjpoYW5kbGVHUFUoV2ViS2l0VVJJU2NoZW1lUmVxdWVzdCogcmVxdWVzdCkKICAgICAgICAgIiAg PHRkPjxkaXYgY2xhc3M9XCJ0aXRsZW5hbWVcIj5UeXBlPC9kaXY+PC90ZD4iCiAgICAgICAgICIg IDx0ZD4lczwvdGQ+IgogICAgICAgICAiIDwvdGJvZHk+PC90cj4iLAotICAgICAgICBQbGF0Zm9y bURpc3BsYXk6OnNoYXJlZERpc3BsYXkoKS50eXBlKCkgPT0gUGxhdGZvcm1EaXNwbGF5OjpUeXBl OjpXYXlsYW5kID8gIldheWxhbmQiIDogIlgxMSIpOworI2lmIFBMQVRGT1JNKFdBWUxBTkQpCisg ICAgICAgIFBsYXRmb3JtRGlzcGxheTo6c2hhcmVkRGlzcGxheSgpLnR5cGUoKSA9PSBQbGF0Zm9y bURpc3BsYXk6OlR5cGU6OldheWxhbmQgPyAiV2F5bGFuZCIgOgorI2VuZGlmCisjaWYgUExBVEZP Uk0oWDExKQorICAgICAgICBQbGF0Zm9ybURpc3BsYXk6OnNoYXJlZERpc3BsYXkoKS50eXBlKCkg PT0gUGxhdGZvcm1EaXNwbGF5OjpUeXBlOjpYMTEgPyAiWDExIiA6CisjZW5kaWYKKyAgICAgICAg IlVua25vd24iCisgICAgKTsKICNlbmRpZgogCiAgICAgYXV0byByZWN0ID0gSW50UmVjdChzY3Jl ZW5SZWN0KG51bGxwdHIpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9nbGliL1dlYktpdFVJQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9n bGliL1dlYktpdFVJQ2xpZW50LmNwcAppbmRleCBhMjJhYmJmNTRlOTc1MjMyZDg0MjIxMjQ0NzIx NTdkZWYxYmQwYTY4Li5lYzIwZGI5MWJmNzVhZDM5NjhmYWM5Mzg5M2YyZjRiZDNjZDBmZmFlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVu dC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0VUlDbGll bnQuY3BwCkBAIC0xNDQsNyArMTQ0LDEwIEBAIHByaXZhdGU6CiAgICAgewogICAgICAgICBHZGtS ZWN0YW5nbGUgZ2VvbWV0cnkgPSB7IDAsIDAsIDAsIDAgfTsKICAgICAgICAgLy8gUG9zaXRpb24g YSB0b3BsZXZlbCB3aW5kb3cgaXMgbm90IHN1cHBvcnRlZCB1bmRlciB3YXlsYW5kLgotICAgICAg ICBpZiAoV2ViQ29yZTo6UGxhdGZvcm1EaXNwbGF5OjpzaGFyZWREaXNwbGF5KCkudHlwZSgpICE9 IFdlYkNvcmU6OlBsYXRmb3JtRGlzcGxheTo6VHlwZTo6V2F5bGFuZCkgeworI2lmIFBMQVRGT1JN KFdBWUxBTkQpCisgICAgICAgIGlmIChXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6OnNoYXJlZERp c3BsYXkoKS50eXBlKCkgIT0gV2ViQ29yZTo6UGxhdGZvcm1EaXNwbGF5OjpUeXBlOjpXYXlsYW5k KQorI2VuZGlmCisgICAgICAgIHsKICAgICAgICAgICAgIGd0a193aW5kb3dfZ2V0X3Bvc2l0aW9u KHdpbmRvdywgJmdlb21ldHJ5LngsICZnZW9tZXRyeS55KTsKICAgICAgICAgICAgIGlmIChnZW9t ZXRyeS54ICE9IHRhcmdldEdlb21ldHJ5LT54IHx8IGdlb21ldHJ5LnkgIT0gdGFyZ2V0R2VvbWV0 cnktPnkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIEZBTFNFOwpAQCAtMTcyLDcgKzE3NSwxMCBA QCBwcml2YXRlOgogICAgICAgICBpZiAod2Via2l0X3dlYl92aWV3X2lzX2NvbnRyb2xsZWRfYnlf YXV0b21hdGlvbihtX3dlYlZpZXcpICYmIFdlYkNvcmU6OndpZGdldElzT25zY3JlZW5Ub3BsZXZl bFdpbmRvdyh3aW5kb3cpICYmIGd0a193aWRnZXRfZ2V0X3Zpc2libGUod2luZG93KSkgewogICAg ICAgICAgICAgYm9vbCBuZWVkc01vdmUgPSBmYWxzZTsKICAgICAgICAgICAgIC8vIFBvc2l0aW9u IGEgdG9wbGV2ZWwgd2luZG93IGlzIG5vdCBzdXBwb3J0ZWQgdW5kZXIgd2F5bGFuZC4KLSAgICAg ICAgICAgIGlmIChXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6OnNoYXJlZERpc3BsYXkoKS50eXBl KCkgIT0gV2ViQ29yZTo6UGxhdGZvcm1EaXNwbGF5OjpUeXBlOjpXYXlsYW5kKSB7CisjaWYgUExB VEZPUk0oV0FZTEFORCkKKyAgICAgICAgICAgIGlmIChXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6 OnNoYXJlZERpc3BsYXkoKS50eXBlKCkgIT0gV2ViQ29yZTo6UGxhdGZvcm1EaXNwbGF5OjpUeXBl OjpXYXlsYW5kKQorI2VuZGlmCisgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgaWYgKGdl b21ldHJ5LnggPj0gMCAmJiBnZW9tZXRyeS55ID49IDApIHsKICAgICAgICAgICAgICAgICAgICAg aW50IHgsIHk7CiAgICAgICAgICAgICAgICAgICAgIGd0a193aW5kb3dfZ2V0X3Bvc2l0aW9uKEdU S19XSU5ET1cod2luZG93KSwgJngsICZ5KTsK