208392 2020-02-28 14:02:33 -0800 Clean up code with how we choose Gigacage sizes and whether or not to use Wasm fast memory 2020-02-28 16:00:16 -0800 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam commit-queue darin ews-watchlist fpizlo ggaren keith_miller mark.lam mjs msaboff sam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1624125 0 saam 2020-02-28 14:02:33 -0800 ... 1624127 1 392018 saam 2020-02-28 14:05:43 -0800 Created attachment 392018 patch 1624128 2 392018 ysuzuki 2020-02-28 14:06:58 -0800 Comment on attachment 392018 patch View in context: https://bugs.webkit.org/attachment.cgi?id=392018&action=review r=me > Source/JavaScriptCore/runtime/OptionsList.h:462 > + v(Bool, useWebAssemblyFastMemory, WTF_OS_CONSTANT_EFFECTIVE_ADDRESS_WIDTH >= 48, Normal, "If true, we will try to use a 32-bit address space with a signal handler to bounds check wasm memory.") \ Use `OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH)` instead. 1624130 3 392019 saam 2020-02-28 14:12:08 -0800 Created attachment 392019 patch for landing 1624166 4 392019 commit-queue 2020-02-28 15:59:31 -0800 Comment on attachment 392019 patch for landing Clearing flags on attachment: 392019 Committed r257662: <https://trac.webkit.org/changeset/257662> 1624167 5 commit-queue 2020-02-28 15:59:33 -0800 All reviewed patches have been landed. Closing bug. 1624169 6 webkit-bug-importer 2020-02-28 16:00:16 -0800 <rdar://problem/59907312> 392018 2020-02-28 14:05:43 -0800 2020-02-28 14:12:08 -0800 patch c-backup.diff text/plain 3314 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjU3NjQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDIwLTAyLTI4ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IENsZWFuIHVwIGNvZGUgd2l0aCBob3cgd2UgY2hvb3NlIEdpZ2FjYWdlIHNpemVzIGFuZCB3aGV0 aGVyIG9yIG5vdCB0byB1c2UgV2FzbSBmYXN0IG1lbW9yeQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL09wdGlvbnNMaXN0Lmg6CisKIDIw MjAtMDItMjcgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4 IGRlYnVnIGFybTY0IFdhc20gdGVzdHMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL09wdGlvbnNMaXN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvT3B0aW9uc0xpc3QuaAkocmV2aXNpb24gMjU3NjQ4KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvT3B0aW9uc0xpc3QuaAkod29ya2luZyBjb3B5KQpAQCAtNDU5LDcgKzQ1 OSw3IEBAIGNvbnN0ZXhwciBib29sIGVuYWJsZVdlYkFzc2VtYmx5U3RyZWFtaW4KICAgICB2KElu dDMyLCBvbWdUaWVyVXBDb3VudGVySW5jcmVtZW50Rm9yTG9vcCwgMSwgTm9ybWFsLCAiVGhlIGFt b3VudCB0aGUgdGllciB1cCBjb3VudGVyIGlzIGluY3JlbWVudGVkIG9uIGVhY2ggbG9vcCBiYWNr ZWRnZS4iKSBcCiAgICAgdihJbnQzMiwgb21nVGllclVwQ291bnRlckluY3JlbWVudEZvckVudHJ5 LCAxNSwgTm9ybWFsLCAiVGhlIGFtb3VudCB0aGUgdGllciB1cCBjb3VudGVyIGlzIGluY3JlbWVu dGVkIG9uIGVhY2ggZnVuY3Rpb24gZW50cnkuIikgXAogICAgIC8qIEZJWE1FOiBlbmFibGUgZmFz dCBtZW1vcmllcyBvbiBpT1MgYW5kIHByZS1hbGxvY2F0ZSB0aGVtLiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNzc0ICovIFwKLSAgICB2KEJvb2wsIHVzZVdlYkFz c2VtYmx5RmFzdE1lbW9yeSwgIWlzSU9TKCksIE5vcm1hbCwgIklmIHRydWUsIHdlIHdpbGwgdHJ5 IHRvIHVzZSBhIDMyLWJpdCBhZGRyZXNzIHNwYWNlIHdpdGggYSBzaWduYWwgaGFuZGxlciB0byBi b3VuZHMgY2hlY2sgd2FzbSBtZW1vcnkuIikgXAorICAgIHYoQm9vbCwgdXNlV2ViQXNzZW1ibHlG YXN0TWVtb3J5LCBXVEZfT1NfQ09OU1RBTlRfRUZGRUNUSVZFX0FERFJFU1NfV0lEVEggPj0gNDgs IE5vcm1hbCwgIklmIHRydWUsIHdlIHdpbGwgdHJ5IHRvIHVzZSBhIDMyLWJpdCBhZGRyZXNzIHNw YWNlIHdpdGggYSBzaWduYWwgaGFuZGxlciB0byBib3VuZHMgY2hlY2sgd2FzbSBtZW1vcnkuIikg XAogICAgIHYoQm9vbCwgbG9nV2ViQXNzZW1ibHlNZW1vcnksIGZhbHNlLCBOb3JtYWwsIG51bGxw dHIpIFwKICAgICB2KFVuc2lnbmVkLCB3ZWJBc3NlbWJseUZhc3RNZW1vcnlSZWR6b25lUGFnZXMs IDEyOCwgTm9ybWFsLCAiV2ViQXNzZW1ibHkgZmFzdCBtZW1vcmllcyB1c2UgNEdpQiB2aXJ0dWFs IGFsbG9jYXRpb25zLCBwbHVzIGEgcmVkem9uZSAoY291bnRlZCBhcyBtdWx0aXBsZSBvZiA2NEtp QiBXZWJBc3NlbWJseSBwYWdlcykgYXQgdGhlIGVuZCB0byBjYXRjaCByZWcraW1tIGFjY2Vzc2Vz IHdoaWNoIGV4Y2VlZCAzMi1iaXQsIGFueXRoaW5nIGJleW9uZCB0aGUgcmVkem9uZSBpcyBleHBs aWNpdGx5IGJvdW5kcy1jaGVja2VkIikgXAogICAgIHYoQm9vbCwgY3Jhc2hJZldlYkFzc2VtYmx5 Q2FudEZhc3RNZW1vcnksIGZhbHNlLCBOb3JtYWwsICJJZiB0cnVlLCB3ZSB3aWxsIGNyYXNoIGlm IHdlIGNhbid0IG9idGFpbiBmYXN0IG1lbW9yeSBmb3Igd2FzbS4iKSBcCkluZGV4OiBTb3VyY2Uv Ym1hbGxvYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTc2NTgpCisrKyBTb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAyMC0wMi0yOCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRp QGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbiB1cCBjb2RlIHdpdGggaG93IHdlIGNob29zZSBH aWdhY2FnZSBzaXplcyBhbmQgd2hldGhlciBvciBub3QgdG8gdXNlIFdhc20gZmFzdCBtZW1vcnkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODM5Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYm1hbGxv Yy9HaWdhY2FnZS5oOgorCiAyMDIwLTAyLTI2ICBCYXN1a2UgU3V6dWtpICA8YmFzdWtlLnN1enVr aUBzb255LmNvbT4KIAogICAgICAgICBbYm1hbGxvY11bUGxheVN0YXRpb25dIFNldCBTY2F2ZW5n ZXIncyB0aHJlYWQgbmFtZS4KSW5kZXg6IFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvR2lnYWNhZ2Uu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0dpZ2FjYWdlLmgJKHJldmlz aW9uIDI1NzY0OCkKKysrIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvR2lnYWNhZ2UuaAkod29ya2lu ZyBjb3B5KQpAQCAtNjYsNyArNjYsNyBAQCBCSU5MSU5FIGNvbnN0IGNoYXIqIG5hbWUoS2luZCBr aW5kKQogCiAjaWYgR0lHQUNBR0VfRU5BQkxFRAogCi0jaWYgQkNQVShBUk02NCkKKyNpZiBCT1Nf RUZGRUNUSVZFX0FERFJFU1NfV0lEVEggPCA0OAogY29uc3RleHByIHNpemVfdCBwcmltaXRpdmVH aWdhY2FnZVNpemUgPSAyICogYm1hbGxvYzo6U2l6ZXM6OkdCOwogY29uc3RleHByIHNpemVfdCBq c1ZhbHVlR2lnYWNhZ2VTaXplID0gMiAqIGJtYWxsb2M6OlNpemVzOjpHQjsKIGNvbnN0ZXhwciBz aXplX3QgbWF4aW11bUNhZ2VTaXplUmVkdWN0aW9uRm9yU2xpZGUgPSBibWFsbG9jOjpTaXplczo6 R0IgLyA0Owo= 392019 2020-02-28 14:12:08 -0800 2020-02-28 15:59:31 -0800 patch for landing c-backup.diff text/plain 3309 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjU3NjQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDIwLTAyLTI4ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IENsZWFuIHVwIGNvZGUgd2l0aCBob3cgd2UgY2hvb3NlIEdpZ2FjYWdlIHNpemVzIGFuZCB3aGV0 aGVyIG9yIG5vdCB0byB1c2UgV2FzbSBmYXN0IG1lbW9yeQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg WXVzdWtlIFN1enVraS4KKworICAgICAgICAqIHJ1bnRpbWUvT3B0aW9uc0xpc3QuaDoKKwogMjAy MC0wMi0yNyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXgg ZGVidWcgYXJtNjQgV2FzbSB0ZXN0cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvT3B0aW9uc0xpc3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9PcHRpb25zTGlzdC5oCShyZXZpc2lvbiAyNTc2NDgpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9PcHRpb25zTGlzdC5oCSh3b3JraW5nIGNvcHkpCkBAIC00NTksNyArNDU5 LDcgQEAgY29uc3RleHByIGJvb2wgZW5hYmxlV2ViQXNzZW1ibHlTdHJlYW1pbgogICAgIHYoSW50 MzIsIG9tZ1RpZXJVcENvdW50ZXJJbmNyZW1lbnRGb3JMb29wLCAxLCBOb3JtYWwsICJUaGUgYW1v dW50IHRoZSB0aWVyIHVwIGNvdW50ZXIgaXMgaW5jcmVtZW50ZWQgb24gZWFjaCBsb29wIGJhY2tl ZGdlLiIpIFwKICAgICB2KEludDMyLCBvbWdUaWVyVXBDb3VudGVySW5jcmVtZW50Rm9yRW50cnks IDE1LCBOb3JtYWwsICJUaGUgYW1vdW50IHRoZSB0aWVyIHVwIGNvdW50ZXIgaXMgaW5jcmVtZW50 ZWQgb24gZWFjaCBmdW5jdGlvbiBlbnRyeS4iKSBcCiAgICAgLyogRklYTUU6IGVuYWJsZSBmYXN0 IG1lbW9yaWVzIG9uIGlPUyBhbmQgcHJlLWFsbG9jYXRlIHRoZW0uIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA3NzQgKi8gXAotICAgIHYoQm9vbCwgdXNlV2ViQXNz ZW1ibHlGYXN0TWVtb3J5LCAhaXNJT1MoKSwgTm9ybWFsLCAiSWYgdHJ1ZSwgd2Ugd2lsbCB0cnkg dG8gdXNlIGEgMzItYml0IGFkZHJlc3Mgc3BhY2Ugd2l0aCBhIHNpZ25hbCBoYW5kbGVyIHRvIGJv dW5kcyBjaGVjayB3YXNtIG1lbW9yeS4iKSBcCisgICAgdihCb29sLCB1c2VXZWJBc3NlbWJseUZh c3RNZW1vcnksIE9TX0NPTlNUQU5UKEVGRkVDVElWRV9BRERSRVNTX1dJRFRIKSA+PSA0OCwgTm9y bWFsLCAiSWYgdHJ1ZSwgd2Ugd2lsbCB0cnkgdG8gdXNlIGEgMzItYml0IGFkZHJlc3Mgc3BhY2Ug d2l0aCBhIHNpZ25hbCBoYW5kbGVyIHRvIGJvdW5kcyBjaGVjayB3YXNtIG1lbW9yeS4iKSBcCiAg ICAgdihCb29sLCBsb2dXZWJBc3NlbWJseU1lbW9yeSwgZmFsc2UsIE5vcm1hbCwgbnVsbHB0cikg XAogICAgIHYoVW5zaWduZWQsIHdlYkFzc2VtYmx5RmFzdE1lbW9yeVJlZHpvbmVQYWdlcywgMTI4 LCBOb3JtYWwsICJXZWJBc3NlbWJseSBmYXN0IG1lbW9yaWVzIHVzZSA0R2lCIHZpcnR1YWwgYWxs b2NhdGlvbnMsIHBsdXMgYSByZWR6b25lIChjb3VudGVkIGFzIG11bHRpcGxlIG9mIDY0S2lCIFdl YkFzc2VtYmx5IHBhZ2VzKSBhdCB0aGUgZW5kIHRvIGNhdGNoIHJlZytpbW0gYWNjZXNzZXMgd2hp Y2ggZXhjZWVkIDMyLWJpdCwgYW55dGhpbmcgYmV5b25kIHRoZSByZWR6b25lIGlzIGV4cGxpY2l0 bHkgYm91bmRzLWNoZWNrZWQiKSBcCiAgICAgdihCb29sLCBjcmFzaElmV2ViQXNzZW1ibHlDYW50 RmFzdE1lbW9yeSwgZmFsc2UsIE5vcm1hbCwgIklmIHRydWUsIHdlIHdpbGwgY3Jhc2ggaWYgd2Ug Y2FuJ3Qgb2J0YWluIGZhc3QgbWVtb3J5IGZvciB3YXNtLiIpIFwKSW5kZXg6IFNvdXJjZS9ibWFs bG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NzY1OCkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEyIEBACisyMDIwLTAyLTI4ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBw bGUuY29tPgorCisgICAgICAgIENsZWFuIHVwIGNvZGUgd2l0aCBob3cgd2UgY2hvb3NlIEdpZ2Fj YWdlIHNpemVzIGFuZCB3aGV0aGVyIG9yIG5vdCB0byB1c2UgV2FzbSBmYXN0IG1lbW9yeQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzkyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgWXVzdWtlIFN1enVraS4KKworICAgICAgICAqIGJtYWxsb2MvR2ln YWNhZ2UuaDoKKwogMjAyMC0wMi0yNiAgQmFzdWtlIFN1enVraSAgPGJhc3VrZS5zdXp1a2lAc29u eS5jb20+CiAKICAgICAgICAgW2JtYWxsb2NdW1BsYXlTdGF0aW9uXSBTZXQgU2NhdmVuZ2VyJ3Mg dGhyZWFkIG5hbWUuCkluZGV4OiBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0dpZ2FjYWdlLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvYm1hbGxvYy9HaWdhY2FnZS5oCShyZXZpc2lvbiAy NTc2NDgpCisrKyBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0dpZ2FjYWdlLmgJKHdvcmtpbmcgY29w eSkKQEAgLTY2LDcgKzY2LDcgQEAgQklOTElORSBjb25zdCBjaGFyKiBuYW1lKEtpbmQga2luZCkK IAogI2lmIEdJR0FDQUdFX0VOQUJMRUQKIAotI2lmIEJDUFUoQVJNNjQpCisjaWYgQk9TX0VGRkVD VElWRV9BRERSRVNTX1dJRFRIIDwgNDgKIGNvbnN0ZXhwciBzaXplX3QgcHJpbWl0aXZlR2lnYWNh Z2VTaXplID0gMiAqIGJtYWxsb2M6OlNpemVzOjpHQjsKIGNvbnN0ZXhwciBzaXplX3QganNWYWx1 ZUdpZ2FjYWdlU2l6ZSA9IDIgKiBibWFsbG9jOjpTaXplczo6R0I7CiBjb25zdGV4cHIgc2l6ZV90 IG1heGltdW1DYWdlU2l6ZVJlZHVjdGlvbkZvclNsaWRlID0gYm1hbGxvYzo6U2l6ZXM6OkdCIC8g NDsK