208391 2020-02-28 13:58:07 -0800 [WinCairo][PlayStation] Add interface to get listening port of RemoteInspectorServer 2020-03-03 12:25:17 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 208349 1 basuke basuke basuke commit-queue don.olmstead ews-watchlist hi joepeck keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1624121 0 basuke 2020-02-28 13:58:07 -0800 Current implementation cannot allow client to specify server address to listen. It is safe to specify "127.0.0.1" when no access from outside is needed. Also if server picks port number available, it is also handy. 1625124 1 basuke 2020-03-03 10:44:46 -0800 Change the title. Now client can get the listening port when passing zero as a port number to allow system to pick an available port. 1625125 2 392296 basuke 2020-03-03 10:48:51 -0800 Created attachment 392296 PATCH 1625130 3 392296 ross.kirsling 2020-03-03 10:53:58 -0800 Comment on attachment 392296 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=392296&action=review > Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.cpp:61 > + if (isRunning()) > + return WTF::nullopt; Shouldn't this condition be negative? 1625131 4 392296 ross.kirsling 2020-03-03 10:56:02 -0800 Comment on attachment 392296 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=392296&action=review > Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.cpp:52 > auto& endpoint = Inspector::RemoteInspectorSocketEndpoint::singleton(); > + if (isRunning()) > + return false; Also it seems like the early out can precede the declaration here. 1625134 5 392296 don.olmstead 2020-03-03 11:00:05 -0800 Comment on attachment 392296 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=392296&action=review > Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.cpp:53 > + if (isRunning()) > + return false; > + Shouldn't this go at the start? You don't use endpoint before this check. > Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.h:42 > + JS_EXPORT_PRIVATE Optional<uint16_t> RemoteInspectorServer::getPort(); Copy pasta error? 1625152 6 392296 basuke 2020-03-03 11:26:10 -0800 Comment on attachment 392296 PATCH Sorry for too many casual mistake. 1625155 7 392304 basuke 2020-03-03 11:35:49 -0800 Created attachment 392304 PATCH I got a coffee. My brain is now working. 1625177 8 392304 commit-queue 2020-03-03 12:24:15 -0800 Comment on attachment 392304 PATCH Clearing flags on attachment: 392304 Committed r257795: <https://trac.webkit.org/changeset/257795> 1625178 9 commit-queue 2020-03-03 12:24:17 -0800 All reviewed patches have been landed. Closing bug. 1625179 10 webkit-bug-importer 2020-03-03 12:25:17 -0800 <rdar://problem/60007846> 392296 2020-03-03 10:48:51 -0800 2020-03-03 11:35:49 -0800 PATCH bug-208391.diff text/plain 2728 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ2NGRhMGI2MTU4Li4wZmNlN2M0NGM1ZSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDMtMDMgIEJhc3Vr ZSBTdXp1a2kgIDxiYXN1a2Uuc3V6dWtpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb11b UGxheVN0YXRpb25dIEFkZCBpbnRlcmZhY2UgdG8gZ2V0IGxpc3RlbmluZyBwb3J0IG9mIFJlbW90 ZUluc3BlY3RvclNlcnZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA4MzkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiBwYXNzaW5nIHplcm8gYXMgYSBwb3J0IGFyZ3VtZW50LCBzeXN0ZW0gd2ls bCBwaWNrIGFuIGF2YWlsYWJsZSBwb3J0IGZvciBpdC4KKyAgICAgICAgV2l0aG91dCB0aGlzIG1l dGhvZCwgY2xpZW50IGNhbm5vdCBnZXQgd2hpY2ggcG9ydCBpcyBsaXN0ZW5pbmcuCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuY3BwOgor ICAgICAgICAoSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3JTZXJ2ZXI6OnN0YXJ0KToKKyAgICAg ICAgKEluc3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9yU2VydmVyOjpnZXRQb3J0KToKKyAgICAgICAg KiBpbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuaDoKKwogMjAy MC0wMy0wMiAgSnVzdGluIE1pY2hhdWQgIDxqdXN0aW5fbWljaGF1ZEBhcHBsZS5jb20+CiAKICAg ICAgICAgRGVsZXRlIGJ5IHZhbCBjYWNoaW5nIGRvZXMgbm90IGtlZXAgdGhlIHN1YnNjcmlwdCBh bGl2ZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUv c29ja2V0L1JlbW90ZUluc3BlY3RvclNlcnZlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL3JlbW90ZS9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcAppbmRleCBm M2EwYzU0MjllMy4uMmFiYWY5NjQ1YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNw ZWN0b3JTZXJ2ZXIuY3BwCkBAIC00OCwxMCArNDgsMjIgQEAgUmVtb3RlSW5zcGVjdG9yU2VydmVy Ojp+UmVtb3RlSW5zcGVjdG9yU2VydmVyKCkKIGJvb2wgUmVtb3RlSW5zcGVjdG9yU2VydmVyOjpz dGFydChjb25zdCBjaGFyKiBhZGRyZXNzLCB1aW50MTZfdCBwb3J0KQogewogICAgIGF1dG8mIGVu ZHBvaW50ID0gSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3JTb2NrZXRFbmRwb2ludDo6c2luZ2xl dG9uKCk7CisgICAgaWYgKGlzUnVubmluZygpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAg ICBtX3NlcnZlciA9IGVuZHBvaW50Lmxpc3RlbkluZXQoYWRkcmVzcywgcG9ydCwgKnRoaXMsIFJl bW90ZUluc3BlY3Rvcjo6c2luZ2xldG9uKCkpOwogICAgIHJldHVybiBpc1J1bm5pbmcoKTsKIH0K IAorT3B0aW9uYWw8dWludDE2X3Q+IFJlbW90ZUluc3BlY3RvclNlcnZlcjo6Z2V0UG9ydCgpCit7 CisgICAgaWYgKGlzUnVubmluZygpKQorICAgICAgICByZXR1cm4gV1RGOjpudWxsb3B0OworCisg ICAgYXV0byYgZW5kcG9pbnQgPSBJbnNwZWN0b3I6OlJlbW90ZUluc3BlY3RvclNvY2tldEVuZHBv aW50OjpzaW5nbGV0b24oKTsKKyAgICByZXR1cm4gZW5kcG9pbnQuZ2V0UG9ydChtX3NlcnZlci52 YWx1ZSgpKTsKK30KKwogYm9vbCBSZW1vdGVJbnNwZWN0b3JTZXJ2ZXI6OmRpZEFjY2VwdChDb25u ZWN0aW9uSUQgYWNjZXB0ZWRJRCwgQ29ubmVjdGlvbklELCBTb2NrZXQ6OkRvbWFpbikKIHsKICAg ICBBU1NFUlQoIWlzTWFpblRocmVhZCgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0 b3JTZXJ2ZXIuaAppbmRleCA4YzIxNTBiMjk4OC4uMzM4Y2Q2MTcxZmQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0 b3JTZXJ2ZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9z b2NrZXQvUmVtb3RlSW5zcGVjdG9yU2VydmVyLmgKQEAgLTM5LDYgKzM5LDcgQEAgcHVibGljOgog ICAgIEpTX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBSZW1vdGVJbnNwZWN0b3JTZXJ2ZXImIHNpbmds ZXRvbigpOwogCiAgICAgSlNfRVhQT1JUX1BSSVZBVEUgYm9vbCBzdGFydChjb25zdCBjaGFyKiBh ZGRyZXNzLCB1aW50MTZfdCBwb3J0KTsKKyAgICBKU19FWFBPUlRfUFJJVkFURSBPcHRpb25hbDx1 aW50MTZfdD4gUmVtb3RlSW5zcGVjdG9yU2VydmVyOjpnZXRQb3J0KCk7CiAgICAgYm9vbCBpc1J1 bm5pbmcoKSBjb25zdCB7IHJldHVybiAhIW1fc2VydmVyOyB9CiAKIHByaXZhdGU6Cg== 392304 2020-03-03 11:35:49 -0800 2020-03-03 12:24:15 -0800 PATCH bug-208391.diff text/plain 2726 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ2NGRhMGI2MTU4Li4wZmNlN2M0NGM1ZSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDMtMDMgIEJhc3Vr ZSBTdXp1a2kgIDxiYXN1a2Uuc3V6dWtpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb11b UGxheVN0YXRpb25dIEFkZCBpbnRlcmZhY2UgdG8gZ2V0IGxpc3RlbmluZyBwb3J0IG9mIFJlbW90 ZUluc3BlY3RvclNlcnZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA4MzkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiBwYXNzaW5nIHplcm8gYXMgYSBwb3J0IGFyZ3VtZW50LCBzeXN0ZW0gd2ls bCBwaWNrIGFuIGF2YWlsYWJsZSBwb3J0IGZvciBpdC4KKyAgICAgICAgV2l0aG91dCB0aGlzIG1l dGhvZCwgY2xpZW50IGNhbm5vdCBnZXQgd2hpY2ggcG9ydCBpcyBsaXN0ZW5pbmcuCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuY3BwOgor ICAgICAgICAoSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3JTZXJ2ZXI6OnN0YXJ0KToKKyAgICAg ICAgKEluc3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9yU2VydmVyOjpnZXRQb3J0KToKKyAgICAgICAg KiBpbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuaDoKKwogMjAy MC0wMy0wMiAgSnVzdGluIE1pY2hhdWQgIDxqdXN0aW5fbWljaGF1ZEBhcHBsZS5jb20+CiAKICAg ICAgICAgRGVsZXRlIGJ5IHZhbCBjYWNoaW5nIGRvZXMgbm90IGtlZXAgdGhlIHN1YnNjcmlwdCBh bGl2ZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUv c29ja2V0L1JlbW90ZUluc3BlY3RvclNlcnZlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL3JlbW90ZS9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcAppbmRleCBm M2EwYzU0MjllMy4uYTM4ZDZiYzU4OWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNw ZWN0b3JTZXJ2ZXIuY3BwCkBAIC00NywxMSArNDcsMjMgQEAgUmVtb3RlSW5zcGVjdG9yU2VydmVy Ojp+UmVtb3RlSW5zcGVjdG9yU2VydmVyKCkKIAogYm9vbCBSZW1vdGVJbnNwZWN0b3JTZXJ2ZXI6 OnN0YXJ0KGNvbnN0IGNoYXIqIGFkZHJlc3MsIHVpbnQxNl90IHBvcnQpCiB7CisgICAgaWYgKGlz UnVubmluZygpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICBhdXRvJiBlbmRwb2ludCA9 IEluc3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9yU29ja2V0RW5kcG9pbnQ6OnNpbmdsZXRvbigpOwog ICAgIG1fc2VydmVyID0gZW5kcG9pbnQubGlzdGVuSW5ldChhZGRyZXNzLCBwb3J0LCAqdGhpcywg UmVtb3RlSW5zcGVjdG9yOjpzaW5nbGV0b24oKSk7CiAgICAgcmV0dXJuIGlzUnVubmluZygpOwog fQogCitPcHRpb25hbDx1aW50MTZfdD4gUmVtb3RlSW5zcGVjdG9yU2VydmVyOjpnZXRQb3J0KCkg Y29uc3QKK3sKKyAgICBpZiAoIWlzUnVubmluZygpKQorICAgICAgICByZXR1cm4gV1RGOjpudWxs b3B0OworCisgICAgY29uc3QgYXV0byYgZW5kcG9pbnQgPSBJbnNwZWN0b3I6OlJlbW90ZUluc3Bl Y3RvclNvY2tldEVuZHBvaW50OjpzaW5nbGV0b24oKTsKKyAgICByZXR1cm4gZW5kcG9pbnQuZ2V0 UG9ydChtX3NlcnZlci52YWx1ZSgpKTsKK30KKwogYm9vbCBSZW1vdGVJbnNwZWN0b3JTZXJ2ZXI6 OmRpZEFjY2VwdChDb25uZWN0aW9uSUQgYWNjZXB0ZWRJRCwgQ29ubmVjdGlvbklELCBTb2NrZXQ6 OkRvbWFpbikKIHsKICAgICBBU1NFUlQoIWlzTWFpblRocmVhZCgpKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0 b3JTZXJ2ZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tl dC9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuaAppbmRleCA4YzIxNTBiMjk4OC4uOGY4ZWYwNTk0YTMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tl dC9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5z cGVjdG9yL3JlbW90ZS9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yU2VydmVyLmgKQEAgLTM5LDYgKzM5 LDcgQEAgcHVibGljOgogICAgIEpTX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBSZW1vdGVJbnNwZWN0 b3JTZXJ2ZXImIHNpbmdsZXRvbigpOwogCiAgICAgSlNfRVhQT1JUX1BSSVZBVEUgYm9vbCBzdGFy dChjb25zdCBjaGFyKiBhZGRyZXNzLCB1aW50MTZfdCBwb3J0KTsKKyAgICBKU19FWFBPUlRfUFJJ VkFURSBPcHRpb25hbDx1aW50MTZfdD4gZ2V0UG9ydCgpIGNvbnN0OwogICAgIGJvb2wgaXNSdW5u aW5nKCkgY29uc3QgeyByZXR1cm4gISFtX3NlcnZlcjsgfQogCiBwcml2YXRlOgo=