<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>208389</bug_id>
          
          <creation_ts>2020-02-28 13:16:06 -0800</creation_ts>
          <short_desc>Clear FontDatabase when low-memory-warning happens</short_desc>
          <delta_ts>2020-02-28 13:40:15 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>cdumez</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1624091</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-02-28 13:16:06 -0800</bug_when>
    <thetext>Clear FontDatabase when low-memory-warning happens</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1624092</commentid>
    <comment_count>1</comment_count>
      <attachid>392011</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-02-28 13:16:55 -0800</bug_when>
    <thetext>Created attachment 392011
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1624093</commentid>
    <comment_count>2</comment_count>
      <attachid>392012</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-02-28 13:17:40 -0800</bug_when>
    <thetext>Created attachment 392012
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1624104</commentid>
    <comment_count>3</comment_count>
      <attachid>392012</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-02-28 13:34:22 -0800</bug_when>
    <thetext>Comment on attachment 392012
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392012&amp;action=review

r=me with change.

&gt; Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1385
&gt; +#if HAVE(DISALLOWABLE_USER_INSTALLED_FONTS)

You can replace all this with simply:
    FontDatabase::singletonAllowingUserInstalledFonts().clear();
    FontDatabase::singletonDisallowingUserInstalledFonts().clear();

without ifdefs. FontDatabase::singletonAllowingUserInstalledFonts() &amp; FontDatabase::singletonDisallowingUserInstalledFonts() resolve to FontDatabase::singleton() when !HAVE(DISALLOWABLE_USER_INSTALLED_FONTS)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1624108</commentid>
    <comment_count>4</comment_count>
      <attachid>392012</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-02-28 13:36:51 -0800</bug_when>
    <thetext>Comment on attachment 392012
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392012&amp;action=review

&gt;&gt; Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1385
&gt;&gt; +#if HAVE(DISALLOWABLE_USER_INSTALLED_FONTS)
&gt; 
&gt; You can replace all this with simply:
&gt;     FontDatabase::singletonAllowingUserInstalledFonts().clear();
&gt;     FontDatabase::singletonDisallowingUserInstalledFonts().clear();
&gt; 
&gt; without ifdefs. FontDatabase::singletonAllowingUserInstalledFonts() &amp; FontDatabase::singletonDisallowingUserInstalledFonts() resolve to FontDatabase::singleton() when !HAVE(DISALLOWABLE_USER_INSTALLED_FONTS)

Changed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1624109</commentid>
    <comment_count>5</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-02-28 13:39:11 -0800</bug_when>
    <thetext>Committed r257657: &lt;https://trac.webkit.org/changeset/257657&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1624110</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-02-28 13:40:15 -0800</bug_when>
    <thetext>&lt;rdar://problem/59900871&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>392011</attachid>
            <date>2020-02-28 13:16:55 -0800</date>
            <delta_ts>2020-02-28 13:17:39 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-208389-20200228131654.patch</filename>
            <type>text/plain</type>
            <size>1609</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTU1MzMwNjQ0ODJjZTA0
ZDJkNDM5ZmFhOTYxYzlkZjYzZDI2ZDI3Yy4uMDI4N2MwNmM3YzFhYTQxYzQ4NmVkNTc1ZjY0MTFm
YTVhMmEyYjYyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAyLTI4ICBZdXN1
a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYXIgRm9udERhdGFi
YXNlIHdoZW4gbG93LW1lbW9yeS13YXJuaW5nIGhhcHBlbnMKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODM4OQorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvbnREYXRhYmFzZSBjYW4gbW9ub3RvbmljYWxs
eSBpbmNyZWFzZS4gV2Ugc2hvdWxkIGNsZWFyIGl0IHdoZW4gbG93LW1lbW9yeS13YXJuaW5nIGhh
cHBlbnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250Q2FjaGVDb3Jl
VGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250Q2FjaGU6OnBsYXRmb3JtUHVyZ2VJbmFj
dGl2ZUZvbnREYXRhKToKKwogMjAyMC0wMi0yOCAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBs
ZS5jb20+CiAKICAgICAgICAgQ29udmVydCBmcmFtZSBhZGRyZXNzIGluIGxvZ2dpbmcgc3RhdGVt
ZW50cyB0byBwYWdlSUQrZnJhbWVJRApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vZ3JhcGhpY3MvY29jb2EvRm9udENhY2hlQ29yZVRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9udENhY2hlQ29yZVRleHQuY3BwCmluZGV4IGM4M2Y4
MzUyMTg3MzIzY2IyNmVlNmIyMDA1YTg1M2E2NWI3N2Y1M2MuLjNlYzAyYWRhMDU2NjcyYjliNjA5
YjliM2MwNzI4Y2Y5ZWYyOTUyODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2dyYXBoaWNzL2NvY29hL0ZvbnRDYWNoZUNvcmVUZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y
ZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250Q2FjaGVDb3JlVGV4dC5jcHAKQEAgLTEzODEs
NiArMTM4MSwxMyBAQCB2b2lkIEZvbnRDYWNoZTo6cGxhdGZvcm1QdXJnZUluYWN0aXZlRm9udERh
dGEoKQogICAgIH0KICAgICBmb3IgKGF1dG8mIGZvbnQgOiB0b1JlbW92ZSkKICAgICAgICAgZmFs
bGJhY2tEZWR1cFNldCgpLnJlbW92ZShmb250KTsKKworI2lmIEhBVkUoRElTQUxMT1dBQkxFX1VT
RVJfSU5TVEFMTEVEX0ZPTlRTKQorICAgIEZvbnREYXRhYmFzZTo6c2luZ2xldG9uQWxsb3dpbmdV
c2VySW5zdGFsbGVkRm9udHMoKS5jbGVhcigpOworICAgIEZvbnREYXRhYmFzZTo6c2luZ2xldG9u
RGlzYWxsb3dpbmdVc2VySW5zdGFsbGVkRm9udHMoKS5jbGVhcigpOworI2Vsc2UKKyAgICBGb250
RGF0YWJhc2U6OnNpbmdsZXRvbigpLmNsZWFyKCk7CisjZW5kaWYKIH0KIAogI2lmIFBMQVRGT1JN
KElPU19GQU1JTFkpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>392012</attachid>
            <date>2020-02-28 13:17:40 -0800</date>
            <delta_ts>2020-02-28 13:34:22 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-208389-20200228131739.patch</filename>
            <type>text/plain</type>
            <size>1645</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTU1MzMwNjQ0ODJjZTA0
ZDJkNDM5ZmFhOTYxYzlkZjYzZDI2ZDI3Yy4uZjE1MzlmMTRjYzZiZTE3OTdiZjM3MjlkNzVjOTY4
ZjA0YjcyODhiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAyLTI4ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+IGFuZCBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBh
cHBsZS5jb20+CisKKyAgICAgICAgQ2xlYXIgRm9udERhdGFiYXNlIHdoZW4gbG93LW1lbW9yeS13
YXJuaW5nIGhhcHBlbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIwODM4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEZvbnREYXRhYmFzZSBjYW4gbW9ub3RvbmljYWxseSBpbmNyZWFzZS4gV2Ugc2hvdWxk
IGNsZWFyIGl0IHdoZW4gbG93LW1lbW9yeS13YXJuaW5nIGhhcHBlbnMuCisKKyAgICAgICAgKiBw
bGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250Q2FjaGVDb3JlVGV4dC5jcHA6CisgICAgICAgIChX
ZWJDb3JlOjpGb250Q2FjaGU6OnBsYXRmb3JtUHVyZ2VJbmFjdGl2ZUZvbnREYXRhKToKKwogMjAy
MC0wMi0yOCAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ29u
dmVydCBmcmFtZSBhZGRyZXNzIGluIGxvZ2dpbmcgc3RhdGVtZW50cyB0byBwYWdlSUQrZnJhbWVJ
RApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9u
dENhY2hlQ29yZVRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29j
b2EvRm9udENhY2hlQ29yZVRleHQuY3BwCmluZGV4IGM4M2Y4MzUyMTg3MzIzY2IyNmVlNmIyMDA1
YTg1M2E2NWI3N2Y1M2MuLjNlYzAyYWRhMDU2NjcyYjliNjA5YjliM2MwNzI4Y2Y5ZWYyOTUyODUg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0ZvbnRD
YWNoZUNvcmVUZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j
b2NvYS9Gb250Q2FjaGVDb3JlVGV4dC5jcHAKQEAgLTEzODEsNiArMTM4MSwxMyBAQCB2b2lkIEZv
bnRDYWNoZTo6cGxhdGZvcm1QdXJnZUluYWN0aXZlRm9udERhdGEoKQogICAgIH0KICAgICBmb3Ig
KGF1dG8mIGZvbnQgOiB0b1JlbW92ZSkKICAgICAgICAgZmFsbGJhY2tEZWR1cFNldCgpLnJlbW92
ZShmb250KTsKKworI2lmIEhBVkUoRElTQUxMT1dBQkxFX1VTRVJfSU5TVEFMTEVEX0ZPTlRTKQor
ICAgIEZvbnREYXRhYmFzZTo6c2luZ2xldG9uQWxsb3dpbmdVc2VySW5zdGFsbGVkRm9udHMoKS5j
bGVhcigpOworICAgIEZvbnREYXRhYmFzZTo6c2luZ2xldG9uRGlzYWxsb3dpbmdVc2VySW5zdGFs
bGVkRm9udHMoKS5jbGVhcigpOworI2Vsc2UKKyAgICBGb250RGF0YWJhc2U6OnNpbmdsZXRvbigp
LmNsZWFyKCk7CisjZW5kaWYKIH0KIAogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCg==
</data>
<flag name="review"
          id="407504"
          type_id="1"
          status="+"
          setter="cdumez"
    />
    <flag name="commit-queue"
          id="407507"
          type_id="3"
          status="-"
          setter="cdumez"
    />
          </attachment>
      

    </bug>

</bugzilla>