208383 2020-02-28 10:44:27 -0800 Deflake animations/font-variations tests 2020-02-28 12:22:15 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208382 InRadar P2 Normal --- 1 ap ap commit-queue graouts mmaxfield rniwa webkit-bug-importer oldest_to_newest 1624002 0 ap 2020-02-28 10:44:27 -0800 animations/font-variations are flaky because of bug 208382. There is an easy workaround that also simplifies the tests, not sure why they were even written in the more complex manner. 1624006 1 391995 ap 2020-02-28 10:49:23 -0800 Created attachment 391995 proposed fix 1624069 2 391995 commit-queue 2020-02-28 12:21:36 -0800 Comment on attachment 391995 proposed fix Clearing flags on attachment: 391995 Committed r257652: <https://trac.webkit.org/changeset/257652> 1624070 3 commit-queue 2020-02-28 12:21:37 -0800 All reviewed patches have been landed. Closing bug. 1624072 4 webkit-bug-importer 2020-02-28 12:22:15 -0800 <rdar://problem/59898045> 391995 2020-02-28 10:49:23 -0800 2020-02-28 12:21:36 -0800 proposed fix font-variations.txt text/plain 5629 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI1NzY0MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIwLTAyLTI4ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIERlZmxha2UgYW5pbWF0aW9ucy9mb250LXZh cmlhdGlvbnMgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwODM4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFVzZSBkb2N1bWVudC5mb250cy5yZWFkeSB0byB3b3JrIGFyb3VuZCBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzgyLAorICAgICAgICBhbmQgdG8gc2lt cGxpZnkgdGhlIHRlc3RzLgorCisgICAgICAgICogYW5pbWF0aW9ucy9mb250LXZhcmlhdGlvbnMv Zm9udC1zdHJldGNoLmh0bWw6CisgICAgICAgICogYW5pbWF0aW9ucy9mb250LXZhcmlhdGlvbnMv Zm9udC1zdHlsZS5odG1sOgorICAgICAgICAqIGFuaW1hdGlvbnMvZm9udC12YXJpYXRpb25zL2Zv bnQtdmFyaWF0aW9uLXNldHRpbmdzLW9yZGVyLmh0bWw6CisgICAgICAgICogYW5pbWF0aW9ucy9m b250LXZhcmlhdGlvbnMvZm9udC12YXJpYXRpb24tc2V0dGluZ3MtdW5saWtlLmh0bWw6CisgICAg ICAgICogYW5pbWF0aW9ucy9mb250LXZhcmlhdGlvbnMvZm9udC12YXJpYXRpb24tc2V0dGluZ3Mu aHRtbDoKKyAgICAgICAgKiBhbmltYXRpb25zL2ZvbnQtdmFyaWF0aW9ucy9mb250LXdlaWdodC5o dG1sOgorCiAyMDIwLTAyLTI4ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS10gR2FyZGVuaW5nLCB1cGRhdGUgVGVzdEV4cGVjdGF0aW9ucwpJbmRl eDogTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9mb250LXZhcmlhdGlvbnMvZm9udC1zdHJldGNoLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9mb250LXZhcmlhdGlvbnMv Zm9udC1zdHJldGNoLmh0bWwJKHJldmlzaW9uIDI1NzIwMCkKKysrIExheW91dFRlc3RzL2FuaW1h dGlvbnMvZm9udC12YXJpYXRpb25zL2ZvbnQtc3RyZXRjaC5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0zMSwxMyArMzEsNyBAQCB2YXIgZXhwZWN0ZWRWYWx1ZXMgPSBbCiAgICAgWyJUaGVBbmltYXRp b24iLCAyLjAsICJib3giLCAiZm9udC1zdHJldGNoIiwgIjE4MyIsIDFdLAogXTsKIAotdmFyIHBy b21pc2VzID0gW107Ci0KLWRvY3VtZW50LmZvbnRzLmZvckVhY2goZnVuY3Rpb24oZikgewotICAg IHByb21pc2VzLnB1c2goZi5sb2FkZWQpOwotfSk7Ci0KLVByb21pc2UuYWxsKHByb21pc2VzKS50 aGVuKGZ1bmN0aW9uKCkgeworZG9jdW1lbnQuZm9udHMucmVhZHkudGhlbihmdW5jdGlvbigpIHsK ICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYm94Iikuc3R5bGUuYW5pbWF0aW9uTmFtZSA9 ICJUaGVBbmltYXRpb24iOwogICAgIHJ1bkFuaW1hdGlvblRlc3QoZXhwZWN0ZWRWYWx1ZXMsIHVu ZGVmaW5lZCwgdW5kZWZpbmVkLCB1bmRlZmluZWQsIGZhbHNlLCB1bmRlZmluZWQpOwogfSk7Cklu ZGV4OiBMYXlvdXRUZXN0cy9hbmltYXRpb25zL2ZvbnQtdmFyaWF0aW9ucy9mb250LXN0eWxlLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9mb250LXZhcmlhdGlvbnMv Zm9udC1zdHlsZS5odG1sCShyZXZpc2lvbiAyNTcyMDApCisrKyBMYXlvdXRUZXN0cy9hbmltYXRp b25zL2ZvbnQtdmFyaWF0aW9ucy9mb250LXN0eWxlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTMx LDEzICszMSw3IEBAIHZhciBleHBlY3RlZFZhbHVlcyA9IFsKICAgICBbIlRoZUFuaW1hdGlvbiIs IDIuMCwgImJveCIsICJmb250LXN0eWxlIiwgIm9ibGlxdWUgNjYuMzMzMyIsIDEwXSwKIF07CiAK LXZhciBwcm9taXNlcyA9IFtdOwotCi1kb2N1bWVudC5mb250cy5mb3JFYWNoKGZ1bmN0aW9uKGYp IHsKLSAgICBwcm9taXNlcy5wdXNoKGYubG9hZGVkKTsKLX0pOwotCi1Qcm9taXNlLmFsbChwcm9t aXNlcykudGhlbihmdW5jdGlvbigpIHsKK2RvY3VtZW50LmZvbnRzLnJlYWR5LnRoZW4oZnVuY3Rp b24oKSB7CiAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJveCIpLnN0eWxlLmFuaW1hdGlv bk5hbWUgPSAiVGhlQW5pbWF0aW9uIjsKICAgICBydW5BbmltYXRpb25UZXN0KGV4cGVjdGVkVmFs dWVzLCB1bmRlZmluZWQsIHVuZGVmaW5lZCwgdW5kZWZpbmVkLCBmYWxzZSwgdW5kZWZpbmVkKTsK IH0pOwpJbmRleDogTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9mb250LXZhcmlhdGlvbnMvZm9udC12 YXJpYXRpb24tc2V0dGluZ3Mtb3JkZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9h bmltYXRpb25zL2ZvbnQtdmFyaWF0aW9ucy9mb250LXZhcmlhdGlvbi1zZXR0aW5ncy1vcmRlci5o dG1sCShyZXZpc2lvbiAyNTcyMDApCisrKyBMYXlvdXRUZXN0cy9hbmltYXRpb25zL2ZvbnQtdmFy aWF0aW9ucy9mb250LXZhcmlhdGlvbi1zZXR0aW5ncy1vcmRlci5odG1sCSh3b3JraW5nIGNvcHkp CkBAIC0zNSwxMyArMzUsNyBAQCB2YXIgZXhwZWN0ZWRWYWx1ZXMgPSBbCiAgICAgWyJUaGVBbmlt YXRpb24iLCAyLjAsICJib3giLCAiZm9udC12YXJpYXRpb24tc2V0dGluZ3MiLCAiXCJ3ZHRoXCIg NzY2LjY2NjYsIFwiaGdodFwiIDY2Ni42NjY2IiwgNV0sCiBdOwogCi12YXIgcHJvbWlzZXMgPSBb XTsKLQotZG9jdW1lbnQuZm9udHMuZm9yRWFjaChmdW5jdGlvbihmKSB7Ci0gICAgcHJvbWlzZXMu cHVzaChmLmxvYWRlZCk7Ci19KTsKLQotUHJvbWlzZS5hbGwocHJvbWlzZXMpLnRoZW4oZnVuY3Rp b24oKSB7Citkb2N1bWVudC5mb250cy5yZWFkeS50aGVuKGZ1bmN0aW9uKCkgewogICAgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJib3giKS5zdHlsZS5hbmltYXRpb25OYW1lID0gIlRoZUFuaW1h dGlvbiI7CiAgICAgcnVuQW5pbWF0aW9uVGVzdChleHBlY3RlZFZhbHVlcywgdW5kZWZpbmVkLCB1 bmRlZmluZWQsIHVuZGVmaW5lZCwgZmFsc2UsIHVuZGVmaW5lZCk7CiB9KTsKSW5kZXg6IExheW91 dFRlc3RzL2FuaW1hdGlvbnMvZm9udC12YXJpYXRpb25zL2ZvbnQtdmFyaWF0aW9uLXNldHRpbmdz LXVubGlrZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2FuaW1hdGlvbnMvZm9udC12 YXJpYXRpb25zL2ZvbnQtdmFyaWF0aW9uLXNldHRpbmdzLXVubGlrZS5odG1sCShyZXZpc2lvbiAy NTcyMDApCisrKyBMYXlvdXRUZXN0cy9hbmltYXRpb25zL2ZvbnQtdmFyaWF0aW9ucy9mb250LXZh cmlhdGlvbi1zZXR0aW5ncy11bmxpa2UuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMzcsMTEgKzM3 LDcgQEAgdmFyIGV4cGVjdGVkVmFsdWVzID0gWwogCiB2YXIgcHJvbWlzZXMgPSBbXTsKIAotZG9j dW1lbnQuZm9udHMuZm9yRWFjaChmdW5jdGlvbihmKSB7Ci0gICAgcHJvbWlzZXMucHVzaChmLmxv YWRlZCk7Ci19KTsKLQotUHJvbWlzZS5hbGwocHJvbWlzZXMpLnRoZW4oZnVuY3Rpb24oKSB7Citk b2N1bWVudC5mb250cy5yZWFkeS50aGVuKGZ1bmN0aW9uKCkgewogICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJib3giKS5zdHlsZS5hbmltYXRpb25OYW1lID0gIlRoZUFuaW1hdGlvbiI7CiAg ICAgcnVuQW5pbWF0aW9uVGVzdChleHBlY3RlZFZhbHVlcywgdW5kZWZpbmVkLCB1bmRlZmluZWQs IHVuZGVmaW5lZCwgZmFsc2UsIHVuZGVmaW5lZCk7CiB9KTsKSW5kZXg6IExheW91dFRlc3RzL2Fu aW1hdGlvbnMvZm9udC12YXJpYXRpb25zL2ZvbnQtdmFyaWF0aW9uLXNldHRpbmdzLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9mb250LXZhcmlhdGlvbnMvZm9udC12 YXJpYXRpb24tc2V0dGluZ3MuaHRtbAkocmV2aXNpb24gMjU3MjAwKQorKysgTGF5b3V0VGVzdHMv YW5pbWF0aW9ucy9mb250LXZhcmlhdGlvbnMvZm9udC12YXJpYXRpb24tc2V0dGluZ3MuaHRtbAko d29ya2luZyBjb3B5KQpAQCAtMzUsMTMgKzM1LDcgQEAgdmFyIGV4cGVjdGVkVmFsdWVzID0gWwog ICAgIFsiVGhlQW5pbWF0aW9uIiwgMi4wLCAiYm94IiwgImZvbnQtdmFyaWF0aW9uLXNldHRpbmdz IiwgIlwid2R0aFwiIDczMy4zMzMzIiwgNV0sCiBdOwogCi12YXIgcHJvbWlzZXMgPSBbXTsKLQot ZG9jdW1lbnQuZm9udHMuZm9yRWFjaChmdW5jdGlvbihmKSB7Ci0gICAgcHJvbWlzZXMucHVzaChm LmxvYWRlZCk7Ci19KTsKLQotUHJvbWlzZS5hbGwocHJvbWlzZXMpLnRoZW4oZnVuY3Rpb24oKSB7 Citkb2N1bWVudC5mb250cy5yZWFkeS50aGVuKGZ1bmN0aW9uKCkgewogICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJib3giKS5zdHlsZS5hbmltYXRpb25OYW1lID0gIlRoZUFuaW1hdGlvbiI7 CiAgICAgcnVuQW5pbWF0aW9uVGVzdChleHBlY3RlZFZhbHVlcywgdW5kZWZpbmVkLCB1bmRlZmlu ZWQsIHVuZGVmaW5lZCwgZmFsc2UsIHVuZGVmaW5lZCk7CiB9KTsKSW5kZXg6IExheW91dFRlc3Rz L2FuaW1hdGlvbnMvZm9udC12YXJpYXRpb25zL2ZvbnQtd2VpZ2h0Lmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9mb250LXZhcmlhdGlvbnMvZm9udC13ZWlnaHQuaHRt bAkocmV2aXNpb24gMjU3MjAwKQorKysgTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9mb250LXZhcmlh dGlvbnMvZm9udC13ZWlnaHQuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMzEsMTMgKzMxLDcgQEAg dmFyIGV4cGVjdGVkVmFsdWVzID0gWwogICAgIFsiVGhlQW5pbWF0aW9uIiwgMi4wLCAiYm94Iiwg ImZvbnQtd2VpZ2h0IiwgIjM2Ni42NjY2IiwgMjBdLAogXTsKIAotdmFyIHByb21pc2VzID0gW107 Ci0KLWRvY3VtZW50LmZvbnRzLmZvckVhY2goZnVuY3Rpb24oZikgewotICAgIHByb21pc2VzLnB1 c2goZi5sb2FkZWQpOwotfSk7Ci0KLVByb21pc2UuYWxsKHByb21pc2VzKS50aGVuKGZ1bmN0aW9u KCkgeworZG9jdW1lbnQuZm9udHMucmVhZHkudGhlbihmdW5jdGlvbigpIHsKICAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiYm94Iikuc3R5bGUuYW5pbWF0aW9uTmFtZSA9ICJUaGVBbmltYXRp b24iOwogICAgIHJ1bkFuaW1hdGlvblRlc3QoZXhwZWN0ZWRWYWx1ZXMsIHVuZGVmaW5lZCwgdW5k ZWZpbmVkLCB1bmRlZmluZWQsIGZhbHNlLCB1bmRlZmluZWQpOwogfSk7Cg==