208381 2020-02-28 10:37:06 -0800 Add quirk to disable to back/forward cache on docs.google.com 2020-03-02 23:18:46 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen annulen beidson ggaren rniwa webkit-bug-importer wenson_hsieh youennf oldest_to_newest 1623993 0 cdumez 2020-02-28 10:37:06 -0800 Add quirk to disable to back/forward cache on docs.google.com. docs.google.com used to bypass the back/forward cache by serving "Cache-Control: no-store" over HTTPS. We started caching such content in r250437 but the docs.google.com content unfortunately is not currently compatible because it puts an overlay over the page and starts an animation when navigating away and fails to remove those when coming back from the back/forward cache (e.g. in 'pageshow' event handler). 1623994 1 cdumez 2020-02-28 10:37:22 -0800 <rdar://problem/59893415> 1623995 2 391990 cdumez 2020-02-28 10:38:36 -0800 Created attachment 391990 Patch 1624113 3 391990 rniwa 2020-02-28 13:42:48 -0800 Comment on attachment 391990 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391990&action=review > Source/WebCore/page/Quirks.cpp:634 > + if (topURL.protocolIs("https") && equalLettersIgnoringASCIICase(host, "docs.google.com")) { Hm... this wouldn't work with Google's hosted apps, would it? 1624115 4 cdumez 2020-02-28 13:44:19 -0800 (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 391990 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391990&action=review > > > Source/WebCore/page/Quirks.cpp:634 > > + if (topURL.protocolIs("https") && equalLettersIgnoringASCIICase(host, "docs.google.com")) { > > Hm... this wouldn't work with Google's hosted apps, would it? Good point. Ideally, we'd find another way to detect google docs which does not rely on the host. Will need to think about it. 1624119 5 rniwa 2020-02-28 13:53:47 -0800 (In reply to Chris Dumez from comment #4) > (In reply to Ryosuke Niwa from comment #3) > > Comment on attachment 391990 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=391990&action=review > > > > > Source/WebCore/page/Quirks.cpp:634 > > > + if (topURL.protocolIs("https") && equalLettersIgnoringASCIICase(host, "docs.google.com")) { > > > > Hm... this wouldn't work with Google's hosted apps, would it? > > Good point. Ideally, we'd find another way to detect google docs which does > not rely on the host. Will need to think about it. Do they add some kind of event listener, meta tag, etc... that makes it easy to target? 1624187 6 392034 cdumez 2020-02-28 17:01:28 -0800 Created attachment 392034 Patch 1624188 7 cdumez 2020-02-28 17:02:43 -0800 (In reply to Ryosuke Niwa from comment #5) > (In reply to Chris Dumez from comment #4) > > (In reply to Ryosuke Niwa from comment #3) > > > Comment on attachment 391990 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=391990&action=review > > > > > > > Source/WebCore/page/Quirks.cpp:634 > > > > + if (topURL.protocolIs("https") && equalLettersIgnoringASCIICase(host, "docs.google.com")) { > > > > > > Hm... this wouldn't work with Google's hosted apps, would it? > > > > Good point. Ideally, we'd find another way to detect google docs which does > > not rely on the host. Will need to think about it. > > Do they add some kind of event listener, meta tag, etc... that makes it easy > to target? Here is an alternative fix that works by detecting the overlay that they put on top of the page when navigating away. 1624227 8 392034 rniwa 2020-02-28 21:46:40 -0800 Comment on attachment 392034 Patch Looks good to me. 1624557 9 392034 cdumez 2020-03-02 08:25:28 -0800 Comment on attachment 392034 Patch Clearing flags on attachment: 392034 Committed r257714: <https://trac.webkit.org/changeset/257714> 1624558 10 cdumez 2020-03-02 08:25:30 -0800 All reviewed patches have been landed. Closing bug. 1624559 11 annulen 2020-03-02 08:30:36 -0800 Is it really correct to have such a quirk specifically for Google Docs? Any other web application can be potentially broken, as they may rely on Cache-Control headers to work properly in any navigation. 1624560 12 cdumez 2020-03-02 08:36:25 -0800 (In reply to Konstantin Tokarev from comment #11) > Is it really correct to have such a quirk specifically for Google Docs? Any > other web application can be potentially broken, as they may rely on > Cache-Control headers to work properly in any navigation. Cache-Control is about the HTTP disk cache, and works. There is no documented impact of the Cache-Control header on the back/forward cache. 1624563 13 annulen 2020-03-02 08:44:16 -0800 It seems to me that RFC 7234 doesn't make a difference between disk and memory caches. And CachedResourceLoader (rightfully) takes them into account, though it's not a disk cache. 1624566 14 annulen 2020-03-02 08:56:42 -0800 If there is a consensus that back/forward cache should be exempt from caching rules[*], IMHO it needs to be codified somewhere in Web Platform standards so that authors could design their pages accordingly. [*]given that Google product doesn't assume this it seems to me there isn't) 1624958 15 rniwa 2020-03-02 23:18:46 -0800 (In reply to Konstantin Tokarev from comment #14) > If there is a consensus that back/forward cache should be exempt from > caching rules[*], IMHO it needs to be codified somewhere in Web Platform > standards so that authors could design their pages accordingly. > > [*]given that Google product doesn't assume this it seems to me there isn't) Back/Forward cache isn't like a "cache". When a page is put into back/forward cache, all page's states are still here. It's as if the page never navigated away. So it's not really a cache in the sense of the browser saving sub-resources & re-loading a web page using those cached resources. For web pages, it behaves as if the user hadn't navigated away / never been closed. 391990 2020-02-28 10:38:36 -0800 2020-02-28 17:01:27 -0800 Patch bug-208381-20200228103835.patch text/plain 2455 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODcyNjVhNTEwNmE4Mzcy N2Y3OTZlYzZjMjkyMTdkNjgwZWFhN2Q5YS4uMDg5ZmU1NDFiMGZhZjg3NDhlNWRhZmVmMmNiMGE1 ZmU5YTZmZmM5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTAyLTI4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHF1aXJrIHRvIGRpc2Fi bGUgdG8gYmFjay9mb3J3YXJkIGNhY2hlIG9uIGRvY3MuZ29vZ2xlLmNvbQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzgxCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81OTg5MzQxNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgcXVpcmsgdG8gZGlzYWJsZSB0byBiYWNrL2ZvcndhcmQgY2FjaGUg b24gZG9jcy5nb29nbGUuY29tLgorCisgICAgICAgIGRvY3MuZ29vZ2xlLmNvbSB1c2VkIHRvIGJ5 cGFzcyB0aGUgYmFjay9mb3J3YXJkIGNhY2hlIGJ5IHNlcnZpbmcgIkNhY2hlLUNvbnRyb2w6IG5v LXN0b3JlIgorICAgICAgICBvdmVyIEhUVFBTLiBXZSBzdGFydGVkIGNhY2hpbmcgc3VjaCBjb250 ZW50IGluIHIyNTA0MzcgYnV0IHRoZSBkb2NzLmdvb2dsZS5jb20gY29udGVudAorICAgICAgICB1 bmZvcnR1bmF0ZWx5IGlzIG5vdCBjdXJyZW50bHkgY29tcGF0aWJsZSBiZWNhdXNlIGl0IHB1dHMg YW4gb3ZlcmxheSBvdmVyIHRoZSBwYWdlIGFuZAorICAgICAgICBzdGFydHMgYW4gYW5pbWF0aW9u IHdoZW4gbmF2aWdhdGluZyBhd2F5IGFuZCBmYWlscyB0byByZW1vdmUgdGhvc2Ugd2hlbiBjb21p bmcgYmFjayBmcm9tCisgICAgICAgIHRoZSBiYWNrL2ZvcndhcmQgY2FjaGUgKGUuZy4gaW4gJ3Bh Z2VzaG93JyBldmVudCBoYW5kbGVyKS4KKworICAgICAgICAqIHBhZ2UvUXVpcmtzLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlF1aXJrczo6c2hvdWxkQnlwYXNzQmFja0ZvcndhcmRDYWNoZSBjb25z dCk6CisKIDIwMjAtMDItMjggIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgUmVncmVzc2lvbiByMjU3NjEyOiBXaW5kb3dzIGJ1aWxkIGJyb2tlbgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9RdWlya3MuY3BwCmluZGV4IGNlYzVlNGRmMzU0MGNlYjI3MWIwYzYzZWFkZjQxM2RiNWE1 ZTEzZWUuLjFhNTg3MzE3ZDg5ODg2MmJiYzNiYmI5M2E5NWY1M2YzYWVlMWJjZTkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL1F1aXJrcy5jcHAKQEAgLTYyNyw2ICs2MjcsMTUgQEAgYm9vbCBRdWlya3M6OnNob3VsZEJ5 cGFzc0JhY2tGb3J3YXJkQ2FjaGUoKSBjb25zdAogICAgICAgICAgICAgcmV0dXJuIGRvY3VtZW50 TG9hZGVyLT5yZXNwb25zZSgpLmNhY2hlQ29udHJvbENvbnRhaW5zTm9TdG9yZSgpOwogICAgIH0K IAorICAgIC8vIGRvY3MuZ29vZ2xlLmNvbSB1c2VkIHRvIGJ5cGFzcyB0aGUgYmFjay9mb3J3YXJk IGNhY2hlIGJ5IHNlcnZpbmcgIkNhY2hlLUNvbnRyb2w6IG5vLXN0b3JlIiBvdmVyIEhUVFBTLgor ICAgIC8vIFdlIHN0YXJ0ZWQgY2FjaGluZyBzdWNoIGNvbnRlbnQgaW4gcjI1MDQzNyBidXQgdGhl IGRvY3MuZ29vZ2xlLmNvbSBjb250ZW50IHVuZm9ydHVuYXRlbHkgaXMgbm90IGN1cnJlbnRseSBj b21wYXRpYmxlCisgICAgLy8gYmVjYXVzZSBpdCBwdXRzIGFuIG92ZXJsYXkgb3ZlciB0aGUgcGFn ZSBhbmQgc3RhcnRzIGFuIGFuaW1hdGlvbiB3aGVuIG5hdmlnYXRpbmcgYXdheSBhbmQgZmFpbHMg dG8gcmVtb3ZlIHRob3NlCisgICAgLy8gd2hlbiBjb21pbmcgYmFjayBmcm9tIHRoZSBiYWNrL2Zv cndhcmQgY2FjaGUgKGUuZy4gaW4gJ3BhZ2VzaG93JyBldmVudCBoYW5kbGVyKS4gU2VlIDxyZGFy Oi8vcHJvYmxlbS81NzY3MDA2ND4uCisgICAgaWYgKHRvcFVSTC5wcm90b2NvbElzKCJodHRwcyIp ICYmIGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGhvc3QsICJkb2NzLmdvb2dsZS5jb20i KSkgeworICAgICAgICBpZiAoYXV0byogZG9jdW1lbnRMb2FkZXIgPSBtX2RvY3VtZW50LT5mcmFt ZSgpID8gbV9kb2N1bWVudC0+ZnJhbWUoKS0+bG9hZGVyKCkuZG9jdW1lbnRMb2FkZXIoKSA6IG51 bGxwdHIpCisgICAgICAgICAgICByZXR1cm4gZG9jdW1lbnRMb2FkZXItPnJlc3BvbnNlKCkuY2Fj aGVDb250cm9sQ29udGFpbnNOb1N0b3JlKCk7CisgICAgfQorCiAgICAgcmV0dXJuIGZhbHNlOwog fQogCg== 392034 2020-02-28 17:01:28 -0800 2020-03-02 08:25:28 -0800 Patch bug-208381-20200228170128.patch text/plain 2876 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzA5Y2M5Y2YyY2E2NzUy MzY4OGYxOWVkMTRlZGIxMmM1NzRhZWQ5ZC4uZjhmNjNkMTU1ZTVmYmQ1NWE1ODg2YzQ3MTljYjUz MGZlMDRmZjdmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTAyLTI4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHF1aXJrIHRvIGRpc2Fi bGUgdG8gYmFjay9mb3J3YXJkIGNhY2hlIG9uIGRvY3MuZ29vZ2xlLmNvbQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzgxCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81OTg5MzQxNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBHb29nbGUgRG9jcyB1c2VkIHRvIGJ5cGFzcyB0aGUgYmFjay9mb3J3YXJk IGNhY2hlIGJ5IHNlcnZpbmcgIkNhY2hlLUNvbnRyb2w6IG5vLXN0b3JlIgorICAgICAgICBvdmVy IEhUVFBTLiBXZSBzdGFydGVkIGNhY2hpbmcgc3VjaCBjb250ZW50IGluIHIyNTA0MzcgYnV0IHRo ZSBHb29nbGUgRG9jcyBjb250ZW50CisgICAgICAgIHVuZm9ydHVuYXRlbHkgaXMgbm90IGN1cnJl bnRseSBjb21wYXRpYmxlIGJlY2F1c2UgaXQgcHV0cyBhbiBvdmVybGF5IG92ZXIgdGhlIHBhZ2Ug YW5kCisgICAgICAgIHN0YXJ0cyBhbiBhbmltYXRpb24gd2hlbiBuYXZpZ2F0aW5nIGF3YXkgYW5k IGZhaWxzIHRvIHJlbW92ZSB0aG9zZSB3aGVuIGNvbWluZyBiYWNrIGZyb20KKyAgICAgICAgdGhl IGJhY2svZm9yd2FyZCBjYWNoZSAoZS5nLiBpbiAncGFnZXNob3cnIGV2ZW50IGhhbmRsZXIpLgor CisgICAgICAgICogcGFnZS9RdWlya3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UXVpcmtzOjpz aG91bGRCeXBhc3NCYWNrRm9yd2FyZENhY2hlIGNvbnN0KToKKwogMjAyMC0wMi0yOCAgSmVyIE5v YmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BVUF0gSW1wbGVtZW50IE1v ZGVybiBFTUUgQVBJIGluIHRoZSBHUFUgUHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9RdWlya3MuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwCmluZGV4 IGNlYzVlNGRmMzU0MGNlYjI3MWIwYzYzZWFkZjQxM2RiNWE1ZTEzZWUuLjZiMzI2OTIyYmVjODky N2I3NTg5ODUxOTc3YTAzYjA3NDUwZjNmYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvUXVpcmtzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAKQEAgLTM0 LDYgKzM0LDcgQEAKICNpbmNsdWRlICJFdmVudE5hbWVzLmgiCiAjaW5jbHVkZSAiRnJhbWVMb2Fk ZXIuaCIKICNpbmNsdWRlICJIVE1MQm9keUVsZW1lbnQuaCIKKyNpbmNsdWRlICJIVE1MRGl2RWxl bWVudC5oIgogI2luY2x1ZGUgIkhUTUxNZXRhRWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxPYmpl Y3RFbGVtZW50LmgiCiAjaW5jbHVkZSAiSlNFdmVudExpc3RlbmVyLmgiCkBAIC02MjcsNiArNjI4 LDE5IEBAIGJvb2wgUXVpcmtzOjpzaG91bGRCeXBhc3NCYWNrRm9yd2FyZENhY2hlKCkgY29uc3QK ICAgICAgICAgICAgIHJldHVybiBkb2N1bWVudExvYWRlci0+cmVzcG9uc2UoKS5jYWNoZUNvbnRy b2xDb250YWluc05vU3RvcmUoKTsKICAgICB9CiAKKyAgICAvLyBHb29nbGUgRG9jcyB1c2VkIHRv IGJ5cGFzcyB0aGUgYmFjay9mb3J3YXJkIGNhY2hlIGJ5IHNlcnZpbmcgIkNhY2hlLUNvbnRyb2w6 IG5vLXN0b3JlIiBvdmVyIEhUVFBTLgorICAgIC8vIFdlIHN0YXJ0ZWQgY2FjaGluZyBzdWNoIGNv bnRlbnQgaW4gcjI1MDQzNyBidXQgdGhlIEdvb2dsZSBEb2NzIGluZGV4IHBhZ2UgdW5mb3J0dW5h dGVseSBpcyBub3QgY3VycmVudGx5IGNvbXBhdGlibGUKKyAgICAvLyBiZWNhdXNlIGl0IHB1dHMg YW4gb3ZlcmxheSAod2l0aCBjbGFzcyAiZG9jcy1ob21lc2NyZWVuLWZyZWV6ZS1lbC1mdWxsIikg b3ZlciB0aGUgcGFnZSB3aGVuIG5hdmlnYXRpbmcgYXdheSBhbmQgZmFpbHMKKyAgICAvLyB0byBy ZW1vdmUgaXQgd2hlbiBjb21pbmcgYmFjayBmcm9tIHRoZSBiYWNrL2ZvcndhcmQgY2FjaGUgKGUu Zy4gaW4gJ3BhZ2VzaG93JyBldmVudCBoYW5kbGVyKS4gU2VlIDxyZGFyOi8vcHJvYmxlbS81NzY3 MDA2ND4uCisgICAgLy8gTm90ZSB0aGF0IHRoaXMgZG9lcyBub3QgY2hlY2sgZm9yIGRvY3MuZ29v Z2xlLmNvbSBob3N0IGJlY2F1c2Ugb2YgaG9zdGVkIEcgU3VpdGUgYXBwcy4KKyAgICBzdGF0aWMg TmV2ZXJEZXN0cm95ZWQ8Y29uc3QgQXRvbVN0cmluZz4gZ29vZ2xlRG9jc092ZXJsYXlEaXZDbGFz cygiZG9jcy1ob21lc2NyZWVuLWZyZWV6ZS1lbC1mdWxsIiwgQXRvbVN0cmluZzo6Q29uc3RydWN0 RnJvbUxpdGVyYWwpOworICAgIGF1dG8qIGZpcnN0Q2hpbGRJbkJvZHkgPSBtX2RvY3VtZW50LT5i b2R5KCkgPyBtX2RvY3VtZW50LT5ib2R5KCktPmZpcnN0Q2hpbGQoKSA6IG51bGxwdHI7CisgICAg aWYgKGlzPEhUTUxEaXZFbGVtZW50PihmaXJzdENoaWxkSW5Cb2R5KSkgeworICAgICAgICBhdXRv JiBkaXYgPSBkb3duY2FzdDxIVE1MRGl2RWxlbWVudD4oKmZpcnN0Q2hpbGRJbkJvZHkpOworICAg ICAgICBpZiAoZGl2Lmhhc0NsYXNzKCkgJiYgZGl2LmNsYXNzTmFtZXMoKS5jb250YWlucyhnb29n bGVEb2NzT3ZlcmxheURpdkNsYXNzKSkKKyAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgIH0K KwogICAgIHJldHVybiBmYWxzZTsKIH0KIAo=