208377 2020-02-28 10:12:24 -0800 Fix issue in cmake build for checking ccache 2020-02-28 11:56:14 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208007 InRadar P2 Normal --- 1 keith_miller keith_miller annulen clopez commit-queue ews-watchlist gyuyoung.kim ryuan.choi sergio webkit-bug-importer oldest_to_newest 1623981 0 keith_miller 2020-02-28 10:12:24 -0800 Fix issue in cmake build for checking ccache 1623988 1 391987 keith_miller 2020-02-28 10:18:05 -0800 Created attachment 391987 Patch 1623989 2 391988 keith_miller 2020-02-28 10:21:25 -0800 Created attachment 391988 Patch 1624001 3 391988 clopez 2020-02-28 10:44:17 -0800 Comment on attachment 391988 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391988&action=review > Source/cmake/WebKitCCache.cmake:17 > if (NOT DEFINED ENV{CCACHE_SLOPPINESS}) > set(ENV{CCACHE_SLOPPINESS} time_macros) > endif () > + # FIXME: readlink -f isn't supported on macOS. https://bugs.webkit.org/show_bug.cgi?id=208379 > execute_process(COMMAND readlink -f ${CMAKE_CXX_COMPILER} RESULT_VARIABLE READLINK_RETCODE OUTPUT_VARIABLE REAL_CXX_PATH OUTPUT_STRIP_TRAILING_WHITESPACE ERROR_QUIET) > execute_process(COMMAND which ${CCACHE_FOUND} RESULT_VARIABLE WHICH_RETCODE OUTPUT_VARIABLE REAL_CCACHE_PATH OUTPUT_STRIP_TRAILING_WHITESPACE ERROR_QUIET) > - if (${WHICH_RETCODE} EQUAL 0 AND ${READLINK_RETCODE} EQUAL 0 AND ${REAL_CXX_PATH} STREQUAL ${REAL_CCACHE_PATH}) > + if (${WHICH_RETCODE} EQUAL 0 AND ${READLINK_RETCODE} EQUAL 0 AND "${REAL_CXX_PATH}" STREQUAL "${REAL_CCACHE_PATH}") This codeblock should not execute on Mac. Its inside a if (!PORT STREQUAL "Mac") 1624020 4 391988 keith_miller 2020-02-28 11:11:53 -0800 Comment on attachment 391988 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391988&action=review >> Source/cmake/WebKitCCache.cmake:17 >> + if (${WHICH_RETCODE} EQUAL 0 AND ${READLINK_RETCODE} EQUAL 0 AND "${REAL_CXX_PATH}" STREQUAL "${REAL_CCACHE_PATH}") > > This codeblock should not execute on Mac. > Its inside a if (!PORT STREQUAL "Mac") If you build JSCOnly you'll hit it. 1624024 5 keith_miller 2020-02-28 11:13:08 -0800 (In reply to Keith Miller from comment #4) > Comment on attachment 391988 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391988&action=review > > >> Source/cmake/WebKitCCache.cmake:17 > >> + if (${WHICH_RETCODE} EQUAL 0 AND ${READLINK_RETCODE} EQUAL 0 AND "${REAL_CXX_PATH}" STREQUAL "${REAL_CCACHE_PATH}") > > > > This codeblock should not execute on Mac. > > Its inside a if (!PORT STREQUAL "Mac") > > If you build JSCOnly you'll hit it. Regardless, you'll have the same problem if either of the command fails on any other platform for some reason. 1624043 6 391988 clopez 2020-02-28 11:26:29 -0800 Comment on attachment 391988 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391988&action=review >>>> Source/cmake/WebKitCCache.cmake:17 >>>> + if (${WHICH_RETCODE} EQUAL 0 AND ${READLINK_RETCODE} EQUAL 0 AND "${REAL_CXX_PATH}" STREQUAL "${REAL_CCACHE_PATH}") >>> >>> This codeblock should not execute on Mac. >>> Its inside a if (!PORT STREQUAL "Mac") >> >> If you build JSCOnly you'll hit it. > > Regardless, you'll have the same problem if either of the command fails on any other platform for some reason. I see 1624056 7 391988 commit-queue 2020-02-28 11:55:25 -0800 Comment on attachment 391988 Patch Clearing flags on attachment: 391988 Committed r257649: <https://trac.webkit.org/changeset/257649> 1624057 8 commit-queue 2020-02-28 11:55:27 -0800 All reviewed patches have been landed. Closing bug. 1624058 9 webkit-bug-importer 2020-02-28 11:56:14 -0800 <rdar://problem/59897121> 391987 2020-02-28 10:18:05 -0800 2020-02-28 10:21:23 -0800 Patch bug-208377-20200228101805.patch text/plain 2357 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0Q0NhY2hlLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdENDYWNoZS5jbWFrZQppbmRleCBj Yjk5ZjU3MWQzYTZkZTJjOWMyZDI5OTkyNTZjZWQ1YTJlMTY4OWQyLi44Zjk5OWJjODhiNWU0MDQz ZTcwMjI3MTI1MjUzZjJiMzM3Nzg0ZmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q0NhY2hlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDQ2FjaGUuY21ha2UKQEAgLTEx LDkgKzExLDEwIEBAIGlmIChOT1QgIiRFTlZ7V0tfVVNFX0NDQUNIRX0iIFNUUkVRVUFMICJOTyIp CiAgICAgICAgICAgICBpZiAoTk9UIERFRklORUQgRU5We0NDQUNIRV9TTE9QUElORVNTfSkKICAg ICAgICAgICAgICAgICBzZXQoRU5We0NDQUNIRV9TTE9QUElORVNTfSB0aW1lX21hY3JvcykKICAg ICAgICAgICAgIGVuZGlmICgpCisgICAgICAgICAgICAjIEZJWE1FOiByZWFkbGluayAtZiBpc24n dCBzdXBwb3J0ZWQgb24gbWFjT1MuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDgzNzkKICAgICAgICAgICAgIGV4ZWN1dGVfcHJvY2VzcyhDT01NQU5EIHJlYWRsaW5r IC1mICR7Q01BS0VfQ1hYX0NPTVBJTEVSfSBSRVNVTFRfVkFSSUFCTEUgUkVBRExJTktfUkVUQ09E RSBPVVRQVVRfVkFSSUFCTEUgUkVBTF9DWFhfUEFUSCBPVVRQVVRfU1RSSVBfVFJBSUxJTkdfV0hJ VEVTUEFDRSBFUlJPUl9RVUlFVCkKICAgICAgICAgICAgIGV4ZWN1dGVfcHJvY2VzcyhDT01NQU5E IHdoaWNoICR7Q0NBQ0hFX0ZPVU5EfSBSRVNVTFRfVkFSSUFCTEUgV0hJQ0hfUkVUQ09ERSBPVVRQ VVRfVkFSSUFCTEUgUkVBTF9DQ0FDSEVfUEFUSCBPVVRQVVRfU1RSSVBfVFJBSUxJTkdfV0hJVEVT UEFDRSBFUlJPUl9RVUlFVCkKLSAgICAgICAgICAgIGlmICgke1dISUNIX1JFVENPREV9IEVRVUFM IDAgQU5EICR7UkVBRExJTktfUkVUQ09ERX0gRVFVQUwgMCBBTkQgJHtSRUFMX0NYWF9QQVRIfSBT VFJFUVVBTCAke1JFQUxfQ0NBQ0hFX1BBVEh9KQorICAgICAgICAgICAgaWYgKCR7V0hJQ0hfUkVU Q09ERX0gRVFVQUwgMCBBTkQgJHtSRUFETElOS19SRVRDT0RFfSBFUVVBTCAwIEFORCAiJHtSRUFM X0NYWF9QQVRIfSIgU1RSRVFVQUwgIiR7UkVBTF9DQ0FDSEVfUEFUSH0iKQogICAgICAgICAgICAg ICAgIG1lc3NhZ2UoU1RBVFVTICJFbmFibGluZyBjY2FjaGU6IENvbXBpbGVyIHBhdGggYWxyZWFk eSBwb2ludGluZyB0byBjY2FjaGUuIE5vdCBzZXR0aW5nIGNjYWNoZSBwcmVmaXguIikKICAgICAg ICAgICAgIGVsc2UgKCkKICAgICAgICAgICAgICAgICBtZXNzYWdlKFNUQVRVUyAiRW5hYmxpbmcg Y2NhY2hlOiBTZXR0aW5nIGNjYWNoZSBwcmVmaXggZm9yIGNvbXBpbGVyLiIpCmRpZmYgLS1naXQg YS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYWU2N2FiNjY4MTc5NGFmMTgxYjE3NWVlZTFh ZjIwZDkzMWI5YzJhOC4uODA3OTYwZGI5NWJlYWFkZjE1OTYxNzRiODNhYzJjYTA1NzIyNjcxMCAx MDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisy MDIwLTAyLTI4ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAg ICAgIEZpeCBpc3N1ZSBpbiBjbWFrZSBidWlsZCBmb3IgY2hlY2tpbmcgY2NhY2hlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgzNzcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBlaXRoZXIgb2YgdGhl ICJyZWFkbGluayIgb3IgIndoaWNoIiBjb21tYW5kcyBmYWlsIHdoZW4gbG9va2luZyBmb3IgdGhl IGNjYWNoZSBwcmVmaXgKKyAgICAgICAgdGhlIG91dHB1dCB2YXJpYWJsZXMgd2lsbCBiZSBlbXB0 eSBhbmQgYW4gaW52YWxpZCBleHByZXNzaW9uIHdpbGwgYmUgcHJvdmlkZWQgdG8gQ01ha2UuCisg ICAgICAgIGUuZy4gd2Ugd2lsbCBnZXQgc29tZXRoaW5nIGxpa2U6CisgICAgICAgIGlmICgiMCIg IkVRVUFMIiAiMCIgIkFORCIgIjEiICJFUVVBTCIgIjAiICJBTkQiICJTVFJFUVVBTCIgIi91c3Iv bG9jYWwvYmluL2NjYWNoZSIpCisKKyAgICAgICAgVGhlIGZpeCBpcyB0byB3cmFwIHRoZSBvdXRw dXQgdmFyaWFibGVzIGluIHRoZSBxdW90ZXMgd2hlbiB1bmJveGluZyB0aGVtIGluIHRoZSBpZi4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRDQ2FjaGUuY21ha2U6CisKIDIwMjAtMDIt MjcgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5d IEZpeCBBcHBsZVdpbiBidWlsZAo= 391988 2020-02-28 10:21:25 -0800 2020-02-28 11:55:25 -0800 Patch bug-208377-20200228102124.patch text/plain 2357 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0Q0NhY2hlLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdENDYWNoZS5jbWFrZQppbmRleCBj Yjk5ZjU3MWQzYTZkZTJjOWMyZDI5OTkyNTZjZWQ1YTJlMTY4OWQyLi44Zjk5OWJjODhiNWU0MDQz ZTcwMjI3MTI1MjUzZjJiMzM3Nzg0ZmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q0NhY2hlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDQ2FjaGUuY21ha2UKQEAgLTEx LDkgKzExLDEwIEBAIGlmIChOT1QgIiRFTlZ7V0tfVVNFX0NDQUNIRX0iIFNUUkVRVUFMICJOTyIp CiAgICAgICAgICAgICBpZiAoTk9UIERFRklORUQgRU5We0NDQUNIRV9TTE9QUElORVNTfSkKICAg ICAgICAgICAgICAgICBzZXQoRU5We0NDQUNIRV9TTE9QUElORVNTfSB0aW1lX21hY3JvcykKICAg ICAgICAgICAgIGVuZGlmICgpCisgICAgICAgICAgICAjIEZJWE1FOiByZWFkbGluayAtZiBpc24n dCBzdXBwb3J0ZWQgb24gbWFjT1MuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDgzNzkKICAgICAgICAgICAgIGV4ZWN1dGVfcHJvY2VzcyhDT01NQU5EIHJlYWRsaW5r IC1mICR7Q01BS0VfQ1hYX0NPTVBJTEVSfSBSRVNVTFRfVkFSSUFCTEUgUkVBRExJTktfUkVUQ09E RSBPVVRQVVRfVkFSSUFCTEUgUkVBTF9DWFhfUEFUSCBPVVRQVVRfU1RSSVBfVFJBSUxJTkdfV0hJ VEVTUEFDRSBFUlJPUl9RVUlFVCkKICAgICAgICAgICAgIGV4ZWN1dGVfcHJvY2VzcyhDT01NQU5E IHdoaWNoICR7Q0NBQ0hFX0ZPVU5EfSBSRVNVTFRfVkFSSUFCTEUgV0hJQ0hfUkVUQ09ERSBPVVRQ VVRfVkFSSUFCTEUgUkVBTF9DQ0FDSEVfUEFUSCBPVVRQVVRfU1RSSVBfVFJBSUxJTkdfV0hJVEVT UEFDRSBFUlJPUl9RVUlFVCkKLSAgICAgICAgICAgIGlmICgke1dISUNIX1JFVENPREV9IEVRVUFM IDAgQU5EICR7UkVBRExJTktfUkVUQ09ERX0gRVFVQUwgMCBBTkQgJHtSRUFMX0NYWF9QQVRIfSBT VFJFUVVBTCAke1JFQUxfQ0NBQ0hFX1BBVEh9KQorICAgICAgICAgICAgaWYgKCR7V0hJQ0hfUkVU Q09ERX0gRVFVQUwgMCBBTkQgJHtSRUFETElOS19SRVRDT0RFfSBFUVVBTCAwIEFORCAiJHtSRUFM X0NYWF9QQVRIfSIgU1RSRVFVQUwgIiR7UkVBTF9DQ0FDSEVfUEFUSH0iKQogICAgICAgICAgICAg ICAgIG1lc3NhZ2UoU1RBVFVTICJFbmFibGluZyBjY2FjaGU6IENvbXBpbGVyIHBhdGggYWxyZWFk eSBwb2ludGluZyB0byBjY2FjaGUuIE5vdCBzZXR0aW5nIGNjYWNoZSBwcmVmaXguIikKICAgICAg ICAgICAgIGVsc2UgKCkKICAgICAgICAgICAgICAgICBtZXNzYWdlKFNUQVRVUyAiRW5hYmxpbmcg Y2NhY2hlOiBTZXR0aW5nIGNjYWNoZSBwcmVmaXggZm9yIGNvbXBpbGVyLiIpCmRpZmYgLS1naXQg YS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYWU2N2FiNjY4MTc5NGFmMTgxYjE3NWVlZTFh ZjIwZDkzMWI5YzJhOC4uODA3OTYwZGI5NWJlYWFkZjE1OTYxNzRiODNhYzJjYTA1NzIyNjcxMCAx MDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisy MDIwLTAyLTI4ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAg ICAgIEZpeCBpc3N1ZSBpbiBjbWFrZSBidWlsZCBmb3IgY2hlY2tpbmcgY2NhY2hlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgzNzcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBlaXRoZXIgb2YgdGhl ICJyZWFkbGluayIgb3IgIndoaWNoIiBjb21tYW5kcyBmYWlsIHdoZW4gbG9va2luZyBmb3IgdGhl IGNjYWNoZSBwcmVmaXgKKyAgICAgICAgdGhlIG91dHB1dCB2YXJpYWJsZXMgd2lsbCBiZSBlbXB0 eSBhbmQgYW4gaW52YWxpZCBleHByZXNzaW9uIHdpbGwgYmUgcHJvdmlkZWQgdG8gQ01ha2UuCisg ICAgICAgIGUuZy4gd2Ugd2lsbCBnZXQgc29tZXRoaW5nIGxpa2U6CisgICAgICAgIGlmICgiMCIg IkVRVUFMIiAiMCIgIkFORCIgIjEiICJFUVVBTCIgIjAiICJBTkQiICJTVFJFUVVBTCIgIi91c3Iv bG9jYWwvYmluL2NjYWNoZSIpCisKKyAgICAgICAgVGhlIGZpeCBpcyB0byB3cmFwIHRoZSBvdXRw dXQgdmFyaWFibGVzIGluIHRoZSBxdW90ZXMgd2hlbiB1bmJveGluZyB0aGVtIGluIHRoZSBpZi4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRDQ2FjaGUuY21ha2U6CisKIDIwMjAtMDIt MjcgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5d IEZpeCBBcHBsZVdpbiBidWlsZAo=