208372 2020-02-28 04:53:53 -0800 Regression r257612: Windows build broken 2020-02-28 10:14:14 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208080 InRadar P2 Normal --- 1 aakash_jain eric.carlson ap commit-queue eric.carlson webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1623933 0 aakash_jain 2020-02-28 04:53:53 -0800 Windows build seems to be broken by r257612. e.g.: build\Source\WebCore\platform\graphics\InbandGenericCue.cpp(93): error C2220: the following warning is treated as an error [WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] build\Source\WebCore\platform\graphics\InbandGenericCue.cpp(93): warning C4701: potentially uninitialized local variable 'align' used [WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] build\Source\WebCore\platform\graphics\InbandGenericCue.cpp(93): warning C4703: potentially uninitialized local pointer variable 'align' used [WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] r257611 passed in https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/11123 r257612 failed in https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/11124 EWS also indicated this failure in the corresponding bug https://bugs.webkit.org/show_bug.cgi?id=208080 1623934 1 webkit-bug-importer 2020-02-28 04:55:01 -0800 <rdar://problem/59885001> 1623975 2 391984 eric.carlson 2020-02-28 09:23:20 -0800 Created attachment 391984 Patch 1623984 3 391984 commit-queue 2020-02-28 10:14:12 -0800 Comment on attachment 391984 Patch Clearing flags on attachment: 391984 Committed r257641: <https://trac.webkit.org/changeset/257641> 1623985 4 commit-queue 2020-02-28 10:14:14 -0800 All reviewed patches have been landed. Closing bug. 391984 2020-02-28 09:23:20 -0800 2020-02-28 10:14:12 -0800 Patch bug-208372-20200228092319.patch text/plain 1473 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjVkYmRhZGRlNzY0ZWY5 YTQ3ZmY5MzFjZWQzMjYyMmFkNjQ0ZGFlYS4uMmM0MTQ3MDFlM2ExYjgxOTZhMDMxMjU1YjY5MjQ3 ZjIyYmIwMGFkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAyLTI4ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJlZ3Jlc3Npb24g cjI1NzYxMjogV2luZG93cyBidWlsZCBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODM3MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTk4 ODUwMDE+CisKKyAgICAgICAgVW5yZXZpZXdlZCBXaW5kb3dzIGJ1aWxkIGZpeC4KKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL0luYmFuZEdlbmVyaWNDdWUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW5iYW5kR2VuZXJpY0N1ZTo6dG9KU09OU3RyaW5nIGNvbnN0KToKKwogMjAyMC0wMi0y OCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldGFpbiBjeWNs ZSBiZXR3ZWVuIENTU0ZvbnRTZWxlY3RvciAtPiBDU1NGb250RmFjZVNldCAtPiBDU1NGb250RmFj ZSAtPiBDU1NGb250U2VsZWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0luYmFuZEdlbmVyaWNDdWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvSW5iYW5kR2VuZXJpY0N1ZS5jcHAKaW5kZXggNTAxZDIzZDU3MjJhZTczNzQ1NTJj YTQxYTQ0MTJmODNlZGIzMDE0NC4uZTM0NGU3YzczN2QzYzhjNTllNjQwYjQ4YzdiZmQzODk5OTY5 MjgwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW5iYW5k R2VuZXJpY0N1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW5i YW5kR2VuZXJpY0N1ZS5jcHAKQEAgLTc1LDcgKzc1LDcgQEAgU3RyaW5nIEluYmFuZEdlbmVyaWND dWU6OnRvSlNPTlN0cmluZygpIGNvbnN0CiAgICAgICAgIG9iamVjdC0+c2V0RG91YmxlKCJwb3Np dGlvbiJfcywgbV9jdWVEYXRhLm1fcG9zaXRpb24pOwogCiAgICAgaWYgKG1fY3VlRGF0YS5tX2Fs aWduICE9IEdlbmVyaWNDdWVEYXRhOjpBbGlnbm1lbnQ6Ok5vbmUpIHsKLSAgICAgICAgY29uc3Qg Y2hhciogYWxpZ247CisgICAgICAgIGNvbnN0IGNoYXIqIGFsaWduID0gIiI7CiAgICAgICAgIHN3 aXRjaCAobV9jdWVEYXRhLm1fYWxpZ24pIHsKICAgICAgICAgY2FzZSBHZW5lcmljQ3VlRGF0YTo6 QWxpZ25tZW50OjpTdGFydDoKICAgICAgICAgICAgIGFsaWduID0gIlN0YXJ0IjsK