208349 2020-02-27 16:09:43 -0800 Introduce JSRemoteInspectorServerStart API for socket-based RWI. 2020-03-03 15:48:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 208391 1 ross.kirsling ross.kirsling annulen aperez basuke cgarcia chris.reid commit-queue don.olmstead ews-watchlist gyuyoung.kim hi joepeck keith_miller mark.lam msaboff ryuan.choi saam sergio stephan.szabo tzagallo webkit-bug-importer oldest_to_newest 1623746 0 ross.kirsling 2020-02-27 16:09:43 -0800 Introduce JSRemoteInspectorServerStart APPI for socket-based RWI. 1623747 1 391937 ross.kirsling 2020-02-27 16:11:43 -0800 Created attachment 391937 Patch 1623754 2 ross.kirsling 2020-02-27 16:19:17 -0800 This is needed for embedded applications making use of socket-based RWI. A couple of possible concerns: - I've guarded the declaration itself here based on Devin's recommendation, though it does seem a bit more typical to just no-op the implementation instead. - Our downstream version calls initializeThreading() too; I'd rather omit this as it feels like an orthogonal concern, but it can be added here if we absolutely need it. 1623829 3 391937 don.olmstead 2020-02-27 18:01:30 -0800 Comment on attachment 391937 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391937&action=review > Source/JavaScriptCore/API/JSRemoteInspector.h:55 > +#if USE(INSPECTOR_SOCKET_SERVER) > +JS_EXPORT bool JSRemoteInspectorServerStart(uint16_t port) JSC_API_AVAILABLE(macos(JSC_MAC_TBA), ios(JSC_IOS_TBA)); > +#endif > + I'm pretty sure having a USE in the API headers is a no go. These are all C headers. I'm going to guess there might need to be a JSRemoteInspectorSocket.h. 1624010 4 391996 ross.kirsling 2020-02-28 10:52:02 -0800 Created attachment 391996 Patch 1624011 5 391997 ross.kirsling 2020-02-28 10:58:01 -0800 Created attachment 391997 Patch 1624013 6 391997 joepeck 2020-02-28 11:04:45 -0800 Comment on attachment 391997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391997&action=review Seems fine to me. It is weird exposing an API that does nothing on Apple ports but were they to implement `INSPECTOR_SOCKET_SERVER` then it would just work. > Source/JavaScriptCore/API/JSRemoteInspector.cpp:92 > + auto& server = Inspector::RemoteInspectorServer::singleton(); > + return server.isRunning() || server.start(nullptr, port); If the server is running it might be running on a different port. Should we return false in such a case, since this was requested to start with a particular port? Have you considered an option to start without a port, and let the OS pick a random available port? (Not necessarily important, just something to consider). 1624015 7 391997 hi 2020-02-28 11:05:27 -0800 Comment on attachment 391997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391997&action=review > Source/JavaScriptCore/API/JSRemoteInspector.h:53 > +JS_EXPORT bool JSRemoteInspectorServerStart(uint16_t port) JSC_API_AVAILABLE(macos(JSC_MAC_TBA), ios(JSC_IOS_TBA)); I'm not familiar with the "rules" about the JSC C API, but I'd think that we wouldn't want to expose a function that doesn't actually do anything. If this is done elsewhere (and the JSC folks are fine with it), then I guess it's fine. I'd really prefer if the function only existed when `USE(INSPECTOR_SOCKET_SERVER)` is guaranteed to be true. 1624016 8 joepeck 2020-02-28 11:06:21 -0800 (In reply to Don Olmstead from comment #3) > Comment on attachment 391937 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391937&action=review > > > Source/JavaScriptCore/API/JSRemoteInspector.h:55 > > +#if USE(INSPECTOR_SOCKET_SERVER) > > +JS_EXPORT bool JSRemoteInspectorServerStart(uint16_t port) JSC_API_AVAILABLE(macos(JSC_MAC_TBA), ios(JSC_IOS_TBA)); > > +#endif > > + > > I'm pretty sure having a USE in the API headers is a no go. Correct regarding having `USE` in an API header! > These are all C headers. I'm going to guess there might need > to be a JSRemoteInspectorSocket.h. This isn't a bad idea, I considered it as well. Then ports that don't want to expose this API/Symbol could just not include the header/implementation. I'm not sure if there is a common practice for that. 1624017 9 391997 don.olmstead 2020-02-28 11:08:58 -0800 Comment on attachment 391997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391997&action=review >> Source/JavaScriptCore/API/JSRemoteInspector.cpp:92 >> + return server.isRunning() || server.start(nullptr, port); > > If the server is running it might be running on a different port. Should we return false in such a case, since this was requested to start with a particular port? > > Have you considered an option to start without a port, and let the OS pick a random available port? (Not necessarily important, just something to consider). I think address should probably be exposed as well on this API. 1624027 10 391997 don.olmstead 2020-02-28 11:17:48 -0800 Comment on attachment 391997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391997&action=review >> Source/JavaScriptCore/API/JSRemoteInspector.h:53 >> +JS_EXPORT bool JSRemoteInspectorServerStart(uint16_t port) JSC_API_AVAILABLE(macos(JSC_MAC_TBA), ios(JSC_IOS_TBA)); > > I'm not familiar with the "rules" about the JSC C API, but I'd think that we wouldn't want to expose a function that doesn't actually do anything. If this is done elsewhere (and the JSC folks are fine with it), then I guess it's fine. I'd really prefer if the function only existed when `USE(INSPECTOR_SOCKET_SERVER)` is guaranteed to be true. I don't know what the practice is for it but if it was to go into a separate file then on the CMake side the header would need to be appended to JavaScriptCore_PUBLIC_FRAMEWORK_HEADERS on the CMake side. if (USE_INSPECTOR_SOCKER_SERVER) list(APPEND JavaScriptCore_PUBLIC_FRAMEWORK_HEADERS API/JSRemoteInspectorServer.h endif () 1624028 11 391997 basuke 2020-02-28 11:18:11 -0800 Comment on attachment 391997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391997&action=review >> Source/JavaScriptCore/API/JSRemoteInspector.h:53 >> +JS_EXPORT bool JSRemoteInspectorServerStart(uint16_t port) JSC_API_AVAILABLE(macos(JSC_MAC_TBA), ios(JSC_IOS_TBA)); > > I'm not familiar with the "rules" about the JSC C API, but I'd think that we wouldn't want to expose a function that doesn't actually do anything. If this is done elsewhere (and the JSC folks are fine with it), then I guess it's fine. I'd really prefer if the function only existed when `USE(INSPECTOR_SOCKET_SERVER)` is guaranteed to be true. We cannot use USE(INSPECTOR_SOCKET_SERVER) here in C API headers. All we can do is using standard definition check for possible platforms to enable this. i.e) #if defined(WIN32) || defined(_WIN32) || defined(__SCE__) 1624131 12 392020 ross.kirsling 2020-02-28 14:17:40 -0800 Created attachment 392020 Patch 1624132 13 392020 ross.kirsling 2020-02-28 14:19:47 -0800 Comment on attachment 392020 Patch Here's a version that addresses most of the voiced concerns. Not going to land this yet though, as Basuke would like to adjust the return type of RemoteInspectorServer::start in bug 208391 first. 1625262 14 392335 ross.kirsling 2020-03-03 14:40:52 -0800 Created attachment 392335 Patch 1625286 15 392335 commit-queue 2020-03-03 15:47:28 -0800 Comment on attachment 392335 Patch Clearing flags on attachment: 392335 Committed r257809: <https://trac.webkit.org/changeset/257809> 1625287 16 commit-queue 2020-03-03 15:47:31 -0800 All reviewed patches have been landed. Closing bug. 1625288 17 webkit-bug-importer 2020-03-03 15:48:17 -0800 <rdar://problem/60017043> 391937 2020-02-27 16:11:43 -0800 2020-02-28 10:52:01 -0800 Patch bug-208349-20200227161142.patch text/plain 2335 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ODA0ODAxNDJkYTA2NGYxZWVjNWI4ZmU0OTFiMzIxMjIyNzJiZTU2Li5jNzY5YWU3OTFkNWY0Yjhl YjM1YzI4MTk3OTAyZDMxYzA5MzgyMGU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAyMC0wMi0yNyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgSW50cm9kdWNlIEpTUmVtb3RlSW5zcGVjdG9yU2VydmVyU3RhcnQg QVBJIGZvciBzb2NrZXQtYmFzZWQgUldJLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBBUEkvSlNSZW1vdGVJbnNwZWN0b3IuY3BwOgorICAgICAgICAo SlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXJTdGFydCk6CisgICAgICAgICogQVBJL0pTUmVtb3RlSW5z cGVjdG9yLmg6CisKIDIwMjAtMDItMjYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgog CiAgICAgICAgIEVuaGFuY2UgSlNPYmplY3RHZXRQcm9wZXJ0eSgpIHRvIG1pdGlnYXRlIGFnYWlu c3QgbnVsbCBvYmplY3QgcG9pbnRlcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkv SlNSZW1vdGVJbnNwZWN0b3IuY3BwCmluZGV4IDk2NzJlZjAyMTQ0NDdjZGJhNDFmODA3NTVhY2Qx ZmRhMWUwMGJjMWMuLmFmZjA3YjlmNzZkODk4ZjY1MzFiMGJhMGNmODFiOWM0NjcwNjQyMzIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1vdGVJbnNwZWN0b3IuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1vdGVJbnNwZWN0b3IuY3BwCkBA IC03NywzICs3NywxNCBAQCB2b2lkIEpTUmVtb3RlSW5zcGVjdG9yU2V0SW5zcGVjdGlvbkVuYWJs ZWRCeURlZmF1bHQoYm9vbCBlbmFibGVkQnlEZWZhdWx0KQogewogICAgIHJlbW90ZUluc3BlY3Rp b25FbmFibGVkQnlEZWZhdWx0ID0gZW5hYmxlZEJ5RGVmYXVsdDsKIH0KKworI2lmIFVTRShJTlNQ RUNUT1JfU09DS0VUX1NFUlZFUikKK2Jvb2wgSlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXJTdGFydCh1 aW50MTZfdCBwb3J0KQoreworICAgIGlmICghcG9ydCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwor CisgICAgYXV0byYgc2VydmVyID0gSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3JTZXJ2ZXI6OnNp bmdsZXRvbigpOworICAgIHJldHVybiBzZXJ2ZXIuaXNSdW5uaW5nKCkgfHwgc2VydmVyLnN0YXJ0 KG51bGxwdHIsIHBvcnQpOworfQorI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L0pTUmVtb3RlSW5zcGVjdG9yLmgKaW5kZXggODU3NjhlNGQ2NTc3ODFiZTRhNzgwN2U1YWE4ZDQw NGE0NzMyODBkYi4uYjhlODRiY2VjY2U3NmY5ZWUwNDBiMWJiMzA3YjU0YmJhOWFlMTVhNCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1JlbW90ZUluc3BlY3Rvci5oCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1vdGVJbnNwZWN0b3IuaApAQCAtNDks NiArNDksMTAgQEAgSlNfRVhQT1JUIHZvaWQgSlNSZW1vdGVJbnNwZWN0b3JTZXRMb2dUb1N5c3Rl bUNvbnNvbGUoYm9vbCkgSlNDX0FQSV9BVkFJTEFCTEUobWEKIEpTX0VYUE9SVCBib29sIEpTUmVt b3RlSW5zcGVjdG9yR2V0SW5zcGVjdGlvbkVuYWJsZWRCeURlZmF1bHQodm9pZCkgSlNDX0FQSV9B VkFJTEFCTEUobWFjb3MoMTAuMTEpLCBpb3MoOS4wKSk7CiBKU19FWFBPUlQgdm9pZCBKU1JlbW90 ZUluc3BlY3RvclNldEluc3BlY3Rpb25FbmFibGVkQnlEZWZhdWx0KGJvb2wpIEpTQ19BUElfQVZB SUxBQkxFKG1hY29zKDEwLjExKSwgaW9zKDkuMCkpOwogCisjaWYgVVNFKElOU1BFQ1RPUl9TT0NL RVRfU0VSVkVSKQorSlNfRVhQT1JUIGJvb2wgSlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXJTdGFydCh1 aW50MTZfdCBwb3J0KSBKU0NfQVBJX0FWQUlMQUJMRShtYWNvcyhKU0NfTUFDX1RCQSksIGlvcyhK U0NfSU9TX1RCQSkpOworI2VuZGlmCisKICNpZmRlZiBfX2NwbHVzcGx1cwogfQogI2VuZGlmCg== 391996 2020-02-28 10:52:02 -0800 2020-02-28 10:57:59 -0800 Patch bug-208349-20200228105202.patch text/plain 2733 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ODA0ODAxNDJkYTA2NGYxZWVjNWI4ZmU0OTFiMzIxMjIyNzJiZTU2Li5jNzY5YWU3OTFkNWY0Yjhl YjM1YzI4MTk3OTAyZDMxYzA5MzgyMGU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAyMC0wMi0yNyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgSW50cm9kdWNlIEpTUmVtb3RlSW5zcGVjdG9yU2VydmVyU3RhcnQg QVBJIGZvciBzb2NrZXQtYmFzZWQgUldJLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBBUEkvSlNSZW1vdGVJbnNwZWN0b3IuY3BwOgorICAgICAgICAo SlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXJTdGFydCk6CisgICAgICAgICogQVBJL0pTUmVtb3RlSW5z cGVjdG9yLmg6CisKIDIwMjAtMDItMjYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgog CiAgICAgICAgIEVuaGFuY2UgSlNPYmplY3RHZXRQcm9wZXJ0eSgpIHRvIG1pdGlnYXRlIGFnYWlu c3QgbnVsbCBvYmplY3QgcG9pbnRlcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkv SlNSZW1vdGVJbnNwZWN0b3IuY3BwCmluZGV4IDk2NzJlZjAyMTQ0NDdjZGJhNDFmODA3NTVhY2Qx ZmRhMWUwMGJjMWMuLjU2Yzk3MTUzNTc5ODMzOTBmMjYzNTAzZjhkMjlmNGQwYmU0MGFjNTggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1vdGVJbnNwZWN0b3IuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1vdGVJbnNwZWN0b3IuY3BwCkBA IC0zMyw2ICszMywxMCBAQAogI2luY2x1ZGUgIlJlbW90ZUluc3BlY3Rvci5oIgogI2VuZGlmCiAK KyNpZiBVU0UoSU5TUEVDVE9SX1NPQ0tFVF9TRVJWRVIpCisjaW5jbHVkZSAiUmVtb3RlSW5zcGVj dG9yU2VydmVyLmgiCisjZW5kaWYKKwogdXNpbmcgbmFtZXNwYWNlIEluc3BlY3RvcjsKIAogc3Rh dGljIGJvb2wgcmVtb3RlSW5zcGVjdGlvbkVuYWJsZWRCeURlZmF1bHQgPSB0cnVlOwpAQCAtNzcs MyArODEsMTYgQEAgdm9pZCBKU1JlbW90ZUluc3BlY3RvclNldEluc3BlY3Rpb25FbmFibGVkQnlE ZWZhdWx0KGJvb2wgZW5hYmxlZEJ5RGVmYXVsdCkKIHsKICAgICByZW1vdGVJbnNwZWN0aW9uRW5h YmxlZEJ5RGVmYXVsdCA9IGVuYWJsZWRCeURlZmF1bHQ7CiB9CisKK2Jvb2wgSlNSZW1vdGVJbnNw ZWN0b3JTZXJ2ZXJTdGFydCh1aW50MTZfdCBwb3J0KQoreworI2lmIFVTRShJTlNQRUNUT1JfU09D S0VUX1NFUlZFUikKKyAgICBpZiAoIXBvcnQpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAg IGF1dG8mIHNlcnZlciA9IEluc3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9yU2VydmVyOjpzaW5nbGV0 b24oKTsKKyAgICByZXR1cm4gc2VydmVyLmlzUnVubmluZygpIHx8IHNlcnZlci5zdGFydChudWxs cHRyLCBwb3J0KTsKKyNlbHNlCisgICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCit9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yLmggYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yLmgKaW5kZXggODU3NjhlNGQ2 NTc3ODFiZTRhNzgwN2U1YWE4ZDQwNGE0NzMyODBkYi4uYjA4OWVmM2JjMWI3ZWFlMmY1YzMwZTUz NjE5YzYzYmJiMWQxZjhlYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9K U1JlbW90ZUluc3BlY3Rvci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1v dGVJbnNwZWN0b3IuaApAQCAtMjgsNiArMjgsNyBAQAogCiAjaW5jbHVkZSA8SmF2YVNjcmlwdENv cmUvSlNCYXNlLmg+CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvV2ViS2l0QXZhaWxhYmlsaXR5 Lmg+CisjaW5jbHVkZSA8c3RkaW50Lmg+CiAKICNpZiBkZWZpbmVkKFdJTjMyKSB8fCBkZWZpbmVk KF9XSU4zMikKIHR5cGVkZWYgaW50IEpTUHJvY2Vzc0lEOwpAQCAtNDksNiArNTAsOCBAQCBKU19F WFBPUlQgdm9pZCBKU1JlbW90ZUluc3BlY3RvclNldExvZ1RvU3lzdGVtQ29uc29sZShib29sKSBK U0NfQVBJX0FWQUlMQUJMRShtYQogSlNfRVhQT1JUIGJvb2wgSlNSZW1vdGVJbnNwZWN0b3JHZXRJ bnNwZWN0aW9uRW5hYmxlZEJ5RGVmYXVsdCh2b2lkKSBKU0NfQVBJX0FWQUlMQUJMRShtYWNvcygx MC4xMSksIGlvcyg5LjApKTsKIEpTX0VYUE9SVCB2b2lkIEpTUmVtb3RlSW5zcGVjdG9yU2V0SW5z cGVjdGlvbkVuYWJsZWRCeURlZmF1bHQoYm9vbCkgSlNDX0FQSV9BVkFJTEFCTEUobWFjb3MoMTAu MTEpLCBpb3MoOS4wKSk7CiAKK0pTX0VYUE9SVCBib29sIEpTUmVtb3RlSW5zcGVjdG9yU2VydmVy U3RhcnQodWludDE2X3QgcG9ydCkgSlNDX0FQSV9BVkFJTEFCTEUobWFjb3MoSlNDX01BQ19UQkEp LCBpb3MoSlNDX0lPU19UQkEpKTsKKwogI2lmZGVmIF9fY3BsdXNwbHVzCiB9CiAjZW5kaWYK 391997 2020-02-28 10:58:01 -0800 2020-02-28 14:17:38 -0800 Patch bug-208349-20200228105800.patch text/plain 2758 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ODA0ODAxNDJkYTA2NGYxZWVjNWI4ZmU0OTFiMzIxMjIyNzJiZTU2Li5jNzY5YWU3OTFkNWY0Yjhl YjM1YzI4MTk3OTAyZDMxYzA5MzgyMGU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAyMC0wMi0yNyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgSW50cm9kdWNlIEpTUmVtb3RlSW5zcGVjdG9yU2VydmVyU3RhcnQg QVBJIGZvciBzb2NrZXQtYmFzZWQgUldJLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBBUEkvSlNSZW1vdGVJbnNwZWN0b3IuY3BwOgorICAgICAgICAo SlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXJTdGFydCk6CisgICAgICAgICogQVBJL0pTUmVtb3RlSW5z cGVjdG9yLmg6CisKIDIwMjAtMDItMjYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgog CiAgICAgICAgIEVuaGFuY2UgSlNPYmplY3RHZXRQcm9wZXJ0eSgpIHRvIG1pdGlnYXRlIGFnYWlu c3QgbnVsbCBvYmplY3QgcG9pbnRlcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkv SlNSZW1vdGVJbnNwZWN0b3IuY3BwCmluZGV4IDk2NzJlZjAyMTQ0NDdjZGJhNDFmODA3NTVhY2Qx ZmRhMWUwMGJjMWMuLjQ3YWVhZmMyMTJkNjU0MzBlNGEwMjRjODkzOTA3NzEzZGU5Y2M2ZmEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1vdGVJbnNwZWN0b3IuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1vdGVJbnNwZWN0b3IuY3BwCkBA IC0zMyw2ICszMywxMCBAQAogI2luY2x1ZGUgIlJlbW90ZUluc3BlY3Rvci5oIgogI2VuZGlmCiAK KyNpZiBVU0UoSU5TUEVDVE9SX1NPQ0tFVF9TRVJWRVIpCisjaW5jbHVkZSAiUmVtb3RlSW5zcGVj dG9yU2VydmVyLmgiCisjZW5kaWYKKwogdXNpbmcgbmFtZXNwYWNlIEluc3BlY3RvcjsKIAogc3Rh dGljIGJvb2wgcmVtb3RlSW5zcGVjdGlvbkVuYWJsZWRCeURlZmF1bHQgPSB0cnVlOwpAQCAtNzcs MyArODEsMTcgQEAgdm9pZCBKU1JlbW90ZUluc3BlY3RvclNldEluc3BlY3Rpb25FbmFibGVkQnlE ZWZhdWx0KGJvb2wgZW5hYmxlZEJ5RGVmYXVsdCkKIHsKICAgICByZW1vdGVJbnNwZWN0aW9uRW5h YmxlZEJ5RGVmYXVsdCA9IGVuYWJsZWRCeURlZmF1bHQ7CiB9CisKK2Jvb2wgSlNSZW1vdGVJbnNw ZWN0b3JTZXJ2ZXJTdGFydCh1aW50MTZfdCBwb3J0KQoreworI2lmIFVTRShJTlNQRUNUT1JfU09D S0VUX1NFUlZFUikKKyAgICBpZiAoIXBvcnQpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAg IGF1dG8mIHNlcnZlciA9IEluc3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9yU2VydmVyOjpzaW5nbGV0 b24oKTsKKyAgICByZXR1cm4gc2VydmVyLmlzUnVubmluZygpIHx8IHNlcnZlci5zdGFydChudWxs cHRyLCBwb3J0KTsKKyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKHBvcnQpOworICAgIHJldHVybiBm YWxzZTsKKyNlbmRpZgorfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9K U1JlbW90ZUluc3BlY3Rvci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1JlbW90ZUlu c3BlY3Rvci5oCmluZGV4IDg1NzY4ZTRkNjU3NzgxYmU0YTc4MDdlNWFhOGQ0MDRhNDczMjgwZGIu LmIwODllZjNiYzFiN2VhZTJmNWMzMGU1MzYxOWM2M2JiYjFkMWY4ZWMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1vdGVJbnNwZWN0b3IuaAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yLmgKQEAgLTI4LDYgKzI4LDcgQEAK IAogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTQmFzZS5oPgogI2luY2x1ZGUgPEphdmFTY3Jp cHRDb3JlL1dlYktpdEF2YWlsYWJpbGl0eS5oPgorI2luY2x1ZGUgPHN0ZGludC5oPgogCiAjaWYg ZGVmaW5lZChXSU4zMikgfHwgZGVmaW5lZChfV0lOMzIpCiB0eXBlZGVmIGludCBKU1Byb2Nlc3NJ RDsKQEAgLTQ5LDYgKzUwLDggQEAgSlNfRVhQT1JUIHZvaWQgSlNSZW1vdGVJbnNwZWN0b3JTZXRM b2dUb1N5c3RlbUNvbnNvbGUoYm9vbCkgSlNDX0FQSV9BVkFJTEFCTEUobWEKIEpTX0VYUE9SVCBi b29sIEpTUmVtb3RlSW5zcGVjdG9yR2V0SW5zcGVjdGlvbkVuYWJsZWRCeURlZmF1bHQodm9pZCkg SlNDX0FQSV9BVkFJTEFCTEUobWFjb3MoMTAuMTEpLCBpb3MoOS4wKSk7CiBKU19FWFBPUlQgdm9p ZCBKU1JlbW90ZUluc3BlY3RvclNldEluc3BlY3Rpb25FbmFibGVkQnlEZWZhdWx0KGJvb2wpIEpT Q19BUElfQVZBSUxBQkxFKG1hY29zKDEwLjExKSwgaW9zKDkuMCkpOwogCitKU19FWFBPUlQgYm9v bCBKU1JlbW90ZUluc3BlY3RvclNlcnZlclN0YXJ0KHVpbnQxNl90IHBvcnQpIEpTQ19BUElfQVZB SUxBQkxFKG1hY29zKEpTQ19NQUNfVEJBKSwgaW9zKEpTQ19JT1NfVEJBKSk7CisKICNpZmRlZiBf X2NwbHVzcGx1cwogfQogI2VuZGlmCg== 392020 2020-02-28 14:17:40 -0800 2020-03-03 14:40:50 -0800 Patch bug-208349-20200228141739.patch text/plain 5580 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ODA0ODAxNDJkYTA2NGYxZWVjNWI4ZmU0OTFiMzIxMjIyNzJiZTU2Li5iYWViNDQ5YzllYTk5Mzk2 MWI4YTc4NWQxNmE0MTM4YmUxMmQzZDI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0wMi0yOCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgSW50cm9kdWNlIEpTUmVtb3RlSW5zcGVjdG9yU2VydmVyU3RhcnQg QVBJIGZvciBzb2NrZXQtYmFzZWQgUldJLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9zZXBoIFBl Y29yYXJvLgorCisgICAgICAgICogQVBJL0pTUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcDogQWRk ZWQuCisgICAgICAgIChKU1JlbW90ZUluc3BlY3RvclNlcnZlclN0YXJ0KToKKyAgICAgICAgKiBB UEkvSlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuaDogQWRkZWQuCisgICAgICAgICogQ01ha2VMaXN0 cy50eHQ6CisKIDIwMjAtMDItMjYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIEVuaGFuY2UgSlNPYmplY3RHZXRQcm9wZXJ0eSgpIHRvIG1pdGlnYXRlIGFnYWluc3Qg bnVsbCBvYmplY3QgcG9pbnRlcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv QVBJL0pTUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9B UEkvSlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmY2NzUxNDY0MWFkNTcy YmY4MzI1N2I0MmY4MmQ5M2IwMGI2ODZjMTIKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcApAQCAtMCwwICsxLDM1 IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDIwIFNvbnkgSW50ZXJhY3RpdmUgRW50ZXJ0YWlu bWVudCBJbmMuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0 ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6Cisg KiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3Zl IGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhl IGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBm b3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhp cyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUK KyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRo IHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBB UFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJworICogQU5EIEFOWSBFWFBS RVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8s CisgKiBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVT UyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVO VCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMKKyAqIEJFIExJQUJMRSBGT1Ig QU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IK KyAqIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8s IFBST0NVUkVNRU5UIE9GCisgKiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9G IFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MKKyAqIElOVEVSUlVQVElPTikgSE9X RVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOCisg KiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJR0VO Q0UgT1IgT1RIRVJXSVNFKQorICogQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9G IFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRgorICogVEhFIFBPU1NJQklMSVRZIE9G IFNVQ0ggREFNQUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlICJKU1Jl bW90ZUluc3BlY3RvclNlcnZlci5oIgorCisjaW5jbHVkZSAiUmVtb3RlSW5zcGVjdG9yU2VydmVy LmgiCisKK2Jvb2wgSlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXJTdGFydChjb25zdCBjaGFyKiBhZGRy ZXNzLCB1aW50MTZfdCBwb3J0KQoreworICAgIGF1dG8mIHNlcnZlciA9IEluc3BlY3Rvcjo6UmVt b3RlSW5zcGVjdG9yU2VydmVyOjpzaW5nbGV0b24oKTsKKyAgICByZXR1cm4gIXNlcnZlci5pc1J1 bm5pbmcoKSAmJiBzZXJ2ZXIuc3RhcnQoYWRkcmVzcywgcG9ydCk7Cit9CmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yU2VydmVyLmggYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yU2VydmVyLmgKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uOTg3YmMyYzRmOGQyMTc1ZDUyNTg5MmRkYjU2OTEyNmM4MTFhMDZmYgotLS0gL2Rldi9udWxs CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXIu aApAQCAtMCwwICsxLDQyIEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDIwIFNvbnkgSW50ZXJh Y3RpdmUgRW50ZXJ0YWlubWVudCBJbmMuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBp biBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRp b24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMK KyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCBy ZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29u ZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRp b25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAq ICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlz Y2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFs cyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJ UyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJwor ICogQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQg Tk9UIExJTUlURUQgVE8sCisgKiBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJ TElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVNDTEFJ TUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMKKyAq IEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUws IEVYRU1QTEFSWSwgT1IKKyAqIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQg Tk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GCisgKiBTVUJTVElUVVRFIEdPT0RTIE9SIFNF UlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MKKyAqIElO VEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZ LCBXSEVUSEVSIElOCisgKiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVCAoSU5D TFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKQorICogQVJJU0lORyBJTiBBTlkgV0FZIE9V VCBPRiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRgorICogVEhF IFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpZm5kZWYgSlNSZW1vdGVJbnNw ZWN0b3JTZXJ2ZXJfaAorI2RlZmluZSBKU1JlbW90ZUluc3BlY3RvclNlcnZlcl9oCisKKyNpbmNs dWRlIDxKYXZhU2NyaXB0Q29yZS9KU0Jhc2UuaD4KKyNpbmNsdWRlIDxzdGRpbnQuaD4KKworI2lm ZGVmIF9fY3BsdXNwbHVzCitleHRlcm4gIkMiIHsKKyNlbmRpZgorCitKU19FWFBPUlQgYm9vbCBK U1JlbW90ZUluc3BlY3RvclNlcnZlclN0YXJ0KGNvbnN0IGNoYXIqIGFkZHJlc3MsIHVpbnQxNl90 IHBvcnQpOworCisjaWZkZWYgX19jcGx1c3BsdXMKK30KKyNlbmRpZgorCisjZW5kaWYgLyogSlNS ZW1vdGVJbnNwZWN0b3JTZXJ2ZXJfaCAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0 CmluZGV4IDVhYmQxODQ2MDFiZWNiYTM3MzJmYTljODE5Y2JhN2MzODU4YWI0MTEuLmY3YzY2NjJm N2ZlNTY3MDlmNDUwOTRjMDczZjU1YzUwODFjYTg4N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01h a2VMaXN0cy50eHQKQEAgLTEwNjksNiArMTA2OSwxMiBAQCBzZXQoSmF2YVNjcmlwdENvcmVfUFJJ VkFURV9GUkFNRVdPUktfSEVBREVSUwogICAgIHlhcnIvWWFyclVuaWNvZGVQcm9wZXJ0aWVzLmgK ICkKIAoraWYgKFVTRV9JTlNQRUNUT1JfU09DS0VUX1NFUlZFUikKKyAgICBsaXN0KEFQUEVORCBK YXZhU2NyaXB0Q29yZV9QUklWQVRFX0ZSQU1FV09SS19IRUFERVJTCisgICAgICAgIEFQSS9KU1Jl bW90ZUluc3BlY3RvclNlcnZlci5oCisgICAgKQorZW5kaWYgKCkKKwogIyBHRU5FUkFUT1IgMS1C OiBwYXJ0aWN1bGFyIExVVCBjcmVhdG9yIChmb3IgMSBmaWxlIG9ubHkpCiBHRU5FUkFURV9IQVNI X0xVVCgke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vcGFyc2VyL0tleXdvcmRzLnRhYmxlICR7 SmF2YVNjcmlwdENvcmVfREVSSVZFRF9TT1VSQ0VTX0RJUn0vTGV4ZXIubHV0LmgpCiAK 392335 2020-03-03 14:40:52 -0800 2020-03-03 15:47:28 -0800 Patch bug-208349-20200303144051.patch text/plain 5653 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3ODAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi YWI0ZDcwNTQyMjRlOTM0MTYyMDUwMDNiY2YzZWM1ZjA2MjhhYWYyLi5mYWFjNjllYmYyOTgxOGJk MWVkYjBkMTExZGQ2Y2EzZjA3OGZlYzc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0wMy0wMyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgSW50cm9kdWNlIEpTUmVtb3RlSW5zcGVjdG9yU2VydmVyU3RhcnQg QVBJIGZvciBzb2NrZXQtYmFzZWQgUldJLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9zZXBoIFBl Y29yYXJvLgorCisgICAgICAgICogQVBJL0pTUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcDogQWRk ZWQuCisgICAgICAgIChKU1JlbW90ZUluc3BlY3RvclNlcnZlclN0YXJ0KToKKyAgICAgICAgKiBB UEkvSlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuaDogQWRkZWQuCisgICAgICAgICogQ01ha2VMaXN0 cy50eHQ6CisKIDIwMjAtMDMtMDMgIEJhc3VrZSBTdXp1a2kgIDxiYXN1a2Uuc3V6dWtpQHNvbnku Y29tPgogCiAgICAgICAgIFtXaW5DYWlyb11bUGxheVN0YXRpb25dIEFkZCBpbnRlcmZhY2UgdG8g Z2V0IGxpc3RlbmluZyBwb3J0IG9mIFJlbW90ZUluc3BlY3RvclNlcnZlcgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1JlbW90ZUluc3BlY3RvclNlcnZlci5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi5jZDBhMWIzYzBlYjU5ZDcwNmJlM2I0Y2Y5MzhkMWRjYTgwOTRmYWIwCi0tLSAvZGV2 L251bGwKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1JlbW90ZUluc3BlY3RvclNl cnZlci5jcHAKQEAgLTAsMCArMSwzOCBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAyMCBTb255 IEludGVyYWN0aXZlIEVudGVydGFpbm1lbnQgSW5jLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFu ZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9k aWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25k aXRpb25zCisgKiBhcmUgbWV0OgorICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2Rl IG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0 IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqIDIuIFJlZGlz dHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJp Z2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93 aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBt YXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09G VFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFT IElTJycKKyAqIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElO RywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICogVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJD SEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUg RElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVU T1JTCisgKiBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBT UEVDSUFMLCBFWEVNUExBUlksIE9SCisgKiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElO RywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRgorICogU1VCU1RJVFVURSBHT09E UyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNT CisgKiBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZIE9GIExJ QUJJTElUWSwgV0hFVEhFUiBJTgorICogQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRP UlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkKKyAqIEFSSVNJTkcgSU4gQU5Z IFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YK KyAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaW5jbHVkZSAiY29u ZmlnLmgiCisjaW5jbHVkZSAiSlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuaCIKKworI2luY2x1ZGUg IlJlbW90ZUluc3BlY3RvclNlcnZlci5oIgorCit1aW50MTZfdCBKU1JlbW90ZUluc3BlY3RvclNl cnZlclN0YXJ0KGNvbnN0IGNoYXIqIGFkZHJlc3MsIHVpbnQxNl90IHBvcnQpCit7CisgICAgY29u c3QgYXV0byYgc2VydmVyID0gSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3JTZXJ2ZXI6OnNpbmds ZXRvbigpOworICAgIGlmICghc2VydmVyLnN0YXJ0KGFkZHJlc3MsIHBvcnQpKQorICAgICAgICBy ZXR1cm4gMDsKKworICAgIHJldHVybiBzZXJ2ZXIuZ2V0UG9ydCgpLnZhbHVlT3IoMCk7Cit9CmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yU2Vy dmVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTUmVtb3RlSW5zcGVjdG9yU2VydmVy LmgKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uNTAzZjM3MDU2ZDU3NmNmYmYyOTk5Yjc4MTkzNmI1NDhhZmZhYTc2Ywot LS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZW1vdGVJbnNw ZWN0b3JTZXJ2ZXIuaApAQCAtMCwwICsxLDQyIEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDIw IFNvbnkgSW50ZXJhY3RpdmUgRW50ZXJ0YWlubWVudCBJbmMuCisgKgorICogUmVkaXN0cmlidXRp b24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0Cisg KiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5n IGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNl IGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlz IGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4g UmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBj b3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBm b2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90 aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJ UyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JT IGBgQVMgSVMnJworICogQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5D TFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisgKiBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9G IE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQT1NF IEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05U UklCVVRPUlMKKyAqIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5U QUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IKKyAqIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5D TFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GCisgKiBTVUJTVElUVVRF IEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVT SU5FU1MKKyAqIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkg T0YgTElBQklMSVRZLCBXSEVUSEVSIElOCisgKiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwg T1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKQorICogQVJJU0lORyBJ TiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNF RCBPRgorICogVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpZm5kZWYg SlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXJfaAorI2RlZmluZSBKU1JlbW90ZUluc3BlY3RvclNlcnZl cl9oCisKKyNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU0Jhc2UuaD4KKyNpbmNsdWRlIDxzdGRp bnQuaD4KKworI2lmZGVmIF9fY3BsdXNwbHVzCitleHRlcm4gIkMiIHsKKyNlbmRpZgorCitKU19F WFBPUlQgdWludDE2X3QgSlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXJTdGFydChjb25zdCBjaGFyKiBh ZGRyZXNzLCB1aW50MTZfdCBwb3J0KTsKKworI2lmZGVmIF9fY3BsdXNwbHVzCit9CisjZW5kaWYK KworI2VuZGlmIC8qIEpTUmVtb3RlSW5zcGVjdG9yU2VydmVyX2ggKi8KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DTWFrZUxpc3RzLnR4dAppbmRleCA1YWJkMTg0NjAxYmVjYmEzNzMyZmE5YzgxOWNiYTdjMzg1 OGFiNDExLi5mN2M2NjYyZjdmZTU2NzA5ZjQ1MDk0YzA3M2Y1NWM1MDgxY2E4ODdlIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0xMDY5LDYgKzEwNjksMTIgQEAgc2V0KEph dmFTY3JpcHRDb3JlX1BSSVZBVEVfRlJBTUVXT1JLX0hFQURFUlMKICAgICB5YXJyL1lhcnJVbmlj b2RlUHJvcGVydGllcy5oCiApCiAKK2lmIChVU0VfSU5TUEVDVE9SX1NPQ0tFVF9TRVJWRVIpCisg ICAgbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfUFJJVkFURV9GUkFNRVdPUktfSEVBREVSUwor ICAgICAgICBBUEkvSlNSZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuaAorICAgICkKK2VuZGlmICgpCisK ICMgR0VORVJBVE9SIDEtQjogcGFydGljdWxhciBMVVQgY3JlYXRvciAoZm9yIDEgZmlsZSBvbmx5 KQogR0VORVJBVEVfSEFTSF9MVVQoJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L3BhcnNlci9L ZXl3b3Jkcy50YWJsZSAke0phdmFTY3JpcHRDb3JlX0RFUklWRURfU09VUkNFU19ESVJ9L0xleGVy Lmx1dC5oKQogCg==