208346 2020-02-27 15:40:30 -0800 [iOS] Remove logging for sysctl access to properties used by NSURLSession 2020-02-27 19:50:20 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue webkit-bug-importer oldest_to_newest 1623726 0 bfulgham 2020-02-27 15:40:30 -0800 Telemetry and logging indicate that two sysctl calls are needed by [NSURLSession sessionWithConfiguration]. We should allow this access so that it can make appropriate decisions about the network stack for the current device: kern.ostype kern.osrelease 1623727 1 bfulgham 2020-02-27 15:40:51 -0800 <rdar://problem/59862967> 1623732 2 391936 bfulgham 2020-02-27 15:45:07 -0800 Created attachment 391936 Patch 1623825 3 391936 ap 2020-02-27 17:54:23 -0800 Comment on attachment 391936 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391936&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:570 > + "kern.ostype" ;; Needed by NSURLSession I find these comments to not be very useful in the long term. Certainly such low level functionality is needed - or will be needed - by a lot of frameworks. So not sure what information a future reader will get from the fact that back in 2020, we first noticed it to be used by this particular one. 1623863 4 391936 commit-queue 2020-02-27 19:50:19 -0800 Comment on attachment 391936 Patch Clearing flags on attachment: 391936 Committed r257615: <https://trac.webkit.org/changeset/257615> 1623864 5 commit-queue 2020-02-27 19:50:20 -0800 All reviewed patches have been landed. Closing bug. 391936 2020-02-27 15:45:07 -0800 2020-02-27 19:50:19 -0800 Patch bug-208346-20200227154507.patch text/plain 2083 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDllYTJmYjdjYzIxOTNiNjdk MGMxMWFmY2Y0MmQ4OThiOTM4ZDhlMzIuLmEwZDJkNmMxNzA2ZTdmZGQ2ZGNhZDZmYWY0ZGUwNjc1 NjVlMWE0ZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDItMjcgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUmVtb3ZlIGxvZ2dp bmcgZm9yIHN5c2N0bCBhY2Nlc3MgdG8gcHJvcGVydGllcyB1c2VkIGJ5IE5TVVJMU2Vzc2lvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzQ2Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS81OTg2Mjk2Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZWxlbWV0cnkgYW5kIGxvZ2dpbmcgaW5kaWNhdGUg dGhhdCB0d28gc3lzY3RsIGNhbGxzIGFyZSBuZWVkZWQgYnkgW05TVVJMU2Vzc2lvbiBzZXNzaW9u V2l0aENvbmZpZ3VyYXRpb25dLgorICAgICAgICBXZSBubyBsb25nZXIgbmVlZCB0byBsb2cgdGhl c2Ugd2VsbCB1bmRlcnN0b29kIHVzZXMuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFBy b2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtpbmcuc2I6CisKIDIwMjAtMDItMjcg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIENoYW5nZSBIaXRU ZXN0UmVxdWVzdFR5cGUgdG8gYW4gT3B0aW9uU2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2lu Zy5zYiBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFw cGxlLldlYktpdC5OZXR3b3JraW5nLnNiCmluZGV4IGZhMjI1OTc2ZTAyODEzOTg2NzU2MDRjYzFi NDk3ZGQxNGM5YWZkNjQuLjUyNTQyYjU3ZDJlZTYzN2QzNzFlMzM1ZmVmNmQwYTU0MmYzMjhjMjEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3Mv Y29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5nLnNiCisrKyBiL1NvdXJjZS9XZWJLaXQvUmVzb3Vy Y2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5nLnNiCkBA IC00ODQsOCArNDg0LDYgQEAKICAgICAoc3lzY3RsLW5hbWUtcHJlZml4ICJrZXJuLm1vbm90b25p Y2Nsb2NrIikKICAgICAoc3lzY3RsLW5hbWUgImtlcm4ubW9ub3RvbmljbG9ja19vZmZzZXRfdXNl Y3MiKQogICAgIChzeXNjdGwtbmFtZSAia2Vybi5uZ3JvdXBzIikKLSAgICAoc3lzY3RsLW5hbWUg Imtlcm4ub3NyZWxlYXNlIikKLSAgICAoc3lzY3RsLW5hbWUgImtlcm4ub3N0eXBlIikKICAgICAo c3lzY3RsLW5hbWUgImtlcm4uc2F2ZWRfaWRzIikKICAgICAoc3lzY3RsLW5hbWUgImtlcm4udXNy c3RhY2siKQogICAgIChzeXNjdGwtbmFtZSAia2Vybi51c3JzdGFjazY0IikKQEAgLTU2OSw2ICs1 NjcsOCBAQAogICAgICAgICAia2Vybi5tYXhmaWxlc3BlcnByb2MiCiAgICAgICAgICJrZXJuLm1l bW9yeXN0YXR1c19sZXZlbCIKICAgICAgICAgImtlcm4ub3Nwcm9kdWN0dmVyc2lvbiIgOzsgTmVl ZGVkIGJ5IENGTmV0d29yayAoSFNUUyBzdG9yZSBhbmQgb3RoZXJzKQorICAgICAgICAia2Vybi5v c3R5cGUiIDs7IE5lZWRlZCBieSBOU1VSTFNlc3Npb24KKyAgICAgICAgImtlcm4ub3NyZWxlYXNl IiA7OyBEaXR0by4KICAgICAgICAgImtlcm4ub3N2YXJpYW50X3N0YXR1cyIgOzsgTmVlZGVkIGZv ciBidW5kbGUgbG9hZGluZwogICAgICAgICAia2Vybi5vc3ZlcnNpb24iIDs7IE5lZWRlZCBieSBX ZWJLaXQgYW5kIEFTTCBsb2dnaW5nLgogICAgICAgICAia2Vybi5zZWN1cmVfa2VybmVsIiA7OyBO ZWVkZWQgYnkgWFBDIGJ1bmRsZSByZXNvbHV0aW9uCg==