208341 2020-02-27 14:10:52 -0800 run-javascriptcore-tests: Make upload format valid 2020-02-28 11:31:37 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue webkit-bug-importer oldest_to_newest 1623663 0 jbedard 2020-02-27 14:10:52 -0800 A number of ports are having trouble uploading JSC results. We should print the json we attempted to upload when the upload fails. 1623664 1 391915 jbedard 2020-02-27 14:17:17 -0800 Created attachment 391915 Patch 1623665 2 aakash_jain 2020-02-27 14:17:33 -0800 (In reply to Jonathan Bedard from comment #0) > A number of ports are having trouble uploading JSC results. can you provide example? > We should print the json we attempted to upload when the upload fails. Wouldn't json be quite large? How will printing help? Is it for debugging? 1623666 3 jbedard 2020-02-27 14:19:19 -0800 (In reply to Aakash Jain from comment #2) > (In reply to Jonathan Bedard from comment #0) > > A number of ports are having trouble uploading JSC results. > can you provide example? > > > We should print the json we attempted to upload when the upload fails. > Wouldn't json be quite large? How will printing help? Is it for debugging? Not any larger than the log we've already printed. I sort of need this because I don't know why non Apple and Windows platforms are getting rejected by the server. I presume it's because their configurations are incorrect, but I don't know for sure. 1623672 4 aakash_jain 2020-02-27 14:27:14 -0800 (In reply to Jonathan Bedard from comment #3) > I sort of need this because I don't know why non Apple and Windows platforms are getting rejected by the server. I presume it's because their configurations are incorrect, but I don't know for sure. In that case, can you add a FIXME/TODO indicating that this is just for debugging and should be removed in some time. 1623683 5 391924 jbedard 2020-02-27 14:52:07 -0800 Created attachment 391924 Patch 1623705 6 391924 ap 2020-02-27 15:22:37 -0800 Comment on attachment 391924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391924&action=review > Tools/Scripts/run-javascriptcore-tests:938 > + # FIXME: https://bugs.webkit.org/show_bug.cgi?id=208341 It's really hard to understand what this means even after looking at the bug. Can you change this to say something like "This is just for debugging and should be removed once not needed any more"? Even so, it's quite vague and non-actionable. 1623724 7 391934 jbedard 2020-02-27 15:38:31 -0800 Created attachment 391934 Patch 1623728 8 391934 aakash_jain 2020-02-27 15:42:52 -0800 Comment on attachment 391934 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391934&action=review > Tools/Scripts/run-javascriptcore-tests:938 > + # FIXME: This is for temporary debugging and should be removed https://bugs.webkit.org/show_bug.cgi?id=208341 looks better. 1623741 9 391934 commit-queue 2020-02-27 16:05:23 -0800 Comment on attachment 391934 Patch Clearing flags on attachment: 391934 Committed r257597: <https://trac.webkit.org/changeset/257597> 1623742 10 commit-queue 2020-02-27 16:05:25 -0800 All reviewed patches have been landed. Closing bug. 1623743 11 webkit-bug-importer 2020-02-27 16:06:16 -0800 <rdar://problem/59867155> 1623958 12 jbedard 2020-02-28 07:58:40 -0800 Found our problem: "version":"5.4.0-0" 1623998 13 jbedard 2020-02-28 10:43:08 -0800 Reopening to attach new patch. 1623999 14 391993 jbedard 2020-02-28 10:43:09 -0800 Created attachment 391993 Patch 1624000 15 jbedard 2020-02-28 10:44:01 -0800 This will fix the source of the problem: https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Tests%29/builds/17124/steps/jscore-test/logs/stdio https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/12794/steps/jscore-test/logs/stdio 1624004 16 391993 aakash_jain 2020-02-28 10:46:30 -0800 Comment on attachment 391993 Patch rs=me 1624012 17 391998 jbedard 2020-02-28 10:59:11 -0800 Created attachment 391998 Patch for landing 1624048 18 391998 commit-queue 2020-02-28 11:31:36 -0800 Comment on attachment 391998 Patch for landing Clearing flags on attachment: 391998 Committed r257647: <https://trac.webkit.org/changeset/257647> 1624049 19 commit-queue 2020-02-28 11:31:37 -0800 All reviewed patches have been landed. Closing bug. 391915 2020-02-27 14:17:17 -0800 2020-02-27 14:52:05 -0800 Patch bug-208341-20200227141716.patch text/plain 1016 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NzU4NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAyLTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6IFByaW50IGpzb24gYmxvYiBm b3IgdXBsb2FkIGFmdGVyIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwODM0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6CisgICAg ICAgICh1cGxvYWRSZXN1bHRzKToKKwogMjAyMC0wMi0yNyAgQWxleCBDaHJpc3RlbnNlbiAgPGFj aHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBTUEkgdG8gcXVlcnkgV0tGcmFt ZUluZm9zIGluIGEgV0tXZWJWaWV3CkluZGV4OiBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0 Y29yZS10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29y ZS10ZXN0cwkocmV2aXNpb24gMjU3NTY4KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlw dGNvcmUtdGVzdHMJKHdvcmtpbmcgY29weSkKQEAgLTkzNCw1ICs5MzQsNyBAQCBzdWIgdXBsb2Fk UmVzdWx0cwogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAgICAgcHJpbnQgIlVwbG9hZCB0byAk cmVwb3J0IGZhaWxlZFxuIjsKKyAgICBwcmludCAiQXR0ZW1wdGVkIHRvIHVwbG9hZDpcbiI7Cisg ICAgcHJpbnQgIiRlbmNvZGVkVXBsb2FkXG4iOwogICAgIHJldHVybiAxOwogfQo= 391924 2020-02-27 14:52:07 -0800 2020-02-27 15:38:29 -0800 Patch bug-208341-20200227145206.patch text/plain 1099 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NzU4NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAyLTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6IE1ha2UgdXBsb2FkIGZvcm1h dCB2YWxpZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA4MzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czoKKyAgICAgICAgKHVwbG9hZFJlc3Vs dHMpOiBQcmludCBqc29uIGJsb2IgZm9yIHVwbG9hZCBhZnRlciBmYWlsdXJlIGZvciBkZWJ1Z2dp bmcuCisKIDIwMjAtMDItMjcgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4K IAogICAgICAgICBbQ01ha2VdIEFkZCBXZWJLaXQ6OlBBTCB0YXJnZXQKSW5kZXg6IFRvb2xzL1Nj cmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw dHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCShyZXZpc2lvbiAyNTc1ODcpCisrKyBUb29scy9T Y3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwkod29ya2luZyBjb3B5KQpAQCAtOTM0LDUg KzkzNCw5IEBAIHN1YiB1cGxvYWRSZXN1bHRzCiAgICAgICAgIHJldHVybiAwOwogICAgIH0KICAg ICBwcmludCAiVXBsb2FkIHRvICRyZXBvcnQgZmFpbGVkXG4iOworCisgICAgIyBGSVhNRTogaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODM0MQorICAgIHByaW50ICJB dHRlbXB0ZWQgdG8gdXBsb2FkOlxuIjsKKyAgICBwcmludCAiJGVuY29kZWRVcGxvYWRcbiI7CiAg ICAgcmV0dXJuIDE7CiB9Cg== 391934 2020-02-27 15:38:31 -0800 2020-02-28 10:43:06 -0800 Patch bug-208341-20200227153830.patch text/plain 1150 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NzU4NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAyLTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6IE1ha2UgdXBsb2FkIGZvcm1h dCB2YWxpZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA4MzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWFrYXNoIEphaW4uCisKKyAgICAgICAgKiBT Y3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czoKKyAgICAgICAgKHVwbG9hZFJlc3VsdHMp OiBQcmludCBqc29uIGJsb2IgZm9yIHVwbG9hZCBhZnRlciBmYWlsdXJlIGZvciBkZWJ1Z2dpbmcu CisKIDIwMjAtMDItMjcgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAog ICAgICAgICBbQ01ha2VdIEFkZCBXZWJLaXQ6OlBBTCB0YXJnZXQKSW5kZXg6IFRvb2xzL1Njcmlw dHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMv cnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCShyZXZpc2lvbiAyNTc1ODcpCisrKyBUb29scy9TY3Jp cHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwkod29ya2luZyBjb3B5KQpAQCAtOTM0LDUgKzkz NCw5IEBAIHN1YiB1cGxvYWRSZXN1bHRzCiAgICAgICAgIHJldHVybiAwOwogICAgIH0KICAgICBw cmludCAiVXBsb2FkIHRvICRyZXBvcnQgZmFpbGVkXG4iOworCisgICAgIyBGSVhNRTogVGhpcyBp cyBmb3IgdGVtcG9yYXJ5IGRlYnVnZ2luZyBhbmQgc2hvdWxkIGJlIHJlbW92ZWQgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODM0MQorICAgIHByaW50ICJBdHRlbXB0 ZWQgdG8gdXBsb2FkOlxuIjsKKyAgICBwcmludCAiJGVuY29kZWRVcGxvYWRcbiI7CiAgICAgcmV0 dXJuIDE7CiB9Cg== 391993 2020-02-28 10:43:09 -0800 2020-02-28 10:59:08 -0800 Patch bug-208341-20200228104308.patch text/plain 5206 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NzY0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAyLTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6IE1ha2UgdXBsb2FkIGZvcm1h dCB2YWxpZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA4MzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czoKKyAgICAgICAgKHVwbG9hZFJlc3Vs dHMpOiBSZW1vdmUuIEZJWE1FLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAg ICAgICAgKHNwbGl0VmVyc2lvblN0cmluZyk6IEhhbmRsZSBjYXNlIHdoZXJlIHRoZSBzdWJtaW5v ciB2ZXJzaW9uIG51bWJlciBoYXMgYSAtIGluIGl0LgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cGVybC93ZWJraXRkaXJzX3VuaXR0ZXN0L3NwbGl0VmVyc2lvbi5wbDogQWRkIHVuaXQgdGVzdHMu CisKIDIwMjAtMDItMjggIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFtld3NdIGNvbW1pdCBxdWV1ZSBzaG91bGQgc2tpcCBidWlsZGluZyBhbmQgdGVzdGlu ZyBmb3Igcm9sbG91dCBwYXRjaGVzCkluZGV4OiBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0 Y29yZS10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29y ZS10ZXN0cwkocmV2aXNpb24gMjU3NjQxKQorKysgVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlw dGNvcmUtdGVzdHMJKHdvcmtpbmcgY29weSkKQEAgLTkzNSw4ICs5MzUsNSBAQCBzdWIgdXBsb2Fk UmVzdWx0cwogICAgIH0KICAgICBwcmludCAiVXBsb2FkIHRvICRyZXBvcnQgZmFpbGVkXG4iOwog Ci0gICAgIyBGSVhNRTogVGhpcyBpcyBmb3IgdGVtcG9yYXJ5IGRlYnVnZ2luZyBhbmQgc2hvdWxk IGJlIHJlbW92ZWQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODM0 MQotICAgIHByaW50ICJBdHRlbXB0ZWQgdG8gdXBsb2FkOlxuIjsKLSAgICBwcmludCAiJGVuY29k ZWRVcGxvYWRcbiI7CiAgICAgcmV0dXJuIDE7CiB9CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCShyZXZp c2lvbiAyNTc2NDEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdvcmtpbmcgY29w eSkKQEAgLTE2MTAsMTAgKzE2MTAsMTEgQEAgc3ViIHNwbGl0VmVyc2lvblN0cmluZwogICAgIG15 ICR2ZXJzaW9uU3RyaW5nID0gc2hpZnQ7CiAgICAgbXkgQHNwbGl0VmVyc2lvbiA9IHNwbGl0KC9c Li8sICR2ZXJzaW9uU3RyaW5nKTsKICAgICBAc3BsaXRWZXJzaW9uID49IDIgb3IgZGllICJJbnZh bGlkIHZlcnNpb24gJHZlcnNpb25TdHJpbmciOworICAgIG15IEBzdWJNaW5vclZlcnNpb24gPSBk ZWZpbmVkKCRzcGxpdFZlcnNpb25bMl0pID8gc3BsaXQoLy0vLCAkc3BsaXRWZXJzaW9uWzJdKSA6 ICgwKTsKICAgICByZXR1cm4gewogICAgICAgICAibWFqb3IiID0+ICRzcGxpdFZlcnNpb25bMF0s CiAgICAgICAgICJtaW5vciIgPT4gJHNwbGl0VmVyc2lvblsxXSwKLSAgICAgICAgInN1Ym1pbm9y IiA9PiAoZGVmaW5lZCgkc3BsaXRWZXJzaW9uWzJdKSA/ICRzcGxpdFZlcnNpb25bMl0gOiAwKSwK KyAgICAgICAgInN1Ym1pbm9yIiA9PiAkc3ViTWlub3JWZXJzaW9uWzBdLAogICAgIH07CiB9CiAK SW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cGVybC93ZWJraXRkaXJzX3VuaXR0ZXN0L3ByZXBl bmRUb0Vudmlyb25tZW50VmFyaWFibGVMaXN0LnBsCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw dHMvd2Via2l0cGVybC93ZWJraXRkaXJzX3VuaXR0ZXN0L3ByZXBlbmRUb0Vudmlyb25tZW50VmFy aWFibGVMaXN0LnBsCShyZXZpc2lvbiAyNTc2NDEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHBl cmwvd2Via2l0ZGlyc191bml0dGVzdC9wcmVwZW5kVG9FbnZpcm9ubWVudFZhcmlhYmxlTGlzdC5w bAkod29ya2luZyBjb3B5KQpAQCAtOTksNCArOTksMyBAQCBmb3JlYWNoIG15ICR0ZXN0Q2FzZSAo QHRlc3RDYXNlcykgewogICAgIGlzX2RlZXBseSgkcmVzdWx0LCAkdGVzdENhc2UtPntleHBlY3Rl ZFZhbHVlfSwgInByZXBlbmRUb0Vudmlyb25tZW50VmFyaWFibGVMaXN0OiAkdGVzdENhc2UtPntk ZXNjcmlwdGlvbn0gLSByZXR1cm4gcmVzdWx0Iik7CiAgICAgaXNfZGVlcGx5KCR0ZXN0Q2FzZS0+ e2V4cGVjdGVkVmFsdWV9LCAkRU5WeyR0ZXN0Q2FzZS0+e2FyZ05hbWV9fSwgInByZXBlbmRUb0Vu dmlyb25tZW50VmFyaWFibGVMaXN0OiAkdGVzdENhc2UtPntkZXNjcmlwdGlvbn0gLSBlbnZpcm9u bWVudCB2YXJpYWJsZSB2YWx1ZSIpOwogfQotCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHBl cmwvd2Via2l0ZGlyc191bml0dGVzdC9zcGxpdFZlcnNpb24ucGwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy93ZWJraXRwZXJsL3dlYmtpdGRpcnNfdW5pdHRlc3Qvc3BsaXRWZXJzaW9uLnBs CShub25leGlzdGVudCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cGVybC93ZWJraXRkaXJzX3Vu aXR0ZXN0L3NwbGl0VmVyc2lvbi5wbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDU4IEBACisj IS91c3IvYmluL2VudiBwZXJsCisKKyMgQ29weXJpZ2h0IChDKSAyMDIwIEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2Ug YW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1vZGlmaWNhdGlvbiwgYXJlIHBl cm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucworIyBhcmUgbWV0 OgorIyAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBh Ym92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5k IHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgMi4gIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5h cnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBub3RpY2Us IHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4g dGhlCisjICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQg d2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorIworIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZ IEFQUExFIElOQy4gQU5EIElUUyBDT05UUklCVVRPUlMgYGBBUyBJUycnIEFORCBBTlkKKyMgRVhQ UkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRP LCBUSEUgSU1QTElFRAorIyBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVT UyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisjIERJU0NMQUlNRUQuIElOIE5PIEVWRU5U IFNIQUxMIEFQUExFIElOQy4gT1IgSVRTIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWQor IyBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENP TlNFUVVFTlRJQUwgREFNQUdFUworIyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBS T0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7CisjIExPU1MgT0YgVVNF LCBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FV U0VEIEFORCBPTgorIyBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFD VCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1Ig T1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUworIyBT T0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFH RS4KKworIyBVbml0IHRlc3RzIGZvciB3ZWJraXRkaXJzOjpwYXJzZUF2YWlsYWJsZVhjb2RlU0RL cygkKS4KKwordXNlIHN0cmljdDsKK3VzZSB3YXJuaW5nczsKKwordXNlIENvbmZpZzsKK3VzZSBU ZXN0OjpNb3JlOwordXNlIHdlYmtpdGRpcnM7CisKK215IEB0ZXN0Q2FzZXMgPSAoCit7CisgICAg c3RyaW5nID0+ICIxLjEiLAorICAgIHZlcnNpb24gPT4ge21ham9yID0+IDEsIG1pbm9yID0+IDEs IHN1Ym1pbm9yID0+IDB9LAorfSwKK3sKKyAgICBzdHJpbmcgPT4gIjEuMi4zIiwKKyAgICB2ZXJz aW9uID0+IHttYWpvciA9PiAxLCBtaW5vciA9PiAyLCBzdWJtaW5vciA9PiAzfSwKK30sCit7Cisg ICAgc3RyaW5nID0+ICI0LjUuNi0wIiwKKyAgICB2ZXJzaW9uID0+IHttYWpvciA9PiA0LCBtaW5v ciA9PiA1LCBzdWJtaW5vciA9PiA2fSwKK30sCit7CisgICAgc3RyaW5nID0+ICIxMC4xNS4yIiwK KyAgICB2ZXJzaW9uID0+IHttYWpvciA9PiAxMCwgbWlub3IgPT4gMTUsIHN1Ym1pbm9yID0+IDJ9 LAorfSwKKyk7CisKK3BsYW4odGVzdHMgPT4gMSAqIEB0ZXN0Q2FzZXMpOworCitmb3JlYWNoIG15 ICR0ZXN0Q2FzZSAoQHRlc3RDYXNlcykgeworICAgIG15ICRyZXN1bHQgPSBzcGxpdFZlcnNpb25T dHJpbmcoJHRlc3RDYXNlLT57c3RyaW5nfSk7CisgICAgaXNfZGVlcGx5KCRyZXN1bHQsICR0ZXN0 Q2FzZS0+e3ZlcnNpb259LCAiVW5leHBlY3RlZCAgcGFyc2VkIHZlcnNpb24gZm9yOiAkdGVzdENh c2UtPntzdHJpbmd9Iik7Cit9Cg== 391998 2020-02-28 10:59:11 -0800 2020-02-28 11:31:36 -0800 Patch for landing bug-208341-20200228105911.patch text/plain 4497 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NzY0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAyLTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6IE1ha2UgdXBsb2FkIGZvcm1h dCB2YWxpZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA4MzQxCisKKyAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgQWFrYXNoIEphaW4uCisKKyAgICAg ICAgKiBTY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czoKKyAgICAgICAgKHVwbG9hZFJl c3VsdHMpOiBSZW1vdmUuIEZJWE1FLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToK KyAgICAgICAgKHNwbGl0VmVyc2lvblN0cmluZyk6IEhhbmRsZSBjYXNlIHdoZXJlIHRoZSBzdWJt aW5vciB2ZXJzaW9uIG51bWJlciBoYXMgYSAtIGluIGl0LgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cGVybC93ZWJraXRkaXJzX3VuaXR0ZXN0L3NwbGl0VmVyc2lvbi5wbDogQWRkIHVuaXQgdGVz dHMuCisKIDIwMjAtMDItMjggIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtld3NdIGNvbW1pdCBxdWV1ZSBzaG91bGQgc2tpcCBidWlsZGluZyBhbmQgdGVz dGluZyBmb3Igcm9sbG91dCBwYXRjaGVzCkluZGV4OiBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2Ny aXB0Y29yZS10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0 Y29yZS10ZXN0cwkocmV2aXNpb24gMjU3NjQxKQorKysgVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNj cmlwdGNvcmUtdGVzdHMJKHdvcmtpbmcgY29weSkKQEAgLTkzNSw4ICs5MzUsNSBAQCBzdWIgdXBs b2FkUmVzdWx0cwogICAgIH0KICAgICBwcmludCAiVXBsb2FkIHRvICRyZXBvcnQgZmFpbGVkXG4i OwogCi0gICAgIyBGSVhNRTogVGhpcyBpcyBmb3IgdGVtcG9yYXJ5IGRlYnVnZ2luZyBhbmQgc2hv dWxkIGJlIHJlbW92ZWQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw ODM0MQotICAgIHByaW50ICJBdHRlbXB0ZWQgdG8gdXBsb2FkOlxuIjsKLSAgICBwcmludCAiJGVu Y29kZWRVcGxvYWRcbiI7CiAgICAgcmV0dXJuIDE7CiB9CkluZGV4OiBUb29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCShy ZXZpc2lvbiAyNTc2NDEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdvcmtpbmcg Y29weSkKQEAgLTE2MTAsMTAgKzE2MTAsMTEgQEAgc3ViIHNwbGl0VmVyc2lvblN0cmluZwogICAg IG15ICR2ZXJzaW9uU3RyaW5nID0gc2hpZnQ7CiAgICAgbXkgQHNwbGl0VmVyc2lvbiA9IHNwbGl0 KC9cLi8sICR2ZXJzaW9uU3RyaW5nKTsKICAgICBAc3BsaXRWZXJzaW9uID49IDIgb3IgZGllICJJ bnZhbGlkIHZlcnNpb24gJHZlcnNpb25TdHJpbmciOworICAgIG15IEBzdWJNaW5vclZlcnNpb24g PSBkZWZpbmVkKCRzcGxpdFZlcnNpb25bMl0pID8gc3BsaXQoLy0vLCAkc3BsaXRWZXJzaW9uWzJd KSA6ICgwKTsKICAgICByZXR1cm4gewogICAgICAgICAibWFqb3IiID0+ICRzcGxpdFZlcnNpb25b MF0sCiAgICAgICAgICJtaW5vciIgPT4gJHNwbGl0VmVyc2lvblsxXSwKLSAgICAgICAgInN1Ym1p bm9yIiA9PiAoZGVmaW5lZCgkc3BsaXRWZXJzaW9uWzJdKSA/ICRzcGxpdFZlcnNpb25bMl0gOiAw KSwKKyAgICAgICAgInN1Ym1pbm9yIiA9PiAkc3ViTWlub3JWZXJzaW9uWzBdLAogICAgIH07CiB9 CiAKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cGVybC93ZWJraXRkaXJzX3VuaXR0ZXN0L3Nw bGl0VmVyc2lvbi5wbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHBlcmwvd2Vi a2l0ZGlyc191bml0dGVzdC9zcGxpdFZlcnNpb24ucGwJKG5vbmV4aXN0ZW50KQorKysgVG9vbHMv U2NyaXB0cy93ZWJraXRwZXJsL3dlYmtpdGRpcnNfdW5pdHRlc3Qvc3BsaXRWZXJzaW9uLnBsCSh3 b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNTggQEAKKyMhL3Vzci9iaW4vZW52IHBlcmwKKworIyBD b3B5cmlnaHQgKEMpIDIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIworIyBS ZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9y IHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl IGZvbGxvd2luZyBjb25kaXRpb25zCisjIGFyZSBtZXQ6CisjIDEuICBSZWRpc3RyaWJ1dGlvbnMg b2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorIyAgICAgbm90 aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVy LgorIyAyLiAgUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRo ZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMg YW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyMgICAgIGRvY3VtZW50YXRpb24g YW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisj CisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRS SUJVVE9SUyBgYEFTIElTJycgQU5EIEFOWQorIyBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElF UywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVECisjIFdBUlJBTlRJ RVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9T RSBBUkUKKyMgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMg Q09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZCisjIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lE RU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTCisjIChJ TkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBH T09EUyBPUiBTRVJWSUNFUzsKKyMgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJV U0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OCisjIEFOWSBUSEVPUlkg T0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBU T1JUCisjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5Z IFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTCisjIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQg T0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCisjIFVuaXQgdGVzdHMgZm9yIHdl YmtpdGRpcnM6OnBhcnNlQXZhaWxhYmxlWGNvZGVTREtzKCQpLgorCit1c2Ugc3RyaWN0OwordXNl IHdhcm5pbmdzOworCit1c2UgQ29uZmlnOwordXNlIFRlc3Q6Ok1vcmU7Cit1c2Ugd2Via2l0ZGly czsKKworbXkgQHRlc3RDYXNlcyA9ICgKK3sKKyAgICBzdHJpbmcgPT4gIjEuMSIsCisgICAgdmVy c2lvbiA9PiB7bWFqb3IgPT4gMSwgbWlub3IgPT4gMSwgc3VibWlub3IgPT4gMH0sCit9LAorewor ICAgIHN0cmluZyA9PiAiMS4yLjMiLAorICAgIHZlcnNpb24gPT4ge21ham9yID0+IDEsIG1pbm9y ID0+IDIsIHN1Ym1pbm9yID0+IDN9LAorfSwKK3sKKyAgICBzdHJpbmcgPT4gIjQuNS42LTAiLAor ICAgIHZlcnNpb24gPT4ge21ham9yID0+IDQsIG1pbm9yID0+IDUsIHN1Ym1pbm9yID0+IDZ9LAor fSwKK3sKKyAgICBzdHJpbmcgPT4gIjEwLjE1LjIiLAorICAgIHZlcnNpb24gPT4ge21ham9yID0+ IDEwLCBtaW5vciA9PiAxNSwgc3VibWlub3IgPT4gMn0sCit9LAorKTsKKworcGxhbih0ZXN0cyA9 PiAxICogQHRlc3RDYXNlcyk7CisKK2ZvcmVhY2ggbXkgJHRlc3RDYXNlIChAdGVzdENhc2VzKSB7 CisgICAgbXkgJHJlc3VsdCA9IHNwbGl0VmVyc2lvblN0cmluZygkdGVzdENhc2UtPntzdHJpbmd9 KTsKKyAgICBpc19kZWVwbHkoJHJlc3VsdCwgJHRlc3RDYXNlLT57dmVyc2lvbn0sICJVbmV4cGVj dGVkICBwYXJzZWQgdmVyc2lvbiBmb3I6ICR0ZXN0Q2FzZS0+e3N0cmluZ30iKTsKK30K