208316 2020-02-27 08:31:37 -0800 Crash in CSSPrimitiveValue::cleanup 2020-03-17 22:47:21 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ajuma pgyanchandani bfulgham commit-queue ews-feeder koivisto pgyanchandani product-security rniwa rohitrao simon.fraser webkit-bug-importer zalan oldest_to_newest 1623496 0 391877 ajuma 2020-02-27 08:31:37 -0800 Created attachment 391877 Minimal test case Filing this as a security bug since it was found using a fuzzer; there's no disclosure deadline for this bug. Crash stack: ================================================================= ==62534==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000004 (pc 0x0001bbb8ab7d bp 0x7ffeedf5da90 sp 0x7ffeedf5da80 T0) ==62534==The signal is caused by a READ memory access. ==62534==Hint: address points to the zero page. ==62534==WARNING: invalid path to external symbolizer! ==62534==WARNING: Failed to use and restart external symbolizer! #0 0x1bbb8ab7c in WTF::RefCountedBase::derefBase() const (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x10b7c) #1 0x1bbd0f36d in WebCore::CSSValue::deref() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x19536d) #2 0x1be814650 in WebCore::CSSPrimitiveValue::cleanup() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2c9a650) #3 0x1be81445d in WebCore::CSSPrimitiveValue::~CSSPrimitiveValue() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2c9a45d) #4 0x1be852774 in WebCore::CSSValue::destroy() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2cd8774) #5 0x1be803a77 in WTF::VectorDestructor<true, WTF::Ref<WebCore::CSSValue, WTF::DumbPtrTraits<WebCore::CSSValue> > >::destruct(WTF::Ref<WebCore::CSSValue, WTF::DumbPtrTraits<WebCore::CSSValue> >*, WTF::Ref<WebCore::CSSValue, WTF::DumbPtrTraits<WebCore::CSSValue> >*) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2c89a77) #6 0x1be8039da in WTF::Vector<WTF::Ref<WebCore::CSSValue, WTF::DumbPtrTraits<WebCore::CSSValue> >, 4ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::~Vector() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2c899da) #7 0x1be7fc9b1 in WebCore::CSSValueList::~CSSValueList() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2c829b1) #8 0x1be852c5a in WebCore::CSSValue::destroy() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2cd8c5a) #9 0x1be77bff7 in WTF::VectorDestructor<true, WebCore::CSSProperty>::destruct(WebCore::CSSProperty*, WebCore::CSSProperty*) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2c01ff7) #10 0x1be90794a in WTF::Vector<WebCore::CSSProperty, 4ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::~Vector() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2d8d94a) #11 0x1be8e939a in WebCore::MutableStyleProperties::~MutableStyleProperties() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2d6f39a) #12 0x1be3d02e9 in WebCore::StylePropertiesBase::deref() const (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x28562e9) #13 0x1bede2e0e in WebCore::EditingStyle::~EditingStyle() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3268e0e) #14 0x1b1b4edf2 in std::__1::default_delete<WebCore::EditingStyle>::operator()(WebCore::EditingStyle*) const (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x1b4edf2) #15 0x1b1b04435 in WebKit::WebPage::editorState(WebKit::WebPage::IncludePostLayoutDataHint) const (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x1b04435) #16 0x1b1b27c46 in WebKit::WebPage::sendEditorStateUpdate() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x1b27c46) #17 0x1b184f824 in WebKit::WebEditorClient::respondToChangedContents() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x184f824) #18 0x1bedf7c90 in WebCore::Editor::respondToChangedContents(WebCore::VisibleSelection const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x327dc90) #19 0x1bedfd6ef in WebCore::Editor::appliedEditing(WebCore::CompositeEditCommand&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x32836ef) #20 0x1bed904b9 in WebCore::CompositeEditCommand::apply() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x32164b9) #21 0x1bee3e1fd in WebCore::executeInsertOrderedList(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x32c41fd) #22 0x1beacdc91 in WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2f53c91) #23 0x1bc587800 in WebCore::jsDocumentPrototypeFunctionExecCommandBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSDocument*, JSC::ThrowScope&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0xa0d800) #24 0x1bc444625 in long long WebCore::IDLOperation<WebCore::JSDocument>::call<&(WebCore::jsDocumentPrototypeFunctionExecCommandBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSDocument*, JSC::ThrowScope&)), (WebCore::CastedThisErrorBehavior)0>(JSC::JSGlobalObject&, JSC::CallFrame&, char const*) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x8ca625) #25 0x442896c01177 (<unknown module>) #26 0x1d66db45b in llint_entry (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0xa8c45b) #27 0x1d66c43d8 in vmEntryToJavaScript (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0xa753d8) #28 0x1d7cec937 in JSC::Interpreter::executeCall(JSC::JSGlobalObject*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0x209d937) #29 0x1d8318140 in JSC::call(JSC::JSGlobalObject*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0x26c9140) #30 0x1d8318242 in JSC::call(JSC::JSGlobalObject*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0x26c9242) #31 0x1d831861f in JSC::profiledCall(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0x26c961f) #32 0x1be41401b in WebCore::JSExecState::profiledCall(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x289a01b) #33 0x1be43d071 in WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext&, WebCore::Event&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x28c3071) #34 0x1bebdf35b in WebCore::EventTarget::innerInvokeEventListeners(WebCore::Event&, WTF::Vector<WTF::RefPtr<WebCore::RegisteredEventListener, WTF::DumbPtrTraits<WebCore::RegisteredEventListener> >, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WebCore::EventTarget::EventInvokePhase) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x306535b) #35 0x1bebda6f2 in WebCore::EventTarget::fireEventListeners(WebCore::Event&, WebCore::EventTarget::EventInvokePhase) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x30606f2) #36 0x1bf95a69d in WebCore::DOMWindow::dispatchEvent(WebCore::Event&, WebCore::EventTarget*) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3de069d) #37 0x1bf96bfa8 in WebCore::DOMWindow::dispatchLoadEvent() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3df1fa8) #38 0x1beab7180 in WebCore::Document::dispatchWindowLoadEvent() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2f3d180) #39 0x1beab6af0 in WebCore::Document::implicitClose() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2f3caf0) #40 0x1bf7a4bc2 in WebCore::FrameLoader::checkCompleted() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3c2abc2) #41 0x1bf7a15de in WebCore::FrameLoader::finishedParsing() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3c275de) #42 0x1bead3af2 in WebCore::Document::finishedParsing() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2f59af2) #43 0x1bf348510 in WebCore::HTMLDocumentParser::prepareToStopParsing() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x37ce510) #44 0x1bf73890a in WebCore::DocumentWriter::end() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3bbe90a) #45 0x1bf7371a8 in WebCore::DocumentLoader::finishedLoading() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3bbd1a8) #46 0x1bf736dee in WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3bbcdee) #47 0x1bf8c4927 in WebCore::CachedResource::checkNotify() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3d4a927) #48 0x1bf8c0ac8 in WebCore::CachedRawResource::finishLoading(WebCore::SharedBuffer*) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3d46ac8) #49 0x1bf844cde in WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3ccacde) #50 0x1b1754ca6 in WebKit::WebResourceLoader::didFinishResourceLoad(WebCore::NetworkLoadMetrics const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x1754ca6) #51 0x1b1e56547 in void IPC::handleMessage<Messages::WebResourceLoader::DidFinishResourceLoad, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)>(IPC::Decoder&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x1e56547) #52 0x1b1e55649 in WebKit::WebResourceLoader::didReceiveWebResourceLoaderMessage(IPC::Connection&, IPC::Decoder&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x1e55649) #53 0x1b1711334 in WebKit::NetworkProcessConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x1711334) #54 0x1b008598a in IPC::Connection::dispatchMessage(IPC::Decoder&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x8598a) #55 0x1b008667a in IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x8667a) #56 0x1b00872b8 in IPC::Connection::dispatchOneIncomingMessage() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x872b8) #57 0x1d5d0c679 in WTF::RunLoop::performWork() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0xbd679) #58 0x1d5d0d25a in WTF::RunLoop::performWork(void*) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0xbe25a) #59 0x7fff2c6f631a in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation:x86_64+0x5731a) #60 0x7fff2c6f62c0 in __CFRunLoopDoSource0 (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation:x86_64+0x572c0) #61 0x7fff2c6da1ba in __CFRunLoopDoSources0 (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation:x86_64+0x3b1ba) #62 0x7fff2c6d9782 in __CFRunLoopRun (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation:x86_64+0x3a782) #63 0x7fff2c6d9084 in CFRunLoopRunSpecific (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation:x86_64+0x3a084) #64 0x7fff2e94da9e in -[NSRunLoop(NSRunLoop) runMode:beforeDate:] (/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation:x86_64+0x1ca9e) #65 0x7fff2e94d973 in -[NSRunLoop(NSRunLoop) run] (/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation:x86_64+0x1c973) #66 0x7fff58dc51d6 in _xpc_objc_main (/usr/lib/system/libxpc.dylib:x86_64+0x111d6) #67 0x7fff58dc4cd8 in xpc_main (/usr/lib/system/libxpc.dylib:x86_64+0x10cd8) #68 0x1b0904465 in WebKit::XPCServiceMain(int, char const**) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x904465) #69 0x7fff58b923d4 in start (/usr/lib/system/libdyld.dylib:x86_64+0x163d4) ==62534==Register values: rax = 0x0000100000000000 rbx = 0x0000000000000000 rcx = 0x0000100000000000 rdx = 0x0000100000000000 rdi = 0x0000000000000004 rsi = 0x0000606000130620 rbp = 0x00007ffeedf5da90 rsp = 0x00007ffeedf5da80 r8 = 0x0000000000000018 r9 = 0x00000fffffffffff r10 = 0x0000000000000000 r11 = 0xffffffffffffffff r12 = 0x00007ffeedf5dd00 r13 = 0x0000000000000000 r14 = 0x0000100000000000 r15 = 0x000060300012c8b0 1623497 1 webkit-bug-importer 2020-02-27 08:31:47 -0800 <rdar://problem/59848034> 1630502 2 393696 pgyanchandani 2020-03-16 15:43:38 -0700 Created attachment 393696 Patch 1630522 3 393703 pgyanchandani 2020-03-16 16:10:48 -0700 Created attachment 393703 Patch 1630547 4 393703 simon.fraser 2020-03-16 16:45:00 -0700 Comment on attachment 393703 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393703&action=review > Source/WebCore/css/CSSPrimitiveValue.cpp:456 > + if (m_value.calc) > + m_value.calc->deref(); Do we understand how we ended up with a type of CSSUnitType::CSS_CALC but no calc value? That suggests a bug elsewhere. 1630548 5 393703 simon.fraser 2020-03-16 16:45:45 -0700 Comment on attachment 393703 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393703&action=review >> Source/WebCore/css/CSSPrimitiveValue.cpp:456 >> + m_value.calc->deref(); > > Do we understand how we ended up with a type of CSSUnitType::CSS_CALC but no calc value? That suggests a bug elsewhere. If we do, then the changelog should explain it. 1630565 6 393703 rniwa 2020-03-16 17:09:53 -0700 Comment on attachment 393703 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393703&action=review > Source/WebCore/ChangeLog:8 > + Added a NULL check before calling defer() for CSSUnitType :: CSS_CALC. Please describe why we need this null check as we discussed. Namely about how WebCore::createCSS can return nullptr. >>> Source/WebCore/css/CSSPrimitiveValue.cpp:456 >>> + m_value.calc->deref(); >> >> Do we understand how we ended up with a type of CSSUnitType::CSS_CALC but no calc value? That suggests a bug elsewhere. > > If we do, then the changelog should explain it. Yes, CSSCalcValue::create calls WebCore::createCSS, which returns nullptr in numerous cases. 1630881 7 393785 pgyanchandani 2020-03-17 14:11:55 -0700 Created attachment 393785 Patch 1630883 8 393786 pgyanchandani 2020-03-17 14:14:47 -0700 Created attachment 393786 Patch 1630884 9 pgyanchandani 2020-03-17 14:16:42 -0700 (In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 393703 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393703&action=review > > >> Source/WebCore/css/CSSPrimitiveValue.cpp:456 > >> + m_value.calc->deref(); > > > > Do we understand how we ended up with a type of CSSUnitType::CSS_CALC but no calc value? That suggests a bug elsewhere. > > If we do, then the changelog should explain it. I have updated the changeling, as per suggestion from you and Ryosuke. Kindly help with review 1630885 10 pgyanchandani 2020-03-17 14:17:06 -0700 (In reply to Pinki Gyanchandani from comment #9) > (In reply to Simon Fraser (smfr) from comment #5) > > Comment on attachment 393703 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=393703&action=review > > > > >> Source/WebCore/css/CSSPrimitiveValue.cpp:456 > > >> + m_value.calc->deref(); > > > > > > Do we understand how we ended up with a type of CSSUnitType::CSS_CALC but no calc value? That suggests a bug elsewhere. > > > > If we do, then the changelog should explain it. > > > I have updated the changelog, as per suggestion from you and Ryosuke. > Kindly help with review 1630972 11 393786 rniwa 2020-03-17 17:40:28 -0700 Comment on attachment 393786 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393786&action=review > Source/WebCore/ChangeLog:11 > + While initializing CSSPrimitiveValue for type Calculated, CSSCalcValue calls "create". This internally calls > + createCSS which return nullptr at multiple places, ends up returning nullptr for "create". This is very wordy. How about something like this: Initializing CSSPrimitiveValue for Calculated type calls createCSS, which return nullptr in multiple circumstances, resulting in m_value.calc to be initialized to nullptr. All ref counted objects have a pattern where the constructor is private, and there is a corresponding static create() function so there is no need to explicitly talk about it. > Source/WebCore/ChangeLog:13 > + Initially createCSS is called for node type Operation, and in op type Min for operationChildren. CSSCalcOperationNode::createMinOrMaxOrClamp What is in op type Min? > Source/WebCore/ChangeLog:14 > + returns NULL in this case as for one of the children node, category(lenght) and valueCategory(percent) are not same, and doesn't satisfy condition I don't think we need to go into details like this. It's sufficient to say createCSS returns nullptr in some cases. Given we've already stated that createCSS is involved, we can just say this here: As an example, createCSS returns nullptr when processing min() operator and there is a category mismatch between length and percent for min() operator as it is the case in the newly added test case. 1631013 12 393819 pgyanchandani 2020-03-17 20:07:30 -0700 Created attachment 393819 Patch 1631049 13 rniwa 2020-03-17 22:01:34 -0700 There is no security implication here. Just a null dereferencing. 1631050 14 393819 commit-queue 2020-03-17 22:47:19 -0700 Comment on attachment 393819 Patch Clearing flags on attachment: 393819 Committed r258625: <https://trac.webkit.org/changeset/258625> 1631051 15 commit-queue 2020-03-17 22:47:21 -0700 All reviewed patches have been landed. Closing bug. 391877 2020-02-27 08:31:37 -0800 2020-02-27 08:31:37 -0800 Minimal test case primitive-value-cleanup.html text/html 1237 ajuma PGh0bWxoZWFkPjxtZXRhPjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4Kd2luZG93Lm9u bG9hZD1mdW5jdGlvbigpewogIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJTZWxlY3RBbGwiKQogIHZh ciBvRWxlbWVudCA9ZnVuY3Rpb24oKXsKICB9OwogIHZhciBvRWxlbWVudCA9ZnVuY3Rpb24oKXsK ICAgIHZhciBhb0VsZW1lbnRzID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoIioiKTsK ICAgIGlmIChhb0VsZW1lbnRzLmxlbmd0aCkgcmV0dXJuIGFvRWxlbWVudHNbMzIgJSBhb0VsZW1l bnRzLmxlbmd0aF07CiAgfSgpOwpvRWxlbWVudC5jb250ZW50RWRpdGFibGUgPSBvRWxlbWVudC5j b250ZW50RWRpdGFibGUgPT0gInRydWUiID8gImZhbHNlIiA6ICJ0cnVlIjsKICBkb2N1bWVudC5l eGVjQ29tbWFuZCgnSW5zZXJ0T3JkZXJlZExpc3QnKTsKfTsKPC9zY3JpcHQ+CjxzdHlsZSB4bWw6 bGFuZz0iZW4sIG5sIiBkaXI9InJ0bCIgdHlwZT0idGV4dC9jc3MiPgoqey13ZWJraXQtYm94LWZs ZXgtZ3JvdXA6aW5oZXJpdDttYXgtd2lkdGg6KzExMiU7Z3JpZC1yb3dzOigxNjM4MyogMDAwMDAw MDAxMjc5OTk5OTk5OTk5OTk5OTk5KiAzLjA5OTFlbSAtMDgyNTcyJSAwLjczJSA5MS4xJSAxMjAq KTstd2Via2l0LWxpbmUtY2xhbXA6NzYuODt0ZXh0LWF1dG9zcGFjZTppZGVvZ3JhcGgtc3BhY2Ug IWltcG9ydGFudDtvdXRsaW5lLXdpZHRoOm1lZGl1bSAhaW1wb3J0YW50O3BhZGRpbmc6MC4wMDgy NjkzNTY2MDE3MzE5MTk3NzU4NDM5NDg2Mjc4ODAzMDg3NzcwOTM4ODczMjkxMDE1NjI1JSAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMCUgMC43MTk2MTcwNTYwMDQzMjc0NTk5OTQ4 NDA0MTAyMTc4NzU2MTQ3NjIzMDYyMTMzNzg5MDYyNWVtIDAwMDAwLjAwMDAxNTI2MDYzNTg5ODkz Mjk3Njc2MzUyMDgyNDU5MjM5MDU2Nzg4NjQ2ODQ4ODcyMzAzOTYyNzA3NTE5NTMwMDAwJTtsZXR0 ZXItc3BhY2luZzorNjQ0MTU1MC43cHg7LXdlYmtpdC1tYXNrLWJveC1pbWFnZTpub25lIDIxNDc0 ODM2NjQuOTk2Mzk0NjM0MjQ2ODI2MTcxODc1JSAwJSAxMjAuMTM3NDg1Mzc5MzE2NTg2ODg2NDg4 OTQ4OTQ4NjgxMzU0NTIyNzA1MDc4MTI1JS8zMjc2OC4xMzQ0Nzg3NzE2MTUyNDk1NzA0NTkxMjc0 MjYxNDc0NjA5Mzc1cHggc3RyZXRjaDtwYWRkaW5nLXRvcDptaW4oMDg2My43cmVtLDQyLjIlLDc2 NTI5MjZjbSw3NzQlKTt9Cjwvc3R5bGU+CjxtaXNzaW5nLWdseXBoPg== 393696 2020-03-16 15:43:38 -0700 2020-03-16 16:10:46 -0700 Patch bug-208316-20200316154338.patch text/plain 2964 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uMjU1YzM2NDFiN2I3MTU5YzdkMGI4YzViNmVhYzdj YzI0MGRiNzQ4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTE2ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFz aCBpbiBDU1NQcmltaXRpdmVWYWx1ZTo6Y2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9leGVjQ29tbWFuZC9wcmltaXRp dmUtdmFsdWUtY2xlYW51cC1taW5pbWFsLmh0bWwKKworICAgICAgICAqIGNzcy9DU1NQcmltaXRp dmVWYWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6Y2xlYW51 cCk6CisKIDIwMjAtMDMtMTAgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAg ICAgICAgQWRkIGxvZ2dpbmcgZm9yIE1vZGVybiBFTUUgbWV0aG9kcy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCmluZGV4IGY5NWFjYzQ5ZTFhZGMxZjlmMGRjZjJjZDcz OTdlMjRiYWZhNWI0MzcuLjdiOWFhMDcwNDNiNWFjNjg2NjZlMTVmMjFmN2JjYjAxNGQwZDFjZWIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcApAQCAtNDUyLDcgKzQ1 Miw4IEBAIHZvaWQgQ1NTUHJpbWl0aXZlVmFsdWU6OmNsZWFudXAoKQogICAgICAgICBtX3ZhbHVl LnBhaXItPmRlcmVmKCk7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgQ1NTVW5pdFR5cGU6OkNT U19DQUxDOgotICAgICAgICBtX3ZhbHVlLmNhbGMtPmRlcmVmKCk7CisgICAgICAgIGlmIChtX3Zh bHVlLmNhbGMpCisgICAgICAgICAgICBtX3ZhbHVlLmNhbGMtPmRlcmVmKCk7CiAgICAgICAgIGJy ZWFrOwogICAgIGNhc2UgQ1NTVW5pdFR5cGU6OkNTU19DQUxDX1BFUkNFTlRBR0VfV0lUSF9OVU1C RVI6CiAgICAgY2FzZSBDU1NVbml0VHlwZTo6Q1NTX0NBTENfUEVSQ0VOVEFHRV9XSVRIX0xFTkdU SDoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCBhMzY2NzIzNTYwMGI0MWQ3NmE0NDcwNmQzZTliMWNiMDYxNTQ0NzI5Li5lZDdh OThjNDA5NzJjYmFjOGUyMjcwZTRmMzAzNjBjNTg4M2ZkZWViIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMjAtMDMtMTYgIFBpbmtpIEd5YW5jaGFuZGFuaSAgPHBneWFuY2hhbmRhbmlAYXBwbGUu Y29tPgorCisgICAgICAgIENyYXNoIGluIENTU1ByaW1pdGl2ZVZhbHVlOjpjbGVhbnVwCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgzMTYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGVkaXRpbmcvZXhl Y0NvbW1hbmQvcHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sOiBBZGRlZC4KKwog MjAyMC0wMy0xMCAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtXUEVdIEdhcmRlbmluZywgZW1pdCBuZXcgYmFzZWxpbmVzIG9mIFdlYkdMIDEuMC4zIGNv bmZvcm1hbmNlIHRlc3RzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21t YW5kL3ByaW1pdGl2ZS12YWx1ZS1jbGVhbnVwLW1pbmltYWwuaHRtbCBiL0xheW91dFRlc3RzL2Vk aXRpbmcvZXhlY0NvbW1hbmQvcHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjNiMDhlM2Y1MjY0N2YxNDRlOTNhMGM1ZGM3YjNjOTQ1N2Q5Yzk4MTMKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3ByaW1pdGl2ZS12 YWx1ZS1jbGVhbnVwLW1pbmltYWwuaHRtbApAQCAtMCwwICsxLDIyIEBACis8IURPQ1RZUEUgaHRt bD4KKzxodG1sPgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorCitmdW5jdGlvbiBw cmltaXRpdmVWYWxDbGVhblVwKCkgeworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAg ICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgCisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQo IlNlbGVjdEFsbCIpOworICAgIGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5jb250ZW50RWRpdGFi bGUgPSB0cnVlOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRPcmRlcmVkTGlzdCcp OworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJJbnNlcnRIVE1MIixmYWxzZSwiVGhpcyB0ZXN0 IGNoZWNrcyBwYXNzZXMgaWYgdGhlcmUgaWYgbm8gY3Jhc2ggb2JzZXJ2ZWQuIik7Cit9OworPC9z Y3JpcHQ+CisKKzxib2R5IG9ubG9hZD1wcmltaXRpdmVWYWxDbGVhblVwKCk+Cis8c3R5bGUgdHlw ZT0idGV4dC9jc3MiPgorKntwYWRkaW5nLXRvcDptaW4oMDg2My43cmVtLDQyLjIlLDc2NTI5MjZj bSw3NzQlKTt9Cis8L3N0eWxlPgorPG1pc3NpbmctZ2x5cGg+Cis8L2JvZHk+Cis8L3NjcmlwdD4K 393703 2020-03-16 16:10:48 -0700 2020-03-17 14:11:54 -0700 Patch bug-208316-20200316161047.patch text/plain 3690 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uYjgxNTY1OGNlMmU4ODdmOGQwYzM5NmM3MzQzMjYz YTk3YWJmMDA2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAzLTE2ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFz aCBpbiBDU1NQcmltaXRpdmVWYWx1ZTo6Y2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBOVUxMIGNoZWNrIGJlZm9yZSBjYWxsaW5n IGRlZmVyKCkgZm9yIENTU1VuaXRUeXBlIDo6IENTU19DQUxDLgorCisgICAgICAgIFRlc3Q6IGVk aXRpbmcvZXhlY0NvbW1hbmQvcHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sCisK KyAgICAgICAgKiBjc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q1NTUHJpbWl0aXZlVmFsdWU6OmNsZWFudXApOgorCiAyMDIwLTAzLTEwICBKZXIgTm9ibGUgIDxq ZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBsb2dnaW5nIGZvciBNb2Rlcm4gRU1F IG1ldGhvZHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFs dWUuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcAppbmRleCBm OTVhY2M0OWUxYWRjMWY5ZjBkY2YyY2Q3Mzk3ZTI0YmFmYTViNDM3Li43YjlhYTA3MDQzYjVhYzY4 NjY2ZTE1ZjIxZjdiY2IwMTRkMGQxY2ViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUHJpbWl0aXZlVmFsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRp dmVWYWx1ZS5jcHAKQEAgLTQ1Miw3ICs0NTIsOCBAQCB2b2lkIENTU1ByaW1pdGl2ZVZhbHVlOjpj bGVhbnVwKCkKICAgICAgICAgbV92YWx1ZS5wYWlyLT5kZXJlZigpOwogICAgICAgICBicmVhazsK ICAgICBjYXNlIENTU1VuaXRUeXBlOjpDU1NfQ0FMQzoKLSAgICAgICAgbV92YWx1ZS5jYWxjLT5k ZXJlZigpOworICAgICAgICBpZiAobV92YWx1ZS5jYWxjKQorICAgICAgICAgICAgbV92YWx1ZS5j YWxjLT5kZXJlZigpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIENTU1VuaXRUeXBlOjpDU1Nf Q0FMQ19QRVJDRU5UQUdFX1dJVEhfTlVNQkVSOgogICAgIGNhc2UgQ1NTVW5pdFR5cGU6OkNTU19D QUxDX1BFUkNFTlRBR0VfV0lUSF9MRU5HVEg6CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTM2NjcyMzU2MDBiNDFkNzZhNDQ3 MDZkM2U5YjFjYjA2MTU0NDcyOS4uODJlZTkwMWRiNDYyZjk2ZTQ4M2NiZDU3N2UzNTM5MTc5YjQ0 NmQ4OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTE2ICBQaW5raSBHeWFuY2hhbmRh bmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBDU1NQcmlt aXRpdmVWYWx1ZTo6Y2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA4MzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkZWQgbW9kaWZpZWQgdmVyc2lvbiBvZiB0ZXN0Y2FzZSBhdHRhY2hlZCBp biAyMDgzMTYuIE1pbmltaXplZCB2ZXJzaW9uIHByb3ZpZGVkIGJ5IFJ5b3N1a2UgTml3YS4KKwor ICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvcHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWlu aW1hbC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQv cHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sOiBBZGRlZC4KKwogMjAyMC0wMy0x MCAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVd IEdhcmRlbmluZywgZW1pdCBuZXcgYmFzZWxpbmVzIG9mIFdlYkdMIDEuMC4zIGNvbmZvcm1hbmNl IHRlc3RzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3ByaW1p dGl2ZS12YWx1ZS1jbGVhbnVwLW1pbmltYWwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRp dGluZy9leGVjQ29tbWFuZC9wcmltaXRpdmUtdmFsdWUtY2xlYW51cC1taW5pbWFsLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi41MWJiZjBhZDVlOWFkZjhiOGVhMTI5YzYwZjY1ZjhhZjYzYzljYzlm Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9wcmlt aXRpdmUtdmFsdWUtY2xlYW51cC1taW5pbWFsLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAK K1RoaXMgdGVzdCBjaGVja3MgcGFzc2VzIGlmIHRoZXJlIGlmIG5vIGNyYXNoIG9ic2VydmVkLgor CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3ByaW1pdGl2ZS12 YWx1ZS1jbGVhbnVwLW1pbmltYWwuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1h bmQvcHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNiMDhl M2Y1MjY0N2YxNDRlOTNhMGM1ZGM3YjNjOTQ1N2Q5Yzk4MTMKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3ByaW1pdGl2ZS12YWx1ZS1jbGVhbnVwLW1p bmltYWwuaHRtbApAQCAtMCwwICsxLDIyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHNj cmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorCitmdW5jdGlvbiBwcmltaXRpdmVWYWxDbGVh blVwKCkgeworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5k dW1wQXNUZXh0KCk7CisgCisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIlNlbGVjdEFsbCIpOwor ICAgIGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5jb250ZW50RWRpdGFibGUgPSB0cnVlOworICAg IGRvY3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRPcmRlcmVkTGlzdCcpOworICAgIGRvY3VtZW50 LmV4ZWNDb21tYW5kKCJJbnNlcnRIVE1MIixmYWxzZSwiVGhpcyB0ZXN0IGNoZWNrcyBwYXNzZXMg aWYgdGhlcmUgaWYgbm8gY3Jhc2ggb2JzZXJ2ZWQuIik7Cit9OworPC9zY3JpcHQ+CisKKzxib2R5 IG9ubG9hZD1wcmltaXRpdmVWYWxDbGVhblVwKCk+Cis8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgor KntwYWRkaW5nLXRvcDptaW4oMDg2My43cmVtLDQyLjIlLDc2NTI5MjZjbSw3NzQlKTt9Cis8L3N0 eWxlPgorPG1pc3NpbmctZ2x5cGg+Cis8L2JvZHk+Cis8L3NjcmlwdD4K 393785 2020-03-17 14:11:55 -0700 2020-03-17 14:14:45 -0700 Patch bug-208316-20200317141155.patch text/plain 4314 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uOTU2ZDBhYTgxMTU1MDUwMWYzOTNkYzdiNTllOGUw ZmExN2YxZTRmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTAzLTE2ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFz aCBpbiBDU1NQcmltaXRpdmVWYWx1ZTo6Y2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBOVUxMIGNoZWNrIGJlZm9yZSBjYWxsaW5n IGRlcmVmKCkgZm9yIENTU1VuaXRUeXBlIDo6IENTU19DQUxDLgorCisgICAgICAgIFdoaWxlIGlu aXRpYWxpemluZyBDU1NQcmltaXRpdmVWYWx1ZSBmb3IgdHlwZSBDYWxjdWxhdGVkLCBDU1NDYWxj VmFsdWUgY2FsbHMgImNyZWF0ZSIuIFRoaXMgaW50ZXJuYWxseSBjYWxscworICAgICAgICBjcmVh dGVDU1Mgd2hpY2ggcmV0dXJuIG51bGxwdHIgYXQgbXVsdGlwbGUgcGxhY2VzLCBlbmRzIHVwIHJl dHVybmluZyBudWxscHRyIGZvciAiY3JlYXRlIi4KKworICAgICAgICBJbml0aWFsbHkgY3JlYXRl Q1NTIGlzIGNhbGxlZCBmb3Igbm9kZSB0eXBlIE9wZXJhdGlvbiwgYW5kIGluIG9wIHR5cGUgTWlu IGZvciBvcGVyYXRpb25DaGlsZHJlbi4gQ1NTQ2FsY09wZXJhdGlvbk5vZGU6OmNyZWF0ZU1pbk9y TWF4T3JDbGFtcAorICAgICAgICByZXR1cm5zIE5VTEwgaW4gdGhpcyBjYXNlIGFzIGZvciBvbmUg b2YgdGhlIGNoaWxkcmVuIG5vZGUsIGNhdGVnb3J5KGxlbmdodCkgYW5kIHZhbHVlQ2F0ZWdvcnko cGVyY2VudCkgYXJlIG5vdCBzYW1lLCBhbmQgZG9lc24ndCBzYXRpc2Z5IGNvbmRpdGlvbiAKKyAg ICAgICAgZm9yIGlzU2FtZVBhaXIoKS4gVGhpcyByZXR1cm5zIG51bGxwdHIsIGFuZCBtX3ZhbHVl LmNhbGMoKSBlbmRzIHVwIHdpdGggdmFsdWUgTlVMTC4gIAorCisgICAgICAgIFRlc3Q6IGVkaXRp bmcvZXhlY0NvbW1hbmQvcHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sCisKKyAg ICAgICAgKiBjc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NT UHJpbWl0aXZlVmFsdWU6OmNsZWFudXApOgorCiAyMDIwLTAzLTEwICBKZXIgTm9ibGUgIDxqZXIu bm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBsb2dnaW5nIGZvciBNb2Rlcm4gRU1FIG1l dGhvZHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUu Y3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcAppbmRleCBmOTVh Y2M0OWUxYWRjMWY5ZjBkY2YyY2Q3Mzk3ZTI0YmFmYTViNDM3Li43YjlhYTA3MDQzYjVhYzY4NjY2 ZTE1ZjIxZjdiY2IwMTRkMGQxY2ViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UHJpbWl0aXZlVmFsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVW YWx1ZS5jcHAKQEAgLTQ1Miw3ICs0NTIsOCBAQCB2b2lkIENTU1ByaW1pdGl2ZVZhbHVlOjpjbGVh bnVwKCkKICAgICAgICAgbV92YWx1ZS5wYWlyLT5kZXJlZigpOwogICAgICAgICBicmVhazsKICAg ICBjYXNlIENTU1VuaXRUeXBlOjpDU1NfQ0FMQzoKLSAgICAgICAgbV92YWx1ZS5jYWxjLT5kZXJl ZigpOworICAgICAgICBpZiAobV92YWx1ZS5jYWxjKQorICAgICAgICAgICAgbV92YWx1ZS5jYWxj LT5kZXJlZigpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIENTU1VuaXRUeXBlOjpDU1NfQ0FM Q19QRVJDRU5UQUdFX1dJVEhfTlVNQkVSOgogICAgIGNhc2UgQ1NTVW5pdFR5cGU6OkNTU19DQUxD X1BFUkNFTlRBR0VfV0lUSF9MRU5HVEg6CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTM2NjcyMzU2MDBiNDFkNzZhNDQ3MDZk M2U5YjFjYjA2MTU0NDcyOS4uODJlZTkwMWRiNDYyZjk2ZTQ4M2NiZDU3N2UzNTM5MTc5YjQ0NmQ4 OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTE2ICBQaW5raSBHeWFuY2hhbmRhbmkg IDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBDU1NQcmltaXRp dmVWYWx1ZTo6Y2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA4MzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkZWQgbW9kaWZpZWQgdmVyc2lvbiBvZiB0ZXN0Y2FzZSBhdHRhY2hlZCBpbiAy MDgzMTYuIE1pbmltaXplZCB2ZXJzaW9uIHByb3ZpZGVkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAg ICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvcHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1h bC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvcHJp bWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sOiBBZGRlZC4KKwogMjAyMC0wMy0xMCAg RGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIEdh cmRlbmluZywgZW1pdCBuZXcgYmFzZWxpbmVzIG9mIFdlYkdMIDEuMC4zIGNvbmZvcm1hbmNlIHRl c3RzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3ByaW1pdGl2 ZS12YWx1ZS1jbGVhbnVwLW1pbmltYWwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGlu Zy9leGVjQ29tbWFuZC9wcmltaXRpdmUtdmFsdWUtY2xlYW51cC1taW5pbWFsLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi41MWJiZjBhZDVlOWFkZjhiOGVhMTI5YzYwZjY1ZjhhZjYzYzljYzlmCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9wcmltaXRp dmUtdmFsdWUtY2xlYW51cC1taW5pbWFsLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK1Ro aXMgdGVzdCBjaGVja3MgcGFzc2VzIGlmIHRoZXJlIGlmIG5vIGNyYXNoIG9ic2VydmVkLgorCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3ByaW1pdGl2ZS12YWx1 ZS1jbGVhbnVwLW1pbmltYWwuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQv cHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNiMDhlM2Y1 MjY0N2YxNDRlOTNhMGM1ZGM3YjNjOTQ1N2Q5Yzk4MTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3ByaW1pdGl2ZS12YWx1ZS1jbGVhbnVwLW1pbmlt YWwuaHRtbApAQCAtMCwwICsxLDIyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHNjcmlw dCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorCitmdW5jdGlvbiBwcmltaXRpdmVWYWxDbGVhblVw KCkgeworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1w QXNUZXh0KCk7CisgCisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIlNlbGVjdEFsbCIpOworICAg IGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5jb250ZW50RWRpdGFibGUgPSB0cnVlOworICAgIGRv Y3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRPcmRlcmVkTGlzdCcpOworICAgIGRvY3VtZW50LmV4 ZWNDb21tYW5kKCJJbnNlcnRIVE1MIixmYWxzZSwiVGhpcyB0ZXN0IGNoZWNrcyBwYXNzZXMgaWYg dGhlcmUgaWYgbm8gY3Jhc2ggb2JzZXJ2ZWQuIik7Cit9OworPC9zY3JpcHQ+CisKKzxib2R5IG9u bG9hZD1wcmltaXRpdmVWYWxDbGVhblVwKCk+Cis8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgorKntw YWRkaW5nLXRvcDptaW4oMDg2My43cmVtLDQyLjIlLDc2NTI5MjZjbSw3NzQlKTt9Cis8L3N0eWxl PgorPG1pc3NpbmctZ2x5cGg+Cis8L2JvZHk+Cis8L3NjcmlwdD4K 393786 2020-03-17 14:14:47 -0700 2020-03-17 20:07:28 -0700 Patch bug-208316-20200317141446.patch text/plain 4311 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uNWIxMjg3ODJmOTdiOTdlMzZiYzU0M2M5YTMyMzQ5 OGFlYjg5MDE1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTAzLTE2ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFz aCBpbiBDU1NQcmltaXRpdmVWYWx1ZTo6Y2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBOVUxMIGNoZWNrIGJlZm9yZSBjYWxsaW5n IGRlcmVmKCkgZm9yIENTU1VuaXRUeXBlIDo6IENTU19DQUxDLgorCisgICAgICAgIFdoaWxlIGlu aXRpYWxpemluZyBDU1NQcmltaXRpdmVWYWx1ZSBmb3IgdHlwZSBDYWxjdWxhdGVkLCBDU1NDYWxj VmFsdWUgY2FsbHMgImNyZWF0ZSIuIFRoaXMgaW50ZXJuYWxseSBjYWxscworICAgICAgICBjcmVh dGVDU1Mgd2hpY2ggcmV0dXJuIG51bGxwdHIgYXQgbXVsdGlwbGUgcGxhY2VzLCBlbmRzIHVwIHJl dHVybmluZyBudWxscHRyIGZvciAiY3JlYXRlIi4KKworICAgICAgICBJbml0aWFsbHkgY3JlYXRl Q1NTIGlzIGNhbGxlZCBmb3Igbm9kZSB0eXBlIE9wZXJhdGlvbiwgYW5kIGluIG9wIHR5cGUgTWlu IGZvciBvcGVyYXRpb25DaGlsZHJlbi4gQ1NTQ2FsY09wZXJhdGlvbk5vZGU6OmNyZWF0ZU1pbk9y TWF4T3JDbGFtcAorICAgICAgICByZXR1cm5zIE5VTEwgaW4gdGhpcyBjYXNlIGFzIGZvciBvbmUg b2YgdGhlIGNoaWxkcmVuIG5vZGUsIGNhdGVnb3J5KGxlbmdodCkgYW5kIHZhbHVlQ2F0ZWdvcnko cGVyY2VudCkgYXJlIG5vdCBzYW1lLCBhbmQgZG9lc24ndCBzYXRpc2Z5IGNvbmRpdGlvbgorICAg ICAgICBmb3IgaXNTYW1lUGFpcigpLiBUaGlzIHJldHVybnMgbnVsbHB0ciwgYW5kIG1fdmFsdWUu Y2FsYygpIGVuZHMgdXAgd2l0aCB2YWx1ZSBOVUxMLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcv ZXhlY0NvbW1hbmQvcHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sCisKKyAgICAg ICAgKiBjc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJp bWl0aXZlVmFsdWU6OmNsZWFudXApOgorCiAyMDIwLTAzLTEwICBKZXIgTm9ibGUgIDxqZXIubm9i bGVAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBsb2dnaW5nIGZvciBNb2Rlcm4gRU1FIG1ldGhv ZHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3Bw IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcAppbmRleCBmOTVhY2M0 OWUxYWRjMWY5ZjBkY2YyY2Q3Mzk3ZTI0YmFmYTViNDM3Li43YjlhYTA3MDQzYjVhYzY4NjY2ZTE1 ZjIxZjdiY2IwMTRkMGQxY2ViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJp bWl0aXZlVmFsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1 ZS5jcHAKQEAgLTQ1Miw3ICs0NTIsOCBAQCB2b2lkIENTU1ByaW1pdGl2ZVZhbHVlOjpjbGVhbnVw KCkKICAgICAgICAgbV92YWx1ZS5wYWlyLT5kZXJlZigpOwogICAgICAgICBicmVhazsKICAgICBj YXNlIENTU1VuaXRUeXBlOjpDU1NfQ0FMQzoKLSAgICAgICAgbV92YWx1ZS5jYWxjLT5kZXJlZigp OworICAgICAgICBpZiAobV92YWx1ZS5jYWxjKQorICAgICAgICAgICAgbV92YWx1ZS5jYWxjLT5k ZXJlZigpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIENTU1VuaXRUeXBlOjpDU1NfQ0FMQ19Q RVJDRU5UQUdFX1dJVEhfTlVNQkVSOgogICAgIGNhc2UgQ1NTVW5pdFR5cGU6OkNTU19DQUxDX1BF UkNFTlRBR0VfV0lUSF9MRU5HVEg6CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTM2NjcyMzU2MDBiNDFkNzZhNDQ3MDZkM2U5 YjFjYjA2MTU0NDcyOS4uODJlZTkwMWRiNDYyZjk2ZTQ4M2NiZDU3N2UzNTM5MTc5YjQ0NmQ4OSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTE2ICBQaW5raSBHeWFuY2hhbmRhbmkgIDxw Z3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBDU1NQcmltaXRpdmVW YWx1ZTo6Y2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjA4MzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkZWQgbW9kaWZpZWQgdmVyc2lvbiBvZiB0ZXN0Y2FzZSBhdHRhY2hlZCBpbiAyMDgz MTYuIE1pbmltaXplZCB2ZXJzaW9uIHByb3ZpZGVkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAgICAg ICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvcHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvcHJpbWl0 aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sOiBBZGRlZC4KKwogMjAyMC0wMy0xMCAgRGll Z28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIEdhcmRl bmluZywgZW1pdCBuZXcgYmFzZWxpbmVzIG9mIFdlYkdMIDEuMC4zIGNvbmZvcm1hbmNlIHRlc3Rz CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3ByaW1pdGl2ZS12 YWx1ZS1jbGVhbnVwLW1pbmltYWwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9l eGVjQ29tbWFuZC9wcmltaXRpdmUtdmFsdWUtY2xlYW51cC1taW5pbWFsLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi41MWJiZjBhZDVlOWFkZjhiOGVhMTI5YzYwZjY1ZjhhZjYzYzljYzlmCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9wcmltaXRpdmUt dmFsdWUtY2xlYW51cC1taW5pbWFsLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK1RoaXMg dGVzdCBjaGVja3MgcGFzc2VzIGlmIHRoZXJlIGlmIG5vIGNyYXNoIG9ic2VydmVkLgorCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3ByaW1pdGl2ZS12YWx1ZS1j bGVhbnVwLW1pbmltYWwuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvcHJp bWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNiMDhlM2Y1MjY0 N2YxNDRlOTNhMGM1ZGM3YjNjOTQ1N2Q5Yzk4MTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3ByaW1pdGl2ZS12YWx1ZS1jbGVhbnVwLW1pbmltYWwu aHRtbApAQCAtMCwwICsxLDIyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHNjcmlwdCB0 eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorCitmdW5jdGlvbiBwcmltaXRpdmVWYWxDbGVhblVwKCkg eworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNU ZXh0KCk7CisgCisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIlNlbGVjdEFsbCIpOworICAgIGRv Y3VtZW50LmRvY3VtZW50RWxlbWVudC5jb250ZW50RWRpdGFibGUgPSB0cnVlOworICAgIGRvY3Vt ZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRPcmRlcmVkTGlzdCcpOworICAgIGRvY3VtZW50LmV4ZWND b21tYW5kKCJJbnNlcnRIVE1MIixmYWxzZSwiVGhpcyB0ZXN0IGNoZWNrcyBwYXNzZXMgaWYgdGhl cmUgaWYgbm8gY3Jhc2ggb2JzZXJ2ZWQuIik7Cit9OworPC9zY3JpcHQ+CisKKzxib2R5IG9ubG9h ZD1wcmltaXRpdmVWYWxDbGVhblVwKCk+Cis8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgorKntwYWRk aW5nLXRvcDptaW4oMDg2My43cmVtLDQyLjIlLDc2NTI5MjZjbSw3NzQlKTt9Cis8L3N0eWxlPgor PG1pc3NpbmctZ2x5cGg+Cis8L2JvZHk+Cis8L3NjcmlwdD4K 393819 2020-03-17 20:07:30 -0700 2020-03-17 22:47:19 -0700 Patch bug-208316-20200317200729.patch text/plain 3933 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uMGE3OWM1ZmM1YWUzNGVlYzg2MTk2ODIzMTQ4YWY3 ZjcyMGYxOTgzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAzLTE2ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFz aCBpbiBDU1NQcmltaXRpdmVWYWx1ZTo6Y2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBOVUxMIGNoZWNrIGJlZm9yZSBjYWxsaW5n IGRlcmVmKCkgZm9yIENTU1VuaXRUeXBlIDo6IENTU19DQUxDLgorCisgICAgICAgIER1cmluZyBp bml0aWFsaXphdGlvbiBvZiBDU1NDYWxjVmFsdWUsIGNyZWF0ZUNTUyByZXR1cm5zIG51bGxwdHIg d2hlbiBwcm9jZXNzaW5nIG1pbigpIG9wZXJhdG9yCisgICAgICAgIGFuZCB0aGVyZSBpcyBhIGNh dGVnb3J5IG1pc21hdGNoIGJldHdlZW4gbGVuZ3RoIGFuZCBwZXJjZW50IGZvciBtaW4oKSBvcGVy YXRvcgorICAgICAgICBhcyBzZWVuIGluIHRoaXMgbmV3bHkgYWRkZWQgdGVzdCBjYXNlLgorCisg ICAgICAgIFRlc3Q6IGVkaXRpbmcvZXhlY0NvbW1hbmQvcHJpbWl0aXZlLXZhbHVlLWNsZWFudXAt bWluaW1hbC5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Q1NTUHJpbWl0aXZlVmFsdWU6OmNsZWFudXApOgorCiAyMDIwLTAzLTEw ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBsb2dnaW5n IGZvciBNb2Rlcm4gRU1FIG1ldGhvZHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUHJpbWl0aXZlVmFsdWUuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZh bHVlLmNwcAppbmRleCBmOTVhY2M0OWUxYWRjMWY5ZjBkY2YyY2Q3Mzk3ZTI0YmFmYTViNDM3Li43 YjlhYTA3MDQzYjVhYzY4NjY2ZTE1ZjIxZjdiY2IwMTRkMGQxY2ViIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAKQEAgLTQ1Miw3ICs0NTIsOCBAQCB2b2lkIENTU1By aW1pdGl2ZVZhbHVlOjpjbGVhbnVwKCkKICAgICAgICAgbV92YWx1ZS5wYWlyLT5kZXJlZigpOwog ICAgICAgICBicmVhazsKICAgICBjYXNlIENTU1VuaXRUeXBlOjpDU1NfQ0FMQzoKLSAgICAgICAg bV92YWx1ZS5jYWxjLT5kZXJlZigpOworICAgICAgICBpZiAobV92YWx1ZS5jYWxjKQorICAgICAg ICAgICAgbV92YWx1ZS5jYWxjLT5kZXJlZigpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIENT U1VuaXRUeXBlOjpDU1NfQ0FMQ19QRVJDRU5UQUdFX1dJVEhfTlVNQkVSOgogICAgIGNhc2UgQ1NT VW5pdFR5cGU6OkNTU19DQUxDX1BFUkNFTlRBR0VfV0lUSF9MRU5HVEg6CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTM2Njcy MzU2MDBiNDFkNzZhNDQ3MDZkM2U5YjFjYjA2MTU0NDcyOS4uODJlZTkwMWRiNDYyZjk2ZTQ4M2Ni ZDU3N2UzNTM5MTc5YjQ0NmQ4OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTE2ICBQ aW5raSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBD cmFzaCBpbiBDU1NQcmltaXRpdmVWYWx1ZTo6Y2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgbW9kaWZpZWQgdmVyc2lvbiBvZiB0ZXN0 Y2FzZSBhdHRhY2hlZCBpbiAyMDgzMTYuIE1pbmltaXplZCB2ZXJzaW9uIHByb3ZpZGVkIGJ5IFJ5 b3N1a2UgTml3YS4KKworICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvcHJpbWl0aXZlLXZh bHVlLWNsZWFudXAtbWluaW1hbC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRp bmcvZXhlY0NvbW1hbmQvcHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sOiBBZGRl ZC4KKwogMjAyMC0wMy0xMCAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgog CiAgICAgICAgIFtXUEVdIEdhcmRlbmluZywgZW1pdCBuZXcgYmFzZWxpbmVzIG9mIFdlYkdMIDEu MC4zIGNvbmZvcm1hbmNlIHRlc3RzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4 ZWNDb21tYW5kL3ByaW1pdGl2ZS12YWx1ZS1jbGVhbnVwLW1pbmltYWwtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9wcmltaXRpdmUtdmFsdWUtY2xlYW51cC1t aW5pbWFsLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41MWJiZjBhZDVlOWFkZjhiOGVhMTI5YzYw ZjY1ZjhhZjYzYzljYzlmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9l eGVjQ29tbWFuZC9wcmltaXRpdmUtdmFsdWUtY2xlYW51cC1taW5pbWFsLWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDIgQEAKK1RoaXMgdGVzdCBjaGVja3MgcGFzc2VzIGlmIHRoZXJlIGlmIG5vIGNy YXNoIG9ic2VydmVkLgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21t YW5kL3ByaW1pdGl2ZS12YWx1ZS1jbGVhbnVwLW1pbmltYWwuaHRtbCBiL0xheW91dFRlc3RzL2Vk aXRpbmcvZXhlY0NvbW1hbmQvcHJpbWl0aXZlLXZhbHVlLWNsZWFudXAtbWluaW1hbC5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjNiMDhlM2Y1MjY0N2YxNDRlOTNhMGM1ZGM3YjNjOTQ1N2Q5Yzk4MTMKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3ByaW1pdGl2ZS12 YWx1ZS1jbGVhbnVwLW1pbmltYWwuaHRtbApAQCAtMCwwICsxLDIyIEBACis8IURPQ1RZUEUgaHRt bD4KKzxodG1sPgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorCitmdW5jdGlvbiBw cmltaXRpdmVWYWxDbGVhblVwKCkgeworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAg ICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgCisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQo IlNlbGVjdEFsbCIpOworICAgIGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5jb250ZW50RWRpdGFi bGUgPSB0cnVlOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRPcmRlcmVkTGlzdCcp OworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJJbnNlcnRIVE1MIixmYWxzZSwiVGhpcyB0ZXN0 IGNoZWNrcyBwYXNzZXMgaWYgdGhlcmUgaWYgbm8gY3Jhc2ggb2JzZXJ2ZWQuIik7Cit9OworPC9z Y3JpcHQ+CisKKzxib2R5IG9ubG9hZD1wcmltaXRpdmVWYWxDbGVhblVwKCk+Cis8c3R5bGUgdHlw ZT0idGV4dC9jc3MiPgorKntwYWRkaW5nLXRvcDptaW4oMDg2My43cmVtLDQyLjIlLDc2NTI5MjZj bSw3NzQlKTt9Cis8L3N0eWxlPgorPG1pc3NpbmctZ2x5cGg+Cis8L2JvZHk+Cis8L3NjcmlwdD4K