208303 2020-02-27 06:49:21 -0800 CanvasRenderingContext2D.putImageData() should not process neutered ImageData 2020-03-25 17:28:43 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ajuma webkit-unassigned bfulgham dino ews-feeder pgyanchandani product-security rniwa rohitrao sabouhallawa simon.fraser webkit-bug-importer oldest_to_newest 1623445 0 391857 ajuma 2020-02-27 06:49:21 -0800 Created attachment 391857 Minimal test case Filing this as a security bug since it was found using a fuzzer; there's no disclosure deadline for this bug. Crash stack: ================================================================= ==70884==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7fff2dcc6200 bp 0x7ffeea06a650 sp 0x7ffeea06a628 T0) ==70884==The signal is caused by a READ memory access. ==70884==Hint: address points to the zero page. ==70884==WARNING: invalid path to external symbolizer! ==70884==WARNING: Failed to use and restart external symbolizer! #0 0x7fff2dcc61ff in vPremultiplyData_RGBA8888_CV_avx (/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage:x86_64+0x6981ff) #1 0x47d2dd3af in WebCore::premultiplyBufferData(vImage_Buffer const&, vImage_Buffer const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x43d73af) #2 0x47d2da253 in WebCore::ImageBufferData::putData(JSC::GenericTypedArrayView<JSC::Uint8ClampedAdaptor> const&, WebCore::AlphaPremultiplication, WebCore::IntSize const&, WebCore::IntRect const&, WebCore::IntPoint const&, WebCore::IntSize const&, bool) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x43d4253) #3 0x47d2d99b7 in WebCore::ImageBuffer::putByteArray(JSC::GenericTypedArrayView<JSC::Uint8ClampedAdaptor> const&, WebCore::AlphaPremultiplication, WebCore::IntSize const&, WebCore::IntRect const&, WebCore::IntPoint const&, WebCore::ImageBuffer::CoordinateSystem) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x43d39b7) #4 0x47c5dbd66 in WebCore::CanvasRenderingContext2DBase::putImageData(WebCore::ImageData&, WebCore::ImageBuffer::CoordinateSystem, float, float, float, float, float, float) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x36d5d66) #5 0x47961205f in WebCore::jsCanvasRenderingContext2DPrototypeFunctionPutImageData1Body(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSCanvasRenderingContext2D*, JSC::ThrowScope&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x70c05f) #6 0x479611c75 in WebCore::jsCanvasRenderingContext2DPrototypeFunctionPutImageDataOverloadDispatcher(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSCanvasRenderingContext2D*, JSC::ThrowScope&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x70bc75) #7 0x479575b35 in long long WebCore::IDLOperation<WebCore::JSCanvasRenderingContext2D>::call<&(WebCore::jsCanvasRenderingContext2DPrototypeFunctionPutImageDataOverloadDispatcher(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSCanvasRenderingContext2D*, JSC::ThrowScope&)), (WebCore::CastedThisErrorBehavior)0>(JSC::JSGlobalObject&, JSC::CallFrame&, char const*) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x66fb35) #8 0x277644001177 (<unknown module>) #9 0x493a6745b in llint_entry (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0xa8c45b) #10 0x493a503d8 in vmEntryToJavaScript (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0xa753d8) #11 0x49506a744 in JSC::Interpreter::execute(JSC::EvalExecutable*, JSC::JSGlobalObject*, JSC::JSValue, JSC::JSScope*) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0x208f744) #12 0x495068f39 in JSC::eval(JSC::JSGlobalObject*, JSC::CallFrame*) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0x208df39) #13 0x49532881d in JSC::LLInt::commonCallEval(JSC::CallFrame*, JSC::Instruction const*, JSC::MacroAssemblerCodePtr<(WTF::PtrTag)357>) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0x234d81d) #14 0x493a68ee2 in llint_entry (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0xa8dee2) #15 0x493a6745b in llint_entry (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0xa8c45b) #16 0x493a503d8 in vmEntryToJavaScript (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0xa753d8) #17 0x49507440d in JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0x209940d) #18 0x4957263fb in JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0x274b3fb) #19 0x4957266cc in JSC::profiledEvaluate(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0x274b6cc) #20 0x47b86dcd3 in WebCore::JSExecState::profiledEvaluate(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x2967cd3) #21 0x47b86d4fb in WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x29674fb) #22 0x47b86d10c in WebCore::ScriptController::evaluateInWorldIgnoringException(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x296710c) #23 0x47c049481 in WebCore::ScriptElement::executeClassicScript(WebCore::ScriptSourceCode const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3143481) #24 0x47c046490 in WebCore::ScriptElement::prepareScript(WTF::TextPosition const&, WebCore::ScriptElement::LegacyTypeSupport) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3140490) #25 0x47c6f528e in WebCore::HTMLScriptRunner::runScript(WebCore::ScriptElement&, WTF::TextPosition const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x37ef28e) #26 0x47c6f4f64 in WebCore::HTMLScriptRunner::execute(WTF::Ref<WebCore::ScriptElement, WTF::DumbPtrTraits<WebCore::ScriptElement> >&&, WTF::TextPosition const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x37eef64) #27 0x47c6d535c in WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x37cf35c) #28 0x47c6d59f4 in WebCore::HTMLDocumentParser::pumpTokenizerLoop(WebCore::HTMLDocumentParser::SynchronousMode, bool, WebCore::PumpSession&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x37cf9f4) #29 0x47c6d49dd in WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x37ce9dd) #30 0x47c6d7109 in WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x37d1109) #31 0x47c6d7388 in WebCore::HTMLDocumentParser::notifyFinished(WebCore::PendingScript&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x37d1388) #32 0x47c00b122 in WebCore::PendingScript::notifyClientFinished() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3105122) #33 0x47bf9a811 in WebCore::LoadableScript::notifyClientFinished() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3094811) #34 0x47bf9a229 in WebCore::LoadableClassicScript::notifyFinished(WebCore::CachedResource&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3094229) #35 0x47cc50927 in WebCore::CachedResource::checkNotify() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3d4a927) #36 0x47cbd0cde in WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebCore.framework/Versions/A/WebCore:x86_64+0x3ccacde) #37 0x1072e9ca6 in WebKit::WebResourceLoader::didFinishResourceLoad(WebCore::NetworkLoadMetrics const&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x1754ca6) #38 0x1079eb547 in void IPC::handleMessage<Messages::WebResourceLoader::DidFinishResourceLoad, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)>(IPC::Decoder&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x1e56547) #39 0x1079ea649 in WebKit::WebResourceLoader::didReceiveWebResourceLoaderMessage(IPC::Connection&, IPC::Decoder&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x1e55649) #40 0x1072a6334 in WebKit::NetworkProcessConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x1711334) #41 0x105c1a98a in IPC::Connection::dispatchMessage(IPC::Decoder&) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x8598a) #42 0x105c1b67a in IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x8667a) #43 0x105c1c2b8 in IPC::Connection::dispatchOneIncomingMessage() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x872b8) #44 0x493098746 in WTF::RunLoop::performWork() (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0xbd746) #45 0x49309925a in WTF::RunLoop::performWork(void*) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore:x86_64+0xbe25a) #46 0x7fff313eb31a in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation:x86_64+0x5731a) #47 0x7fff313eb2c0 in __CFRunLoopDoSource0 (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation:x86_64+0x572c0) #48 0x7fff313cf1ba in __CFRunLoopDoSources0 (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation:x86_64+0x3b1ba) #49 0x7fff313ce782 in __CFRunLoopRun (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation:x86_64+0x3a782) #50 0x7fff313ce084 in CFRunLoopRunSpecific (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation:x86_64+0x3a084) #51 0x7fff33642a9e in -[NSRunLoop(NSRunLoop) runMode:beforeDate:] (/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation:x86_64+0x1ca9e) #52 0x7fff33642973 in -[NSRunLoop(NSRunLoop) run] (/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation:x86_64+0x1c973) #53 0x7fff5daba1d6 in _xpc_objc_main (/usr/lib/system/libxpc.dylib:x86_64+0x111d6) #54 0x7fff5dab9cd8 in xpc_main (/usr/lib/system/libxpc.dylib:x86_64+0x10cd8) #55 0x106499465 in WebKit::XPCServiceMain(int, char const**) (/Users/chrome-bot/clusterfuzz/bot/builds/mac_asan_webkit/custom/Release/WebKit.framework/Versions/A/WebKit:x86_64+0x904465) #56 0x7fff5d8873d4 in start (/usr/lib/system/libdyld.dylib:x86_64+0x163d4) ==70884==Register values: rax = 0x0000000000000001 rbx = 0x00007ffeea06a990 rcx = 0x0000000000000001 rdx = 0x0000000000000000 rdi = 0x00000004a441b000 rsi = 0x00007ffeea06a990 rbp = 0x00007ffeea06a650 rsp = 0x00007ffeea06a628 r8 = 0x00000004a441b000 r9 = 0x0000000000000000 r10 = 0x00000001113d14d8 r11 = 0x00000004a441b000 r12 = 0x0000000000000000 r13 = 0x0000000000000000 r14 = 0x0000000000000001 r15 = 0x0000000000000000 1623446 1 webkit-bug-importer 2020-02-27 06:49:44 -0800 <rdar://problem/59845825> 1624134 2 rniwa 2020-02-28 14:26:05 -0800 Could you also attach the content of worker-onmessage-noop.js? 1624139 3 392022 ajuma 2020-02-28 14:42:52 -0800 Created attachment 392022 Minimal test case 1624140 4 ajuma 2020-02-28 14:44:48 -0800 (In reply to Ryosuke Niwa from comment #2) > Could you also attach the content of worker-onmessage-noop.js? There's actually no such file -- the crash reproduces without the file existing. I've changed that line in the test case to 'non-existent-file' to clarify that. 1624142 5 rniwa 2020-02-28 14:50:28 -0800 (In reply to Ali Juma from comment #4) > (In reply to Ryosuke Niwa from comment #2) > > Could you also attach the content of worker-onmessage-noop.js? > > There's actually no such file -- the crash reproduces without the file > existing. I've changed that line in the test case to 'non-existent-file' to > clarify that. Ah, okay. Thanks for the clarification. 1632948 6 394281 pgyanchandani 2020-03-23 11:35:00 -0700 Created attachment 394281 Patch 1633487 7 394281 simon.fraser 2020-03-24 14:22:25 -0700 Comment on attachment 394281 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394281&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:2162 > + if (!data.data() || !data.data()->data()) Why is it null, though? The buffer is 1x1? > LayoutTests/ChangeLog:8 > + Added the test case attached to bugzilla ticket 208303 with little modification. We don't call them "tickets". And this is bug 208303 so this comment is redundant. > LayoutTests/canvas/philip/tests/canvas-bug.html:4 > +<div>Test passes if it does not crash.</div> > +<canvas id=canvas > These should be inside <body>. <canvas> should have a closing tag. > LayoutTests/canvas/philip/tests/canvas-bug.html:11 > + var worker = new Worker('./resources/worker-onmessage-noop.js'); Is the worker necessary? 1633716 8 pgyanchandani 2020-03-24 18:11:08 -0700 (In reply to Simon Fraser (smfr) from comment #7) > Comment on attachment 394281 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394281&action=review > > > Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:2162 > > + if (!data.data() || !data.data()->data()) > > Why is it null, though? The buffer is 1x1? Probably because the file which is used for worker is not valid. In the test case attached by google, ./resources/worker-onmessage-noop.js is modified to "non-existent-file". So array buffer content in CanvasRenderingContext2DBase::putImageData is received as NULL > > > LayoutTests/ChangeLog:8 > > + Added the test case attached to bugzilla ticket 208303 with little modification. > > We don't call them "tickets". And this is bug 208303 so this comment is > redundant. OK, will correct the comment > > > LayoutTests/canvas/philip/tests/canvas-bug.html:4 > > +<div>Test passes if it does not crash.</div> > > +<canvas id=canvas > > > These should be inside <body>. <div> </div> If I put inside body, it doesn't dump the text in canvas-big-exptected.txt file. So I moved it here. Any other way to get it right?? <canvas> should have a closing tag. OK, Will add </canvas> to the test case > > > LayoutTests/canvas/philip/tests/canvas-bug.html:11 > > + var worker = new Worker('./resources/worker-onmessage-noop.js'); > > Is the worker necessary? Yes, not having worker, the crash is not reproduced. The attached file its changed to var worker = new Worker('non-existent-file');. I have also changed the same in test case and crash is still happening. (In reply to Simon Fraser (smfr) from comment #7) > Comment on attachment 394281 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394281&action=review > > > Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:2162 > > + if (!data.data() || !data.data()->data()) > > Why is it null, though? The buffer is 1x1? > > > LayoutTests/ChangeLog:8 > > + Added the test case attached to bugzilla ticket 208303 with little modification. > > We don't call them "tickets". And this is bug 208303 so this comment is > redundant. > > > LayoutTests/canvas/philip/tests/canvas-bug.html:4 > > +<div>Test passes if it does not crash.</div> > > +<canvas id=canvas > > > These should be inside <body>. <canvas> should have a closing tag. > > > LayoutTests/canvas/philip/tests/canvas-bug.html:11 > > + var worker = new Worker('./resources/worker-onmessage-noop.js'); > > Is the worker necessary? 1633726 9 394457 pgyanchandani 2020-03-24 18:50:44 -0700 Created attachment 394457 Patch 1633727 10 394457 rniwa 2020-03-24 18:54:46 -0700 Comment on attachment 394457 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394457&action=review > Source/WebCore/ChangeLog:8 > + Test: canvas/philip/tests/canvas-bug.html This line should appear after the long description but above the list of files. > Source/WebCore/ChangeLog:13 > + Right here, surrounded by single blank lines. 1633730 11 394458 pgyanchandani 2020-03-24 18:58:46 -0700 Created attachment 394458 Patch 1633758 12 394281 sabouhallawa 2020-03-24 20:32:17 -0700 Comment on attachment 394281 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394281&action=review >>>> Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:2162 >>>> + if (!data.data() || !data.data()->data()) >>> >>> Why is it null, though? The buffer is 1x1? >> >> Probably because the file which is used for worker is not valid. In the test case attached by google, ./resources/worker-onmessage-noop.js is modified to "non-existent-file". >> >> So array buffer content in CanvasRenderingContext2DBase::putImageData is received as NULL > > This explanation is incorrect. This JavaScript statement worker.postMessage({data: image.data.buffer}, [image.data.buffer]); transfers the ownership of the image.data.buffer to the worker. Therefore image.data becomes "neutered". See https://developer.mozilla.org/en-US/docs/Web/API/Worker/postMessage. So this change is okay but you may change it to if (!data.data() || data.data()->isNeutered()) 1633760 13 394457 sabouhallawa 2020-03-24 20:38:28 -0700 Comment on attachment 394457 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394457&action=review > LayoutTests/ChangeLog:11 > + * canvas/philip/tests/canvas-bug-expected.txt: Added. > + * canvas/philip/tests/canvas-bug.html: Added. Are you sure this test crashes when you run-webkit-tests it without your fix? I could only got it to crash when I made it an http test. Please put it under LayoutTests/http/tests/misc/. And please do not make its name "canvas-bug.html". It is too generic. You may use canvas-putImageData-neutered-ImageData.html or something similar. 1633762 14 394457 sabouhallawa 2020-03-24 20:48:25 -0700 Comment on attachment 394457 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394457&action=review >> LayoutTests/ChangeLog:11 >> + * canvas/philip/tests/canvas-bug.html: Added. > > Are you sure this test crashes when you run-webkit-tests it without your fix? I could only got it to crash when I made it an http test. Please put it under LayoutTests/http/tests/misc/. And please do not make its name "canvas-bug.html". It is too generic. You may use canvas-putImageData-neutered-ImageData.html or something similar. I was wrong. I could get it to crash when it is local layout test. But please put it under LayoutTests/fast/canvas since canvas/Philip/tests are imported tests. 1633772 15 394470 pgyanchandani 2020-03-24 22:00:10 -0700 Created attachment 394470 Patch 1633794 16 394470 sabouhallawa 2020-03-24 23:07:35 -0700 Comment on attachment 394470 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394470&action=review > Source/WebCore/ChangeLog:3 > + Crash in WebCore::premultiplyBufferData Please change the bug title in Bugzilla and in the ChangeLogs to reflect what exactly the bug is. The bug title should say that CanvasRenderingContext2D.putImageData() should not process neutered ImageData. > Source/WebCore/ChangeLog:13 > + Crash is observed in PremultiplyData_RGBA8888_CV_avx2 () as src is NULL. > + arrayBuffercontent for data of imageData's object is NULL. > + The postMessage() method of the worker, transfers the ownership of the image.data.buffer to the worker, > + causing image.data becomes "neutered". Added the check for the same. Please consider revising the description of the bug and the fix. The bug has nothing to do with PremultiplyData_RGBA8888_CV_avx2(), so you do not have even to mention it. The description should focus on when and why the crash happens and how it is fixed. > LayoutTests/ChangeLog:8 > + Added slightly modified version of testcase from bugzilla. This comment adds no value. Either describe what the test is doing or just remove it. > LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData.html:12 > + var worker = new Worker('non-existent-file'); Do we still need 'non-existent-file'? > LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData.html:17 > + worker.postMessage({data: image.data.buffer}, [image.data.buffer]); Can't this just be: worker.postMessage([image.data.buffer]); > LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData.html:23 > +<body onload=canvasTest()> > +</body> Usually the <body></body> tag encloses all the other elements. So this test can look like this: <body onload=canvasTest()> <div>Test passes if it does not crash.</div> <canvas id=canvas></canvas> </body> 1633938 17 pgyanchandani 2020-03-25 10:33:55 -0700 (In reply to Said Abou-Hallawa from comment #16) > Comment on attachment 394470 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394470&action=review > > > Source/WebCore/ChangeLog:3 > > + Crash in WebCore::premultiplyBufferData > > Please change the bug title in Bugzilla and in the ChangeLogs to reflect > what exactly the bug is. The bug title should say that > CanvasRenderingContext2D.putImageData() should not process neutered > ImageData. I don't have permission to change the title. Seems only submitter can change it. Can anyone help with this?? > > > Source/WebCore/ChangeLog:13 > > + Crash is observed in PremultiplyData_RGBA8888_CV_avx2 () as src is NULL. > > + arrayBuffercontent for data of imageData's object is NULL. > > + The postMessage() method of the worker, transfers the ownership of the image.data.buffer to the worker, > > + causing image.data becomes "neutered". Added the check for the same. > > Please consider revising the description of the bug and the fix. The bug has > nothing to do with PremultiplyData_RGBA8888_CV_avx2(), so you do not have > even to mention it. The description should focus on when and why the crash > happens and how it is fixed OK will modify it. > > LayoutTests/ChangeLog:8 > > + Added slightly modified version of testcase from bugzilla. > > This comment adds no value. Either describe what the test is doing or just > remove it. > > > LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData.html:12 > > + var worker = new Worker('non-existent-file'); > > Do we still need 'non-existent-file'? Removing var worker = new Worker('non-existent-file'); doesn't work. crash is not reproduced for me if removed. > > > LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData.html:17 > > + worker.postMessage({data: image.data.buffer}, [image.data.buffer]); > > Can't this just be: > > worker.postMessage([image.data.buffer]); No, crash is not reproduced for me with this statement changed. It has to be as is. > > > LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData.html:23 > > +<body onload=canvasTest()> > > +</body> > > Usually the <body></body> tag encloses all the other elements. So this test > can look like this: > > <body onload=canvasTest()> > <div>Test passes if it does not crash.</div> > <canvas id=canvas></canvas> > </body> will change it 1633972 18 394520 pgyanchandani 2020-03-25 11:42:34 -0700 Created attachment 394520 Patch 1633988 19 rniwa 2020-03-25 12:28:13 -0700 There is no security implication here (checked with Simon & Said). 1633989 20 rniwa 2020-03-25 12:29:06 -0700 Let's wait for EWS (e.g. iOS WK2). 1634129 21 ews-feeder 2020-03-25 17:28:41 -0700 Committed r259024: <https://trac.webkit.org/changeset/259024> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394520. 391857 2020-02-27 06:49:21 -0800 2020-02-28 14:42:52 -0800 Minimal test case canvas-bug.html text/html 365 ajuma PGNhbnZhcyBpZD1jYW52YXMgPjxzY3JpcHQ+CnZhciB3b3JrZXIgPSBuZXcgV29ya2VyKCcuL3Jl c291cmNlcy93b3JrZXItb25tZXNzYWdlLW5vb3AuanMnKTsKdmFyIGltYWdlV2lkdGggPSAxOwp2 YXIgaW1hZ2VIZWlnaHQgPSAxOwp2YXIgaW1hZ2UgPSBuZXcgSW1hZ2VEYXRhKCBpbWFnZVdpZHRo LCBpbWFnZUhlaWdodCk7CnZhciBjb250ZXh0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNh bnZhcyIpLmdldENvbnRleHQoIjJkIik7Cndvcmtlci5wb3N0TWVzc2FnZSh7ZGF0YTogaW1hZ2Uu ZGF0YS5idWZmZXJ9LCBbaW1hZ2UuZGF0YS5idWZmZXJdKTsKY29udGV4dC5wdXRJbWFnZURhdGEo aW1hZ2UsIDAsIDApOwo8L3NjcmlwdD4= 392022 2020-02-28 14:42:52 -0800 2020-02-28 14:42:52 -0800 Minimal test case canvas-bug.html text/html 346 ajuma PGNhbnZhcyBpZD1jYW52YXMgPjxzY3JpcHQ+CnZhciB3b3JrZXIgPSBuZXcgV29ya2VyKCdub24t ZXhpc3RlbnQtZmlsZScpOwp2YXIgaW1hZ2VXaWR0aCA9IDE7CnZhciBpbWFnZUhlaWdodCA9IDE7 CnZhciBpbWFnZSA9IG5ldyBJbWFnZURhdGEoIGltYWdlV2lkdGgsIGltYWdlSGVpZ2h0KTsKdmFy IGNvbnRleHQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY2FudmFzIikuZ2V0Q29udGV4dCgi MmQiKTsKd29ya2VyLnBvc3RNZXNzYWdlKHtkYXRhOiBpbWFnZS5kYXRhLmJ1ZmZlcn0sIFtpbWFn ZS5kYXRhLmJ1ZmZlcl0pOwpjb250ZXh0LnB1dEltYWdlRGF0YShpbWFnZSwgMCwgMCk7Cjwvc2Ny aXB0Pg== 394281 2020-03-23 11:35:00 -0700 2020-03-24 18:50:42 -0700 Patch bug-208303-20200323113500.patch text/plain 3672 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uNjMzNmY3OGM2NDcxMjA2MGIzMWNjODk3ODllMjNh ZTVjNzQwMjdmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAzLTIzICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFz aCBpbiBXZWJDb3JlOjpwcmVtdWx0aXBseUJ1ZmZlckRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODMwMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyYXNoIGlzIG9ic2VydmVkIGluIFByZW11bHRp cGx5RGF0YV9SR0JBODg4OF9DVl9hdngyICgpIGFzIHNyYyBpcyBOVUxMLiAKKyAgICAgICAgSXQg aXMgb2JzcnZlZCB0aGF0IGJhc2VBZGRyZXNzZSBmb3IgZGF0YSBvZiBpbWFnZURhdGEncyBkYXRh IG9iamVjdCB3aGljaCBVaW50OENsYW1wZWRBcnJheSBpcyBOVUxMLiAKKyAgICAgICAgQWRkZWQg TlVMTCBjaGVjayBmb3IgdGhlIHNhbWUuICAKKyAKKyAgICAgICAgVGVzdDogY2FudmFzL3BoaWxp cC90ZXN0cy9jYW52YXMtYnVnLmh0bWwKKworICAgICAgICAqIGh0bWwvY2FudmFzL0NhbnZhc1Jl bmRlcmluZ0NvbnRleHQyREJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFzUmVuZGVy aW5nQ29udGV4dDJEQmFzZTo6cHV0SW1hZ2VEYXRhKToKKwogMjAyMC0wMy0xMCAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgbG9nZ2luZyBmb3IgTW9kZXJu IEVNRSBtZXRob2RzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2Fu dmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcAppbmRleCA2NGNhN2VlZjBmZjg5MDA3 MWFkMGE1ZDRlMTZmMzU3YzM4MmFlMjExLi5lMWNhOWQzY2E2NDgxNTdkM2I0NzY4NDM4Y2QwNTMw MTYwOWQyNmRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNS ZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcApAQCAtMjE1OSw3ICsyMTU5LDcgQEAg dm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpwdXRJbWFnZURhdGEoSW1hZ2VEYXRh JiBkYXRhLCBmbG9hdCBkeCwgZmxvYXQKICAgICBpZiAoIWJ1ZmZlcikKICAgICAgICAgcmV0dXJu OwogCi0gICAgaWYgKCFkYXRhLmRhdGEoKSkKKyAgICBpZiAoIWRhdGEuZGF0YSgpIHx8ICFkYXRh LmRhdGEoKS0+ZGF0YSgpKQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAoZGlydHlXaWR0aCA8 IDApIHsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwppbmRleCBhMzY2NzIzNTYwMGI0MWQ3NmE0NDcwNmQzZTliMWNiMDYxNTQ0NzI5Li4w ZDdhNDYwZDU4YmQ1MjVkZTUyNTBjODM2ZGNiNDU5ODNmMjcxMDcwIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTUgQEAKKzIwMjAtMDMtMjMgIFBpbmtpIEd5YW5jaGFuZGFuaSAgPHBneWFuY2hhbmRhbmlAYXBw bGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFdlYkNvcmU6OnByZW11bHRpcGx5QnVmZmVyRGF0 YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MzAz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQg dGhlIHRlc3QgY2FzZSBhdHRhY2hlZCB0byBidWd6aWxsYSB0aWNrZXQgMjA4MzAzIHdpdGggbGl0 dGxlIG1vZGlmaWNhdGlvbi4KKworICAgICAgICAqIGNhbnZhcy9waGlsaXAvdGVzdHMvY2FudmFz LWJ1Zy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGNhbnZhcy9waGlsaXAvdGVzdHMv Y2FudmFzLWJ1Zy5odG1sOiBBZGRlZC4KKwogMjAyMC0wMy0xMCAgRGllZ28gUGlubyBHYXJjaWEg IDxkcGlub0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIEdhcmRlbmluZywgZW1pdCBuZXcg YmFzZWxpbmVzIG9mIFdlYkdMIDEuMC4zIGNvbmZvcm1hbmNlIHRlc3RzCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9jYW52YXMvcGhpbGlwL3Rlc3RzL2NhbnZhcy1idWctZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvY2FudmFzL3BoaWxpcC90ZXN0cy9jYW52YXMtYnVnLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4xMDQyYzc2NzhlNGE4MzVjNGFlMmRlMjFkYTE2ZWFlYTAwMWRmYWNkCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY2FudmFzL3BoaWxpcC90ZXN0cy9jYW52YXMtYnVn LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK1Rlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90 IGNyYXNoLgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jYW52YXMvcGhpbGlwL3Rlc3RzL2Nh bnZhcy1idWcuaHRtbCBiL0xheW91dFRlc3RzL2NhbnZhcy9waGlsaXAvdGVzdHMvY2FudmFzLWJ1 Zy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLmMxYzA5MTUzMWM1YmZmNjEyMmZkZThiZGNkNWJiMmJlMGIzNzcy NTAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jYW52YXMvcGhpbGlwL3Rlc3RzL2Nh bnZhcy1idWcuaHRtbApAQCAtMCwwICsxLDI0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGRpdj5UZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjcmFzaC48L2Rpdj4KKzxjYW52YXMgaWQ9 Y2FudmFzID4KKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIGNhbnZhc1Rlc3QoKSB7CisgICAgaWYgKHdp bmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKworICAg IHZhciB3b3JrZXIgPSBuZXcgV29ya2VyKCcuL3Jlc291cmNlcy93b3JrZXItb25tZXNzYWdlLW5v b3AuanMnKTsKKyAgICB2YXIgaW1hZ2VXaWR0aCA9IDE7CisgICAgdmFyIGltYWdlSGVpZ2h0ID0g MTsKKyAgICB2YXIgaW1hZ2UgPSBuZXcgSW1hZ2VEYXRhKCBpbWFnZVdpZHRoLCBpbWFnZUhlaWdo dCk7CisgICAgdmFyIGNvbnRleHQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY2FudmFzIiku Z2V0Q29udGV4dCgiMmQiKTsKKyAgICB3b3JrZXIucG9zdE1lc3NhZ2Uoe2RhdGE6IGltYWdlLmRh dGEuYnVmZmVyfSwgW2ltYWdlLmRhdGEuYnVmZmVyXSk7CisgICAgY29udGV4dC5wdXRJbWFnZURh dGEoaW1hZ2UsIDAsIDApOworfQorPC9zY3JpcHQ+CisKKzxib2R5IG9ubG9hZD1jYW52YXNUZXN0 KCk+Cis8L2JvZHk+Cis8L2h0bWw+CisK 394457 2020-03-24 18:50:44 -0700 2020-03-24 18:58:44 -0700 Patch bug-208303-20200324185043.patch text/plain 3591 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uMTEwNDA5NDkzMWM3Njg3YmY1Y2Y2YjcxOGE0ZWM4 MzAxNDZmYWZkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAzLTI0ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFz aCBpbiBXZWJDb3JlOjpwcmVtdWx0aXBseUJ1ZmZlckRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODMwMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGNhbnZhcy9waGlsaXAvdGVzdHMvY2Fu dmFzLWJ1Zy5odG1sCisKKyAgICAgICAgQ3Jhc2ggaXMgb2JzZXJ2ZWQgaW4gUHJlbXVsdGlwbHlE YXRhX1JHQkE4ODg4X0NWX2F2eDIgKCkgYXMgc3JjIGlzIE5VTEwuCisgICAgICAgIGFycmF5QnVm ZmVyY29udGVudCBmb3IgZGF0YSBvZiBpbWFnZURhdGEncyBvYmplY3QgaXMgTlVMTC4KKyAgICAg ICAgQWRkZWQgYSBjaGVjayBOVUxMIGNoZWNrIGZvciB0aGUgc2FtZS4KKworICAgICAgICAqIGh0 bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZTo6cHV0SW1hZ2VEYXRhKToKKwogMjAy MC0wMy0xMCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQg bG9nZ2luZyBmb3IgTW9kZXJuIEVNRSBtZXRob2RzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcAppbmRl eCA2NGNhN2VlZjBmZjg5MDA3MWFkMGE1ZDRlMTZmMzU3YzM4MmFlMjExLi5lMWNhOWQzY2E2NDgx NTdkM2I0NzY4NDM4Y2QwNTMwMTYwOWQyNmRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcApAQCAt MjE1OSw3ICsyMTU5LDcgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpwdXRJ bWFnZURhdGEoSW1hZ2VEYXRhJiBkYXRhLCBmbG9hdCBkeCwgZmxvYXQKICAgICBpZiAoIWJ1ZmZl cikKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKCFkYXRhLmRhdGEoKSkKKyAgICBpZiAoIWRh dGEuZGF0YSgpIHx8ICFkYXRhLmRhdGEoKS0+ZGF0YSgpKQogICAgICAgICByZXR1cm47CiAKICAg ICBpZiAoZGlydHlXaWR0aCA8IDApIHsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhMzY2NzIzNTYwMGI0MWQ3NmE0NDcwNmQz ZTliMWNiMDYxNTQ0NzI5Li45M2FmMjdmOTYxY2FiY2VlZjU3ODJmYjhkMDRkZmNmMDUzNjUwNzRj IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDMtMjQgIFBpbmtpIEd5YW5jaGFuZGFuaSAg PHBneWFuY2hhbmRhbmlAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFdlYkNvcmU6OnBy ZW11bHRpcGx5QnVmZmVyRGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA4MzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkZWQgbW9kaWZpZWQgdmVyc2lvbiBvZiB0ZXN0Y2FzZSBmcm9tIGJ1Z3pp bGxhLgorCisgICAgICAgICogY2FudmFzL3BoaWxpcC90ZXN0cy9jYW52YXMtYnVnLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogY2FudmFzL3BoaWxpcC90ZXN0cy9jYW52YXMtYnVnLmh0 bWw6IEFkZGVkLgorCiAyMDIwLTAzLTEwICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxp YS5jb20+CiAKICAgICAgICAgW1dQRV0gR2FyZGVuaW5nLCBlbWl0IG5ldyBiYXNlbGluZXMgb2Yg V2ViR0wgMS4wLjMgY29uZm9ybWFuY2UgdGVzdHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Nh bnZhcy9waGlsaXAvdGVzdHMvY2FudmFzLWJ1Zy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9j YW52YXMvcGhpbGlwL3Rlc3RzL2NhbnZhcy1idWctZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjEw NDJjNzY3OGU0YTgzNWM0YWUyZGUyMWRhMTZlYWVhMDAxZGZhY2QKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9jYW52YXMvcGhpbGlwL3Rlc3RzL2NhbnZhcy1idWctZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsMiBAQAorVGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2guCisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2NhbnZhcy9waGlsaXAvdGVzdHMvY2FudmFzLWJ1Zy5odG1s IGIvTGF5b3V0VGVzdHMvY2FudmFzL3BoaWxpcC90ZXN0cy9jYW52YXMtYnVnLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uMjMwNmQxYzgyOWU5Mzk0MmUzMDY3M2Q0NjdmMmI3ZmZkOWNiYjFlNgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2NhbnZhcy9waGlsaXAvdGVzdHMvY2FudmFzLWJ1Zy5odG1s CkBAIC0wLDAgKzEsMjQgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8ZGl2PlRlc3QgcGFz c2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLjwvZGl2PgorPGNhbnZhcyBpZD1jYW52YXM+Cis8L2Nh bnZhcz4KKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIGNhbnZhc1Rlc3QoKSB7CisgICAgaWYgKHdpbmRv dy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKworICAgIHZh ciB3b3JrZXIgPSBuZXcgV29ya2VyKCdub24tZXhpc3RlbnQtZmlsZScpOworICAgIHZhciBpbWFn ZVdpZHRoID0gMTsKKyAgICB2YXIgaW1hZ2VIZWlnaHQgPSAxOworICAgIHZhciBpbWFnZSA9IG5l dyBJbWFnZURhdGEoIGltYWdlV2lkdGgsIGltYWdlSGVpZ2h0KTsKKyAgICB2YXIgY29udGV4dCA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjYW52YXMiKS5nZXRDb250ZXh0KCIyZCIpOworICAg IHdvcmtlci5wb3N0TWVzc2FnZSh7ZGF0YTogaW1hZ2UuZGF0YS5idWZmZXJ9LCBbaW1hZ2UuZGF0 YS5idWZmZXJdKTsKKyAgICBjb250ZXh0LnB1dEltYWdlRGF0YShpbWFnZSwgMCwgMCk7Cit9Cis8 L3NjcmlwdD4KKworPGJvZHkgb25sb2FkPWNhbnZhc1Rlc3QoKT4KKzwvYm9keT4KKzwvaHRtbD4K 394458 2020-03-24 18:58:46 -0700 2020-03-24 22:00:08 -0700 Patch bug-208303-20200324185845.patch text/plain 3591 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uZjBmZTNkMjkxYjkzNWEwYjFjNzYxMzI5ZTQ0ODcw ZDVmODliNmNmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAzLTI0ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFz aCBpbiBXZWJDb3JlOjpwcmVtdWx0aXBseUJ1ZmZlckRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODMwMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyYXNoIGlzIG9ic2VydmVkIGluIFByZW11bHRp cGx5RGF0YV9SR0JBODg4OF9DVl9hdngyICgpIGFzIHNyYyBpcyBOVUxMLgorICAgICAgICBhcnJh eUJ1ZmZlcmNvbnRlbnQgZm9yIGRhdGEgb2YgaW1hZ2VEYXRhJ3Mgb2JqZWN0IGlzIE5VTEwuCisg ICAgICAgIEFkZGVkIGEgY2hlY2sgTlVMTCBjaGVjayBmb3IgdGhlIHNhbWUuCisKKyAgICAgICAg VGVzdDogY2FudmFzL3BoaWxpcC90ZXN0cy9jYW52YXMtYnVnLmh0bWwKKworICAgICAgICAqIGh0 bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZTo6cHV0SW1hZ2VEYXRhKToKKwogMjAy MC0wMy0xMCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQg bG9nZ2luZyBmb3IgTW9kZXJuIEVNRSBtZXRob2RzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcAppbmRl eCA2NGNhN2VlZjBmZjg5MDA3MWFkMGE1ZDRlMTZmMzU3YzM4MmFlMjExLi5lMWNhOWQzY2E2NDgx NTdkM2I0NzY4NDM4Y2QwNTMwMTYwOWQyNmRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcApAQCAt MjE1OSw3ICsyMTU5LDcgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpwdXRJ bWFnZURhdGEoSW1hZ2VEYXRhJiBkYXRhLCBmbG9hdCBkeCwgZmxvYXQKICAgICBpZiAoIWJ1ZmZl cikKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKCFkYXRhLmRhdGEoKSkKKyAgICBpZiAoIWRh dGEuZGF0YSgpIHx8ICFkYXRhLmRhdGEoKS0+ZGF0YSgpKQogICAgICAgICByZXR1cm47CiAKICAg ICBpZiAoZGlydHlXaWR0aCA8IDApIHsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhMzY2NzIzNTYwMGI0MWQ3NmE0NDcwNmQz ZTliMWNiMDYxNTQ0NzI5Li45M2FmMjdmOTYxY2FiY2VlZjU3ODJmYjhkMDRkZmNmMDUzNjUwNzRj IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDMtMjQgIFBpbmtpIEd5YW5jaGFuZGFuaSAg PHBneWFuY2hhbmRhbmlAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFdlYkNvcmU6OnBy ZW11bHRpcGx5QnVmZmVyRGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA4MzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkZWQgbW9kaWZpZWQgdmVyc2lvbiBvZiB0ZXN0Y2FzZSBmcm9tIGJ1Z3pp bGxhLgorCisgICAgICAgICogY2FudmFzL3BoaWxpcC90ZXN0cy9jYW52YXMtYnVnLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogY2FudmFzL3BoaWxpcC90ZXN0cy9jYW52YXMtYnVnLmh0 bWw6IEFkZGVkLgorCiAyMDIwLTAzLTEwICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxp YS5jb20+CiAKICAgICAgICAgW1dQRV0gR2FyZGVuaW5nLCBlbWl0IG5ldyBiYXNlbGluZXMgb2Yg V2ViR0wgMS4wLjMgY29uZm9ybWFuY2UgdGVzdHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Nh bnZhcy9waGlsaXAvdGVzdHMvY2FudmFzLWJ1Zy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9j YW52YXMvcGhpbGlwL3Rlc3RzL2NhbnZhcy1idWctZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjEw NDJjNzY3OGU0YTgzNWM0YWUyZGUyMWRhMTZlYWVhMDAxZGZhY2QKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9jYW52YXMvcGhpbGlwL3Rlc3RzL2NhbnZhcy1idWctZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsMiBAQAorVGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2guCisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2NhbnZhcy9waGlsaXAvdGVzdHMvY2FudmFzLWJ1Zy5odG1s IGIvTGF5b3V0VGVzdHMvY2FudmFzL3BoaWxpcC90ZXN0cy9jYW52YXMtYnVnLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uMjMwNmQxYzgyOWU5Mzk0MmUzMDY3M2Q0NjdmMmI3ZmZkOWNiYjFlNgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2NhbnZhcy9waGlsaXAvdGVzdHMvY2FudmFzLWJ1Zy5odG1s CkBAIC0wLDAgKzEsMjQgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8ZGl2PlRlc3QgcGFz c2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLjwvZGl2PgorPGNhbnZhcyBpZD1jYW52YXM+Cis8L2Nh bnZhcz4KKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIGNhbnZhc1Rlc3QoKSB7CisgICAgaWYgKHdpbmRv dy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKworICAgIHZh ciB3b3JrZXIgPSBuZXcgV29ya2VyKCdub24tZXhpc3RlbnQtZmlsZScpOworICAgIHZhciBpbWFn ZVdpZHRoID0gMTsKKyAgICB2YXIgaW1hZ2VIZWlnaHQgPSAxOworICAgIHZhciBpbWFnZSA9IG5l dyBJbWFnZURhdGEoIGltYWdlV2lkdGgsIGltYWdlSGVpZ2h0KTsKKyAgICB2YXIgY29udGV4dCA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjYW52YXMiKS5nZXRDb250ZXh0KCIyZCIpOworICAg IHdvcmtlci5wb3N0TWVzc2FnZSh7ZGF0YTogaW1hZ2UuZGF0YS5idWZmZXJ9LCBbaW1hZ2UuZGF0 YS5idWZmZXJdKTsKKyAgICBjb250ZXh0LnB1dEltYWdlRGF0YShpbWFnZSwgMCwgMCk7Cit9Cis8 L3NjcmlwdD4KKworPGJvZHkgb25sb2FkPWNhbnZhc1Rlc3QoKT4KKzwvYm9keT4KKzwvaHRtbD4K 394470 2020-03-24 22:00:10 -0700 2020-03-25 11:42:32 -0700 Patch bug-208303-20200324220009.patch text/plain 3932 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uZmMxNjk4ZmIzOGI0YmExOGFmYmRkZTQ2ZGNjM2Ey YWQ5NzI1ZDE2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAzLTI0ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFz aCBpbiBXZWJDb3JlOjpwcmVtdWx0aXBseUJ1ZmZlckRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODMwMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvY2FudmFzL2NhbnZhcy1wdXRJ bWFnZURhdGEtbmV1dGVyZWQtSW1hZ2VEYXRhLmh0bWwKKworICAgICAgICBDcmFzaCBpcyBvYnNl cnZlZCBpbiBQcmVtdWx0aXBseURhdGFfUkdCQTg4ODhfQ1ZfYXZ4MiAoKSBhcyBzcmMgaXMgTlVM TC4KKyAgICAgICAgYXJyYXlCdWZmZXJjb250ZW50IGZvciBkYXRhIG9mIGltYWdlRGF0YSdzIG9i amVjdCBpcyBOVUxMLiAKKyAgICAgICAgVGhlIHBvc3RNZXNzYWdlKCkgbWV0aG9kIG9mIHRoZSB3 b3JrZXIsIHRyYW5zZmVycyB0aGUgb3duZXJzaGlwIG9mIHRoZSBpbWFnZS5kYXRhLmJ1ZmZlciB0 byB0aGUgd29ya2VyLAorICAgICAgICBjYXVzaW5nIGltYWdlLmRhdGEgYmVjb21lcyAibmV1dGVy ZWQiLiBBZGRlZCB0aGUgY2hlY2sgZm9yIHRoZSBzYW1lLgorCisKKyAgICAgICAgKiBodG1sL2Nh bnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2U6OnB1dEltYWdlRGF0YSk6CisKIDIwMjAtMDMt MTAgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGxvZ2dp bmcgZm9yIE1vZGVybiBFTUUgbWV0aG9kcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuY3BwIGIvU291cmNlL1dlYkNv cmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5jcHAKaW5kZXggNjRj YTdlZWYwZmY4OTAwNzFhZDBhNWQ0ZTE2ZjM1N2MzODJhZTIxMS4uZDQ3MjM1Y2M1OTY2MWY3Yjk0 ZGRkYzk5NDMzM2RkNDZjOTZmZmYwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9j YW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5jcHAKQEAgLTIxNTks NyArMjE1OSw3IEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZTo6cHV0SW1hZ2VE YXRhKEltYWdlRGF0YSYgZGF0YSwgZmxvYXQgZHgsIGZsb2F0CiAgICAgaWYgKCFidWZmZXIpCiAg ICAgICAgIHJldHVybjsKIAotICAgIGlmICghZGF0YS5kYXRhKCkpCisgICAgaWYgKCFkYXRhLmRh dGEoKSB8fCBkYXRhLmRhdGEoKS0+aXNOZXV0ZXJlZCgpKQogICAgICAgICByZXR1cm47CiAKICAg ICBpZiAoZGlydHlXaWR0aCA8IDApIHsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhMzY2NzIzNTYwMGI0MWQ3NmE0NDcwNmQz ZTliMWNiMDYxNTQ0NzI5Li5jMTVjMDhjNDI2MzljODllMzBhZTA0MWI1N2MxNmZjYjkxMGU5NzZj IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDMtMjQgIFBpbmtpIEd5YW5jaGFuZGFuaSAg PHBneWFuY2hhbmRhbmlAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFdlYkNvcmU6OnBy ZW11bHRpcGx5QnVmZmVyRGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA4MzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkZWQgc2xpZ2h0bHkgbW9kaWZpZWQgdmVyc2lvbiBvZiB0ZXN0Y2FzZSBm cm9tIGJ1Z3ppbGxhLgorCisgICAgICAgICogZmFzdC9jYW52YXMvY2FudmFzLXB1dEltYWdlRGF0 YS1uZXV0ZXJlZC1JbWFnZURhdGEtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2NhbnZhcy9jYW52YXMtcHV0SW1hZ2VEYXRhLW5ldXRlcmVkLUltYWdlRGF0YS5odG1sOiBBZGRl ZC4KKwogMjAyMC0wMy0xMCAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgog CiAgICAgICAgIFtXUEVdIEdhcmRlbmluZywgZW1pdCBuZXcgYmFzZWxpbmVzIG9mIFdlYkdMIDEu MC4zIGNvbmZvcm1hbmNlIHRlc3RzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZh cy9jYW52YXMtcHV0SW1hZ2VEYXRhLW5ldXRlcmVkLUltYWdlRGF0YS1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtcHV0SW1hZ2VEYXRhLW5ldXRlcmVkLUltYWdl RGF0YS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMTA0MmM3Njc4ZTRhODM1YzRhZTJkZTIxZGEx NmVhZWEwMDFkZmFjZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFz L2NhbnZhcy1wdXRJbWFnZURhdGEtbmV1dGVyZWQtSW1hZ2VEYXRhLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDIgQEAKK1Rlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLgorCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtcHV0SW1hZ2VEYXRhLW5ldXRlcmVk LUltYWdlRGF0YS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXB1dEltYWdl RGF0YS1uZXV0ZXJlZC1JbWFnZURhdGEuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yNWJkNDg2OWYxNTBjZWVh YWZiOTliM2M3NzRhNTg5MTE2ZTg1NzkyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9jYW52YXMvY2FudmFzLXB1dEltYWdlRGF0YS1uZXV0ZXJlZC1JbWFnZURhdGEuaHRtbApA QCAtMCwwICsxLDI0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGRpdj5UZXN0IHBhc3Nl cyBpZiBpdCBkb2VzIG5vdCBjcmFzaC48L2Rpdj4KKzxjYW52YXMgaWQ9Y2FudmFzID4KKzwvY2Fu dmFzPgorPHNjcmlwdD4KKworZnVuY3Rpb24gY2FudmFzVGVzdCgpIHsKKyAgICBpZiAod2luZG93 LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCisgICAgdmFy IHdvcmtlciA9IG5ldyBXb3JrZXIoJ25vbi1leGlzdGVudC1maWxlJyk7CisgICAgdmFyIGltYWdl V2lkdGggPSAxOworICAgIHZhciBpbWFnZUhlaWdodCA9IDE7CisgICAgdmFyIGltYWdlID0gbmV3 IEltYWdlRGF0YSggaW1hZ2VXaWR0aCwgaW1hZ2VIZWlnaHQpOworICAgIHZhciBjb250ZXh0ID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNhbnZhcyIpLmdldENvbnRleHQoIjJkIik7CisgICAg d29ya2VyLnBvc3RNZXNzYWdlKHtkYXRhOiBpbWFnZS5kYXRhLmJ1ZmZlcn0sIFtpbWFnZS5kYXRh LmJ1ZmZlcl0pOworICAgIGNvbnRleHQucHV0SW1hZ2VEYXRhKGltYWdlLCAwLCAwKTsKK30KKzwv c2NyaXB0PgorCis8Ym9keSBvbmxvYWQ9Y2FudmFzVGVzdCgpPgorPC9ib2R5PgorPC9odG1sPgo= 394520 2020-03-25 11:42:34 -0700 2020-03-25 17:28:42 -0700 Patch bug-208303-20200325114233.patch text/plain 3977 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uMjQ3MmE4OWY1ZDlkMTA4MGI0MzMzNWNkNzcwN2Ex NmRjM2VjZWRlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAzLTI0ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDYW52 YXNSZW5kZXJpbmdDb250ZXh0MkQucHV0SW1hZ2VEYXRhKCkgc2hvdWxkIG5vdCBwcm9jZXNzIG5l dXRlcmVkIEltYWdlRGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA4MzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGVzdDogZmFzdC9jYW52YXMvY2FudmFzLXB1dEltYWdlRGF0YS1uZXV0ZXJlZC1J bWFnZURhdGEuaHRtbAorCisgICAgICAgIFRoZSBjcmFzaCBoYXBwZW5zIHdoZW4gcHV0SW1hZ2VE YXRhIGlzIGNhbGxlZCBvbiBhIG5ldXRlcmVkIEltYWdlRGF0YSBvYmplY3QuIAorICAgICAgICBB ZGRlZCBhIGNoZWNrIHRvIGV4aXQgZnJvbSBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQucHV0SW1h Z2VEYXRhKCkgZnVuY3Rpb24gd2hlbiBJbWFnZURhdGEgb2JqZWN0IGlzIG5ldXRlcmVkLgorCisg ICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpwdXRJbWFnZURh dGEpOgorCiAyMDIwLTAzLTEwICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZCBsb2dnaW5nIGZvciBNb2Rlcm4gRU1FIG1ldGhvZHMuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJh c2UuY3BwCmluZGV4IDY0Y2E3ZWVmMGZmODkwMDcxYWQwYTVkNGUxNmYzNTdjMzgyYWUyMTEuLmQ0 NzIzNWNjNTk2NjFmN2I5NGRkZGM5OTQzMzNkZDQ2Yzk2ZmZmMDYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJh c2UuY3BwCkBAIC0yMTU5LDcgKzIxNTksNyBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQy REJhc2U6OnB1dEltYWdlRGF0YShJbWFnZURhdGEmIGRhdGEsIGZsb2F0IGR4LCBmbG9hdAogICAg IGlmICghYnVmZmVyKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoIWRhdGEuZGF0YSgpKQor ICAgIGlmICghZGF0YS5kYXRhKCkgfHwgZGF0YS5kYXRhKCktPmlzTmV1dGVyZWQoKSkKICAgICAg ICAgcmV0dXJuOwogCiAgICAgaWYgKGRpcnR5V2lkdGggPCAwKSB7CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTM2NjcyMzU2 MDBiNDFkNzZhNDQ3MDZkM2U5YjFjYjA2MTU0NDcyOS4uZDhhMWU0ODI2OTE3NmIzZjY3MDViNzI3 ZTg0YWRiNWZhZmJkZTVkNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTI0ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBDYW52 YXNSZW5kZXJpbmdDb250ZXh0MkQucHV0SW1hZ2VEYXRhKCkgc2hvdWxkIG5vdCBwcm9jZXNzIG5l dXRlcmVkIEltYWdlRGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA4MzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkZWQgc2xpZ2h0bHkgbW9kaWZpZWQgdmVyc2lvbiBvZiB0ZXN0Y2FzZSBmcm9t IGJ1Z3ppbGxhLgorICAgICAgICBUaGlzIHRlc3RjYXNlIGNoZWNrcyB0aGF0IGEgbmV1dGVyZWQg SW1hZ2VEYXRhIG9iamVjdCBpcyBub3QgY29uc2lkZXJlZCB0byBiZSBwdXQgb250byB0aGUgY2Fu dmFzLgorCisgICAgICAgICogZmFzdC9jYW52YXMvY2FudmFzLXB1dEltYWdlRGF0YS1uZXV0ZXJl ZC1JbWFnZURhdGEtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy9j YW52YXMtcHV0SW1hZ2VEYXRhLW5ldXRlcmVkLUltYWdlRGF0YS5odG1sOiBBZGRlZC4KKwogMjAy MC0wMy0xMCAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgogCiAgICAgICAg IFtXUEVdIEdhcmRlbmluZywgZW1pdCBuZXcgYmFzZWxpbmVzIG9mIFdlYkdMIDEuMC4zIGNvbmZv cm1hbmNlIHRlc3RzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMt cHV0SW1hZ2VEYXRhLW5ldXRlcmVkLUltYWdlRGF0YS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9mYXN0L2NhbnZhcy9jYW52YXMtcHV0SW1hZ2VEYXRhLW5ldXRlcmVkLUltYWdlRGF0YS1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uMTA0MmM3Njc4ZTRhODM1YzRhZTJkZTIxZGExNmVhZWEwMDFk ZmFjZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1w dXRJbWFnZURhdGEtbmV1dGVyZWQtSW1hZ2VEYXRhLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIg QEAKK1Rlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLgorCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtcHV0SW1hZ2VEYXRhLW5ldXRlcmVkLUltYWdlRGF0 YS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXB1dEltYWdlRGF0YS1uZXV0 ZXJlZC1JbWFnZURhdGEuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mNzI5NzdmMDBiZjMyZWFlOTYzODFkNzE4 ZmIwODMxNDRkOGVlMjJlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52 YXMvY2FudmFzLXB1dEltYWdlRGF0YS1uZXV0ZXJlZC1JbWFnZURhdGEuaHRtbApAQCAtMCwwICsx LDIzIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHNjcmlwdD4KKworZnVuY3Rpb24gY2Fu dmFzVGVzdCgpIHsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5u ZXIuZHVtcEFzVGV4dCgpOworCisgICAgdmFyIHdvcmtlciA9IG5ldyBXb3JrZXIoJ25vbi1leGlz dGVudC1maWxlJyk7CisgICAgdmFyIGltYWdlV2lkdGggPSAxOworICAgIHZhciBpbWFnZUhlaWdo dCA9IDE7CisgICAgdmFyIGltYWdlID0gbmV3IEltYWdlRGF0YSggaW1hZ2VXaWR0aCwgaW1hZ2VI ZWlnaHQpOworICAgIHZhciBjb250ZXh0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNhbnZh cyIpLmdldENvbnRleHQoIjJkIik7CisgICAgd29ya2VyLnBvc3RNZXNzYWdlKHtkYXRhOiBpbWFn ZS5kYXRhLmJ1ZmZlcn0sIFtpbWFnZS5kYXRhLmJ1ZmZlcl0pOworICAgIGNvbnRleHQucHV0SW1h Z2VEYXRhKGltYWdlLCAwLCAwKTsKK30KKzwvc2NyaXB0PgorCis8Ym9keSBvbmxvYWQ9Y2FudmFz VGVzdCgpPgorPGRpdj5UZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjcmFzaC48L2Rpdj4KKzxj YW52YXMgaWQ9Y2FudmFzPjwvY2FudmFzPgorPC9ib2R5PgorPC9odG1sPgo=