208302 2020-02-27 06:47:01 -0800 REGRESSION(r257299): [GTK] Check and radio buttons don't keep the aspect ratio 2020-02-28 01:38:05 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply oldest_to_newest 1623443 0 cgarcia 2020-02-27 06:47:01 -0800 When different width and height is used, we should use the lower value and render the button centered. 1623444 1 391856 cgarcia 2020-02-27 06:48:26 -0800 Created attachment 391856 Patch 1623915 2 cgarcia 2020-02-28 01:38:05 -0800 Committed r257630: <https://trac.webkit.org/changeset/257630> 391856 2020-02-27 06:48:26 -0800 2020-02-27 07:04:52 -0800 Patch wk-radio-check-aspect-ratio.diff text/plain 2531 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZDZhZmU5NjQwZS4uNjMwMzhlNTM5YWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wMi0yNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjU3Mjk5KTogW0dUS10gQ2hlY2sgYW5k IHJhZGlvIGJ1dHRvbnMgZG9uJ3Qga2VlcCB0aGUgYXNwZWN0IHJhdGlvCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgzMDIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGRpZmZlcmVudCB3aWR0aCBh bmQgaGVpZ2h0IGlzIHVzZWQsIHdlIHNob3VsZCB1c2UgdGhlIGxvd2VyIHZhbHVlIGFuZCByZW5k ZXIgdGhlIGJ1dHRvbiBjZW50ZXJlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2Fkd2FpdGEvVGhl bWVBZHdhaXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRoZW1lQWR3YWl0YTo6cGFpbnRDaGVj a2JveCk6CisgICAgICAgIChXZWJDb3JlOjpUaGVtZUFkd2FpdGE6OnBhaW50UmFkaW8pOgorCiAy MDIwLTAyLTI3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBUZXN0IGltcG9ydGVkL2JsaW5rL2Zhc3QvZm9ybXMvZGF0YWxpc3Qvc2xpZGVyLWFw cGVhcmFuY2Utd2l0aC10aWNrcy1jcmFzaC5odG1sIGZhaWxzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9hZHdhaXRhL1RoZW1lQWR3YWl0YS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9hZHdhaXRhL1RoZW1lQWR3YWl0YS5jcHAKaW5kZXggMzMwNzg3ZjU1ZWUuLmVl M2ViZTA4YjEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hZHdhaXRhL1Ro ZW1lQWR3YWl0YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYWR3YWl0YS9UaGVt ZUFkd2FpdGEuY3BwCkBAIC0yMzUsNiArMjM1LDE1IEBAIHZvaWQgVGhlbWVBZHdhaXRhOjpwYWlu dENoZWNrYm94KENvbnRyb2xTdGF0ZXMmIHN0YXRlcywgR3JhcGhpY3NDb250ZXh0JiBncmFwaGlj CiAgICAgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBzdGF0ZVNhdmVyKGdyYXBoaWNzQ29udGV4 dCk7CiAKICAgICBGbG9hdFJlY3QgZmllbGRSZWN0ID0gem9vbWVkUmVjdDsKKyAgICBpZiAoZmll bGRSZWN0LndpZHRoKCkgIT0gZmllbGRSZWN0LmhlaWdodCgpKSB7CisgICAgICAgIGF1dG8gYnV0 dG9uU2l6ZSA9IHN0ZDo6bWluKGZpZWxkUmVjdC53aWR0aCgpLCBmaWVsZFJlY3QuaGVpZ2h0KCkp OworICAgICAgICBmaWVsZFJlY3Quc2V0U2l6ZSh7IGJ1dHRvblNpemUsIGJ1dHRvblNpemUgfSk7 CisgICAgICAgIGlmIChmaWVsZFJlY3Qud2lkdGgoKSAhPSB6b29tZWRSZWN0LndpZHRoKCkpCisg ICAgICAgICAgICBmaWVsZFJlY3QubW92ZSgoem9vbWVkUmVjdC53aWR0aCgpIC0gZmllbGRSZWN0 LndpZHRoKCkpIC8gMi4wLCAwKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgZmllbGRSZWN0 Lm1vdmUoMCwgKHpvb21lZFJlY3QuaGVpZ2h0KCkgLSBmaWVsZFJlY3QuaGVpZ2h0KCkpIC8gMi4w KTsKKyAgICB9CisKICAgICBGbG9hdFNpemUgY29ybmVyKDIsIDIpOwogICAgIFBhdGggcGF0aDsK ICAgICBwYXRoLmFkZFJvdW5kZWRSZWN0KGZpZWxkUmVjdCwgY29ybmVyKTsKQEAgLTI4OCw2ICsy OTcsMTUgQEAgdm9pZCBUaGVtZUFkd2FpdGE6OnBhaW50UmFkaW8oQ29udHJvbFN0YXRlcyYgc3Rh dGVzLCBHcmFwaGljc0NvbnRleHQmIGdyYXBoaWNzQ28KIHsKICAgICBHcmFwaGljc0NvbnRleHRT dGF0ZVNhdmVyIHN0YXRlU2F2ZXIoZ3JhcGhpY3NDb250ZXh0KTsKICAgICBGbG9hdFJlY3QgZmll bGRSZWN0ID0gem9vbWVkUmVjdDsKKyAgICBpZiAoZmllbGRSZWN0LndpZHRoKCkgIT0gZmllbGRS ZWN0LmhlaWdodCgpKSB7CisgICAgICAgIGF1dG8gYnV0dG9uU2l6ZSA9IHN0ZDo6bWluKGZpZWxk UmVjdC53aWR0aCgpLCBmaWVsZFJlY3QuaGVpZ2h0KCkpOworICAgICAgICBmaWVsZFJlY3Quc2V0 U2l6ZSh7IGJ1dHRvblNpemUsIGJ1dHRvblNpemUgfSk7CisgICAgICAgIGlmIChmaWVsZFJlY3Qu d2lkdGgoKSAhPSB6b29tZWRSZWN0LndpZHRoKCkpCisgICAgICAgICAgICBmaWVsZFJlY3QubW92 ZSgoem9vbWVkUmVjdC53aWR0aCgpIC0gZmllbGRSZWN0LndpZHRoKCkpIC8gMi4wLCAwKTsKKyAg ICAgICAgZWxzZQorICAgICAgICAgICAgZmllbGRSZWN0Lm1vdmUoMCwgKHpvb21lZFJlY3QuaGVp Z2h0KCkgLSBmaWVsZFJlY3QuaGVpZ2h0KCkpIC8gMi4wKTsKKyAgICB9CisKICAgICBQYXRoIHBh dGg7CiAgICAgcGF0aC5hZGRFbGxpcHNlKGZpZWxkUmVjdCk7CiAgICAgZmllbGRSZWN0LmluZmxh dGUoLWJ1dHRvbkJvcmRlclNpemUpOwo=