208295 2020-02-27 03:34:11 -0800 REGRESSION(r257299): [GTK] Test fast/replaced/table-percent-height.html is failing since r257299 2020-02-28 01:36:27 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 208296 1 cgarcia webkit-unassigned aperez bugs-noreply oldest_to_newest 1623411 0 cgarcia 2020-02-27 03:34:11 -0800 We are now hardcoding the size of check and radio buttons, except when width and height are both specified. 1623412 1 391847 cgarcia 2020-02-27 03:35:54 -0800 Created attachment 391847 Patch 1623419 2 391847 aperez 2020-02-27 05:34:21 -0800 Comment on attachment 391847 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391847&action=review Please fix the typo in the ChangeLog before landing =) > Source/WebCore/ChangeLog:11 > + (WebCore::ThemeAdwaita::controlSize const): Only set width and height of check and rario buttons when they are Typo: s/rario/radio 1623913 3 cgarcia 2020-02-28 01:36:27 -0800 Committed r257629: <https://trac.webkit.org/changeset/257629> 391847 2020-02-27 03:35:54 -0800 2020-02-27 05:34:21 -0800 Patch wk-check-radio-size.diff text/plain 1854 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMTMxZmM2ZmZlYy4uYTA3M2FiMDU2YTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wMi0yNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjU3Mjk5KTogW0dUS10gVGVzdCBmYXN0 L3JlcGxhY2VkL3RhYmxlLXBlcmNlbnQtaGVpZ2h0Lmh0bWwgaXMgZmFpbGluZyBzaW5jZSByMjU3 Mjk5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgy OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBh cmUgbm93IGhhcmRjb2RpbmcgdGhlIHNpemUgb2YgY2hlY2sgYW5kIHJhZGlvIGJ1dHRvbnMsIGV4 Y2VwdCB3aGVuIHdpZHRoIGFuZCBoZWlnaHQgYXJlIGJvdGggc3BlY2lmaWVkLgorCisgICAgICAg ICogcGxhdGZvcm0vYWR3YWl0YS9UaGVtZUFkd2FpdGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 VGhlbWVBZHdhaXRhOjpjb250cm9sU2l6ZSBjb25zdCk6IE9ubHkgc2V0IHdpZHRoIGFuZCBoZWln aHQgb2YgY2hlY2sgYW5kIHJhcmlvIGJ1dHRvbnMgd2hlbiB0aGV5IGFyZQorICAgICAgICBpbnRy aW5zaWMgb3IgYXV0by4KKwogMjAyMC0wMi0yNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjU3Mjk5KTogW0dUS10gTWFr ZSBmb2N1cyByaW5nIG9mIGltYWdlIGFyZWEgY29uc2lzdGVudCB3aXRoIHRoZSB0aGVtZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYWR3YWl0YS9UaGVtZUFkd2FpdGEuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYWR3YWl0YS9UaGVtZUFkd2FpdGEuY3BwCmluZGV4 IGJkZGZkYzIyNzYwLi4wMWVlNmE1MWRiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYWR3YWl0YS9UaGVtZUFkd2FpdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2Fkd2FpdGEvVGhlbWVBZHdhaXRhLmNwcApAQCAtMTU2LDggKzE1NiwxNCBAQCBMZW5ndGhT aXplIFRoZW1lQWR3YWl0YTo6Y29udHJvbFNpemUoQ29udHJvbFBhcnQgcGFydCwgY29uc3QgRm9u dENhc2NhZGUmIGZvbnRDYQogCiAgICAgc3dpdGNoIChwYXJ0KSB7CiAgICAgY2FzZSBDaGVja2Jv eFBhcnQ6Ci0gICAgY2FzZSBSYWRpb1BhcnQ6Ci0gICAgICAgIHJldHVybiBMZW5ndGhTaXplIHsg TGVuZ3RoKDEyLCBGaXhlZCksIExlbmd0aCgxMiwgRml4ZWQpIH07CisgICAgY2FzZSBSYWRpb1Bh cnQ6IHsKKyAgICAgICAgTGVuZ3RoU2l6ZSBidXR0b25TaXplID0gem9vbWVkU2l6ZTsKKyAgICAg ICAgaWYgKGJ1dHRvblNpemUud2lkdGguaXNJbnRyaW5zaWNPckF1dG8oKSkKKyAgICAgICAgICAg IGJ1dHRvblNpemUud2lkdGggPSBMZW5ndGgoMTIsIEZpeGVkKTsKKyAgICAgICAgaWYgKGJ1dHRv blNpemUuaGVpZ2h0LmlzSW50cmluc2ljT3JBdXRvKCkpCisgICAgICAgICAgICBidXR0b25TaXpl LmhlaWdodCA9IExlbmd0aCgxMiwgRml4ZWQpOworICAgICAgICByZXR1cm4gYnV0dG9uU2l6ZTsK KyAgICB9CiAgICAgY2FzZSBJbm5lclNwaW5CdXR0b25QYXJ0OiB7CiAgICAgICAgIExlbmd0aFNp emUgc3BpbkJ1dHRvblNpemUgPSB6b29tZWRTaXplOwogICAgICAgICBpZiAoc3BpbkJ1dHRvblNp emUud2lkdGguaXNJbnRyaW5zaWNPckF1dG8oKSkK