208281 2020-02-26 17:27:52 -0800 [iPad Simulator] TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder is failing 2020-05-03 15:37:45 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208082 InRadar P2 Normal --- 1 ryanhaddad dbates webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1623303 0 ryanhaddad 2020-02-26 17:27:52 -0800 The API test added with https://trac.webkit.org/changeset/257487/webkit is failing on iPad simulator bots with the following output: TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder /Volumes/Data/slave/ios-simulator-13-release/build/Tools/TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:125 Expected equality of these values: "BODY" [webView stringByEvaluatingJavaScript:@"document.activeElement.tagName"] Which is: "DIV" Example of failure: https://build.webkit.org/builders/Apple%20iPadOS%2013%20Simulator%20Release%20WK2%20%28Tests%29/builds/2271 Test history: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder 1623306 1 webkit-bug-importer 2020-02-26 17:30:58 -0800 <rdar://problem/59829265> 1623333 2 dbates 2020-02-26 18:32:56 -0800 Oops. DismissFormAccesory is not enough for iPad. Need new SPI to dismiss keyboard or fake a keyboard dismissal. Can we skip the test on iPad? 1623762 3 ryanhaddad 2020-02-27 16:25:54 -0800 (In reply to Daniel Bates from comment #2) > Oops. DismissFormAccesory is not enough for iPad. Need new SPI to dismiss > keyboard or fake a keyboard dismissal. Can we skip the test on iPad? Is there a platform check for iPad simulator that you could add to the test? (I'm not sure if such a thing exists) 1648392 4 dbates 2020-05-03 14:58:55 -0700 (In reply to Ryan Haddad from comment #3) > (In reply to Daniel Bates from comment #2) > > Oops. DismissFormAccesory is not enough for iPad. Need new SPI to dismiss > > keyboard or fake a keyboard dismissal. Can we skip the test on iPad? > Is there a platform check for iPad simulator that you could add to the test? > (I'm not sure if such a thing exists) So, not a way to skip a test, but there is a way to force an iPad to behave like an iPhone: IPhoneUserInterfaceSwizzler. 1648395 5 398335 dbates 2020-05-03 15:08:37 -0700 Created attachment 398335 Patch 1648396 6 398336 dbates 2020-05-03 15:13:55 -0700 Created attachment 398336 To Land 1648397 7 398336 dbates 2020-05-03 15:14:49 -0700 Comment on attachment 398336 To Land Clearing flags on attachment: 398336 Committed r261068: <https://trac.webkit.org/changeset/261068> 1648398 8 dbates 2020-05-03 15:14:51 -0700 All reviewed patches have been landed. Closing bug. 1648402 9 dbates 2020-05-03 15:37:45 -0700 Committed build fix <https://trac.webkit.org/changeset/261069> 398335 2020-05-03 15:08:37 -0700 2020-05-03 15:13:54 -0700 Patch bug-208281-20200503150836.patch text/plain 2426 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjQzMGIzNmJiMGVhMjhjMzUxNTQ4MDNjNGQ5MmM4ZGNl YzA1ODAwNi4uNzAyZjMzMmNkYzRkMTIzODBkNmQ4ZGFiZjA2ODkwMDExMmFhNmIwMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDIwLTA1LTAzICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbaVBhZCBTaW11bGF0b3JdIFRlc3RXZWJLaXRBUEkuVUlXS0ludGVyYWN0aW9uVmlld1By b3RvY29sLlNlbGVjdFBvc2l0aW9uQXRQb2ludEFmdGVyQmVjb21pbmdGaXJzdFJlc3BvbmRlciBp cyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDgyODEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5ODI5MjY1PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEkgdHJpZWQgdG8gd3JpdGUgdGhl IHRlc3QgU2VsZWN0UG9zaXRpb25BdFBvaW50QWZ0ZXJCZWNvbWluZ0ZpcnN0UmVzcG9uZGVyIGZv ciBib3RoIGlQYWQgYW5kIGlQaG9uZSwKKyAgICAgICAgYnV0IGl0IHR1cm5zIG91dCB0aGF0IEkg Zm9yZ290IGFuIGltcGwgZGV0YWlsIG9uIGhvdyBmb3JtIGNvbnRyb2wgZGlzbWlzc2FsIHdvcmtz IGZvciBpUGFkIGFuZCBmaXhpbmcKKyAgICAgICAgdGhpcyB3b3VsZCByZXF1aXJlIGFkZGluZyBt b3JlIFNQSS9JUEkuIFRoaXMgaXMgbGFyZ2VseSBkdWUgdG8gZGlmZmVyZW5jZXMgaW4gZm9ybSBj b250cm9sIFVJIGFuZAorICAgICAgICBjb252ZW50aW9ucyBmb3IgZGlzbWlzc2luZyBzdWNoIFVJ LiBUaGlzIHRlc3QgaXNuJ3QgdGVzdGluZyBzdWNoIFVJIGl0IGp1c3QgbmVlZHMgdG8gZW5zdXJl IHRoYXQgdGhlCisgICAgICAgIHZpZXcgaXMgbm90IHJlc3BvbmRlciBiZWZvcmUgaXQgcnVucyB0 aGUgYWN0dWFsIHRlc3QgY29kZS4gSXQgdXNlcyBhbiBpUGhvbmUgc3BlY2lmaWMgc2V0IG9mIHN0 ZXBzCisgICAgICAgIHRvIGRvIHRoaXMuIEl0J3MgZW5vdWdoIHRvIHRlc3QgdGhpcyBmdW5jdGlv bmFsaXR5IG9uIGlQaG9uZS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL1VJ V0tJbnRlcmFjdGlvblZpZXdQcm90b2NvbC5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIwLTA1 LTAyICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBQYWdlOjpl ZGl0YWJsZUVsZW1lbnRzSW5SZWN0KCkgc2hvdWxkIHJldHVybiByb290IGVkaXRhYmxlIGVsZW1l bnRzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9VSVdLSW50ZXJh Y3Rpb25WaWV3UHJvdG9jb2wubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9VSVdL SW50ZXJhY3Rpb25WaWV3UHJvdG9jb2wubW0KaW5kZXggNTQwNDA2NmQwZjM5ZjFlZDJmNzA1MGUw NTdjMzJkY2FjMTEwMzJhZi4uNDIwNDZkNzk1MTBjNjk4MWJjZTgxMGY3NjA5YzhhMWE0Zjg3MjJm YiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvVUlXS0ludGVyYWN0 aW9uVmlld1Byb3RvY29sLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL1VJ V0tJbnRlcmFjdGlvblZpZXdQcm90b2NvbC5tbQpAQCAtMzEsNiArMzEsNyBAQAogI2ltcG9ydCAi VGVzdElucHV0RGVsZWdhdGUuaCIKICNpbXBvcnQgIlRlc3RXS1dlYlZpZXcuaCIKICNpbXBvcnQg IlVJS2l0U1BJLmgiCisjaW1wb3J0ICJVc2VySW50ZXJmYWNlU3dpenpsZXIuaCIKICNpbXBvcnQg PFdlYktpdC9XS1dlYlZpZXdQcml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvV0tXZWJWaWV3UHJp dmF0ZUZvclRlc3RpbmcuaD4KICNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KQEAgLTEwNyw2ICsx MDgsOCBAQCBURVNUKFVJV0tJbnRlcmFjdGlvblZpZXdQcm90b2NvbCwgVXBkYXRlU2VsZWN0aW9u V2l0aEV4dGVudFBvaW50KQogCiBURVNUKFVJV0tJbnRlcmFjdGlvblZpZXdQcm90b2NvbCwgU2Vs ZWN0UG9zaXRpb25BdFBvaW50QWZ0ZXJCZWNvbWluZ0ZpcnN0UmVzcG9uZGVyKQogeworICAgIElQ aG9uZVVzZXJJbnRlcmZhY2VTd2l6emxlciB1c2VySW50ZXJmYWNlU3dpenpsZXI7CisKICAgICBh dXRvIGlucHV0RGVsZWdhdGUgPSBhZG9wdE5TKFtUZXN0SW5wdXREZWxlZ2F0ZSBuZXddKTsKICAg ICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhG cmFtZTpDR1JlY3RNYWtlKDAsIDAsIDQwMCwgNDAwKV0pOwogICAgIFt3ZWJWaWV3IF9zZXRJbnB1 dERlbGVnYXRlOmlucHV0RGVsZWdhdGUuZ2V0KCldOwo= 398336 2020-05-03 15:13:55 -0700 2020-05-03 15:13:55 -0700 To Land bug-208281-20200503151355.patch text/plain 2430 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjQzMGIzNmJiMGVhMjhjMzUxNTQ4MDNjNGQ5MmM4ZGNl YzA1ODAwNi4uMDJmM2I2YjM5YzNjYjRhMjBlYmFkMTkzZGE0N2E4NzU2OWZmOWRmYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDIwLTA1LTAzICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbaVBhZCBTaW11bGF0b3JdIFRlc3RXZWJLaXRBUEkuVUlXS0ludGVyYWN0aW9uVmlld1By b3RvY29sLlNlbGVjdFBvc2l0aW9uQXRQb2ludEFmdGVyQmVjb21pbmdGaXJzdFJlc3BvbmRlciBp cyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDgyODEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5ODI5MjY1PgorCisgICAgICAgIFJl dmlld2VkIGJ5IFdlbnNvbiBIc2llaC4KKworICAgICAgICBJIHRyaWVkIHRvIHdyaXRlIHRoZSB0 ZXN0IFNlbGVjdFBvc2l0aW9uQXRQb2ludEFmdGVyQmVjb21pbmdGaXJzdFJlc3BvbmRlciBmb3Ig Ym90aCBpUGFkIGFuZCBpUGhvbmUsCisgICAgICAgIGJ1dCBpdCB0dXJucyBvdXQgdGhhdCBJIGZv cmdvdCBhbiBpbXBsIGRldGFpbCBvbiBob3cgZm9ybSBjb250cm9sIGRpc21pc3NhbCB3b3JrcyBm b3IgaVBhZCBhbmQgZml4aW5nCisgICAgICAgIHRoaXMgd291bGQgcmVxdWlyZSBhZGRpbmcgbW9y ZSBTUEkvSVBJLiBUaGlzIGlzIGxhcmdlbHkgZHVlIHRvIGRpZmZlcmVuY2VzIGluIGZvcm0gY29u dHJvbCBVSSBhbmQKKyAgICAgICAgY29udmVudGlvbnMgZm9yIGRpc21pc3Npbmcgc3VjaCBVSS4g VGhpcyB0ZXN0IGlzbid0IHRlc3Rpbmcgc3VjaCBVSSBpdCBqdXN0IG5lZWRzIHRvIGVuc3VyZSB0 aGF0IHRoZQorICAgICAgICB2aWV3IGlzIG5vdCBmaXJzdCByZXNwb25kZXIgYmVmb3JlIGl0IHJ1 bnMgdGhlIGFjdHVhbCB0ZXN0IGNvZGUuIEl0IHVzZXMgYW4gaVBob25lIHNwZWNpZmljIHNldCBv ZgorICAgICAgICBzdGVwcyB0byBkbyB0aGlzLiBJdCdzIGVub3VnaCB0byB0ZXN0IHRoaXMgZnVu Y3Rpb25hbGl0eSBvbiBpUGhvbmUuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL2lv cy9VSVdLSW50ZXJhY3Rpb25WaWV3UHJvdG9jb2wubW06CisgICAgICAgIChURVNUKToKKwogMjAy MC0wNS0wMiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUGFn ZTo6ZWRpdGFibGVFbGVtZW50c0luUmVjdCgpIHNob3VsZCByZXR1cm4gcm9vdCBlZGl0YWJsZSBl bGVtZW50cwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvVUlXS0lu dGVyYWN0aW9uVmlld1Byb3RvY29sLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3Mv VUlXS0ludGVyYWN0aW9uVmlld1Byb3RvY29sLm1tCmluZGV4IDU0MDQwNjZkMGYzOWYxZWQyZjcw NTBlMDU3YzMyZGNhYzExMDMyYWYuLjQyMDQ2ZDc5NTEwYzY5ODFiY2U4MTBmNzYwOWM4YTFhNGY4 NzIyZmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL1VJV0tJbnRl cmFjdGlvblZpZXdQcm90b2NvbC5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lv cy9VSVdLSW50ZXJhY3Rpb25WaWV3UHJvdG9jb2wubW0KQEAgLTMxLDYgKzMxLDcgQEAKICNpbXBv cnQgIlRlc3RJbnB1dERlbGVnYXRlLmgiCiAjaW1wb3J0ICJUZXN0V0tXZWJWaWV3LmgiCiAjaW1w b3J0ICJVSUtpdFNQSS5oIgorI2ltcG9ydCAiVXNlckludGVyZmFjZVN3aXp6bGVyLmgiCiAjaW1w b3J0IDxXZWJLaXQvV0tXZWJWaWV3UHJpdmF0ZS5oPgogI2ltcG9ydCA8V2ViS2l0L1dLV2ViVmll d1ByaXZhdGVGb3JUZXN0aW5nLmg+CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+CkBAIC0xMDcs NiArMTA4LDggQEAgVEVTVChVSVdLSW50ZXJhY3Rpb25WaWV3UHJvdG9jb2wsIFVwZGF0ZVNlbGVj dGlvbldpdGhFeHRlbnRQb2ludCkKIAogVEVTVChVSVdLSW50ZXJhY3Rpb25WaWV3UHJvdG9jb2ws IFNlbGVjdFBvc2l0aW9uQXRQb2ludEFmdGVyQmVjb21pbmdGaXJzdFJlc3BvbmRlcikKIHsKKyAg ICBJUGhvbmVVc2VySW50ZXJmYWNlU3dpenpsZXIgdXNlckludGVyZmFjZVN3aXp6bGVyOworCiAg ICAgYXV0byBpbnB1dERlbGVnYXRlID0gYWRvcHROUyhbVGVzdElucHV0RGVsZWdhdGUgbmV3XSk7 CiAgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZpZXcgYWxsb2NdIGluaXRX aXRoRnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCA0MDAsIDQwMCldKTsKICAgICBbd2ViVmlldyBfc2V0 SW5wdXREZWxlZ2F0ZTppbnB1dERlbGVnYXRlLmdldCgpXTsK