208275 2020-02-26 16:16:52 -0800 Enhance JSObjectGetProperty() to mitigate against null object pointers. 2020-02-26 16:30:05 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1623256 0 mark.lam 2020-02-26 16:16:52 -0800 The client really shouldn't pass us a null JSObjectRef, but we'll be nice and mitigate it this time. <rdar://problem/59789796> 1623257 1 mark.lam 2020-02-26 16:17:44 -0800 Oops ... wrong radar. Need a new one. 1623258 2 webkit-bug-importer 2020-02-26 16:18:05 -0800 <rdar://problem/59826325> 1623260 3 391803 mark.lam 2020-02-26 16:23:22 -0800 Created attachment 391803 proposed patch. 1623261 4 391803 rmorisset 2020-02-26 16:25:30 -0800 Comment on attachment 391803 proposed patch. r=me 1623265 5 mark.lam 2020-02-26 16:30:05 -0800 Thanks for the review. Landed in r257529: <http://trac.webkit.org/r257529>. 391803 2020-02-26 16:23:22 -0800 2020-02-26 16:25:30 -0800 proposed patch. bug-208275.patch text/plain 1445 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjU3NTI2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTAyLTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBF bmhhbmNlIEpTT2JqZWN0R2V0UHJvcGVydHkoKSB0byBtaXRpZ2F0ZSBhZ2FpbnN0IG51bGwgb2Jq ZWN0IHBvaW50ZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjA4Mjc1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81OTgyNjMyNT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEFQSS9KU09iamVjdFJl Zi5jcHA6CisgICAgICAgIChKU09iamVjdEdldFByb3BlcnR5KToKKwogMjAyMC0wMi0yNiAgU2Fh bSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIHRlc3RhaXIgcGFz cyBvbiBhcm02NApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU09iamVjdFJlZi5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU09iamVjdFJlZi5j cHAJKHJldmlzaW9uIDI1NzM5OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNPYmpl Y3RSZWYuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdo dCAoQykgMjAwNi0yMDE5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHly aWdodCAoQykgMjAwNi0yMDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENv cHlyaWdodCAoQykgMjAwOCBLZWx2aW4gVyBTaGVybG9jayAoa3NoZXJsb2NrQGdtYWlsLmNvbSkK ICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKQEAgLTM0Niw3ICszNDYsNyBAQCBib29sIEpTT2JqZWN0SGFzUHJv cGVydHkoSlNDb250ZXh0UmVmIGN0CiAKIEpTVmFsdWVSZWYgSlNPYmplY3RHZXRQcm9wZXJ0eShK U0NvbnRleHRSZWYgY3R4LCBKU09iamVjdFJlZiBvYmplY3QsIEpTU3RyaW5nUmVmIHByb3BlcnR5 TmFtZSwgSlNWYWx1ZVJlZiogZXhjZXB0aW9uKQogewotICAgIGlmICghY3R4KSB7CisgICAgaWYg KCFjdHggfHwgIW9iamVjdCkgewogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAg ICAgcmV0dXJuIDA7CiAgICAgfQo=