208272 2020-02-26 15:53:12 -0800 REGRESSION (r257394) [ Mac wk2 ] media/modern-media-controls/pip-support/pip-support-click.html is flaky timing out. 2020-02-27 14:08:36 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Mac macOS 10.15 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208168 InRadar P2 Normal --- 1 Lawrence.j nham eric.carlson ews-feeder ews-watchlist glenn jer.noble nham peng.liu6 philipj sergio simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1623235 0 Lawrence.j 2020-02-26 15:53:12 -0800 media/modern-media-controls/pip-support/pip-support-click.html Description: This test is flaky timing out on Mac wk2. It appears to have a possible regression point of r257394. History: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fpip-support%2Fpip-support-click.html&flavor=wk2&limit=50000 Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/media/modern-media-controls/pip-support/pip-support-click-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/media/modern-media-controls/pip-support/pip-support-click-actual.txt @@ -1,11 +1,6 @@ -Testing the PiPSupport behavior when clicking the PiP button. +CONSOLE MESSAGE: Unhandled Promise Rejection: InvalidStateError: The video element does not have a video track or it has not detected a video track yet. +#PID UNRESPONSIVE - WebKitTestRunner (pid 78234) +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS mediaController.controls.pipButton.element.getBoundingClientRect().width became different from 0 -PASS media.webkitPresentationMode is "picture-in-picture" -PASS successfullyParsed is true - -TEST COMPLETE - +#EOF +#EOF 1623237 1 webkit-bug-importer 2020-02-26 15:53:31 -0800 <rdar://problem/59825227> 1623246 2 Lawrence.j 2020-02-26 16:00:36 -0800 I have marked this test as timing out while this issue is investigated. https://trac.webkit.org/changeset/257525/webkit 1623262 3 Lawrence.j 2020-02-26 16:25:59 -0800 This timeout issue appears to have started on r257394. I can reproduce the timeout issue on r257515 and r257394, but I cannot on r257391. This is the command that I used: run-webkit-tests --force -f --exit-after-n-failures 3 --iterations 1000 media/modern-media-controls/pip-support/pip-support-click.html r257515: [22/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (text diff) [51/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (test timed out, text diff) [52/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (test timed out, text diff) Exiting early after 3 failures. 49 tests run. 46 tests ran as expected, 3 didn't (951 didn't run): r257394: [76/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (test timed out, text diff) [77/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (test timed out, text diff) [90/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (test timed out, text diff) Exiting early after 3 failures. 87 tests run. 84 tests ran as expected, 3 didn't (913 didn't run): r257391: [8/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (text diff) Retrying 1 unexpected failure .. Running 1 WebKitTestRunner. 999 tests ran as expected, 1 didn't: 1623614 4 nham 2020-02-27 12:38:53 -0800 *** Bug 208333 has been marked as a duplicate of this bug. *** 1623616 5 391901 nham 2020-02-27 12:53:14 -0800 Created attachment 391901 Patch 1623617 6 nham 2020-02-27 12:54:08 -0800 This test sometimes fails because it presses the PIP control before the video starts playing. Jer suggested that I work around this by only playing the video after the event handler that presses the PIP control is set up. That's what I've done in this patch. 1623653 7 391910 nham 2020-02-27 14:00:41 -0800 Created attachment 391910 Patch for landing 1623655 8 391910 ews-feeder 2020-02-27 14:02:04 -0800 Comment on attachment 391910 Patch for landing Rejecting attachment 391910 from commit-queue. nham@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1623659 9 nham 2020-02-27 14:08:36 -0800 Committed r257585: <https://trac.webkit.org/changeset/257585> 391901 2020-02-27 12:53:14 -0800 2020-02-27 14:00:40 -0800 Patch bug-208272-20200227125313.patch text/plain 3003 nham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NTczCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDY4YWRjZDIxMjgxOTU2N2EzZDBk ODM5OTRmMTM4ODkzOTAxM2Y0MC4uMTFmNWJmNjg0NjIxYzdjZjljMDYwMjA0ZjhkOGU0ZmE5NDJk ZGUzYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAyLTI3ICBCZW4gTmhhbSAgPG5oYW1A YXBwbGUuY29tPgorCisgICAgICAgIEZpeCBmbGFreSBlbnRlci9leGl0IFBJUCB0ZXN0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgyNzIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHRlc3Qgc29t ZXRpbWVzIGZhaWxzIGJlY2F1c2UgaXQgcHJlc3NlcyB0aGUgUElQIGNvbnRyb2wgYmVmb3JlIHRo ZSB2aWRlbyBzdGFydHMKKyAgICAgICAgcGxheWluZy4gRml4IHRoaXMgYnkgd2FpdGluZyBmb3Ig dGhlIHBsYXlpbmcgZXZlbnQgYmVmb3JlIHByZXNzaW5nIHRoZSBjb250cm9sLgorCisgICAgICAg ICogbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3BpcC1zdXBwb3J0L3BpcC1zdXBwb3J0LWNs aWNrLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zOgor CiAyMDIwLTAyLTI3ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtDU1MgQmFja2dyb3VuZHNdIFNraXAgV1BUIHRlc3RzIGFsd2F5cyBj cmFzaGluZyBpbiBEZWJ1Zy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1t ZWRpYS1jb250cm9scy9waXAtc3VwcG9ydC9waXAtc3VwcG9ydC1jbGljay5odG1sIGIvTGF5b3V0 VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3BpcC1zdXBwb3J0L3BpcC1zdXBwb3J0 LWNsaWNrLmh0bWwKaW5kZXggY2RkZjU2NmIzYzEzOTY0MTFiZmM0ZmIwZmU1N2E0MThlMjU1N2Q1 Zi4uZWY4ZmNmYzU2MDIyYmRiYTgyNTk1MTAyZDgzMDA4YWNlOWY2YzUxNiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3BpcC1zdXBwb3J0L3BpcC1z dXBwb3J0LWNsaWNrLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNv bnRyb2xzL3BpcC1zdXBwb3J0L3BpcC1zdXBwb3J0LWNsaWNrLmh0bWwKQEAgLTEzLDcgKzEzLDcg QEAKICAgICB9CiAgICAgCiA8L3N0eWxlPgotPHZpZGVvIHNyYz0iLi4vLi4vY29udGVudC90ZXN0 Lm1wNCIgYXV0b3BsYXkgY29udHJvbHM+PC92aWRlbz4KKzx2aWRlbyBjb250cm9scz48L3ZpZGVv PgogPGRpdiBpZD0iaG9zdCI+PC9kaXY+CiA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+ CiAKQEAgLTM2LDExICszNiwxNiBAQCBtZWRpYS5hZGRFdmVudExpc3RlbmVyKCJ3ZWJraXRwcmVz ZW50YXRpb25tb2RlY2hhbmdlZCIsICgpID0+IHsKICAgICBmaW5pc2hNZWRpYUNvbnRyb2xzVGVz dCgpOwogfSk7CiAKLXNob3VsZEJlY29tZURpZmZlcmVudCgibWVkaWFDb250cm9sbGVyLmNvbnRy b2xzLnBpcEJ1dHRvbi5lbGVtZW50LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLndpZHRoIiwgIjAi LCAoKSA9PiB7Ci0gICAgbWVkaWEucGF1c2UoKTsKLSAgICBwcmVzc09uRWxlbWVudChtZWRpYUNv bnRyb2xsZXIuY29udHJvbHMucGlwQnV0dG9uLmVsZW1lbnQpOworbWVkaWEuYWRkRXZlbnRMaXN0 ZW5lcigicGxheWluZyIsICgpID0+IHsKKyAgICBzaG91bGRCZWNvbWVEaWZmZXJlbnQoIm1lZGlh Q29udHJvbGxlci5jb250cm9scy5waXBCdXR0b24uZWxlbWVudC5nZXRCb3VuZGluZ0NsaWVudFJl Y3QoKS53aWR0aCIsICIwIiwgKCkgPT4geworICAgICAgICBtZWRpYS5wYXVzZSgpOworICAgICAg ICBwcmVzc09uRWxlbWVudChtZWRpYUNvbnRyb2xsZXIuY29udHJvbHMucGlwQnV0dG9uLmVsZW1l bnQpOworICAgIH0pOwogfSk7CiAKK21lZGlhLnNyYyA9ICIuLi8uLi9jb250ZW50L3Rlc3QubXA0 IjsKK21lZGlhLnBsYXkoKTsKKwogPC9zY3JpcHQ+CiA8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVz b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CiA8L2JvZHk+CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZDZlZGMyNTBlNjJkNmE0 ZTNhYzlmZTUwOGY0NWNmNjllZjkxMDc3Mi4uNDcyYmMzOGUzZTZlY2ExZmM1NDM0NzBhOGJlZjQ0 NWY3NDVmYjc3YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0 RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVj dGF0aW9ucwpAQCAtMTA3Myw1ICsxMDczLDMgQEAgd2Via2l0Lm9yZy9iLzIwODE2NyBbIERlYnVn IF0gaW5zcGVjdG9yL2RvbS1kZWJ1Z2dlci9hdHRyaWJ1dGUtbW9kaWZpZWQtc3R5bGUuaHQKIHdl YmtpdC5vcmcvYi8yMDgyMjIgWyBSZWxlYXNlIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy93ZWJydGMvUlRDUGVlckNvbm5lY3Rpb24taWNlQ29ubmVjdGlvblN0YXRlLmh0dHBzLmh0 bWwgWyBQYXNzIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMjA4MjY0IFsgUmVsZWFzZSBdIGZh c3QvaGFybmVzcy91aXNjcmlwdGNvbnRyb2xsZXIvY29uY3VycmVudC11aS1zaWRlLXNjcmlwdHMu aHRtbCBbIFBhc3MgRmFpbHVyZSBdCi0KLXdlYmtpdC5vcmcvYi8yMDgyNzIgbWVkaWEvbW9kZXJu LW1lZGlhLWNvbnRyb2xzL3BpcC1zdXBwb3J0L3BpcC1zdXBwb3J0LWNsaWNrLmh0bWwgWyBQYXNz IFRpbWVvdXQgXQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 391910 2020-02-27 14:00:41 -0800 2020-02-27 14:02:04 -0800 Patch for landing bug-208272-20200227140041.patch text/plain 3002 nham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NTczCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDY4YWRjZDIxMjgxOTU2N2EzZDBk ODM5OTRmMTM4ODkzOTAxM2Y0MC4uYTUzZjczZDkyMWUyNTM0NzY4YjIzOWE5NmZhZjVlZDBlMjk0 MTk0NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAyLTI3ICBCZW4gTmhhbSAgPG5oYW1A YXBwbGUuY29tPgorCisgICAgICAgIEZpeCBmbGFreSBlbnRlci9leGl0IFBJUCB0ZXN0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgyNzIKKworICAg ICAgICBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nLgorCisgICAgICAgIFRoaXMgdGVzdCBzb21l dGltZXMgZmFpbHMgYmVjYXVzZSBpdCBwcmVzc2VzIHRoZSBQSVAgY29udHJvbCBiZWZvcmUgdGhl IHZpZGVvIHN0YXJ0cworICAgICAgICBwbGF5aW5nLiBGaXggdGhpcyBieSB3YWl0aW5nIGZvciB0 aGUgcGxheWluZyBldmVudCBiZWZvcmUgcHJlc3NpbmcgdGhlIGNvbnRyb2wuCisKKyAgICAgICAg KiBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcGlwLXN1cHBvcnQvcGlwLXN1cHBvcnQtY2xp Y2suaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisK IDIwMjAtMDItMjcgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5j b20+CiAKICAgICAgICAgW0NTUyBCYWNrZ3JvdW5kc10gU2tpcCBXUFQgdGVzdHMgYWx3YXlzIGNy YXNoaW5nIGluIERlYnVnLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1l ZGlhLWNvbnRyb2xzL3BpcC1zdXBwb3J0L3BpcC1zdXBwb3J0LWNsaWNrLmh0bWwgYi9MYXlvdXRU ZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcGlwLXN1cHBvcnQvcGlwLXN1cHBvcnQt Y2xpY2suaHRtbAppbmRleCBjZGRmNTY2YjNjMTM5NjQxMWJmYzRmYjBmZTU3YTQxOGUyNTU3ZDVm Li5lZjhmY2ZjNTYwMjJiZGJhODI1OTUxMDJkODMwMDhhY2U5ZjZjNTE2IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcGlwLXN1cHBvcnQvcGlwLXN1 cHBvcnQtY2xpY2suaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29u dHJvbHMvcGlwLXN1cHBvcnQvcGlwLXN1cHBvcnQtY2xpY2suaHRtbApAQCAtMTMsNyArMTMsNyBA QAogICAgIH0KICAgICAKIDwvc3R5bGU+Ci08dmlkZW8gc3JjPSIuLi8uLi9jb250ZW50L3Rlc3Qu bXA0IiBhdXRvcGxheSBjb250cm9scz48L3ZpZGVvPgorPHZpZGVvIGNvbnRyb2xzPjwvdmlkZW8+ CiA8ZGl2IGlkPSJob3N0Ij48L2Rpdj4KIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4K IApAQCAtMzYsMTEgKzM2LDE2IEBAIG1lZGlhLmFkZEV2ZW50TGlzdGVuZXIoIndlYmtpdHByZXNl bnRhdGlvbm1vZGVjaGFuZ2VkIiwgKCkgPT4gewogICAgIGZpbmlzaE1lZGlhQ29udHJvbHNUZXN0 KCk7CiB9KTsKIAotc2hvdWxkQmVjb21lRGlmZmVyZW50KCJtZWRpYUNvbnRyb2xsZXIuY29udHJv bHMucGlwQnV0dG9uLmVsZW1lbnQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCkud2lkdGgiLCAiMCIs ICgpID0+IHsKLSAgICBtZWRpYS5wYXVzZSgpOwotICAgIHByZXNzT25FbGVtZW50KG1lZGlhQ29u dHJvbGxlci5jb250cm9scy5waXBCdXR0b24uZWxlbWVudCk7CittZWRpYS5hZGRFdmVudExpc3Rl bmVyKCJwbGF5aW5nIiwgKCkgPT4geworICAgIHNob3VsZEJlY29tZURpZmZlcmVudCgibWVkaWFD b250cm9sbGVyLmNvbnRyb2xzLnBpcEJ1dHRvbi5lbGVtZW50LmdldEJvdW5kaW5nQ2xpZW50UmVj dCgpLndpZHRoIiwgIjAiLCAoKSA9PiB7CisgICAgICAgIG1lZGlhLnBhdXNlKCk7CisgICAgICAg IHByZXNzT25FbGVtZW50KG1lZGlhQ29udHJvbGxlci5jb250cm9scy5waXBCdXR0b24uZWxlbWVu dCk7CisgICAgfSk7CiB9KTsKIAorbWVkaWEuc3JjID0gIi4uLy4uL2NvbnRlbnQvdGVzdC5tcDQi OworbWVkaWEucGxheSgpOworCiA8L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNv dXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KIDwvYm9keT4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBkNmVkYzI1MGU2MmQ2YTRl M2FjOWZlNTA4ZjQ1Y2Y2OWVmOTEwNzcyLi40NzJiYzM4ZTNlNmVjYTFmYzU0MzQ3MGE4YmVmNDQ1 Zjc0NWZiNzdhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RF eHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0 YXRpb25zCkBAIC0xMDczLDUgKzEwNzMsMyBAQCB3ZWJraXQub3JnL2IvMjA4MTY3IFsgRGVidWcg XSBpbnNwZWN0b3IvZG9tLWRlYnVnZ2VyL2F0dHJpYnV0ZS1tb2RpZmllZC1zdHlsZS5odAogd2Vi a2l0Lm9yZy9iLzIwODIyMiBbIFJlbGVhc2UgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL3dlYnJ0Yy9SVENQZWVyQ29ubmVjdGlvbi1pY2VDb25uZWN0aW9uU3RhdGUuaHR0cHMuaHRt bCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8yMDgyNjQgWyBSZWxlYXNlIF0gZmFz dC9oYXJuZXNzL3Vpc2NyaXB0Y29udHJvbGxlci9jb25jdXJyZW50LXVpLXNpZGUtc2NyaXB0cy5o dG1sIFsgUGFzcyBGYWlsdXJlIF0KLQotd2Via2l0Lm9yZy9iLzIwODI3MiBtZWRpYS9tb2Rlcm4t bWVkaWEtY29udHJvbHMvcGlwLXN1cHBvcnQvcGlwLXN1cHBvcnQtY2xpY2suaHRtbCBbIFBhc3Mg VGltZW91dCBdClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=