208267 2020-02-26 15:20:27 -0800 MediaResourceLoader leaks resource responses 2020-02-28 13:24:15 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue dbates eric.carlson ews-watchlist glenn japhet jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1623209 0 cdumez 2020-02-26 15:20:27 -0800 MediaResourceLoader leaks resource responses when browsing in Safari, even though these responses are only used for testing. AVAssetCustomURLBridgeForNSURLSession holds on to the WebCoreNSURLSession, which keeps the MediaResourceLoader alive, even if there is no media on the current page. In turn, the MediaResourceLoader always keeps in memory the last 5 HTTP responses. 1623212 1 391788 cdumez 2020-02-26 15:23:14 -0800 Created attachment 391788 Patch 1624095 2 391788 commit-queue 2020-02-28 13:23:59 -0800 Comment on attachment 391788 Patch Clearing flags on attachment: 391788 Committed r257655: <https://trac.webkit.org/changeset/257655> 1624096 3 commit-queue 2020-02-28 13:24:00 -0800 All reviewed patches have been landed. Closing bug. 1624097 4 webkit-bug-importer 2020-02-28 13:24:15 -0800 <rdar://problem/59900095> 391788 2020-02-26 15:23:14 -0800 2020-02-28 13:23:59 -0800 Patch bug-208267-20200226152313.patch text/plain 3831 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E4MzgxYmQ5YzE5MTZi ZWVmOGMzZGZmMzA0NDg3ZDQ0NjFjNDY3Mi4uMmQ4ZGQyNDM0MWFjNjM3ZWRmNDIzODFjZTdjNWM0 Yzk5ZmZiZTM4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTAyLTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTWVkaWFSZXNvdXJjZUxvYWRl ciBsZWFrcyByZXNvdXJjZSByZXNwb25zZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwODI2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE1lZGlhUmVzb3VyY2VMb2FkZXIgbGVha3MgcmVzb3VyY2UgcmVz cG9uc2VzIHdoZW4gYnJvd3NpbmcgaW4gU2FmYXJpLCBldmVuIHRob3VnaCB0aGVzZSByZXNwb25z ZXMgYXJlCisgICAgICAgIG9ubHkgdXNlZCBmb3IgdGVzdGluZy4gQVZBc3NldEN1c3RvbVVSTEJy aWRnZUZvck5TVVJMU2Vzc2lvbiBob2xkcyBvbiB0byB0aGUgV2ViQ29yZU5TVVJMU2Vzc2lvbiwg d2hpY2gKKyAgICAgICAga2VlcHMgdGhlIE1lZGlhUmVzb3VyY2VMb2FkZXIgYWxpdmUsIGV2ZW4g aWYgdGhlcmUgaXMgbm8gbWVkaWEgb24gdGhlIGN1cnJlbnQgcGFnZS4gSW4gdHVybiwgdGhlCisg ICAgICAgIE1lZGlhUmVzb3VyY2VMb2FkZXIgYWx3YXlzIGtlZXBzIGluIG1lbW9yeSB0aGUgbGFz dCA1IEhUVFAgcmVzcG9uc2VzLgorCisgICAgICAgIFRvIGFkZHJlc3MgdGhlIGlzc3VlLCB3ZSBu b3cgb25seSByZWNvcmQgdGhlc2UgcmVzcG9uc2VzIHdoZW4gcnVubmluZyB0aGUgdGVzdHMuCisK KyAgICAgICAgKiBsb2FkZXIvTWVkaWFSZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpNZWRpYVJlc291cmNlTG9hZGVyOjpyZWNvcmRSZXNwb25zZXNGb3JUZXN0aW5nKToKKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhUmVzb3VyY2VMb2FkZXI6OmFkZFJlc3BvbnNlRm9yVGVzdGlu Zyk6CisgICAgICAgICogbG9hZGVyL01lZGlhUmVzb3VyY2VMb2FkZXIuaDoKKyAgICAgICAgKiB0 ZXN0aW5nL0ludGVybmFscy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbHM6OnJlc2V0 VG9Db25zaXN0ZW50U3RhdGUpOgorCiAyMDIwLTAyLTI2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVz QGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbiB1cCBIaXRUZXN0TG9jYXRpb24uaApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL01lZGlhUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL01lZGlhUmVzb3VyY2VMb2FkZXIuY3BwCmluZGV4IDBmN2JiYmU5 NjI4ZjdkMWJjMWY4NTY1ZjczYTAzYTZmNjEwNGQzZjcuLjBkZjZjZjhiZjRhMDc3ZWU5ZDlmNGVm NzIxOWI5YjdhMDdhMTE0MjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9NZWRp YVJlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvTWVkaWFSZXNv dXJjZUxvYWRlci5jcHAKQEAgLTQxLDYgKzQxLDEzIEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAorc3RhdGljIGJvb2wgc2hvdWxkUmVjb3JkUmVzcG9uc2VzRm9yVGVzdGluZyA9IGZhbHNlOwor Cit2b2lkIE1lZGlhUmVzb3VyY2VMb2FkZXI6OnJlY29yZFJlc3BvbnNlc0ZvclRlc3RpbmcoKQor eworICAgIHNob3VsZFJlY29yZFJlc3BvbnNlc0ZvclRlc3RpbmcgPSB0cnVlOworfQorCiBNZWRp YVJlc291cmNlTG9hZGVyOjpNZWRpYVJlc291cmNlTG9hZGVyKERvY3VtZW50JiBkb2N1bWVudCwg SFRNTE1lZGlhRWxlbWVudCYgbWVkaWFFbGVtZW50LCBjb25zdCBTdHJpbmcmIGNyb3NzT3JpZ2lu TW9kZSkKICAgICA6IENvbnRleHREZXN0cnVjdGlvbk9ic2VydmVyKCZkb2N1bWVudCkKICAgICAs IG1fZG9jdW1lbnQobWFrZVdlYWtQdHIoZG9jdW1lbnQpKQpAQCAtMTE4LDcgKzEyNSw3IEBAIHZv aWQgTWVkaWFSZXNvdXJjZUxvYWRlcjo6cmVtb3ZlUmVzb3VyY2UoTWVkaWFSZXNvdXJjZSYgbWVk aWFSZXNvdXJjZSkKIHZvaWQgTWVkaWFSZXNvdXJjZUxvYWRlcjo6YWRkUmVzcG9uc2VGb3JUZXN0 aW5nKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogewogICAgIGNvbnN0IGF1dG8g bWF4aW11bVJlc3BvbnNlc0ZvclRlc3RpbmcgPSA1OwotICAgIGlmIChtX3Jlc3BvbnNlc0ZvclRl c3Rpbmcuc2l6ZSgpID4gbWF4aW11bVJlc3BvbnNlc0ZvclRlc3RpbmcpCisgICAgaWYgKCFzaG91 bGRSZWNvcmRSZXNwb25zZXNGb3JUZXN0aW5nIHx8IG1fcmVzcG9uc2VzRm9yVGVzdGluZy5zaXpl KCkgPiBtYXhpbXVtUmVzcG9uc2VzRm9yVGVzdGluZykKICAgICAgICAgcmV0dXJuOwogICAgIG1f cmVzcG9uc2VzRm9yVGVzdGluZy5hcHBlbmQocmVzcG9uc2UpOwogfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvbG9hZGVyL01lZGlhUmVzb3VyY2VMb2FkZXIuaCBiL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9NZWRpYVJlc291cmNlTG9hZGVyLmgKaW5kZXggMWEzZTBhZmYwYjUwZjg5ZGY1MWUy M2FhOTMwODJkYmQ4NTA5NjdiZC4uNjA5ZDRmZTQ3MDY1NTA1OGNlZWYxYjQ3Yjg4ZmIxMzc4MmQx Mjk1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL01lZGlhUmVzb3VyY2VMb2Fk ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvTWVkaWFSZXNvdXJjZUxvYWRlci5oCkBA IC01NSw2ICs1NSw3IEBAIHB1YmxpYzoKICAgICBEb2N1bWVudCogZG9jdW1lbnQoKSB7IHJldHVy biBtX2RvY3VtZW50LmdldCgpOyB9CiAgICAgY29uc3QgU3RyaW5nJiBjcm9zc09yaWdpbk1vZGUo KSBjb25zdCB7IHJldHVybiBtX2Nyb3NzT3JpZ2luTW9kZTsgfQogCisgICAgV0VCQ09SRV9FWFBP UlQgc3RhdGljIHZvaWQgcmVjb3JkUmVzcG9uc2VzRm9yVGVzdGluZygpOwogICAgIFZlY3RvcjxS ZXNvdXJjZVJlc3BvbnNlPiByZXNwb25zZXNGb3JUZXN0aW5nKCkgY29uc3QgeyByZXR1cm4gbV9y ZXNwb25zZXNGb3JUZXN0aW5nOyB9CiAgICAgdm9pZCBhZGRSZXNwb25zZUZvclRlc3RpbmcoY29u c3QgUmVzb3VyY2VSZXNwb25zZSYpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0 aW5nL0ludGVybmFscy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAK aW5kZXggMGE4Yjc1ZWIwNDA3Y2JlNjMzNGRmMjdiOTE4YjdlMGVjNTJhOWIwYS4uN2E0MzQ3ZGFi MDc0NzNjNDRlMjI5NjA4NDllOTMzYWQ3M2M3MGVmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50 ZXJuYWxzLmNwcApAQCAtNTMxLDYgKzUzMSw4IEBAIHZvaWQgSW50ZXJuYWxzOjpyZXNldFRvQ29u c2lzdGVudFN0YXRlKFBhZ2UmIHBhZ2UpCiAgICAgcGFnZS5zZXRNb2NrTWVkaWFQbGF5YmFja1Rh cmdldFBpY2tlclN0YXRlKGVtcHR5U3RyaW5nKCksIE1lZGlhUGxheWJhY2tUYXJnZXRDb250ZXh0 OjpVbmtub3duKTsKICNlbmRpZgogCisgICAgTWVkaWFSZXNvdXJjZUxvYWRlcjo6cmVjb3JkUmVz cG9uc2VzRm9yVGVzdGluZygpOworCiAgICAgcGFnZS5zZXRTaG93QWxsUGx1Z2lucyhmYWxzZSk7 CiAgICAgcGFnZS5zZXRMb3dQb3dlck1vZGVFbmFibGVkT3ZlcnJpZGVGb3JUZXN0aW5nKFdURjo6 bnVsbG9wdCk7CiAK