208264 2020-02-26 14:27:21 -0800 REGRESSION: (257072) [ Mac wk2 Release ] fast/harness/uiscriptcontroller/concurrent-ui-side-scripts.html is flaky failing. 2020-03-09 16:49:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Mac macOS 10.15 RESOLVED FIXED InRadar P2 Normal --- 1 Lawrence.j webkit-unassigned commit-queue koivisto simon.fraser webkit-bug-importer WebkitBugTracker oldest_to_newest 1623181 0 Lawrence.j 2020-02-26 14:27:21 -0800 fast/harness/uiscriptcontroller/concurrent-ui-side-scripts.html Description: This test is flaky failing on Mac wk2. The oldest failure that I see is on r257099 which has the same diff. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fharness%2Fuiscriptcontroller%2Fconcurrent-ui-side-scripts.html&flavor=wk2&platform=mac&version_name=Catalina&style=release&limit=50000 Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/fast/harness/uiscriptcontroller/concurrent-ui-side-scripts-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/fast/harness/uiscriptcontroller/concurrent-ui-side-scripts-actual.txt @@ -1,9 +1,9 @@ -Script 2: -Running UI-side script 2 -Completed async task 2.1. Script done. Script 1: Running UI-side script 1 Completed async task 1.1. Completed async task 1.2. Completed async task 1.3. Script done. +Script 2: +Running UI-side script 2 +Completed async task 2.1. Script done. . 1623182 1 webkit-bug-importer 2020-02-26 14:27:48 -0800 <rdar://problem/59821552> 1623186 2 Lawrence.j 2020-02-26 14:39:44 -0800 I have marked this test as failing while this issue is being investigated. https://trac.webkit.org/changeset/257517/webkit 1623519 3 Lawrence.j 2020-02-27 09:10:07 -0800 The regression point for this flaky failure is r257072. The diff that I get when reproducing the issue matches. 1623565 4 391891 koivisto 2020-02-27 10:51:30 -0800 Created attachment 391891 patch 1623570 5 391891 simon.fraser 2020-02-27 11:03:50 -0800 Comment on attachment 391891 patch View in context: https://bugs.webkit.org/attachment.cgi?id=391891&action=review > LayoutTests/fast/harness/uiscriptcontroller/concurrent-ui-side-scripts.html:71 > + document.getElementById('results').textContent += 'Script 1:\n' + script1Result + 'Script 2:\n' + script2Result; Another option is to have two "results" divs, one per async script. Then ordering will be document order. 1623590 6 391891 commit-queue 2020-02-27 11:50:03 -0800 Comment on attachment 391891 patch Clearing flags on attachment: 391891 Committed r257580: <https://trac.webkit.org/changeset/257580> 1623591 7 commit-queue 2020-02-27 11:50:05 -0800 All reviewed patches have been landed. Closing bug. 1628031 8 Lawrence.j 2020-03-09 16:49:31 -0700 I have removed the failing state expectation, as this issue is resolved. https://trac.webkit.org/changeset/258175/webkit 391891 2020-02-27 10:51:30 -0800 2020-02-27 11:50:03 -0800 patch concurrent-ui-side-scripts-flake.patch text/plain 3344 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0MGI0NjM2YTQzNC4uNDU3ZTNmNTQ0OWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAor MjAyMC0wMi0yNyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTjogKDI1NzA3MikgWyBNYWMgd2syIFJlbGVhc2UgXSBmYXN0L2hhcm5lc3MvdWlz Y3JpcHRjb250cm9sbGVyL2NvbmN1cnJlbnQtdWktc2lkZS1zY3JpcHRzLmh0bWwgaXMgZmxha3kg ZmFpbGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwODI2NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTk4MjE1NTI+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2hhcm5lc3MvdWlzY3Jp cHRjb250cm9sbGVyL2NvbmN1cnJlbnQtdWktc2lkZS1zY3JpcHRzLWV4cGVjdGVkLnR4dDoKKyAg ICAgICAgKiBmYXN0L2hhcm5lc3MvdWlzY3JpcHRjb250cm9sbGVyL2NvbmN1cnJlbnQtdWktc2lk ZS1zY3JpcHRzLmh0bWw6CisKKyAgICAgICAgVGhlcmUgaXMgbm8gZ3VhcmFudGVlIHRoYXQgdHdv IGluZGVwZW5kZW50IGFzeW5jIFVJIHNjcmlwdHMgZmluaXNoIGluIHBhcnRpY3VsYXIgb3JkZXIu IE9yZGVyIHRoZSBvdXRwdXQgaW5zdGVhZC4KKwogMjAyMC0wMi0yNiAgTmlrb3MgTW91Y2h0YXJp cyAgPG5tb3VjaHRhcmlzQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgcGxhdGZvcm0gdGVzdHMg Zm9yIFdlYiBTaGFyZSBBUEkgZmFpbCBpbmNvcnJlY3RseQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9oYXJuZXNzL3Vpc2NyaXB0Y29udHJvbGxlci9jb25jdXJyZW50LXVpLXNpZGUtc2Ny aXB0cy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvdWlzY3JpcHRjb250 cm9sbGVyL2NvbmN1cnJlbnQtdWktc2lkZS1zY3JpcHRzLWV4cGVjdGVkLnR4dAppbmRleCA0NjU2 ZmIxOTJmMS4uZmU4ZWYwZmM1NmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvaGFybmVz cy91aXNjcmlwdGNvbnRyb2xsZXIvY29uY3VycmVudC11aS1zaWRlLXNjcmlwdHMtZXhwZWN0ZWQu dHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaGFybmVzcy91aXNjcmlwdGNvbnRyb2xsZXIvY29u Y3VycmVudC11aS1zaWRlLXNjcmlwdHMtZXhwZWN0ZWQudHh0CkBAIC0xLDkgKzEsOSBAQAotU2Ny aXB0IDI6Ci1SdW5uaW5nIFVJLXNpZGUgc2NyaXB0IDIKLUNvbXBsZXRlZCBhc3luYyB0YXNrIDIu MS4gU2NyaXB0IGRvbmUuCiBTY3JpcHQgMToKIFJ1bm5pbmcgVUktc2lkZSBzY3JpcHQgMQogQ29t cGxldGVkIGFzeW5jIHRhc2sgMS4xLgogQ29tcGxldGVkIGFzeW5jIHRhc2sgMS4yLgogQ29tcGxl dGVkIGFzeW5jIHRhc2sgMS4zLiBTY3JpcHQgZG9uZS4KK1NjcmlwdCAyOgorUnVubmluZyBVSS1z aWRlIHNjcmlwdCAyCitDb21wbGV0ZWQgYXN5bmMgdGFzayAyLjEuIFNjcmlwdCBkb25lLgogLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Vpc2NyaXB0Y29udHJvbGxlci9j b25jdXJyZW50LXVpLXNpZGUtc2NyaXB0cy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNz L3Vpc2NyaXB0Y29udHJvbGxlci9jb25jdXJyZW50LXVpLXNpZGUtc2NyaXB0cy5odG1sCmluZGV4 IGM5YWQ4MWY2ODNhLi40M2EzOTJmYjUzOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9o YXJuZXNzL3Vpc2NyaXB0Y29udHJvbGxlci9jb25jdXJyZW50LXVpLXNpZGUtc2NyaXB0cy5odG1s CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaGFybmVzcy91aXNjcmlwdGNvbnRyb2xsZXIvY29uY3Vy cmVudC11aS1zaWRlLXNjcmlwdHMuaHRtbApAQCAtNDAsMjAgKzQwLDIzIEBACiAgICAgICAgICAg ICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKICAgICAgICAgfQogCisgICAgICAgIGxldCBz Y3JpcHQxUmVzdWx0OworICAgICAgICBsZXQgc2NyaXB0MlJlc3VsdDsKKwogICAgICAgICB2YXIg b3V0c3RhbmRpbmdTY3JpcHRzID0gMjsKICAgICAgICAgZnVuY3Rpb24gcnVuVGVzdCgpCiAgICAg ICAgIHsKICAgICAgICAgICAgIGlmICh0ZXN0UnVubmVyLnJ1blVJU2NyaXB0KSB7CiAgICAgICAg ICAgICAgICAgdmFyIHVpU2NyaXB0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3VpLXNjcmlw dDEnKS50ZXh0OwogICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIucnVuVUlTY3JpcHQodWlTY3Jp cHQsIGZ1bmN0aW9uKHJlc3VsdCkgewotICAgICAgICAgICAgICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgncmVzdWx0cycpLnRleHRDb250ZW50ICs9ICdTY3JpcHQgMTpcbicgKyByZXN1 bHQ7CisgICAgICAgICAgICAgICAgICAgIHNjcmlwdDFSZXN1bHQgPSByZXN1bHQ7CiAgICAgICAg ICAgICAgICAgICAgIC0tb3V0c3RhbmRpbmdTY3JpcHRzOwogICAgICAgICAgICAgICAgICAgICBj aGVja0lmU2NyaXB0c0NvbXBsZXRlKCk7CiAgICAgICAgICAgICAgICAgfSk7CiAKICAgICAgICAg ICAgICAgICB2YXIgdWlTY3JpcHQyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3VpLXNjcmlw dDInKS50ZXh0OwogICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIucnVuVUlTY3JpcHQodWlTY3Jp cHQyLCBmdW5jdGlvbihyZXN1bHQpIHsKLSAgICAgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ3Jlc3VsdHMnKS50ZXh0Q29udGVudCArPSAnU2NyaXB0IDI6XG4nICsgcmVz dWx0OworICAgICAgICAgICAgICAgICAgICBzY3JpcHQyUmVzdWx0ID0gcmVzdWx0OwogICAgICAg ICAgICAgICAgICAgICAtLW91dHN0YW5kaW5nU2NyaXB0czsKICAgICAgICAgICAgICAgICAgICAg Y2hlY2tJZlNjcmlwdHNDb21wbGV0ZSgpOwogICAgICAgICAgICAgICAgIH0pOwpAQCAtNjUsNiAr NjgsOCBAQAogICAgICAgICAgICAgaWYgKG91dHN0YW5kaW5nU2NyaXB0cykKICAgICAgICAgICAg ICAgICByZXR1cm47CiAKKyAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1 bHRzJykudGV4dENvbnRlbnQgKz0gJ1NjcmlwdCAxOlxuJyArIHNjcmlwdDFSZXN1bHQgKyAnU2Ny aXB0IDI6XG4nICsgc2NyaXB0MlJlc3VsdDsKKwogICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3Rp ZnlEb25lKCk7CiAgICAgICAgIH0KIApAQCAtNzcsNCArODIsNCBAQAogCiA8L2JvZHk+CiA8L2h0 bWw+Ci0uClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorLgo=