208258 2020-02-26 13:40:50 -0800 Make testair pass on arm64 2020-02-26 16:00:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff tzagallo webkit-bug-importer oldest_to_newest 1623156 0 saam 2020-02-26 13:40:50 -0800 some tests were never tested on arm64, and are obviously broken. For example, some produce invalid instructions 1623173 1 391778 saam 2020-02-26 14:06:24 -0800 Created attachment 391778 patch 1623207 2 391778 tzagallo 2020-02-26 15:11:52 -0800 Comment on attachment 391778 patch r=me 1623241 3 391778 commit-queue 2020-02-26 15:59:17 -0800 Comment on attachment 391778 patch Clearing flags on attachment: 391778 Committed r257524: <https://trac.webkit.org/changeset/257524> 1623242 4 commit-queue 2020-02-26 15:59:18 -0800 All reviewed patches have been landed. Closing bug. 1623244 5 webkit-bug-importer 2020-02-26 16:00:16 -0800 <rdar://problem/59825534> 391778 2020-02-26 14:06:24 -0800 2020-02-26 15:59:17 -0800 patch c-backup.diff text/plain 3838 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjU3MzcxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDIwLTAyLTI2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IE1ha2UgdGVzdGFpciBwYXNzIG9uIGFybTY0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgyNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICB0ZXN0RWxpZGVNb3ZlVGhlblJlYWxsb2MgYW5kIHRlc3RFbGlk ZVNpbXBsZU1vdmUgd2VyZSBuZXZlciB0ZXN0ZWQKKyAgICAgICAgb24gYXJtNjQuIFRoaXMgcGF0 Y2ggbWFrZXMgdGhvc2UgdGVzdHMgd29yay4gCisgICAgICAgIC0gdGVzdEVsaWRlTW92ZVRoZW5S ZWFsbG9jIHdhcyB1c2luZyBhIEJpdEltbSB0aGF0IGlzIGludmFsaWQgb24gYXJtNjQKKyAgICAg ICAgLSB0ZXN0RWxpZGVTaW1wbGVNb3ZlIHdhcyB0ZXN0aW5nIGZvciB0aGUgd3JvbmcgZGlzYXNz ZW1ibHkKKworICAgICAgICAqIGIzL2Fpci90ZXN0YWlyLmNwcDoKKwogMjAyMC0wMi0yNCAgWXVz dWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtXVEZdIEF0dGFjaCBX QVJOX1VOVVNFRF9SRVRVUk4gdG8gbWFrZVNjb3BlRXhpdCBhbmQgZml4IGV4aXN0aW5nIHdyb25n IHVzYWdlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL3Rlc3RhaXIuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvdGVzdGFpci5jcHAJKHJl dmlzaW9uIDI1NzM3MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvdGVzdGFpci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTIwOTYsMTEgKzIwOTYsMTkgQEAgdm9pZCB0ZXN0RWxpZGVT aW1wbGVNb3ZlKCkKIAogICAgICAgICBhdXRvIGNvbXBpbGF0aW9uID0gY29tcGlsZShwcm9jKTsK ICAgICAgICAgQ1N0cmluZyBkaXNhc3NlbWJseSA9IGNvbXBpbGF0aW9uLT5kaXNhc3NlbWJseSgp OwotICAgICAgICBzdGQ6OnJlZ2V4IGZpbmRSUk1vdmUoaXNBUk02NCgpID8gIm1vdiByXFxkKywg clxcZCtcXG4iIDogIm1vdiAlXFx3KywgJVxcdytcXG4iKTsKKyAgICAgICAgc3RkOjpyZWdleCBm aW5kUlJNb3ZlKGlzQVJNNjQoKSA/ICJtb3ZcXHMreFxcZCssIHhcXGQrXFxuIiA6ICJtb3YgJVxc dyssICVcXHcrXFxuIik7CiAgICAgICAgIGF1dG8gcmVzdWx0ID0gbWF0Y2hBbGwoZGlzYXNzZW1i bHksIGZpbmRSUk1vdmUpOwotICAgICAgICAvLyBzcCAtPiBmcDsgYXJnMCAtPiByZXQwOyBmcCAt PiBzcAotICAgICAgICAvLyBmcCAtPiBzcCBvbmx5IGhhcHBlbnMgaW4gTzAgYmVjYXVzZSB3ZSBk b24ndCBhY3R1YWxseSBuZWVkIHRvIG1vdmUgdGhlIHN0YWNrIGluIGdlbmVyYWwuCi0gICAgICAg IENIRUNLKHJlc3VsdC5zaXplKCkgPT0gMiArICFPcHRpb25zOjpkZWZhdWx0QjNPcHRMZXZlbCgp KTsKKyAgICAgICAgaWYgKGlzQVJNNjQoKSkgeworICAgICAgICAgICAgaWYgKCFPcHRpb25zOjpk ZWZhdWx0QjNPcHRMZXZlbCgpKQorICAgICAgICAgICAgICAgIENIRUNLKHJlc3VsdC5zaXplKCkg PT0gMik7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgQ0hFQ0socmVzdWx0LnNp emUoKSA9PSAwKTsKKyAgICAgICAgfSBlbHNlIGlmIChpc1g4NigpKSB7CisgICAgICAgICAgICAv LyBzcCAtPiBmcDsgYXJnMCAtPiByZXQwOyBmcCAtPiBzcAorICAgICAgICAgICAgLy8gZnAgLT4g c3Agb25seSBoYXBwZW5zIGluIE8wIGJlY2F1c2Ugd2UgZG9uJ3QgYWN0dWFsbHkgbmVlZCB0byBt b3ZlIHRoZSBzdGFjayBpbiBnZW5lcmFsLgorICAgICAgICAgICAgQ0hFQ0socmVzdWx0LnNpemUo KSA9PSAyICsgIU9wdGlvbnM6OmRlZmF1bHRCM09wdExldmVsKCkpOworICAgICAgICB9IGVsc2UK KyAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQogfQogCkBA IC0yMTc3LDEwICsyMTg1LDE5IEBAIHZvaWQgdGVzdEVsaWRlTW92ZVRoZW5SZWFsbG9jKCkKICAg ICAgICAgQmFzaWNCbG9jayogY29udGludWF0aW9uID0gY29kZS5hZGRCbG9jaygpOwogCiAgICAg ICAgIFRtcCB0bXAgPSBjb2RlLm5ld1RtcChCMzo6R1ApOworICAgICAgICBBcmcgbmVnT25lOwor ICAgICAgICBpZiAoaXNBUk02NCgpKSB7CisgICAgICAgICAgICBuZWdPbmUgPSBjb2RlLm5ld1Rt cChCMzo6R1ApOworICAgICAgICAgICAgcm9vdC0+YXBwZW5kKE1vdmUsIG51bGxwdHIsIEFyZzo6 YmlnSW1tKC0xKSwgbmVnT25lKTsKKyAgICAgICAgfSBlbHNlIGlmIChpc1g4NigpKQorICAgICAg ICAgICAgbmVnT25lID0gQXJnOjpiaXRJbW0oLTEpOworICAgICAgICBlbHNlCisgICAgICAgICAg ICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworCiAgICAgICAgIHsKICAgICAgICAgICAg IHJvb3QtPmFwcGVuZChNb3ZlLCBudWxscHRyLCBBcmc6OmltbSgxKSwgVG1wKHJlZykpOwogCi0g ICAgICAgICAgICByb290LT5hcHBlbmQoQnJhbmNoVGVzdDMyLCBudWxscHRyLCBBcmc6OnJlc0Nv bmQoTWFjcm9Bc3NlbWJsZXI6Ok5vblplcm8pLCBUbXAocmVnKSwgQXJnOjpiaXRJbW0oLTEpKTsK KyAgICAgICAgICAgIHJvb3QtPmFwcGVuZChCcmFuY2hUZXN0MzIsIG51bGxwdHIsIEFyZzo6cmVz Q29uZChNYWNyb0Fzc2VtYmxlcjo6Tm9uWmVybyksIFRtcChyZWcpLCBuZWdPbmUpOwogICAgICAg ICAgICAgcm9vdC0+c2V0U3VjY2Vzc29ycyh0YWtlbiwgbm90VGFrZW4pOwogICAgICAgICB9CiAK QEAgLTIxOTAsMTQgKzIyMDcsMTQgQEAgdm9pZCB0ZXN0RWxpZGVNb3ZlVGhlblJlYWxsb2MoKQog ICAgICAgICB9CiAKICAgICAgICAgewotICAgICAgICAgICAgbm90VGFrZW4tPmFwcGVuZChCcmFu Y2hUZXN0MzIsIG51bGxwdHIsIEFyZzo6cmVzQ29uZChNYWNyb0Fzc2VtYmxlcjo6Tm9uWmVybyks IFRtcChyZWcpLCBBcmc6OmJpdEltbSgtMSkpOworICAgICAgICAgICAgbm90VGFrZW4tPmFwcGVu ZChCcmFuY2hUZXN0MzIsIG51bGxwdHIsIEFyZzo6cmVzQ29uZChNYWNyb0Fzc2VtYmxlcjo6Tm9u WmVybyksIFRtcChyZWcpLCBuZWdPbmUpOwogICAgICAgICAgICAgbm90VGFrZW4tPnNldFN1Y2Nl c3NvcnMoY29udGludWF0aW9uLCBub3RUYWtlblJldHVybik7CiAgICAgICAgIH0KIAogICAgICAg ICB7CiAgICAgICAgICAgICB0bXAgPSBjb2RlLm5ld1RtcChCMzo6R1ApOwogICAgICAgICAgICAg Y29udGludWF0aW9uLT5hcHBlbmQoTW92ZSwgbnVsbHB0ciwgQXJnOjppbW0oNDIpLCB0bXApOwot ICAgICAgICAgICAgY29udGludWF0aW9uLT5hcHBlbmQoQnJhbmNoVGVzdDMyLCBudWxscHRyLCBB cmc6OnJlc0NvbmQoTWFjcm9Bc3NlbWJsZXI6Ok5vblplcm8pLCB0bXAsIEFyZzo6Yml0SW1tKC0x KSk7CisgICAgICAgICAgICBjb250aW51YXRpb24tPmFwcGVuZChCcmFuY2hUZXN0MzIsIG51bGxw dHIsIEFyZzo6cmVzQ29uZChNYWNyb0Fzc2VtYmxlcjo6Tm9uWmVybyksIHRtcCwgbmVnT25lKTsK ICAgICAgICAgICAgIGNvbnRpbnVhdGlvbi0+c2V0U3VjY2Vzc29ycyhyZXQsIG5vdFRha2VuUmV0 dXJuKTsKICAgICAgICAgfQogCg==