208254 2020-02-26 11:55:25 -0800 Clean up HitTestLocation.h 2020-03-11 15:48:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208269 InRadar P2 Normal --- 208947 1 dbates dbates esprehn+autocc ews-watchlist glenn jer.noble kondapallykalyan pdr webkit-bug-importer oldest_to_newest 1623092 0 dbates 2020-02-26 11:55:25 -0800 Use C++11 and later features to reduce code duplication and simplify the code in HitTestLocation.h. This will make it easier for me to add a new rect-based location constructor in the future. 1623093 1 webkit-bug-importer 2020-02-26 11:55:37 -0800 <rdar://problem/59815136> 1623096 2 391765 dbates 2020-02-26 12:01:35 -0800 Created attachment 391765 Patch 1623098 3 391765 dbates 2020-02-26 12:05:10 -0800 Comment on attachment 391765 Patch Clearing flags on attachment: 391765 Committed r257502: <https://trac.webkit.org/changeset/257502> 1623099 4 dbates 2020-02-26 12:05:11 -0800 All reviewed patches have been landed. Closing bug. 1628856 5 391765 dbates 2020-03-11 14:44:57 -0700 Comment on attachment 391765 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391765&action=review > Source/WebCore/rendering/HitTestLocation.cpp:-56 > - , m_isRectBased(true) This is wrong. This needs to be set to true. 1628886 6 dbates 2020-03-11 15:48:49 -0700 (In reply to Daniel Bates from comment #5) > Comment on attachment 391765 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391765&action=review > > > Source/WebCore/rendering/HitTestLocation.cpp:-56 > > - , m_isRectBased(true) > > This is wrong. This needs to be set to true. Fixed in bug #208947. 391765 2020-02-26 12:01:35 -0800 2020-02-26 12:05:10 -0800 Patch bug-208254-20200226120135.patch text/plain 5087 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQxNmNiZTI4ZjY3ZGNi OWQzNzJmMTU4YjU2ZWI1NjgzOTYxMDdjMy4uMDM4NjhiN2RkM2EwMGJjZDQ4ZTBkMDM4YjMxMjk3 NWY1NWM0NGVkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTAyLTI2ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbiB1cCBIaXRUZXN0 TG9jYXRpb24uaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA4MjU0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81OTgxNTEzNj4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgbW9kZXJuIEMrKyBmZWF0 dXJlcyB0byByZW1vdmUgZHVwbGljYXRlIGNvZGUuCisKKyAgICAgICAgKiByZW5kZXJpbmcvSGl0 VGVzdExvY2F0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhpdFRlc3RMb2NhdGlvbjo6SGl0 VGVzdExvY2F0aW9uKToKKyAgICAgICAgKiByZW5kZXJpbmcvSGl0VGVzdExvY2F0aW9uLmg6Cisg ICAgICAgICogcmVuZGVyaW5nL0hpdFRlc3RSZXN1bHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SGl0VGVzdFJlc3VsdDo6SGl0VGVzdFJlc3VsdCk6CisgICAgICAgICogcmVuZGVyaW5nL0hpdFRl c3RSZXN1bHQuaDogUmVtb3ZlIHVubmVjZXNzYXJ5ICNpbmNsdWRlcy4gVGhpcyBmaWxlIG9ubHkg bmVlZHMKKyAgICAgICAgdG8gaW5jbHVkZSBSb3VuZGVkUmVjdC5oOiBSb3VuZGVkUmVjdC5oIGlu Y2x1ZGVzIEZsb2F0UXVhZC5oIGFuZCBMYXlvdXRSZWN0LmgKKyAgICAgICAgYW5kIEZsb2F0UXVh ZC5oIHdpbGwgaW5jbHVkZSBGbG9hdFJlY3QuaC4gV2UgZG8gbm90IG1ha2UgdXNlIG9mIGhhdmUg ZGVjbGFyYXRpb25zCisgICAgICAgIGluIDx3dGYvRm9yd2FyZC5oPiBzbyByZW1vdmUgdGhhdCBh cyB3ZWxsLgorCiAyMDE5LTA5LTEzICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4K IAogICAgICAgICBTdXBwb3J0IGJ1aWxkaW5nIFdlYktpdCBmb3IgTWFjIENhdGFseXN0IGZyb20g WGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9IaXRUZXN0TG9jYXRp b24uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RMb2NhdGlvbi5jcHAKaW5k ZXggNDZjYmMwOTllZDQxNDJhZWJhNWJiN2NmYzJiMTdkZjcwNWE3NmU3NC4uMzhlZWUxYTAzNmM3 NzVmM2I3M2RhNzAyZDZjNzU0ODRkYWUyMGNhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL0hpdFRlc3RMb2NhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL0hpdFRlc3RMb2NhdGlvbi5jcHAKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0 IChDKSAyMDA2LCAyMDA4LCAyMDExIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq IENvcHlyaWdodCAoQykgMjAwNiwgMjAwOCwgMjAxMSwgMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCiAgKiBDb3B5cmlnaHQgKEMpIDIwMTIgTm9raWEgQ29ycG9yYXRpb24gYW5k L29yIGl0cyBzdWJzaWRpYXJ5KC1pZXMpCiAgKgogICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29m dHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgpAQCAtMjQsNTAgKzI0LDM3IEBA CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotSGl0VGVzdExvY2F0aW9uOjpIaXRUZXN0TG9jYXRp b24oKQotICAgIDogbV9pc1JlY3RCYXNlZChmYWxzZSkKLSAgICAsIG1faXNSZWN0aWxpbmVhcih0 cnVlKQotewotfQorSGl0VGVzdExvY2F0aW9uOjpIaXRUZXN0TG9jYXRpb24oKSA9IGRlZmF1bHQ7 CiAKIEhpdFRlc3RMb2NhdGlvbjo6SGl0VGVzdExvY2F0aW9uKGNvbnN0IExheW91dFBvaW50JiBw b2ludCkKICAgICA6IG1fcG9pbnQocG9pbnQpCiAgICAgLCBtX2JvdW5kaW5nQm94KHJlY3RGb3JQ b2ludChwb2ludCwgMCwgMCwgMCwgMCkpCiAgICAgLCBtX3RyYW5zZm9ybWVkUG9pbnQocG9pbnQp CiAgICAgLCBtX3RyYW5zZm9ybWVkUmVjdChtX2JvdW5kaW5nQm94KQotICAgICwgbV9pc1JlY3RC YXNlZChmYWxzZSkKLSAgICAsIG1faXNSZWN0aWxpbmVhcih0cnVlKQogewogfQogCiBIaXRUZXN0 TG9jYXRpb246OkhpdFRlc3RMb2NhdGlvbihjb25zdCBGbG9hdFBvaW50JiBwb2ludCkKLSAgICA6 IG1fcG9pbnQoZmxvb3JlZExheW91dFBvaW50KHBvaW50KSkKLSAgICAsIG1fYm91bmRpbmdCb3go cmVjdEZvclBvaW50KG1fcG9pbnQsIDAsIDAsIDAsIDApKQotICAgICwgbV90cmFuc2Zvcm1lZFBv aW50KHBvaW50KQotICAgICwgbV90cmFuc2Zvcm1lZFJlY3QobV9ib3VuZGluZ0JveCkKLSAgICAs IG1faXNSZWN0QmFzZWQoZmFsc2UpCi0gICAgLCBtX2lzUmVjdGlsaW5lYXIodHJ1ZSkKKyAgICA6 IEhpdFRlc3RMb2NhdGlvbjo6SGl0VGVzdExvY2F0aW9uIHsgZmxvb3JlZExheW91dFBvaW50KHBv aW50KSB9CiB7CiB9CiAKIEhpdFRlc3RMb2NhdGlvbjo6SGl0VGVzdExvY2F0aW9uKGNvbnN0IEZs b2F0UG9pbnQmIHBvaW50LCBjb25zdCBGbG9hdFF1YWQmIHF1YWQpCi0gICAgOiBtX3RyYW5zZm9y bWVkUG9pbnQocG9pbnQpCi0gICAgLCBtX3RyYW5zZm9ybWVkUmVjdChxdWFkKQotICAgICwgbV9p c1JlY3RCYXNlZCh0cnVlKQorICAgIDogbV9wb2ludCB7IGZsb29yZWRMYXlvdXRQb2ludChwb2lu dCkgfQorICAgICwgbV9ib3VuZGluZ0JveCB7IHF1YWQuZW5jbG9zaW5nQm91bmRpbmdCb3goKSB9 CisgICAgLCBtX3RyYW5zZm9ybWVkUG9pbnQgeyBwb2ludCB9CisgICAgLCBtX3RyYW5zZm9ybWVk UmVjdCB7IHF1YWQgfQorICAgICwgbV9pc1JlY3RpbGluZWFyIHsgcXVhZC5pc1JlY3RpbGluZWFy KCkgfQogewotICAgIG1fcG9pbnQgPSBmbG9vcmVkTGF5b3V0UG9pbnQocG9pbnQpOwotICAgIG1f Ym91bmRpbmdCb3ggPSBlbmNsb3NpbmdJbnRSZWN0KHF1YWQuYm91bmRpbmdCb3goKSk7Ci0gICAg bV9pc1JlY3RpbGluZWFyID0gcXVhZC5pc1JlY3RpbGluZWFyKCk7CiB9CiAKIEhpdFRlc3RMb2Nh dGlvbjo6SGl0VGVzdExvY2F0aW9uKGNvbnN0IExheW91dFBvaW50JiBjZW50ZXJQb2ludCwgdW5z aWduZWQgdG9wUGFkZGluZywgdW5zaWduZWQgcmlnaHRQYWRkaW5nLCB1bnNpZ25lZCBib3R0b21Q YWRkaW5nLCB1bnNpZ25lZCBsZWZ0UGFkZGluZykKICAgICA6IG1fcG9pbnQoY2VudGVyUG9pbnQp CiAgICAgLCBtX2JvdW5kaW5nQm94KHJlY3RGb3JQb2ludChjZW50ZXJQb2ludCwgdG9wUGFkZGlu ZywgcmlnaHRQYWRkaW5nLCBib3R0b21QYWRkaW5nLCBsZWZ0UGFkZGluZykpCiAgICAgLCBtX3Ry YW5zZm9ybWVkUG9pbnQoY2VudGVyUG9pbnQpCisgICAgLCBtX3RyYW5zZm9ybWVkUmVjdChGbG9h dFF1YWQgeyBtX2JvdW5kaW5nQm94IH0pCiAgICAgLCBtX2lzUmVjdEJhc2VkKHRvcFBhZGRpbmcg fHwgcmlnaHRQYWRkaW5nIHx8IGJvdHRvbVBhZGRpbmcgfHwgbGVmdFBhZGRpbmcpCi0gICAgLCBt X2lzUmVjdGlsaW5lYXIodHJ1ZSkKIHsKLSAgICBtX3RyYW5zZm9ybWVkUmVjdCA9IEZsb2F0UXVh ZChtX2JvdW5kaW5nQm94KTsKIH0KIAogSGl0VGVzdExvY2F0aW9uOjpIaXRUZXN0TG9jYXRpb24o Y29uc3QgSGl0VGVzdExvY2F0aW9uJiBvdGhlciwgY29uc3QgTGF5b3V0U2l6ZSYgb2Zmc2V0KQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RMb2NhdGlvbi5oIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RMb2NhdGlvbi5oCmluZGV4IGQzNDMxYTgy OTZkYjU4OTk5MWRlMWJkM2JkOTQ1YjQxNDdiNDU4MjcuLmFkZjE0ZWY1ZTZhOWYxYTBhZjcxZTk3 MWMyZmQ2ZGU1MGE2MDE4ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9I aXRUZXN0TG9jYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdExv Y2F0aW9uLmgKQEAgLTIxLDExICsyMSw3IEBACiAKICNwcmFnbWEgb25jZQogCi0jaW5jbHVkZSAi RmxvYXRRdWFkLmgiCi0jaW5jbHVkZSAiRmxvYXRSZWN0LmgiCi0jaW5jbHVkZSAiTGF5b3V0UmVj dC5oIgogI2luY2x1ZGUgIlJvdW5kZWRSZWN0LmgiCi0jaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4K IAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC02NSwxOSArNjEsMTkgQEAgcHVibGljOgogICAg IGNvbnN0IEZsb2F0UXVhZCYgdHJhbnNmb3JtZWRSZWN0KCkgY29uc3QgeyByZXR1cm4gbV90cmFu c2Zvcm1lZFJlY3Q7IH0KIAogcHJpdmF0ZToKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBSZWN0VHlw ZT4KLSAgICBib29sIGludGVyc2VjdHNSZWN0KGNvbnN0IFJlY3RUeXBlJikgY29uc3Q7Ci0gICAg dm9pZCBtb3ZlKGNvbnN0IExheW91dFNpemUmIG9mZnNldCk7CisgICAgdGVtcGxhdGU8dHlwZW5h bWUgUmVjdFR5cGU+IGJvb2wgaW50ZXJzZWN0c1JlY3QoY29uc3QgUmVjdFR5cGUmKSBjb25zdDsK IAotICAgIC8vIFRoaXMgaXMgY2FjaGVkIGZvcm1zIG9mIHRoZSBtb3JlIGFjY3VyYXRlIHBvaW50 IGFuZCBhcmVhIGJlbG93LgorICAgIHZvaWQgbW92ZShjb25zdCBMYXlvdXRTaXplJik7CisKKyAg ICAvLyBUaGVzZSBhcmUgdGhlIGNhY2hlZCBmb3JtcyBvZiB0aGUgbW9yZSBhY2N1cmF0ZSBwb2lu dCBhbmQgcmVjdCBiZWxvdy4KICAgICBMYXlvdXRQb2ludCBtX3BvaW50OwogICAgIEludFJlY3Qg bV9ib3VuZGluZ0JveDsKIAogICAgIEZsb2F0UG9pbnQgbV90cmFuc2Zvcm1lZFBvaW50OwogICAg IEZsb2F0UXVhZCBtX3RyYW5zZm9ybWVkUmVjdDsKIAotICAgIGJvb2wgbV9pc1JlY3RCYXNlZDsK LSAgICBib29sIG1faXNSZWN0aWxpbmVhcjsKKyAgICBib29sIG1faXNSZWN0QmFzZWQgeyBmYWxz ZSB9OworICAgIGJvb2wgbV9pc1JlY3RpbGluZWFyIHsgdHJ1ZSB9OwogfTsKIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQo=