208251 2020-02-26 11:07:33 -0800 REGRESSION: (257410) [ macOS ] inspector/network/client-blocked-load.html is failing 2020-02-26 13:11:00 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206911 1 jacob_uphoff hi commit-queue hi inspector-bugzilla-changes timothy webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1623064 0 jacob_uphoff 2020-02-26 11:07:33 -0800 inspector/network/client-blocked-load.html is failing after commit r257410 on all of Mac OS 1623066 1 webkit-bug-importer 2020-02-26 11:07:53 -0800 <rdar://problem/59812765> 1623070 2 jacob_uphoff 2020-02-26 11:18:22 -0800 History: https://results.webkit.org/?suite=layout-tests&test=inspector%2Fnetwork%2Fclient-blocked-load.html 1623073 3 jacob_uphoff 2020-02-26 11:20:23 -0800 Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/inspector/network/client-blocked-load-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/inspector/network/client-blocked-load-actual.txt @@ -4,6 +4,8 @@ == Running test suite: ClientBlockedResourceLoad -- Running test case: TriggerBlockedResourceLoad PASS: Resource should be created. -PASS: Request url should be rewritten to the null string. +FAIL: Request url should be rewritten to the null string. + Expected: truthy + Actual: false PASS: Resource load should fail. 1623083 4 391761 hi 2020-02-26 11:30:25 -0800 Created attachment 391761 Patch 1623102 5 391761 timothy 2020-02-26 12:09:55 -0800 Comment on attachment 391761 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391761&action=review > Source/WebInspectorUI/UserInterface/Models/SourceCode.js:32 > + this._url = url; Could you use ?? Instead? 1623104 6 391761 hi 2020-02-26 12:27:29 -0800 Comment on attachment 391761 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391761&action=review >> Source/WebInspectorUI/UserInterface/Models/SourceCode.js:32 >> + this._url = url; > > Could you use ?? Instead? I could've, and initially I did just that :P For the reason listed in the ChangeLog, I'd prefer to avoid introducing a potential other bug by changing functionality. I think it's safer to just leave it as it was. 1623125 7 391761 commit-queue 2020-02-26 13:10:58 -0800 Comment on attachment 391761 Patch Clearing flags on attachment: 391761 Committed r257504: <https://trac.webkit.org/changeset/257504> 1623126 8 commit-queue 2020-02-26 13:11:00 -0800 All reviewed patches have been landed. Closing bug. 391761 2020-02-26 11:30:25 -0800 2020-02-26 13:10:58 -0800 Patch bug-208251-20200226113024.patch text/plain 1807 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQ2OTE0OTc3ZDViMmVlMjA5Yzg5NzUyN2RjNGZk NjM2MTk1NDdhYzEuLmFkYWViYmQ2ZmE2NTcyNmUyZGMyZjg0N2NhNzI2ZTkyMDI0ZTNiYWIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAyLTI2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiAoMjU3 NDEwKSBbIG1hY09TIF0gaW5zcGVjdG9yL25ldHdvcmsvY2xpZW50LWJsb2NrZWQtbG9hZC5odG1s IGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwODI1MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTk4MTI3NjU+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01v ZGVscy9Tb3VyY2VDb2RlLmpzOgorICAgICAgICAoV0kuU291cmNlQ29kZSk6CisgICAgICAgIFRo ZSB0ZXN0IGZhaWxlZCBiZWNhdXNlIGl0IGV4cGVjdGVkIGB1cmxgIHRvIGJlIGFuIGVtcHR5IHN0 cmluZyAoYCIiYCkgaW5zdGVhZCBvZiBgbnVsbGAuCisgICAgICAgIFVzZSB0aGUgZ2l2ZW4gYHVy bGAgcGFyYW1ldGVyIGV4YWN0bHkgYXMgcHJvdmlkZWQgaW5zdGVhZCBvZiB0cnlpbmcgdG8gYWRk IGEgZmFsbGJhY2sgaW4gdGhlCisgICAgICAgIGNhc2Ugb2YgYSBmYWxzeSB2YWx1ZS4gR2l2ZW4g dGhlIHByZXZhbGVuY2Ugb2YgdXNhZ2Ugb2YgYFdJLlNvdXJjZUNvZGVgLCBpdCdzIGJldHRlciB0 bworICAgICAgICBtYXRjaCB0aGUgZXhpc3RpbmcgYmVoYXZpb3Igb2YgYmVmb3JlIHIyNTc0MTAg dGhhbiBjaGFuZ2UgaXQgYW5kIHJpc2sgb3RoZXIgc3VidGxlIGJ1Z3MuCisKIDIwMjAtMDItMjUg IERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHNhZmFyaSBhcHAgZXh0ZW5zaW9uIGlzb2xhdGVkIHdvcmxkcyBhbmQgaW5qZWN0ZWQgZmls ZXMgdXNlIHRoZSBleHRlbnNpb24ncyBpZGVudGlmaWVyIGluc3RlYWQgb2YgaXRzIG5hbWUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Tb3Vy Y2VDb2RlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1Nv dXJjZUNvZGUuanMKaW5kZXggOGNlN2I1OGExMzQ4YWY5MzkwMTgzODg2ZWQ4NDlmMDRkNmFhMzZi ZC4uYTE4ZmU4N2U3MjUwMDlkYTA2ODBjZTcxNzUzN2RjODZiZmQ1N2IxNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJjZUNvZGUuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJjZUNv ZGUuanMKQEAgLTI5LDcgKzI5LDcgQEAgV0kuU291cmNlQ29kZSA9IGNsYXNzIFNvdXJjZUNvZGUg ZXh0ZW5kcyBXSS5PYmplY3QKICAgICB7CiAgICAgICAgIHN1cGVyKCk7CiAKLSAgICAgICAgdGhp cy5fdXJsID0gdXJsIHx8IG51bGw7CisgICAgICAgIHRoaXMuX3VybCA9IHVybDsKICAgICAgICAg dGhpcy5fdXJsQ29tcG9uZW50cyA9IG51bGw7CiAKICAgICAgICAgdGhpcy5fb3JpZ2luYWxSZXZp c2lvbiA9IG5ldyBXSS5Tb3VyY2VDb2RlUmV2aXNpb24odGhpcyk7Cg==