208242 2020-02-26 07:13:54 -0800 GPUProcess should be made aware of device orientation for correct video capture frame rotation computation 2020-02-26 09:42:25 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson simon.fraser webkit-bug-importer youennf oldest_to_newest 1622992 0 youennf 2020-02-26 07:13:54 -0800 GPUProcess should be made aware of device orientation for correct video capture frame rotation computation 1622993 1 391746 youennf 2020-02-26 07:24:44 -0800 Created attachment 391746 Patch 1622994 2 webkit-bug-importer 2020-02-26 07:25:10 -0800 <rdar://problem/59804921> 1623027 3 391746 commit-queue 2020-02-26 09:15:52 -0800 Comment on attachment 391746 Patch Clearing flags on attachment: 391746 Committed r257478: <https://trac.webkit.org/changeset/257478> 1623028 4 commit-queue 2020-02-26 09:15:53 -0800 All reviewed patches have been landed. Closing bug. 1623034 5 391746 simon.fraser 2020-02-26 09:42:25 -0800 Comment on attachment 391746 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391746&action=review > Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h:78 > + void setOrientationForMediaCapture(uint64_t orientation); Why does orientation need 64 bits instead of 2? 391746 2020-02-26 07:24:44 -0800 2020-02-26 09:15:52 -0800 Patch bug-208242-20200226162443.patch text/plain 7406 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcwNGZmNTFhZTRmNDg4YTM0 YzlkOWMyMzBlMWUxNGI0MjNmMTkzNTkuLmY1MmNlMTFhMjhkNzk3NjIwZTljZjc4Mzg2MmU3OWNm MzFjNTc0OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjAtMDItMjYgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIEdQVVByb2Nlc3Mgc2hvdWxkIGJl IG1hZGUgYXdhcmUgb2YgZGV2aWNlIG9yaWVudGF0aW9uIGZvciBjb3JyZWN0IHZpZGVvIGNhcHR1 cmUgZnJhbWUgcm90YXRpb24gY29tcHV0YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODI0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFBpcGUgb3JpZW50YXRpb24gaW5mb3JtYXRpb24gdG8gR1BV UHJvY2VzcyB3aGVuZXZlciBhIHBhZ2UgaGFzIGEgdXNlciBtZWRpYSBjYXB0dXJlIG1hbmFnZXIg cHJveHkuCisgICAgICAgIFRoaXMgaXMgdXNlZCBieSBBVlZpZGVvQ2FwdHVyZVNvdXJjZSB0byBj b21wdXRlIHRoZSBjb3JyZWN0IHZpZGVvIHNhbXBsZSByb3RhdGlvbiB2YWx1ZS4KKyAgICAgICAg TWFudWFsbHkgdGVzdGVkLgorCisgICAgICAgICogR1BVUHJvY2Vzcy9HUFVDb25uZWN0aW9uVG9X ZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6R1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vz czo6c2V0T3JpZW50YXRpb25Gb3JNZWRpYUNhcHR1cmUpOgorICAgICAgICAqIEdQVVByb2Nlc3Mv R1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5oOgorICAgICAgICAqIEdQVVByb2Nlc3MvR1BVUHJv Y2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OkdQVVByb2Nlc3M6OnNldE1vY2tDYXB0dXJlRGV2 aWNlc0VuYWJsZWQpOgorICAgICAgICAoV2ViS2l0OjpHUFVQcm9jZXNzOjpzZXRPcmllbnRhdGlv bkZvck1lZGlhQ2FwdHVyZSk6CisgICAgICAgICogR1BVUHJvY2Vzcy9HUFVQcm9jZXNzLmg6Cisg ICAgICAgICogR1BVUHJvY2Vzcy9HUFVQcm9jZXNzLm1lc3NhZ2VzLmluOgorICAgICAgICAqIFVJ UHJvY2Vzcy9HUFUvR1BVUHJvY2Vzc1Byb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6R1BVUHJv Y2Vzc1Byb3h5OjpzZXRPcmllbnRhdGlvbkZvck1lZGlhQ2FwdHVyZSk6CisgICAgICAgICogVUlQ cm9jZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcDoKKwogMjAyMC0wMi0yNiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5j b20+CiAKICAgICAgICAgQ29udmVyc2lvbiBiZXR3ZWVuIE1lZGlhU2FtcGxlIGFuZCBSZW1vdGVW aWRlb1NhbXBsZSBzaG91bGQgcHJlc2VydmUgdGhlIHJvdGF0aW9uIGluZm9ybWF0aW9uCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vz cy5jcHAgYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vz cy5jcHAKaW5kZXggZDhjZjAyOWQzOWMwMzFiZjRjYjNkMGY4ZTVmYmQ1MTM4NTVlMDY5Yy4uNzM3 MjdjMWJhNzMyMzExZWM5YzA2YTFhM2M0ZWY2N2NhMGVjZTE5YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9HUFVQcm9jZXNzL0dQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcApAQCAt MzAwLDYgKzMwMCwxMyBAQCB2b2lkIEdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnVwZGF0ZVNl c3Npb25TdGF0ZSgpCiAgICAgICAgIG1fc2Vzc2lvbk1hbmFnZXItPnVwZGF0ZVNlc3Npb25TdGF0 ZSgpOwogfQogCisjaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKK3ZvaWQgR1BVQ29ubmVjdGlvblRv V2ViUHJvY2Vzczo6c2V0T3JpZW50YXRpb25Gb3JNZWRpYUNhcHR1cmUodWludDY0X3Qgb3JpZW50 YXRpb24pCit7CisgICAgdXNlck1lZGlhQ2FwdHVyZU1hbmFnZXJQcm94eSgpLnNldE9yaWVudGF0 aW9uKG9yaWVudGF0aW9uKTsKK30KKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAog I2VuZGlmIC8vIEVOQUJMRShHUFVfUFJPQ0VTUykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv R1BVUHJvY2Vzcy9HUFVDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmggYi9Tb3VyY2UvV2ViS2l0L0dQ VVByb2Nlc3MvR1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5oCmluZGV4IGI1YWQ5YWE2ZmEwOWVi NjU4MWNmODRkZjZhZGU1MzM0OTljNzI2MWMuLjc3NDAxYTM3YjIwNzIyN2MxMjUyNThkZWYzNzE0 NDNlODViNTBjOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVDb25u ZWN0aW9uVG9XZWJQcm9jZXNzLmgKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL0dQVUNv bm5lY3Rpb25Ub1dlYlByb2Nlc3MuaApAQCAtNzQsNiArNzQsMTAgQEAgcHVibGljOgogICAgIGNv bnN0IFN0cmluZyYgbWVkaWFLZXlzU3RvcmFnZURpcmVjdG9yeSgpIGNvbnN0OwogI2VuZGlmCiAK KyNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQorICAgIHZvaWQgc2V0T3JpZW50YXRpb25Gb3JNZWRp YUNhcHR1cmUodWludDY0X3Qgb3JpZW50YXRpb24pOworI2VuZGlmCisKICAgICBXZWJDb3JlOjpQ bGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXImIHNlc3Npb25NYW5hZ2VyKCk7CiAKIHByaXZhdGU6 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vzcy5jcHAgYi9T b3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vzcy5jcHAKaW5kZXggZmZiZWVjMWM5YmNh NzA5YTYwYzEwZDc4NDI3ODE3M2ZjYzlkMjQ4Yy4uY2Y0NDA5M2ZiNTMzNzgwZTQ5ZjQ0NGJiNTZm MWVhZjg1MGFjYWNmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL0dQVVBy b2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVQcm9jZXNzLmNwcApA QCAtMTU2LDEzICsxNTYsMTkgQEAgR1BVQ29ubmVjdGlvblRvV2ViUHJvY2VzcyogR1BVUHJvY2Vz czo6d2ViUHJvY2Vzc0Nvbm5lY3Rpb24oUHJvY2Vzc0lkZW50aWZpZXIgaWQKICAgICByZXR1cm4g bV93ZWJQcm9jZXNzQ29ubmVjdGlvbnMuZ2V0KGlkZW50aWZpZXIpOwogfQogCisjaWYgRU5BQkxF KE1FRElBX1NUUkVBTSkKIHZvaWQgR1BVUHJvY2Vzczo6c2V0TW9ja0NhcHR1cmVEZXZpY2VzRW5h YmxlZChib29sIGlzRW5hYmxlZCkKIHsKLSNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQogICAgIE1v Y2tSZWFsdGltZU1lZGlhU291cmNlQ2VudGVyOjpzZXRNb2NrUmVhbHRpbWVNZWRpYVNvdXJjZUNl bnRlckVuYWJsZWQoaXNFbmFibGVkKTsKLSNlbmRpZgogfQogCit2b2lkIEdQVVByb2Nlc3M6OnNl dE9yaWVudGF0aW9uRm9yTWVkaWFDYXB0dXJlKHVpbnQ2NF90IG9yaWVudGF0aW9uKQoreworICAg IGZvciAoYXV0byYgY29ubmVjdGlvbiA6IG1fd2ViUHJvY2Vzc0Nvbm5lY3Rpb25zLnZhbHVlcygp KQorICAgICAgICBjb25uZWN0aW9uLT5zZXRPcmllbnRhdGlvbkZvck1lZGlhQ2FwdHVyZShvcmll bnRhdGlvbik7Cit9CisjZW5kaWYKKwogdm9pZCBHUFVQcm9jZXNzOjphZGRTZXNzaW9uKFBBTDo6 U2Vzc2lvbklEIHNlc3Npb25JRCwgR1BVUHJvY2Vzc1Nlc3Npb25QYXJhbWV0ZXJzJiYgcGFyYW1l dGVycykKIHsKICAgICBBU1NFUlQoIW1fc2Vzc2lvbnMuY29udGFpbnMoc2Vzc2lvbklEKSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vzcy5oIGIvU291cmNl L1dlYktpdC9HUFVQcm9jZXNzL0dQVVByb2Nlc3MuaAppbmRleCBmYTIxYWUwMjFkMzA1YjYzNDk2 ODhlN2U0YWM5OWI0ZTMzMzhiMmQ1Li45MjgzOGUyY2IzYTVlMzU4OGEyNGQ1ODBmYmFhZGFjYTVi OTBhOTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vzcy5o CisrKyBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVQcm9jZXNzLmgKQEAgLTgzLDcgKzgz LDEwIEBAIHByaXZhdGU6CiAKICAgICB2b2lkIHByb2Nlc3NEaWRUcmFuc2l0aW9uVG9Gb3JlZ3Jv dW5kKCk7CiAgICAgdm9pZCBwcm9jZXNzRGlkVHJhbnNpdGlvblRvQmFja2dyb3VuZCgpOworI2lm IEVOQUJMRShNRURJQV9TVFJFQU0pCiAgICAgdm9pZCBzZXRNb2NrQ2FwdHVyZURldmljZXNFbmFi bGVkKGJvb2wpOworICAgIHZvaWQgc2V0T3JpZW50YXRpb25Gb3JNZWRpYUNhcHR1cmUodWludDY0 X3Qgb3JpZW50YXRpb24pOworI2VuZGlmCiAKICAgICAvLyBDb25uZWN0aW9ucyB0byBXZWJQcm9j ZXNzZXMuCiAgICAgSGFzaE1hcDxXZWJDb3JlOjpQcm9jZXNzSWRlbnRpZmllciwgUmVmPEdQVUNv bm5lY3Rpb25Ub1dlYlByb2Nlc3M+PiBtX3dlYlByb2Nlc3NDb25uZWN0aW9uczsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVQcm9jZXNzLm1lc3NhZ2VzLmluIGIvU291 cmNlL1dlYktpdC9HUFVQcm9jZXNzL0dQVVByb2Nlc3MubWVzc2FnZXMuaW4KaW5kZXggNGQ3Nzk5 YmZjNDQ5OTQxOGJhZGFkNmE3MDYyNjgyNzg5ZGM5ZWEyNC4uNzc2YzhlODA4Mzc2NWNjYmE4MWQ5 ODY4NzNiZDg1MDZlNzIzZmEzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNz L0dQVVByb2Nlc3MubWVzc2FnZXMuaW4KKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL0dQ VVByb2Nlc3MubWVzc2FnZXMuaW4KQEAgLTM3LDYgKzM3LDcgQEAgbWVzc2FnZXMgLT4gR1BVUHJv Y2VzcyB7CiAKICNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQogICAgIFNldE1vY2tDYXB0dXJlRGV2 aWNlc0VuYWJsZWQoYm9vbCBpc0VuYWJsZWQpCisgICAgU2V0T3JpZW50YXRpb25Gb3JNZWRpYUNh cHR1cmUodWludDY0X3Qgb3JpZW50YXRpb24pOwogI2VuZGlmCiB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvR1BVL0dQVVByb2Nlc3NQcm94eS5jcHAKaW5kZXggY2MxMzkyODhlMTc2 N2NkZDVhZTNjZDRkNzA4MjU4NWNhZjI2NDdlZC4uOWIwOGYzMjRhZDg4NTYxNWRhOWY1OThiZWYx MTc1ZDdmMzE1YWNiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvR1BVL0dQ VVByb2Nlc3NQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvR1BVL0dQVVBy b2Nlc3NQcm94eS5jcHAKQEAgLTE0Niw2ICsxNDYsMTQgQEAgdm9pZCBHUFVQcm9jZXNzUHJveHk6 OnNldFVzZU1vY2tDYXB0dXJlRGV2aWNlcyhib29sIHZhbHVlKQogICAgIG1fdXNlTW9ja0NhcHR1 cmVEZXZpY2VzID0gdmFsdWU7CiAgICAgc2VuZChNZXNzYWdlczo6R1BVUHJvY2Vzczo6U2V0TW9j a0NhcHR1cmVEZXZpY2VzRW5hYmxlZCB7IG1fdXNlTW9ja0NhcHR1cmVEZXZpY2VzIH0sIDApOwog fQorCit2b2lkIEdQVVByb2Nlc3NQcm94eTo6c2V0T3JpZW50YXRpb25Gb3JNZWRpYUNhcHR1cmUo dWludDY0X3Qgb3JpZW50YXRpb24pCit7CisgICAgaWYgKG1fb3JpZW50YXRpb24gPT0gb3JpZW50 YXRpb24pCisgICAgICAgIHJldHVybjsKKyAgICBtX29yaWVudGF0aW9uID0gb3JpZW50YXRpb247 CisgICAgc2VuZChNZXNzYWdlczo6R1BVUHJvY2Vzczo6U2V0T3JpZW50YXRpb25Gb3JNZWRpYUNh cHR1cmUgeyBvcmllbnRhdGlvbiB9LCAwKTsKK30KICNlbmRpZgogCiB2b2lkIEdQVVByb2Nlc3NQ cm94eTo6Z2V0TGF1bmNoT3B0aW9ucyhQcm9jZXNzTGF1bmNoZXI6OkxhdW5jaE9wdGlvbnMmIGxh dW5jaE9wdGlvbnMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9HUFUvR1BV UHJvY2Vzc1Byb3h5LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9HUFUvR1BVUHJvY2Vzc1By b3h5LmgKaW5kZXggYmM1NzYyY2ZmNzU1YmI3OGJlNGM1YWQ5MTUxN2E1M2U0ZWY3MDMzZS4uZGY4 YzExNTQ0YjU3MDZmNDlkZTQ2MGNjZDM1NjA4M2RmZTNhMzAzYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvR1BVL0dQVVByb2Nlc3NQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuaApAQCAtNjEsNiArNjEsNyBAQCBwdWJs aWM6CiAKICNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQogICAgIHZvaWQgc2V0VXNlTW9ja0NhcHR1 cmVEZXZpY2VzKGJvb2wpOworICAgIHZvaWQgc2V0T3JpZW50YXRpb25Gb3JNZWRpYUNhcHR1cmUo dWludDY0X3Qgb3JpZW50YXRpb24pOwogI2VuZGlmCiAKICAgICB2b2lkIHJlbW92ZVNlc3Npb24o UEFMOjpTZXNzaW9uSUQpOwpAQCAtMTA3LDYgKzEwOCw3IEBAIHByaXZhdGU6CiAgICAgUHJvY2Vz c1Rocm90dGxlcjo6QWN0aXZpdHlWYXJpYW50IG1fYWN0aXZpdHlGcm9tV2ViUHJvY2Vzc2VzOwog I2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCiAgICAgYm9vbCBtX3VzZU1vY2tDYXB0dXJlRGV2aWNl cyB7IGZhbHNlIH07CisgICAgdWludDY0X3QgbV9vcmllbnRhdGlvbiB7IDAgfTsKICNlbmRpZgog ICAgIEhhc2hTZXQ8UEFMOjpTZXNzaW9uSUQ+IG1fc2Vzc2lvbklEczsKIH07CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCAwMWRjYzRiMzUwYzAzNjEzZjBkZTNh NDI1MGFlMjUxOTljMWQ1MDQyLi44ZGZlY2MzZmQ3MjQwOGIyNTEwNjRmMzExMDQxNjE0ZWNlMTVm MTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTk5MDks NiArOTkwOSw5IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpzZXRPcmllbnRhdGlvbkZvck1lZGlhQ2Fw dHVyZSh1aW50NjRfdCBvcmllbnRhdGlvbikKICNpZiBQTEFURk9STShDT0NPQSkgJiYgRU5BQkxF KE1FRElBX1NUUkVBTSkKICAgICBpZiAoYXV0byogcHJveHkgPSBtX3Byb2Nlc3MtPnVzZXJNZWRp YUNhcHR1cmVNYW5hZ2VyUHJveHkoKSkKICAgICAgICAgcHJveHktPnNldE9yaWVudGF0aW9uKG9y aWVudGF0aW9uKTsKKworICAgIGlmIChwcmVmZXJlbmNlcygpLmNhcHR1cmVWaWRlb0luR1BVUHJv Y2Vzc0VuYWJsZWQoKSkKKyAgICAgICAgR1BVUHJvY2Vzc1Byb3h5OjpzaW5nbGV0b24oKS5zZXRP cmllbnRhdGlvbkZvck1lZGlhQ2FwdHVyZShvcmllbnRhdGlvbik7CiAjZW5kaWYKIH0KIAo=