208241 2020-02-26 05:54:37 -0800 REGRESSION(r257299): [GTK] Test fast/forms/menulist-restrict-line-height.html is failing since r257299 2020-02-28 01:33:25 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply esprehn+autocc ews-watchlist glenn kondapallykalyan lmoura pdr oldest_to_newest 1622982 0 cgarcia 2020-02-26 05:54:37 -0800 We should not honor line-height for styled combo buttons. 1622983 1 391744 cgarcia 2020-02-26 06:01:18 -0800 Created attachment 391744 Patch 1623912 2 cgarcia 2020-02-28 01:33:25 -0800 Committed r257628: <https://trac.webkit.org/changeset/257628> 391744 2020-02-26 06:01:18 -0800 2020-02-26 06:06:08 -0800 Patch wk-combo-line-height.diff text/plain 2604 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZDlhOTEyMjgzNS4uNmQ5OGVmZmFhZWIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wMi0yNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjU3Mjk5KTogW0dUS10gVGVzdCBmYXN0 L2Zvcm1zL21lbnVsaXN0LXJlc3RyaWN0LWxpbmUtaGVpZ2h0Lmh0bWwgaXMgZmFpbGluZyBzaW5j ZSByMjU3Mjk5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDgyNDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXZSBzaG91bGQgbm90IGhvbm9yIGxpbmUtaGVpZ2h0IGZvciBzdHlsZWQgY29tYm8gYnV0dG9u cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUFkd2FpdGEuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVBZHdhaXRhOjphZGp1c3RNZW51TGlzdFN0eWxlIGNvbnN0 KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQWR3YWl0YTo6YWRqdXN0TWVudUxpc3RC dXR0b25TdHlsZSBjb25zdCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQWR3YWl0 YS5oOgorCiAyMDIwLTAyLTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNTcyOTkpOiBbR1RLXSBib3ggc2hhZG93IGlz IG5vIGxvbmdlciBpZ25vcmVkIGZvciBzZWFyY2ggZmllbGQgZGVjb3JhdGlvbnMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUFkd2FpdGEuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQWR3YWl0YS5jcHAKaW5kZXggNzI4MmVm ZWE4NzIuLjc3NTQ2ZTAwMmUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGhlbWVBZHdhaXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWVBZHdhaXRhLmNwcApAQCAtMjQ2LDYgKzI0NiwxNiBAQCBib29sIFJlbmRlclRoZW1l QWR3YWl0YTo6cGFpbnRTZWFyY2hGaWVsZChjb25zdCBSZW5kZXJPYmplY3QmIHJlbmRlck9iamVj dCwgY29ucwogICAgIHJldHVybiBwYWludFRleHRGaWVsZChyZW5kZXJPYmplY3QsIHBhaW50SW5m bywgcmVjdCk7CiB9CiAKK3ZvaWQgUmVuZGVyVGhlbWVBZHdhaXRhOjphZGp1c3RNZW51TGlzdFN0 eWxlKFJlbmRlclN0eWxlJiBzdHlsZSwgY29uc3QgRWxlbWVudCopIGNvbnN0Cit7CisgICAgc3R5 bGUuc2V0TGluZUhlaWdodChSZW5kZXJTdHlsZTo6aW5pdGlhbExpbmVIZWlnaHQoKSk7Cit9CisK K3ZvaWQgUmVuZGVyVGhlbWVBZHdhaXRhOjphZGp1c3RNZW51TGlzdEJ1dHRvblN0eWxlKFJlbmRl clN0eWxlJiBzdHlsZSwgY29uc3QgRWxlbWVudCogZWxlbWVudCkgY29uc3QKK3sKKyAgICBhZGp1 c3RNZW51TGlzdFN0eWxlKHN0eWxlLCBlbGVtZW50KTsKK30KKwogTGVuZ3RoQm94IFJlbmRlclRo ZW1lQWR3YWl0YTo6cG9wdXBJbnRlcm5hbFBhZGRpbmdCb3goY29uc3QgUmVuZGVyU3R5bGUmIHN0 eWxlKSBjb25zdAogewogICAgIGlmIChzdHlsZS5hcHBlYXJhbmNlKCkgPT0gTm9Db250cm9sUGFy dCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUFkd2Fp dGEuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUFkd2FpdGEuaAppbmRl eCBlMjFjYzI3NTEwYi4uZWM2ODQwZGQxODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUaGVtZUFkd2FpdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWVBZHdhaXRhLmgKQEAgLTYyLDYgKzYyLDggQEAgcHJpdmF0ZToKICAgICBi b29sIHBhaW50U2VhcmNoRmllbGQoY29uc3QgUmVuZGVyT2JqZWN0JiwgY29uc3QgUGFpbnRJbmZv JiwgY29uc3QgSW50UmVjdCYpIGZpbmFsOwogCiAgICAgYm9vbCBwb3BzTWVudUJ5U3BhY2VPclJl dHVybigpIGNvbnN0IGZpbmFsIHsgcmV0dXJuIHRydWU7IH0KKyAgICB2b2lkIGFkanVzdE1lbnVM aXN0U3R5bGUoUmVuZGVyU3R5bGUmLCBjb25zdCBFbGVtZW50KikgY29uc3Q7CisgICAgdm9pZCBh ZGp1c3RNZW51TGlzdEJ1dHRvblN0eWxlKFJlbmRlclN0eWxlJiwgY29uc3QgRWxlbWVudCopIGNv bnN0OwogICAgIExlbmd0aEJveCBwb3B1cEludGVybmFsUGFkZGluZ0JveChjb25zdCBSZW5kZXJT dHlsZSYpIGNvbnN0IGZpbmFsOwogICAgIGJvb2wgcGFpbnRNZW51TGlzdChjb25zdCBSZW5kZXJP YmplY3QmLCBjb25zdCBQYWludEluZm8mLCBjb25zdCBGbG9hdFJlY3QmKSBmaW5hbDsKICAgICBi b29sIHBhaW50TWVudUxpc3RCdXR0b25EZWNvcmF0aW9ucyhjb25zdCBSZW5kZXJCb3gmLCBjb25z dCBQYWludEluZm8mLCBjb25zdCBGbG9hdFJlY3QmKSBmaW5hbDsK