208234 2020-02-26 04:29:50 -0800 [GStreamer] Correctly remove webvttenc on WebKitTextCombiner pad release 2020-02-26 06:45:36 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris cgarcia commit-queue ews-watchlist gustavo menard pnormand vjaquez oldest_to_newest 1622956 0 aboya 2020-02-26 04:29:50 -0800 The implementation of webkitTextCombinerReleasePad() was wrong in that it was checking the peer pad of webkittextcombinerpad to check if it belonged a webvttenc element and remove it... But since this is a ghostpad, the peer is upstream, not downstream. When the release pad function is called, upstream is already disconnected, so the branch was never hit. To actually remove the webvttenc element we must check the target pad instead of the peer pad, which corresponds to the element downstream. Also, we need to set the element state to NULL before removing it, which the previous code didn't. 1622957 1 391735 aboya 2020-02-26 04:32:32 -0800 Created attachment 391735 Patch 1622987 2 391735 commit-queue 2020-02-26 06:45:34 -0800 Comment on attachment 391735 Patch Clearing flags on attachment: 391735 Committed r257468: <https://trac.webkit.org/changeset/257468> 1622988 3 commit-queue 2020-02-26 06:45:36 -0800 All reviewed patches have been landed. Closing bug. 391735 2020-02-26 04:32:32 -0800 2020-02-26 06:45:34 -0800 Patch bug-208234-20200226133231.patch text/plain 2800 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGYxMjA4ZmFhMjNiNmZk ZjcxM2MyYzU3OWMzODcyMmY4MjhlOGNiMi4uODE2ZDI0MWViMDFjMjFlYWE5NjI3YjA3YzQ1ZDI4 ODI5MzBhNWE3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTAyLTI2ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBDb3JyZWN0bHkgcmVtb3ZlIHdlYnZ0dGVuYyBvbiBXZWJLaXRUZXh0Q29tYmluZXIgcGFkIHJl bGVhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw ODIzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBpbXBsZW1lbnRhdGlvbiBvZiB3ZWJraXRUZXh0Q29tYmluZXJSZWxlYXNlUGFkKCkgd2FzIHdy b25nIGluIHRoYXQKKyAgICAgICAgaXQgd2FzIGNoZWNraW5nIHRoZSBwZWVyIHBhZCBvZiB3ZWJr aXR0ZXh0Y29tYmluZXJwYWQgdG8gY2hlY2sgaWYgaXQKKyAgICAgICAgYmVsb25nZWQgYSB3ZWJ2 dHRlbmMgZWxlbWVudCBhbmQgcmVtb3ZlIGl0Li4uIEJ1dCBzaW5jZSB0aGlzIGlzIGEKKyAgICAg ICAgZ2hvc3RwYWQsIHRoZSBwZWVyIGlzIHVwc3RyZWFtLCBub3QgZG93bnN0cmVhbS4gV2hlbiB0 aGUgcmVsZWFzZSBwYWQKKyAgICAgICAgZnVuY3Rpb24gaXMgY2FsbGVkLCB1cHN0cmVhbSBpcyBh bHJlYWR5IGRpc2Nvbm5lY3RlZCwgc28gdGhlIGJyYW5jaAorICAgICAgICB3YXMgbmV2ZXIgaGl0 LgorCisgICAgICAgIFRvIGFjdHVhbGx5IHJlbW92ZSB0aGUgd2VidnR0ZW5jIGVsZW1lbnQgd2Ug bXVzdCBjaGVjayB0aGUgdGFyZ2V0IHBhZAorICAgICAgICBpbnN0ZWFkIG9mIHRoZSBwZWVyIHBh ZCwgd2hpY2ggY29ycmVzcG9uZHMgdG8gdGhlIGVsZW1lbnQgZG93bnN0cmVhbS4KKyAgICAgICAg QWxzbywgd2UgbmVlZCB0byBzZXQgdGhlIGVsZW1lbnQgc3RhdGUgdG8gTlVMTCBiZWZvcmUgcmVt b3ZpbmcgaXQsCisgICAgICAgIHdoaWNoIHRoZSBwcmV2aW91cyBjb2RlIGRpZG4ndC4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJHU3RyZWFtZXIu Y3BwOgorICAgICAgICAod2Via2l0VGV4dENvbWJpbmVyUmVsZWFzZVBhZCk6CisKIDIwMjAtMDIt MjEgIEFsaWNpYSBCb3lhIEdhcmPDrWEgIDxhYm95YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtH U3RyZWFtZXJdIFVucmV2aWV3ZWQgR1N0cmVhbWVyIDEuMTQgZml4IGZvciBUZXh0Q29tYmluZXJH U3RyZWFtZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9UZXh0Q29tYmluZXJHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1RleHRDb21iaW5lckdTdHJlYW1lci5jcHAKaW5kZXggNWRi NjVjNzFhZDlhM2Y3MDJkZjIxZmU3OTNkNjRjZWVjMzlmNWJkNC4uNjY0MjEyNmQyMTc2M2M3MmVm Njk3ZjAyMjJiNzhjMmJkYmViZjUwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1RleHRDb21iaW5lckdTdHJlYW1lci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1RleHRDb21iaW5lckdTdHJl YW1lci5jcHAKQEAgLTI0MywxMSArMjQzLDEzIEBAIHN0YXRpYyB2b2lkIHdlYmtpdFRleHRDb21i aW5lclJlbGVhc2VQYWQoR3N0RWxlbWVudCAqZWxlbWVudCwgR3N0UGFkICpwYWQpCiAgICAgV2Vi S2l0VGV4dENvbWJpbmVyKiBjb21iaW5lciA9IFdFQktJVF9URVhUX0NPTUJJTkVSKGVsZW1lbnQp OwogICAgIFdlYktpdFRleHRDb21iaW5lclBhZCogY29tYmluZXJQYWQgPSBXRUJLSVRfVEVYVF9D T01CSU5FUl9QQUQocGFkKTsKIAotICAgIGlmIChHUmVmUHRyPEdzdFBhZD4gcGVlciA9IGFkb3B0 R1JlZihnc3RfcGFkX2dldF9wZWVyKHBhZCkpKSB7Ci0gICAgICAgIEdSZWZQdHI8R3N0RWxlbWVu dD4gcGFyZW50ID0gYWRvcHRHUmVmKGdzdF9wYWRfZ2V0X3BhcmVudF9lbGVtZW50KHBlZXIuZ2V0 KCkpKTsKKyAgICBpZiAoR1JlZlB0cjxHc3RQYWQ+IHRhcmdldCA9IGFkb3B0R1JlZihnc3RfZ2hv c3RfcGFkX2dldF90YXJnZXQoR1NUX0dIT1NUX1BBRChwYWQpKSkpIHsKKyAgICAgICAgR1JlZlB0 cjxHc3RFbGVtZW50PiBwYXJlbnQgPSBhZG9wdEdSZWYoZ3N0X3BhZF9nZXRfcGFyZW50X2VsZW1l bnQodGFyZ2V0LmdldCgpKSk7CiAgICAgICAgIEFTU0VSVChwYXJlbnQpOwotICAgICAgICBpZiAo R19UWVBFX0ZST01fSU5TVEFOQ0UocGFyZW50LmdldCgpKSA9PSB3ZWJWVFRFbmNUeXBlKQorICAg ICAgICBpZiAoR19UWVBFX0ZST01fSU5TVEFOQ0UocGFyZW50LmdldCgpKSA9PSB3ZWJWVFRFbmNU eXBlKSB7CisgICAgICAgICAgICBnc3RfZWxlbWVudF9zZXRfc3RhdGUocGFyZW50LmdldCgpLCBH U1RfU1RBVEVfTlVMTCk7CiAgICAgICAgICAgICBnc3RfYmluX3JlbW92ZShHU1RfQklOKGNvbWJp bmVyKSwgcGFyZW50LmdldCgpKTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIGdzdF9lbGVtZW50 X3JlbGVhc2VfcmVxdWVzdF9wYWQoY29tYmluZXItPmZ1bm5lbCwgY29tYmluZXJQYWQtPmZ1bm5l bFBhZCk7Cg==