208230 2020-02-25 19:09:34 -0800 [LFC][IFC][Floats] ASSERT(committedInlineItemCount || line.hasIntrusiveFloat()) in LineLayoutContext::close 2020-02-26 07:05:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1622887 0 zalan 2020-02-25 19:09:34 -0800 Let's fix it. 1622888 1 webkit-bug-importer 2020-02-25 19:09:50 -0800 <rdar://problem/59791249> 1622890 2 391717 zalan 2020-02-25 19:20:14 -0800 Created attachment 391717 Patch 1622990 3 391717 commit-queue 2020-02-26 07:05:19 -0800 Comment on attachment 391717 Patch Clearing flags on attachment: 391717 Committed r257469: <https://trac.webkit.org/changeset/257469> 1622991 4 commit-queue 2020-02-26 07:05:20 -0800 All reviewed patches have been landed. Closing bug. 391717 2020-02-25 19:20:14 -0800 2020-02-26 07:05:19 -0800 Patch bug-208230-20200225192013.patch text/plain 7505 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3Mzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY1NTZlY2M2ODA5ZWE4 YmMwZmFkMTQ0ZDE1ODY5MzVmNTVhZGJiOC4uZWI3YzNiNGM2NmU2OGMxNzdkZmFkY2Q4ZWIyODY3 ODA4YTlmNzllNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTAyLTI1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXVtGbG9hdHNd IEFTU0VSVChjb21taXR0ZWRJbmxpbmVJdGVtQ291bnQgfHwgbGluZS5oYXNJbnRydXNpdmVGbG9h dCgpKSBpbiBMaW5lTGF5b3V0Q29udGV4dDo6Y2xvc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODIzMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NTk3OTEyNDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGVzdDogZmFzdC9sYXlvdXRmb3JtYXR0aW5nY29udGV4dC9mbG9hdC1hbmQtYnItaW5saW5l LWNvbnRlbnQtb25seS5odG1sCisKKyAgICAgICAgRXhwYW5kIHRoZSBBU1NFUlQgdG8gaW5jbHVk ZSBhbGwgdGhlIHZhbGlkIGNhc2VzCisgICAgICAgIDEuIElubGluZSBjb250ZW50IGlzIGFkZGVk IHRvIHRoZSBsaW5lCisgICAgICAgIDIuIE9ubHkgZmxvYXQocykgZ290IHByb2Nlc3NlZCAobm8g aW5saW5lIGNvbnRlbnQpCisgICAgICAgIDMuIE5laXRoZXIgZmxvYXRzIG5vdCBpbmxpbmUgY29u dGVudCBnb3QgcHJvY2Vzc2VkIGR1ZSB0byBpbnRydXNpdmUgZmxvYXRzLgorICAgICAgICAoVGhp cyBwYXRjaCBzbGlnaHRseSByZWFycmFuZ2VzIHRoZSBib2R5IG9mIExpbmVMYXlvdXRDb250ZXh0 Ojpjb21taXRGbG9hdHMgYW5kIGFsc28gZml4ZXMgYW4gb2ZmLWJ5LTEgZXJyb3IgaW4gTGluZUxh eW91dENvbnRleHQ6OmNsb3NlLikKKworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5n L0xpbmVMYXlvdXRDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZUxh eW91dENvbnRleHQ6OmNsb3NlKToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZUxheW91 dENvbnRleHQ6OmNvbW1pdEZsb2F0cyk6CisKIDIwMjAtMDItMjUgIE15bGVzIEMuIE1heGZpZWxk ICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBbaVBhZE9TXSBSRUdSRVNTSU9OKHIy NDc2NjcpOiBBdXRvc2l6aW5nIHN0eWxlIGNoYW5nZXMgZG9uJ3QgaW52YWxpZGF0ZSBSZW5kZXJU ZXh0J3MgcHJlZmVycmVkIGxvZ2ljYWwgd2lkdGhzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9MaW5lTGF5b3V0Q29udGV4dC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9MaW5lTGF5b3V0Q29udGV4dC5jcHAKaW5k ZXggMGUxZTgxMWFjZTEwMzY1ODVkMTc5ZWRhMWY2NWY2OTdmNzM5ZjZmNy4uOGMzOWVlMTg3MTc3 YzM2NDMwZjE1NWYyYzgxMDBmOTdkYmM1ZmU5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2lubGluZWZvcm1hdHRpbmcvTGluZUxheW91dENvbnRleHQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0xpbmVMYXlvdXRDb250ZXh0LmNwcApA QCAtMzI3LDEzICszMjcsMTMgQEAgTGluZUxheW91dENvbnRleHQ6OkxpbmVDb250ZW50IExpbmVM YXlvdXRDb250ZXh0OjpsYXlvdXRMaW5lKExpbmVCdWlsZGVyJiBsaW5lLAogCiBMaW5lTGF5b3V0 Q29udGV4dDo6TGluZUNvbnRlbnQgTGluZUxheW91dENvbnRleHQ6OmNsb3NlKExpbmVCdWlsZGVy JiBsaW5lLCBjb25zdCBJbmxpbmVJdGVtUmFuZ2UgbGF5b3V0UmFuZ2UsIHVuc2lnbmVkIGNvbW1p dHRlZElubGluZUl0ZW1Db3VudCwgT3B0aW9uYWw8TGluZUNvbnRlbnQ6OlBhcnRpYWxDb250ZW50 PiBwYXJ0aWFsQ29udGVudCkKIHsKLSAgICBBU1NFUlQoY29tbWl0dGVkSW5saW5lSXRlbUNvdW50 IHx8IGxpbmUuaGFzSW50cnVzaXZlRmxvYXQoKSk7CisgICAgQVNTRVJUKGNvbW1pdHRlZElubGlu ZUl0ZW1Db3VudCB8fCAhbV9mbG9hdHMuaXNFbXB0eSgpIHx8IGxpbmUuaGFzSW50cnVzaXZlRmxv YXQoKSk7CiAgICAgaWYgKCFjb21taXR0ZWRJbmxpbmVJdGVtQ291bnQpIHsKICAgICAgICAgaWYg KG1fZmxvYXRzLmlzRW1wdHkoKSkgewogICAgICAgICAgICAgLy8gV2UgZGlkbid0IG1hbmFnZSB0 byBhZGQgYSBydW4gb3IgYSBmbG9hdCBhdCB0aGlzIHZlcnRpY2FsIHBvc2l0aW9uLgogICAgICAg ICAgICAgcmV0dXJuIExpbmVDb250ZW50IHsgeyB9LCB7IH0sIFdURk1vdmUobV9mbG9hdHMpLCBs aW5lLmNsb3NlKCksIGxpbmUubGluZUJveCgpIH07CiAgICAgICAgIH0KLSAgICAgICAgdW5zaWdu ZWQgdHJhaWxpbmdJbmxpbmVJdGVtSW5kZXggPSBsYXlvdXRSYW5nZS5zdGFydCArIG1fZmxvYXRz LnNpemUoKTsKKyAgICAgICAgdW5zaWduZWQgdHJhaWxpbmdJbmxpbmVJdGVtSW5kZXggPSBsYXlv dXRSYW5nZS5zdGFydCArIG1fZmxvYXRzLnNpemUoKSAtIDE7CiAgICAgICAgIHJldHVybiBMaW5l Q29udGVudCB7IHRyYWlsaW5nSW5saW5lSXRlbUluZGV4LCB7IH0sIFdURk1vdmUobV9mbG9hdHMp LCBsaW5lLmNsb3NlKCksIGxpbmUubGluZUJveCgpIH07CiAgICAgfQogICAgIC8vIEFkanVzdCBo eXBoZW5hdGVkIGxpbmUgY291bnQuCkBAIC00MTAsMzAgKzQxMCwzMSBAQCB2b2lkIExpbmVMYXlv dXRDb250ZXh0OjpuZXh0Q29udGVudEZvckxpbmUoTGluZUNhbmRpZGF0ZSYgbGluZUNhbmRpZGF0 ZSwgdW5zaWduZQogdm9pZCBMaW5lTGF5b3V0Q29udGV4dDo6Y29tbWl0RmxvYXRzKExpbmVCdWls ZGVyJiBsaW5lLCBjb25zdCBMaW5lQ2FuZGlkYXRlJiBsaW5lQ2FuZGlkYXRlLCBDb21taXRJbnRy dXNpdmVGbG9hdHNPbmx5IGNvbW1pdEludHJ1c2l2ZU9ubHkpCiB7CiAgICAgYXV0byYgZmxvYXRD b250ZW50ID0gbGluZUNhbmRpZGF0ZS5mbG9hdENvbnRlbnQ7Ci0gICAgYXV0byBsZWZ0RmxvYXRz V2lkdGggPSBJbmxpbmVMYXlvdXRVbml0IHsgfTsKLSAgICBhdXRvIHJpZ2h0RmxvYXRzV2lkdGgg PSBJbmxpbmVMYXlvdXRVbml0IHsgfTsKKyAgICBhdXRvIGxlZnRJbnRydXNpdmVGbG9hdHNXaWR0 aCA9IElubGluZUxheW91dFVuaXQgeyB9OworICAgIGF1dG8gcmlnaHRJbnRydXNpdmVGbG9hdHNX aWR0aCA9IElubGluZUxheW91dFVuaXQgeyB9OworICAgIGF1dG8gaGFzSW50cnVzaXZlRmxvYXQg PSBmYWxzZTsKIAogICAgIGZvciAoYXV0byYgZmxvYXRDYW5kaWRhdGUgOiBmbG9hdENvbnRlbnQu bGlzdCgpKSB7Ci0gICAgICAgIGlmIChmbG9hdENhbmRpZGF0ZS5pc0ludHJ1c2l2ZSAmJiBjb21t aXRJbnRydXNpdmVPbmx5ID09IENvbW1pdEludHJ1c2l2ZUZsb2F0c09ubHk6OlllcykKLSAgICAg ICAgICAgIGNvbnRpbnVlOwotICAgICAgICBpZiAoIWZsb2F0Q2FuZGlkYXRlLmlzSW50cnVzaXZl KSB7Ci0gICAgICAgICAgICBtX2Zsb2F0cy5hcHBlbmQoeyBMaW5lQ29udGVudDo6RmxvYXQ6Oklu dHJ1c2l2ZTo6Tm8sIGZsb2F0Q2FuZGlkYXRlLml0ZW0gfSk7CisgICAgICAgIGlmICghZmxvYXRD YW5kaWRhdGUuaXNJbnRydXNpdmUgJiYgY29tbWl0SW50cnVzaXZlT25seSA9PSBDb21taXRJbnRy dXNpdmVGbG9hdHNPbmx5OjpZZXMpCiAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgbV9m bG9hdHMuYXBwZW5kKHsgZmxvYXRDYW5kaWRhdGUuaXNJbnRydXNpdmU/IExpbmVDb250ZW50OjpG bG9hdDo6SW50cnVzaXZlOjpZZXMgOiBMaW5lQ29udGVudDo6RmxvYXQ6OkludHJ1c2l2ZTo6Tm8s IGZsb2F0Q2FuZGlkYXRlLml0ZW0gfSk7CisgICAgICAgIGlmIChmbG9hdENhbmRpZGF0ZS5pc0lu dHJ1c2l2ZSkgeworICAgICAgICAgICAgaGFzSW50cnVzaXZlRmxvYXQgPSB0cnVlOworICAgICAg ICAgICAgLy8gVGhpcyBmbG9hdCBpcyBpbnRydXNpdmUgYW5kIGl0IHNocmlua3MgdGhlIGN1cnJl bnQgbGluZS4KKyAgICAgICAgICAgIC8vIFNocmluayBhdmFpbGFibGUgc3BhY2UgZm9yIGN1cnJl bnQgbGluZS4KKyAgICAgICAgICAgIGlmIChmbG9hdENhbmRpZGF0ZS5pdGVtLT5sYXlvdXRCb3go KS5pc0xlZnRGbG9hdGluZ1Bvc2l0aW9uZWQoKSkKKyAgICAgICAgICAgICAgICBsZWZ0SW50cnVz aXZlRmxvYXRzV2lkdGggKz0gZmxvYXRDYW5kaWRhdGUubG9naWNhbFdpZHRoOworICAgICAgICAg ICAgZWxzZQorICAgICAgICAgICAgICAgIHJpZ2h0SW50cnVzaXZlRmxvYXRzV2lkdGggKz0gZmxv YXRDYW5kaWRhdGUubG9naWNhbFdpZHRoOwogICAgICAgICB9Ci0gICAgICAgIG1fZmxvYXRzLmFw cGVuZCh7IExpbmVDb250ZW50OjpGbG9hdDo6SW50cnVzaXZlOjpZZXMsIGZsb2F0Q2FuZGlkYXRl Lml0ZW0gfSk7Ci0gICAgICAgIC8vIFRoaXMgZmxvYXQgaXMgaW50cnVzaXZlIGFuZCBpdCBzaHJp bmtzIHRoZSBjdXJyZW50IGxpbmUuCi0gICAgICAgIC8vIFNocmluayBhdmFpbGFibGUgc3BhY2Ug Zm9yIGN1cnJlbnQgbGluZS4KLSAgICAgICAgaWYgKGZsb2F0Q2FuZGlkYXRlLml0ZW0tPmxheW91 dEJveCgpLmlzTGVmdEZsb2F0aW5nUG9zaXRpb25lZCgpKQotICAgICAgICAgICAgbGVmdEZsb2F0 c1dpZHRoICs9IGZsb2F0Q2FuZGlkYXRlLmxvZ2ljYWxXaWR0aDsKLSAgICAgICAgZWxzZQotICAg ICAgICAgICAgcmlnaHRGbG9hdHNXaWR0aCArPSBmbG9hdENhbmRpZGF0ZS5sb2dpY2FsV2lkdGg7 CiAgICAgfQotICAgIGlmIChsZWZ0RmxvYXRzV2lkdGggfHwgcmlnaHRGbG9hdHNXaWR0aCkgewor ICAgIGlmIChoYXNJbnRydXNpdmVGbG9hdCkKICAgICAgICAgbGluZS5zZXRIYXNJbnRydXNpdmVG bG9hdCgpOwotICAgICAgICBpZiAobGVmdEZsb2F0c1dpZHRoKQotICAgICAgICAgICAgbGluZS5t b3ZlTG9naWNhbExlZnQobGVmdEZsb2F0c1dpZHRoKTsKLSAgICAgICAgaWYgKHJpZ2h0RmxvYXRz V2lkdGgpCi0gICAgICAgICAgICBsaW5lLm1vdmVMb2dpY2FsUmlnaHQocmlnaHRGbG9hdHNXaWR0 aCk7CisgICAgaWYgKGxlZnRJbnRydXNpdmVGbG9hdHNXaWR0aCB8fCByaWdodEludHJ1c2l2ZUZs b2F0c1dpZHRoKSB7CisgICAgICAgIGlmIChsZWZ0SW50cnVzaXZlRmxvYXRzV2lkdGgpCisgICAg ICAgICAgICBsaW5lLm1vdmVMb2dpY2FsTGVmdChsZWZ0SW50cnVzaXZlRmxvYXRzV2lkdGgpOwor ICAgICAgICBpZiAocmlnaHRJbnRydXNpdmVGbG9hdHNXaWR0aCkKKyAgICAgICAgICAgIGxpbmUu bW92ZUxvZ2ljYWxSaWdodChyaWdodEludHJ1c2l2ZUZsb2F0c1dpZHRoKTsKICAgICB9CiB9CiAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZThlODUxMTc2ZDcyM2RlZjdkZGM0N2IxZDk5ZjE2NWQ4MzVlYzA4Li4wNTFjODZk N2UxZTc5Mjc5OGQ5ZjIzMWJjOWZjMmRjODJlOWQyZDYyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMjAtMDItMjUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBb TEZDXVtJRkNdW0Zsb2F0c10gQVNTRVJUKGNvbW1pdHRlZElubGluZUl0ZW1Db3VudCB8fCBsaW5l Lmhhc0ludHJ1c2l2ZUZsb2F0KCkpIGluIExpbmVMYXlvdXRDb250ZXh0OjpjbG9zZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MjMwCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS81OTc5MTI0OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvZmxvYXQt YW5kLWJyLWlubGluZS1jb250ZW50LW9ubHktZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAg ICogZmFzdC9sYXlvdXRmb3JtYXR0aW5nY29udGV4dC9mbG9hdC1hbmQtYnItaW5saW5lLWNvbnRl bnQtb25seS5odG1sOiBBZGRlZC4KKwogMjAyMC0wMi0yNSAgSmFzb24gTGF3cmVuY2UgIDxsYXdy ZW5jZS5qQGFwcGxlLmNvbT4KIAogICAgICAgICBbIGlQYWRPUyB3azIgXSBmYXN0L3Njcm9sbGlu Zy9pb3MvY2hhbmdlLXNjcm9sbGFiaWxpdHktb24tY29udGVudC1yZXNpemUtbmVzdGVkLmh0bWwg aXMgZmFpbGluZy4gCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2xheW91dGZvcm1hdHRp bmdjb250ZXh0L2Zsb2F0LWFuZC1ici1pbmxpbmUtY29udGVudC1vbmx5LWV4cGVjdGVkLmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L2Zsb2F0LWFuZC1ici1p bmxpbmUtY29udGVudC1vbmx5LWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMDNjNmY0Y2NlMGI2 MTBhNTBjZWUyOGRmYjk2NTg1NmUyNGMyZmQxNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvZmxvYXQtYW5kLWJyLWlubGluZS1jb250 ZW50LW9ubHktZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDIgQEAKKzwhLS0gd2Via2l0LXRlc3Qt cnVubmVyIFsgaW50ZXJuYWw6TGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRFbmFibGVkPXRydWUgaW50 ZXJuYWw6TGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRJbnRlZ3JhdGlvbkVuYWJsZWQ9ZmFsc2UgXSAt LT4KK2VtcHR5IGNvbnRlbnQtPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9sYXlvdXRm b3JtYXR0aW5nY29udGV4dC9mbG9hdC1hbmQtYnItaW5saW5lLWNvbnRlbnQtb25seS5odG1sIGIv TGF5b3V0VGVzdHMvZmFzdC9sYXlvdXRmb3JtYXR0aW5nY29udGV4dC9mbG9hdC1hbmQtYnItaW5s aW5lLWNvbnRlbnQtb25seS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBiNzllNmVkNjEwZjJiZDU0ZDY1ODY5 NzMzN2ZkYjM5YzVjYzQwODEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2xh eW91dGZvcm1hdHRpbmdjb250ZXh0L2Zsb2F0LWFuZC1ici1pbmxpbmUtY29udGVudC1vbmx5Lmh0 bWwKQEAgLTAsMCArMSw3IEBACis8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIGludGVybmFsOkxh eW91dEZvcm1hdHRpbmdDb250ZXh0RW5hYmxlZD10cnVlIGludGVybmFsOkxheW91dEZvcm1hdHRp bmdDb250ZXh0SW50ZWdyYXRpb25FbmFibGVkPWZhbHNlIF0gLS0+Cis8c3R5bGU+CisjY29udGFp bmVyIHsKKyAgICBmbG9hdDogbGVmdDsKK30KKzwvc3R5bGU+Cis8ZGl2PmVtcHR5IGNvbnRlbnQt PjwvZGl2Pjxicj48ZGl2IGlkPSJjb250YWluZXIiPjwvZGl2Pgo=