208228 2020-02-25 17:46:31 -0800 Custom element caching should be aware of different worlds. 2020-02-26 00:48:04 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208229 InRadar P2 Normal --- 1 mark.lam mark.lam cdumez commit-queue rniwa webkit-bug-importer oldest_to_newest 1622863 0 mark.lam 2020-02-25 17:46:31 -0800 Even though a custom element is cached in one world, it should return an unknown HTMl element in a different world. <rdar://problem/57881013> 1622873 1 391707 mark.lam 2020-02-25 17:53:13 -0800 Created attachment 391707 proposed patch. 1622921 2 mark.lam 2020-02-25 23:59:32 -0800 The ios-wk2 bot failures are unrelated. Landing the patch now. 1622928 3 391707 commit-queue 2020-02-26 00:48:03 -0800 Comment on attachment 391707 proposed patch. Clearing flags on attachment: 391707 Committed r257414: <https://trac.webkit.org/changeset/257414> 1622929 4 commit-queue 2020-02-26 00:48:04 -0800 All reviewed patches have been landed. Closing bug. 391707 2020-02-25 17:53:13 -0800 2020-02-26 00:48:03 -0800 proposed patch. bug-208228.patch text/plain 2039 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1NzM5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAyLTI1ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBDdXN0b20gZWxlbWVudCBjYWNoaW5n IHNob3VsZCBiZSBhd2FyZSBvZiBkaWZmZXJlbnQgd29ybGRzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MjI4CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS81Nzg4MTAxMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBFdmVuIHRob3VnaCBhIGN1c3RvbSBlbGVtZW50IGlzIGNhY2hlZCBpbiBvbmUgd29y bGQsIHdlIHNob3VsZCByZXR1cm4gYW4gdW5rbm93bgorICAgICAgICBIVE1sIGVsZW1lbnQgaW4g YSBkaWZmZXJlbnQgd29ybGQuCisKKyAgICAgICAgVGVzdCB0byBiZSBhZGRlZCBpbiBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MjI5LgorCisgICAgICAgICogYmlu ZGluZ3MvanMvSlNFbGVtZW50Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRvSlNOZXds eUNyZWF0ZWQpOgorCiAyMDIwLTAyLTI1ICBCZW4gTmhhbSAgPG5oYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZSByZW5kZXIgdXBkYXRlIHRocm90dGxpbmcKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTRWxlbWVudEN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNFbGVtZW50Q3VzdG9tLmNwcAkocmV2aXNpb24gMjU3Mzk4 KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNFbGVtZW50Q3VzdG9tLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDcsIDIw MDgsIDIwMDkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChD KSAyMDA3LTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlz dHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0 aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZv bGxvd2luZyBjb25kaXRpb25zCkBAIC03MSw4ICs3MSwxMiBAQCBKU1ZhbHVlIHRvSlMoSlNHbG9i YWxPYmplY3QqLCBKU0RPTUdsb2JhCiAKIEpTVmFsdWUgdG9KU05ld2x5Q3JlYXRlZChKU0dsb2Jh bE9iamVjdCosIEpTRE9NR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIFJlZjxFbGVtZW50PiYm IGVsZW1lbnQpCiB7Ci0gICAgaWYgKGVsZW1lbnQtPmlzRGVmaW5lZEN1c3RvbUVsZW1lbnQoKSkK LSAgICAgICAgcmV0dXJuIGdldENhY2hlZFdyYXBwZXIoZ2xvYmFsT2JqZWN0LT53b3JsZCgpLCBl bGVtZW50KTsKKyAgICBpZiAoZWxlbWVudC0+aXNEZWZpbmVkQ3VzdG9tRWxlbWVudCgpKSB7Cisg ICAgICAgIEpTVmFsdWUgcmVzdWx0ID0gZ2V0Q2FjaGVkV3JhcHBlcihnbG9iYWxPYmplY3QtPndv cmxkKCksIGVsZW1lbnQpOworICAgICAgICBpZiAocmVzdWx0KQorICAgICAgICAgICAgcmV0dXJu IHJlc3VsdDsKKyAgICAgICAgQVNTRVJUKCFnbG9iYWxPYmplY3QtPnZtKCkuZXhjZXB0aW9uRm9y SW5zcGVjdGlvbigpKTsKKyAgICB9CiAgICAgQVNTRVJUKCFnZXRDYWNoZWRXcmFwcGVyKGdsb2Jh bE9iamVjdC0+d29ybGQoKSwgZWxlbWVudCkpOwogICAgIHJldHVybiBjcmVhdGVOZXdFbGVtZW50 V3JhcHBlcihnbG9iYWxPYmplY3QsIFdURk1vdmUoZWxlbWVudCkpOwogfQo=