208226 2020-02-25 17:20:14 -0800 Add Highlight API to features.json 2021-08-18 10:17:15 -0700 1 1 1 Unclassified WebKit HTML Editing Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser megan_gardner ews-watchlist joepeck simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1622849 0 simon.fraser 2020-02-25 17:20:14 -0800 Need to add highlight API to WebCore/features.json so it shows up on https://webkit.org/status/ 1784990 1 435728 megan_gardner 2021-08-17 16:43:15 -0700 Created attachment 435728 Patch 1785014 2 435728 simon.fraser 2021-08-17 19:02:27 -0700 Comment on attachment 435728 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435728&action=review > Source/WebCore/features.json:98 > + "status": "Under Consideration", Isn't it more like "In Development"? > Source/WebCore/features.json:104 > + "description": "Allows content to define the style for pseudo-elements and their ranges." You could just lift text from the spec and say " A mechanism for styling arbitrary ranges of a document identified by script." 1785140 3 megan_gardner 2021-08-18 09:45:43 -0700 I tried searching other specs for their description text and I didn't find any that did, or ideas of where to pull from, so I just tried my best. Copying the description is better, though. 1785142 4 435777 megan_gardner 2021-08-18 09:47:05 -0700 Created attachment 435777 Patch 1785144 5 435779 megan_gardner 2021-08-18 09:48:02 -0700 Created attachment 435779 Patch for landing 1785153 6 ews-feeder 2021-08-18 10:16:17 -0700 Committed r281196 (240640@main): <https://commits.webkit.org/240640@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435779. 1785154 7 webkit-bug-importer 2021-08-18 10:17:15 -0700 <rdar://problem/82083022> 435728 2021-08-17 16:43:15 -0700 2021-08-18 09:47:59 -0700 Patch bug-208226-20210817164314.patch text/plain 1572 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2EyNTBjM2ExZTQzNjE4 MWEzMzUxNjQwODQwMDE0YjJlZDZjMjdmMy4uNjY2YTZjZWUyYzg5MjVlNTg3ZjU0MTk5Y2ZjMzhi ZWY2ZjYwN2UyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA4LTE3ICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIEhpZ2hs aWdodCBBUEkgdG8gZmVhdHVyZXMuanNvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MjI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBmZWF0dXJlcy5qc29uOgorCiAyMDIxLTA4LTE2ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVzb3VyY2Ug VGltaW5nOiBEdXJhdGlvbiBpcyAwIGluIG1hbnkgY2FzZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2ZlYXR1cmVzLmpzb24gYi9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5qc29uCmluZGV4 IGFiZmM2ZjNiYWJkYmU5ZTZiYmQyYzgwYzQ0MTBjN2M5MzI1ZGZhODYuLmU0M2EzOGIyZDdmMDJj NmYwMTQzMzcxZjQ3OWJiMjdlMjQ4NDM0NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Zl YXR1cmVzLmpzb24KKysrIGIvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbgpAQCAtOTIsNiAr OTIsMTcgQEAKICAgICAgICAgImNhdGVnb3J5IjogImNzcyIsCiAgICAgICAgICJkZXNjcmlwdGlv biI6ICJBbGxvd3MgY29udGVudCB0byBzcGVjaWZ5IHRoYXQgYW4gZWxlbWVudOKAmXMgc3VidHJl ZSBpcyBpbmRlcGVuZGVudCBvZiB0aGUgcmVzdCBvZiB0aGUgcGFnZSB0byBhbGxvdyBmb3Igb3B0 aW1pemF0aW9ucyBieSB0aGUgYnJvd3Nlci4iCiAgICAgfSwKKyAgICB7CisgICAgICAgICJuYW1l IjogIkNTUyBDdXN0b20gSGlnaGxpZ2h0IEFQSSBNb2R1bGUgTGV2ZWwgMSIsCisgICAgICAgICJz dGF0dXMiOiB7CisgICAgICAgICAgICAic3RhdHVzIjogIlVuZGVyIENvbnNpZGVyYXRpb24iLAor ICAgICAgICAgICAgImVuYWJsZWQtYnktZGVmYXVsdCI6IGZhbHNlCisgICAgICAgIH0sCisgICAg ICAgICJ1cmwiOiAiaHR0cHM6Ly9kcmFmdHMuY3Nzd2cub3JnL2Nzcy1oaWdobGlnaHQtYXBpLTEv IiwKKyAgICAgICAgImtleXdvcmRzIjogWyJjc3MgcHNldWRvLWVsZW1lbnQiLCAiaGlnaGxpZ2h0 Il0sCisgICAgICAgICJjYXRlZ29yeSI6ICJjc3MiLAorICAgICAgICAiZGVzY3JpcHRpb24iOiAi QWxsb3dzIGNvbnRlbnQgdG8gZGVmaW5lIHRoZSBzdHlsZSBmb3IgcHNldWRvLWVsZW1lbnRzIGFu ZCB0aGVpciByYW5nZXMuIgorICAgIH0sCiAgICAgewogICAgICAgICAibmFtZSI6ICJDU1MgRm9u dCBEaXNwbGF5IiwKICAgICAgICAgInN0YXR1cyI6IHsK 435777 2021-08-18 09:47:05 -0700 2021-08-18 09:48:00 -0700 Patch bug-208226-20210818094705.patch text/plain 1571 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2EyNTBjM2ExZTQzNjE4 MWEzMzUxNjQwODQwMDE0YjJlZDZjMjdmMy4uYmE4YmU3NzYzMThjOTE0MzhhNWMyZjU0Y2NjZTVm Y2NkYTQ2NDUzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA4LTE4ICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIEhpZ2hs aWdodCBBUEkgdG8gZmVhdHVyZXMuanNvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MjI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBmZWF0dXJlcy5qc29uOgorCiAyMDIxLTA4LTE2ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVzb3VyY2Ug VGltaW5nOiBEdXJhdGlvbiBpcyAwIGluIG1hbnkgY2FzZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2ZlYXR1cmVzLmpzb24gYi9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5qc29uCmluZGV4 IGFiZmM2ZjNiYWJkYmU5ZTZiYmQyYzgwYzQ0MTBjN2M5MzI1ZGZhODYuLjU3NTZlNzIwZGFlYTlj NGM2ZjIxZjI3NDVlMTAwZDQwMGE3NTJlYjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Zl YXR1cmVzLmpzb24KKysrIGIvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbgpAQCAtOTIsNiAr OTIsMTcgQEAKICAgICAgICAgImNhdGVnb3J5IjogImNzcyIsCiAgICAgICAgICJkZXNjcmlwdGlv biI6ICJBbGxvd3MgY29udGVudCB0byBzcGVjaWZ5IHRoYXQgYW4gZWxlbWVudOKAmXMgc3VidHJl ZSBpcyBpbmRlcGVuZGVudCBvZiB0aGUgcmVzdCBvZiB0aGUgcGFnZSB0byBhbGxvdyBmb3Igb3B0 aW1pemF0aW9ucyBieSB0aGUgYnJvd3Nlci4iCiAgICAgfSwKKyAgICB7CisgICAgICAgICJuYW1l IjogIkNTUyBDdXN0b20gSGlnaGxpZ2h0IEFQSSBNb2R1bGUgTGV2ZWwgMSIsCisgICAgICAgICJz dGF0dXMiOiB7CisgICAgICAgICAgICAic3RhdHVzIjogIkluIERldmVsb3BtZW50IiwKKyAgICAg ICAgICAgICJlbmFibGVkLWJ5LWRlZmF1bHQiOiBmYWxzZQorICAgICAgICB9LAorICAgICAgICAi dXJsIjogImh0dHBzOi8vZHJhZnRzLmNzc3dnLm9yZy9jc3MtaGlnaGxpZ2h0LWFwaS0xLyIsCisg ICAgICAgICJrZXl3b3JkcyI6IFsiY3NzIHBzZXVkby1lbGVtZW50IiwgImhpZ2hsaWdodCJdLAor ICAgICAgICAiY2F0ZWdvcnkiOiAiY3NzIiwKKyAgICAgICAgImRlc2NyaXB0aW9uIjogIkEgbWVj aGFuaXNtIGZvciBzdHlsaW5nIGFyYml0cmFyeSByYW5nZXMgb2YgYSBkb2N1bWVudCBpZGVudGlm aWVkIGJ5IHNjcmlwdC4iCisgICAgfSwKICAgICB7CiAgICAgICAgICJuYW1lIjogIkNTUyBGb250 IERpc3BsYXkiLAogICAgICAgICAic3RhdHVzIjogewo= 435779 2021-08-18 09:48:02 -0700 2021-08-18 10:16:18 -0700 Patch for landing bug-208226-20210818094801.patch text/plain 1569 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2EyNTBjM2ExZTQzNjE4 MWEzMzUxNjQwODQwMDE0YjJlZDZjMjdmMy4uZjdkZjM3OGJlYzhjYTA5ZDNhNDZkNmIyNDZkY2Nm MTcxOTRhZTcwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA4LTE4ICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIEhpZ2hs aWdodCBBUEkgdG8gZmVhdHVyZXMuanNvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA4MjI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJh c2VyLgorCisgICAgICAgICogZmVhdHVyZXMuanNvbjoKKwogMjAyMS0wOC0xNiAgQWxleCBDaHJp c3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlc291cmNlIFRp bWluZzogRHVyYXRpb24gaXMgMCBpbiBtYW55IGNhc2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9mZWF0dXJlcy5qc29uIGIvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbgppbmRleCBh YmZjNmYzYmFiZGJlOWU2YmJkMmM4MGM0NDEwYzdjOTMyNWRmYTg2Li41NzU2ZTcyMGRhZWE5YzRj NmYyMWYyNzQ1ZTEwMGQ0MDBhNzUyZWIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9mZWF0 dXJlcy5qc29uCisrKyBiL1NvdXJjZS9XZWJDb3JlL2ZlYXR1cmVzLmpzb24KQEAgLTkyLDYgKzky LDE3IEBACiAgICAgICAgICJjYXRlZ29yeSI6ICJjc3MiLAogICAgICAgICAiZGVzY3JpcHRpb24i OiAiQWxsb3dzIGNvbnRlbnQgdG8gc3BlY2lmeSB0aGF0IGFuIGVsZW1lbnTigJlzIHN1YnRyZWUg aXMgaW5kZXBlbmRlbnQgb2YgdGhlIHJlc3Qgb2YgdGhlIHBhZ2UgdG8gYWxsb3cgZm9yIG9wdGlt aXphdGlvbnMgYnkgdGhlIGJyb3dzZXIuIgogICAgIH0sCisgICAgeworICAgICAgICAibmFtZSI6 ICJDU1MgQ3VzdG9tIEhpZ2hsaWdodCBBUEkgTW9kdWxlIExldmVsIDEiLAorICAgICAgICAic3Rh dHVzIjogeworICAgICAgICAgICAgInN0YXR1cyI6ICJJbiBEZXZlbG9wbWVudCIsCisgICAgICAg ICAgICAiZW5hYmxlZC1ieS1kZWZhdWx0IjogZmFsc2UKKyAgICAgICAgfSwKKyAgICAgICAgInVy bCI6ICJodHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3NzLWhpZ2hsaWdodC1hcGktMS8iLAorICAg ICAgICAia2V5d29yZHMiOiBbImNzcyBwc2V1ZG8tZWxlbWVudCIsICJoaWdobGlnaHQiXSwKKyAg ICAgICAgImNhdGVnb3J5IjogImNzcyIsCisgICAgICAgICJkZXNjcmlwdGlvbiI6ICJBIG1lY2hh bmlzbSBmb3Igc3R5bGluZyBhcmJpdHJhcnkgcmFuZ2VzIG9mIGEgZG9jdW1lbnQgaWRlbnRpZmll ZCBieSBzY3JpcHQuIgorICAgIH0sCiAgICAgewogICAgICAgICAibmFtZSI6ICJDU1MgRm9udCBE aXNwbGF5IiwKICAgICAgICAgInN0YXR1cyI6IHsK