208221 2020-02-25 15:44:53 -0800 PDFPlugin: 'Open in Preview' and 'Save' don't work for blobs 2020-02-25 16:21:02 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton achristensen beidson commit-queue webkit-bug-importer wenson_hsieh oldest_to_newest 1622790 0 thorton 2020-02-25 15:44:53 -0800 PDFPlugin: 'Open in Preview' and 'Save' don't work for blobs 1622791 1 391693 thorton 2020-02-25 15:45:03 -0800 Created attachment 391693 Patch 1622792 2 thorton 2020-02-25 15:45:05 -0800 <rdar://problem/22676176> 1622797 3 391693 achristensen 2020-02-25 15:56:09 -0800 Comment on attachment 391693 Patch test? 1622803 4 thorton 2020-02-25 16:01:58 -0800 Of the PDFPlugin HUD? None exist. It's nontrivial, though probably not impossible. Of some special just-for-testing SPI? I don't love those. 1622816 5 391693 commit-queue 2020-02-25 16:21:01 -0800 Comment on attachment 391693 Patch Clearing flags on attachment: 391693 Committed r257390: <https://trac.webkit.org/changeset/257390> 1622817 6 commit-queue 2020-02-25 16:21:02 -0800 All reviewed patches have been landed. Closing bug. 391693 2020-02-25 15:45:03 -0800 2020-02-25 16:21:01 -0800 Patch bug-208221-20200225154502.patch text/plain 4287 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3Mjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ0OTA4MWVjOWI2NTBmODM3 ZDM5ZGNmNGUzZGI5MjgzZmEyMTZjMzMuLmM1NDRiZDUzYTk0ODVlZWFmOWVkNzY1Y2UxOGVjYTFk N2IyMWRkNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjAtMDItMjUgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUERGUGx1Z2luOiAnT3Bl biBpbiBQcmV2aWV3JyBhbmQgJ1NhdmUnIGRvbid0IHdvcmsgZm9yIGJsb2JzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgyMjEKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzIyNjc2MTc2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4uaDoKKyAg ICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbToKKyAgICAgICAgKFdl YktpdDo6UERGUGx1Z2luOjpjb252ZXJ0UG9zdFNjcmlwdERhdGFJZk5lZWRlZCk6CisgICAgICAg IChXZWJLaXQ6OlBERlBsdWdpbjo6c2V0U3VnZ2VzdGVkRmlsZW5hbWUpOgorICAgICAgICAoV2Vi S2l0OjpQREZQbHVnaW46OnN0cmVhbURpZFJlY2VpdmVSZXNwb25zZSk6CisgICAgICAgIChXZWJL aXQ6OlBERlBsdWdpbjo6bWFudWFsU3RyZWFtRGlkUmVjZWl2ZVJlc3BvbnNlKToKKyAgICAgICAg RW5zdXJlIHRoYXQgUERGUGx1Z2luJ3Mgc3VnZ2VzdGVkRmlsZW5hbWUgYWx3YXlzIGhhcyBhIC5w ZGYgZXh0ZW5zaW9uLgorICAgICAgICBUaGUgVUkgcHJvY2VzcyBhbHJlYWR5IHJlcXVpcmVzIHRo aXMsIGFuZCBlbmZvcmNlcyBpdCwgY2F1c2luZyBvcGVyYXRpb25zCisgICAgICAgIHRoYXQgdXNl IHRoZSBzdWdnZXN0ZWRGaWxlbmFtZSB0byBmYWlsIGlmIGl0IGRvZXMgbm90IGhhdmUgYSAucGRm IGV4dGVuc2lvbi4KKyAgICAgICAgSG93ZXZlciwgaW4gdGhlIGNhc2Ugb2YgYSBibG9iLWxvYWRl ZCBQREYsIHdlIGdldCBqdXN0IHRoZSBuYW1lICJVbmtub3duIi4KKyAgICAgICAgU2xhcCB0aGUg ZXh0ZW5zaW9uIG9uIHRoZXJlLCBhbmQgYWxsIGlzIHdlbGwhCisKIDIwMjAtMDItMjQgIEppZXdl biBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViQXV0aG5dIEltcGxl bWVudCBTUEkgZm9yIHRoZSBwbGF0Zm9ybSBhdXRoZW50aWNhdG9yCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLmggYi9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLmgKaW5kZXggZTNkZTA1YWFiYmUy MWM0MGUxYmU4OGQ5ZTljNjg1YTA2NGJiMDMzNy4uMDcyYTFjMDNlMTU2OWUxNDliMmM4Y2YxZWJl ODk5MzdjMDM2M2JkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdp bnMvUERGL1BERlBsdWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5z L1BERi9QREZQbHVnaW4uaApAQCAtMjU5LDYgKzI1OSw4IEBAIHByaXZhdGU6CiAKICAgICB2b2lk IGNvbnZlcnRQb3N0U2NyaXB0RGF0YUlmTmVlZGVkKCk7CiAKKyAgICB2b2lkIHNldFN1Z2dlc3Rl ZEZpbGVuYW1lKGNvbnN0IFN0cmluZyYpOworCiAgICAgLy8gUmVndWxhciBwbHVnLWlucyBkb24n dCBuZWVkIGFjY2VzcyB0byB2aWV3LCBidXQgd2UgYWRkIHNjcm9sbGJhcnMgdG8gZW1iZWRkaW5n IEZyYW1lVmlldyBmb3IgcHJvcGVyIGV2ZW50IGhhbmRsaW5nLgogICAgIFBsdWdpblZpZXcqIHBs dWdpblZpZXcoKTsKICAgICBjb25zdCBQbHVnaW5WaWV3KiBwbHVnaW5WaWV3KCkgY29uc3Q7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2lu Lm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbQpp bmRleCA2NzcyYWViMTdjOWFhMjUxODdhMjJhZmE2MDBhYzQxNWJkZjYxMDFlLi5kNWZhMTdhYWFm YmUyZjA1NzNiMmI3NjI0NmFhMWY1ZTdkNTg4MmVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0KQEAgLTY4LDYgKzY4LDcgQEAKICNp bXBvcnQgPFdlYkNvcmUvSFRNTEZvcm1FbGVtZW50Lmg+CiAjaW1wb3J0IDxXZWJDb3JlL0hUTUxQ bHVnSW5FbGVtZW50Lmg+CiAjaW1wb3J0IDxXZWJDb3JlL0xlZ2FjeU5TUGFzdGVib2FyZFR5cGVz Lmg+CisjaW1wb3J0IDxXZWJDb3JlL0xvYWRlck5TVVJMRXh0cmFzLmg+CiAjaW1wb3J0IDxXZWJD b3JlL0xvY2FsRGVmYXVsdFN5c3RlbUFwcGVhcmFuY2UuaD4KICNpbXBvcnQgPFdlYkNvcmUvTG9j YWxpemVkU3RyaW5ncy5oPgogI2ltcG9ydCA8V2ViQ29yZS9Nb3VzZUV2ZW50Lmg+CkBAIC05Mzcs NyArOTM4LDYgQEAgdm9pZCBQREZQbHVnaW46OmNvbnZlcnRQb3N0U2NyaXB0RGF0YUlmTmVlZGVk KCkKICAgICBpZiAoIW1faXNQb3N0U2NyaXB0KQogICAgICAgICByZXR1cm47CiAKLSAgICBtX3N1 Z2dlc3RlZEZpbGVuYW1lID0gU3RyaW5nKG1fc3VnZ2VzdGVkRmlsZW5hbWUgKyAiLnBkZiIpOwog ICAgIG1fZGF0YSA9IFBERkRvY3VtZW50SW1hZ2U6OmNvbnZlcnRQb3N0U2NyaXB0RGF0YVRvUERG KFdURk1vdmUobV9kYXRhKSk7CiB9CiAKQEAgLTk3MiwxMiArOTcyLDIzIEBAIHZvaWQgUERGUGx1 Z2luOjpwZGZEb2N1bWVudERpZExvYWQoKQogICAgICAgICBbbV9wZGZMYXllckNvbnRyb2xsZXIg c2V0VVJMRnJhZ21lbnQ6cGRmVVJMRnJhZ21lbnRdOwogICAgIH0KIH0KKwordm9pZCBQREZQbHVn aW46OnNldFN1Z2dlc3RlZEZpbGVuYW1lKGNvbnN0IFN0cmluZyYgc3VnZ2VzdGVkRmlsZW5hbWUp Cit7CisgICAgbV9zdWdnZXN0ZWRGaWxlbmFtZSA9IHN1Z2dlc3RlZEZpbGVuYW1lOworCisgICAg aWYgKG1fc3VnZ2VzdGVkRmlsZW5hbWUuaXNFbXB0eSgpKQorICAgICAgICBtX3N1Z2dlc3RlZEZp bGVuYW1lID0gc3VnZ2VzdGVkRmlsZW5hbWVXaXRoTUlNRVR5cGUobmlsLCAiYXBwbGljYXRpb24v cGRmIik7CisKKyAgICBpZiAoIW1fc3VnZ2VzdGVkRmlsZW5hbWUuZW5kc1dpdGhJZ25vcmluZ0FT Q0lJQ2FzZSgiLnBkZiIpKQorICAgICAgICBtX3N1Z2dlc3RlZEZpbGVuYW1lLmFwcGVuZCgiLnBk ZiIpOworfQogICAgIAogdm9pZCBQREZQbHVnaW46OnN0cmVhbURpZFJlY2VpdmVSZXNwb25zZSh1 aW50NjRfdCBzdHJlYW1JRCwgY29uc3QgVVJMJiwgdWludDMyX3QsIHVpbnQzMl90LCBjb25zdCBT dHJpbmcmIG1pbWVUeXBlLCBjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmIHN1Z2dlc3RlZEZp bGVuYW1lKQogewogICAgIEFTU0VSVF9VTlVTRUQoc3RyZWFtSUQsIHN0cmVhbUlEID09IHBkZkRv Y3VtZW50UmVxdWVzdElEKTsKIAotICAgIG1fc3VnZ2VzdGVkRmlsZW5hbWUgPSBzdWdnZXN0ZWRG aWxlbmFtZTsKKyAgICBzZXRTdWdnZXN0ZWRGaWxlbmFtZShzdWdnZXN0ZWRGaWxlbmFtZSk7CiAK ICAgICBpZiAoZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZShtaW1lVHlwZSwgcG9zdFNjcmlwdE1JTUVU eXBlKSkKICAgICAgICAgbV9pc1Bvc3RTY3JpcHQgPSB0cnVlOwpAQCAtMTAxMCw3ICsxMDIxLDcg QEAgdm9pZCBQREZQbHVnaW46OnN0cmVhbURpZEZhaWwodWludDY0X3Qgc3RyZWFtSUQsIGJvb2wg d2FzQ2FuY2VsbGVkKQogCiB2b2lkIFBERlBsdWdpbjo6bWFudWFsU3RyZWFtRGlkUmVjZWl2ZVJl c3BvbnNlKGNvbnN0IFVSTCYgcmVzcG9uc2VVUkwsIHVpbnQzMl90IHN0cmVhbUxlbmd0aCwgIHVp bnQzMl90IGxhc3RNb2RpZmllZFRpbWUsIGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIGNvbnN0IFN0 cmluZyYgaGVhZGVycywgY29uc3QgU3RyaW5nJiBzdWdnZXN0ZWRGaWxlbmFtZSkKIHsKLSAgICBt X3N1Z2dlc3RlZEZpbGVuYW1lID0gc3VnZ2VzdGVkRmlsZW5hbWU7CisgICAgc2V0U3VnZ2VzdGVk RmlsZW5hbWUoc3VnZ2VzdGVkRmlsZW5hbWUpOwogCiAgICAgaWYgKGVxdWFsSWdub3JpbmdBU0NJ SUNhc2UobWltZVR5cGUsIHBvc3RTY3JpcHRNSU1FVHlwZSkpCiAgICAgICAgIG1faXNQb3N0U2Ny aXB0ID0gdHJ1ZTsK