208214 2020-02-25 12:48:50 -0800 TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes 2020-02-25 14:12:15 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build iPhone / iPad iOS 13 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208082 InRadar P2 Normal --- 1 dbates dbates webkit-bug-importer wenson_hsieh oldest_to_newest 1622707 0 dbates 2020-02-25 12:48:50 -0800 The test TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly copies text from one web view and pastes it into another, but it neither waits until the copy operation completes nor does it ensure that this operation completed successfully. As a result, the test is timing dependent, aka flaky. 1622708 1 391676 dbates 2020-02-25 12:50:53 -0800 Created attachment 391676 Patch 1622709 2 dbates 2020-02-25 12:55:53 -0800 We don't need to explicitly wait for select all and paste operations because we implicit wait for them by virtue of sending additional web page messages. Specifically, do not need to wait for select all to complete before executing copy because the WebProcess is guaranteed to receive these requests in order. Similar argument for why there is no need to wait for paste. 1622737 3 391676 wenson_hsieh 2020-02-25 13:52:34 -0800 Comment on attachment 391676 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391676&action=review Good catch! > Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:-316 > - [source _executeEditCommand:@"copy" argument:nil completion:nil]; Nit - it would probably be simpler to just call -_synchronouslyExecuteEditCommand:argument:. 1622745 4 391676 dbates 2020-02-25 14:06:58 -0800 Comment on attachment 391676 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391676&action=review Thanks for the review. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:-316 >> - [source _executeEditCommand:@"copy" argument:nil completion:nil]; > > Nit - it would probably be simpler to just call -_synchronouslyExecuteEditCommand:argument:. !! I didn't know about this. !! 1622747 5 391683 dbates 2020-02-25 14:10:21 -0800 Created attachment 391683 To land 1622749 6 dbates 2020-02-25 14:11:35 -0800 All reviewed patches have been landed. Closing bug. 1622750 7 dbates 2020-02-25 14:11:58 -0800 Committed r257375: <https://trac.webkit.org/changeset/257375> 1622751 8 webkit-bug-importer 2020-02-25 14:12:15 -0800 <rdar://problem/59779909> 391676 2020-02-25 12:50:53 -0800 2020-02-25 14:10:20 -0800 Patch bug-208214-20200225125052.patch text/plain 2614 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MzY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmVmNWYwNTFiODEyOTJjN2EwMWVlMjY5MDY3NGNjYTBk YjU1NmM5Ni4uZDU4NzRkZWUzNzlkOWZmYjE5MTJkOTk0MTQ2YzZjNDRhMWFiZDU5YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIwLTAyLTI1ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBUZXN0V2ViS2l0QVBJLlBhc3RlTWl4ZWRDb250ZW50LkNvcHlBbmRQYXN0ZVdpdGhDdXN0 b21QYXN0ZWJvYXJkRGF0YU9ubHkgc2hvdWxkIHdhaXQgdW50aWwgY29weSBvcGVyYXRpb24gY29t cGxldGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDgyMTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX YWl0IHVudGlsIHRoZSBjb3B5IG9wZXJhdGlvbiBjb21wbGV0ZXMgYmVmb3JlIGxvYWRpbmcgdGhl IHNlY29uZCB3ZWIgdmlldyBhbmQgdGVzdGluZyBwYXN0ZQorICAgICAgICB0byBlbnN1cmUgdGhh dCBzb21ldGhpbmcgd2FzIGFjdHVhbGx5IGNvcGllZCB0byB0aGUgY2xpcGJvYXJkLgorCisgICAg ICAgICogVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0QVBJLnhjb2RlcHJvai94Y3NoYXJlZGRhdGEv eGNzY2hlbWVzL1Rlc3RXZWJLaXRBUEkueGNzY2hlbWU6CisgICAgICAgICogVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXRDb2NvYS9QYXN0ZU1peGVkQ29udGVudC5tbToKKyAgICAgICAgKFRlc3RX ZWJLaXRBUEk6OlRFU1QpOgorCiAyMDIwLTAyLTI1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI1Njg4Mik6IENhbid0IGRyYWcgYW4gSFRN TCBmaWxlIGludG8gYSBuZXcgKGVtcHR5KSBTYWZhcmkgdGFiCmRpZmYgLS1naXQgYS9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Bhc3RlTWl4ZWRDb250ZW50Lm1tIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9QYXN0ZU1peGVkQ29udGVudC5tbQpp bmRleCA1Yjk4MGVlYTMxMTBlZmI5NmM2MGY2YmU1NDE3YTU0NjA0MTU3YzAxLi5kY2IyYWUwN2Iy ZWYyOGZiNWJkZmNmM2E5OWY3ZDkwYjE3MTIyMzhmIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Bhc3RlTWl4ZWRDb250ZW50Lm1tCisrKyBiL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUGFzdGVNaXhlZENvbnRlbnQubW0KQEAg LTI5OSw2ICsyOTksOSBAQCBURVNUKFBhc3RlTWl4ZWRDb250ZW50LCBQYXN0ZU9uZU9yTW9yZVVS THMpCiAKICNlbmRpZiAvLyBQTEFURk9STShNQUMpCiAKK3N0YXRpYyBib29sIGRvbmU7CitzdGF0 aWMgYm9vbCBkaWRDb3B5OworCiBURVNUKFBhc3RlTWl4ZWRDb250ZW50LCBDb3B5QW5kUGFzdGVX aXRoQ3VzdG9tUGFzdGVib2FyZERhdGFPbmx5KQogewogICAgIE5TU3RyaW5nICptYXJrdXBGb3JT b3VyY2UgPSBAIjxib2R5IG9uY29weT1cImV2ZW50LnByZXZlbnREZWZhdWx0KCk7IGV2ZW50LmNs aXBib2FyZERhdGEuc2V0RGF0YSgnZm9vJywgJ2JhcicpXCI+aGVsbG88L2JvZHk+IjsKQEAgLTMx Myw3ICszMTYsMTUgQEAgVEVTVChQYXN0ZU1peGVkQ29udGVudCwgQ29weUFuZFBhc3RlV2l0aEN1 c3RvbVBhc3RlYm9hcmREYXRhT25seSkKICAgICBhdXRvIHNvdXJjZSA9IGFkb3B0TlMoW1tUZXN0 V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1ha2UoMCwgMCwgNDAwLCA0MDAp IGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbi5nZXQoKV0pOwogICAgIFtzb3VyY2Ugc3luY2hy b25vdXNseUxvYWRIVE1MU3RyaW5nOm1hcmt1cEZvclNvdXJjZSBiYXNlVVJMOltOU1VSTCBVUkxX aXRoU3RyaW5nOkAic2FtZTovLyJdXTsKICAgICBbc291cmNlIHNlbGVjdEFsbDpuaWxdOwotICAg IFtzb3VyY2UgX2V4ZWN1dGVFZGl0Q29tbWFuZDpAImNvcHkiIGFyZ3VtZW50Om5pbCBjb21wbGV0 aW9uOm5pbF07CisKKyAgICBkb25lID0gZmFsc2U7CisgICAgZGlkQ29weSA9IGZhbHNlOworICAg IFtzb3VyY2UgX2V4ZWN1dGVFZGl0Q29tbWFuZDpAImNvcHkiIGFyZ3VtZW50Om5pbCBjb21wbGV0 aW9uOl4oQk9PTCBzdWNjZXNzKSB7CisgICAgICAgIGRpZENvcHkgPSBzdWNjZXNzOworICAgICAg ICBkb25lID0gdHJ1ZTsKKyAgICB9XTsKKyAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRv bmUpOworICAgIEVYUEVDVF9UUlVFKGRpZENvcHkpOwogCiAgICAgYXV0byBkZXN0aW5hdGlvbiA9 IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1ha2Uo MCwgMCwgNDAwLCA0MDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbi5nZXQoKV0pOwogICAg IFtkZXN0aW5hdGlvbiBzeW5jaHJvbm91c2x5TG9hZEhUTUxTdHJpbmc6bWFya3VwRm9yRGVzdGlu YXRpb24gYmFzZVVSTDpbTlNVUkwgVVJMV2l0aFN0cmluZzpAInNhbWU6Ly8iXV07Cg== 391683 2020-02-25 14:10:21 -0800 2020-02-25 14:11:33 -0800 To land bug-208214-20200225141020.patch text/plain 2215 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MzY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmVmNWYwNTFiODEyOTJjN2EwMWVlMjY5MDY3NGNjYTBk YjU1NmM5Ni4uOTM2YzI4ZTFhMDRkZDIzNDA4NDIwNWRhYmIzM2VmYzlkNmQzMDAzZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIwLTAyLTI1ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBUZXN0V2ViS2l0QVBJLlBhc3RlTWl4ZWRDb250ZW50LkNvcHlBbmRQYXN0ZVdpdGhDdXN0 b21QYXN0ZWJvYXJkRGF0YU9ubHkgc2hvdWxkIHdhaXQgdW50aWwgY29weSBvcGVyYXRpb24gY29t cGxldGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDgyMTQKKworICAgICAgICBSZXZpZXdlZCBieSBXZW5zb24gSHNpZWguCisKKyAgICAgICAgV2Fp dCB1bnRpbCB0aGUgY29weSBvcGVyYXRpb24gY29tcGxldGVzIGJlZm9yZSBsb2FkaW5nIHRoZSBz ZWNvbmQgd2ViIHZpZXcgYW5kIHRlc3RpbmcgcGFzdGUKKyAgICAgICAgdG8gZW5zdXJlIHRoYXQg c29tZXRoaW5nIHdhcyBhY3R1YWxseSBjb3BpZWQgdG8gdGhlIGNsaXBib2FyZC4KKworICAgICAg ICAqIFRlc3RXZWJLaXRBUEkvVGVzdFdlYktpdEFQSS54Y29kZXByb2oveGNzaGFyZWRkYXRhL3hj c2NoZW1lcy9UZXN0V2ViS2l0QVBJLnhjc2NoZW1lOgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvUGFzdGVNaXhlZENvbnRlbnQubW06CisgICAgICAgIChUZXN0V2Vi S2l0QVBJOjpURVNUKTogU3Vic3RpdHV0ZSAtX3N5bmNocm9ub3VzbHlFeGVjdXRlRWRpdENvbW1h bmQgZm9yIC1fZXhlY3V0ZUVkaXRDb21tYW5kCisgICAgICAgIHNvIHRoYXQgd2Ugd2FpdCB1bnRp bCB0aGUgY29tbWFuZCBjb21wbGV0ZXMuCisKIDIwMjAtMDItMjUgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjU2ODgyKTogQ2FuJ3QgZHJh ZyBhbiBIVE1MIGZpbGUgaW50byBhIG5ldyAoZW1wdHkpIFNhZmFyaSB0YWIKZGlmZiAtLWdpdCBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUGFzdGVNaXhlZENvbnRlbnQu bW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Bhc3RlTWl4ZWRDb250 ZW50Lm1tCmluZGV4IDViOTgwZWVhMzExMGVmYjk2YzYwZjZiZTU0MTdhNTQ2MDQxNTdjMDEuLjg3 OTViNDk5ZmNkNzBiMjZmMDRkMzE5ZGRmYTNkMjA4YjdiZTcyNTcgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUGFzdGVNaXhlZENvbnRlbnQubW0KKysr IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9QYXN0ZU1peGVkQ29udGVu dC5tbQpAQCAtMzEzLDcgKzMxMyw3IEBAIFRFU1QoUGFzdGVNaXhlZENvbnRlbnQsIENvcHlBbmRQ YXN0ZVdpdGhDdXN0b21QYXN0ZWJvYXJkRGF0YU9ubHkpCiAgICAgYXV0byBzb3VyY2UgPSBhZG9w dE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpDR1JlY3RNYWtlKDAsIDAs IDQwMCwgNDAwKSBjb25maWd1cmF0aW9uOmNvbmZpZ3VyYXRpb24uZ2V0KCldKTsKICAgICBbc291 cmNlIHN5bmNocm9ub3VzbHlMb2FkSFRNTFN0cmluZzptYXJrdXBGb3JTb3VyY2UgYmFzZVVSTDpb TlNVUkwgVVJMV2l0aFN0cmluZzpAInNhbWU6Ly8iXV07CiAgICAgW3NvdXJjZSBzZWxlY3RBbGw6 bmlsXTsKLSAgICBbc291cmNlIF9leGVjdXRlRWRpdENvbW1hbmQ6QCJjb3B5IiBhcmd1bWVudDpu aWwgY29tcGxldGlvbjpuaWxdOworICAgIFtzb3VyY2UgX3N5bmNocm9ub3VzbHlFeGVjdXRlRWRp dENvbW1hbmQ6QCJjb3B5IiBhcmd1bWVudDpuaWxdOwogCiAgICAgYXV0byBkZXN0aW5hdGlvbiA9 IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1ha2Uo MCwgMCwgNDAwLCA0MDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbi5nZXQoKV0pOwogICAg IFtkZXN0aW5hdGlvbiBzeW5jaHJvbm91c2x5TG9hZEhUTUxTdHJpbmc6bWFya3VwRm9yRGVzdGlu YXRpb24gYmFzZVVSTDpbTlNVUkwgVVJMV2l0aFN0cmluZzpAInNhbWU6Ly8iXV07Cg==