208213 2020-02-25 12:46:30 -0800 Stub Repository needs to call the scm constructor 2020-02-25 15:06:24 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jlewis3 jlewis3 ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1622706 0 jlewis3 2020-02-25 12:46:30 -0800 stub_repository.py needs to call the scm constructor. 1622727 1 webkit-bug-importer 2020-02-25 13:41:59 -0800 <rdar://problem/59778312> 1622736 2 391681 jlewis3 2020-02-25 13:52:12 -0800 Created attachment 391681 Patch This is actually the correct fix I think as when adding stub repository support initially we left out the scm initilization due to trying to override the fact that we don't actually have a SCM. Initiallizing it could have further complications with the filesystems that getr passed around. 1622738 3 391681 jbedard 2020-02-25 13:54:47 -0800 Comment on attachment 391681 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391681&action=review > Tools/Scripts/webkitpy/common/checkout/scm/stub_repository.py:42 > + self.checkout_root = self.find_checkout_root(cwd) Can we call out in a comment why we aren't calling the parent's constructor? That's the sort of mistake I would expect a future contributor to make. 1622756 4 391686 jlewis3 2020-02-25 14:18:16 -0800 Created attachment 391686 Patch Added a comment to signify why we aren't calling the parent. 1622768 5 jlewis3 2020-02-25 15:06:24 -0800 Committed r257378: <https://trac.webkit.org/changeset/257378> 391681 2020-02-25 13:52:12 -0800 2020-02-25 14:18:14 -0800 Patch bug-208213-20200225135212.patch text/plain 1347 jlewis3 U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MTQ0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmVkOTAwNWMxZjE1NDFhNTQxMWZjN2M5MThkZDFkMTky ZWY5MTBiMy4uYjhiOWIwMDU0NWIyNThiNDlkYjMwOTZhMTVmYzAyYjg5ZDg5OTFjYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTAyLTI1ICBNYXR0IExld2lzICA8amxld2lzM0BhcHBsZS5jb20+CisKKyAgICAg ICAgQWRkIGNoZWNrb3V0X3Jvb3QgdG8gc3R1YnJlcG9zaXRvcnkucHkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODIxMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21t b24vY2hlY2tvdXQvc2NtL3N0dWJfcmVwb3NpdG9yeS5weToKKyAgICAgICAgKFN0dWJSZXBvc2l0 b3J5Ll9faW5pdF9fKToKKwogMjAyMC0wMi0yMCAgTWF0dCBMZXdpcyAgPGpsZXdpczNAYXBwbGUu Y29tPgogCiAgICAgICAgIFN0dWIgcmVwb3NpdG9yaWVzIGZhaWwgdG8gdXBsb2FkIHNvbWUgcmVz dWx0cyBkdWUgdG8gbWlzc2luZyBoZWFkIHN2biByZXZpc2lvbgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3N0dWJfcmVwb3NpdG9yeS5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9zdHViX3JlcG9zaXRv cnkucHkKaW5kZXggODg2NzlhMTA0NjIxMDcwZDk4NzE3ZTY0YTI5YWMxMjUyOGNiN2JiMS4uOWI4 ZjU0ZTdiNmRjMmYwOWZlNWNmYjlkYmJlMGIwNGM1OWI4YjQ3NiAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3N0dWJfcmVwb3NpdG9yeS5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vc3R1Yl9yZXBv c2l0b3J5LnB5CkBAIC0zOSw2ICszOSw3IEBAIGNsYXNzIFN0dWJSZXBvc2l0b3J5KFNDTSk6CiAK ICAgICBkZWYgX19pbml0X18oc2VsZiwgY3dkLCBmaWxlc3lzdGVtLCAqKmt3YXJncyk6CiAgICAg ICAgIHNlbGYuX2ZpbGVzeXN0ZW0gPSBmaWxlc3lzdGVtCisgICAgICAgIHNlbGYuY2hlY2tvdXRf cm9vdCA9IHNlbGYuZmluZF9jaGVja291dF9yb290KGN3ZCkKIAogICAgIEBjbGFzc21ldGhvZAog ICAgIGRlZiBfZmluZF9wYXJlbnRfcGF0aF9tYXRjaGluZ19jYWxsYmFja19jb25kaXRpb24oY2xz LCBwYXRoLCBjYWxsYmFjaywgZmlsZXN5c3RlbT1Ob25lKToK 391686 2020-02-25 14:18:16 -0800 2020-02-25 15:03:28 -0800 Patch bug-208213-20200225141815.patch text/plain 1797 jlewis3 U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MTQ0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmVkOTAwNWMxZjE1NDFhNTQxMWZjN2M5MThkZDFkMTky ZWY5MTBiMy4uZDBlOGQyODA2MzU3NTg3NDIxZTM3NzA4NDM1MTk1ZThmMjFkOTZiMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIwLTAyLTI1ICBNYXR0IExld2lzICA8amxld2lzM0BhcHBsZS5jb20+CisKKyAgICAg ICAgQWRkIGNoZWNrb3V0X3Jvb3QgdG8gc3R1YnJlcG9zaXRvcnkucHkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODIxMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21t b24vY2hlY2tvdXQvc2NtL3N0dWJfcmVwb3NpdG9yeS5weToKKyAgICAgICAgKFN0dWJSZXBvc2l0 b3J5Ll9faW5pdF9fKToKKworICAgICAgICBXZSBhcmUgY3JlYXRpbmcgb3VyIG93biBjbGFzcyB2 YXJpYWJsZSBmb3IgY2hlY2tvdXRfcm9vdCByYXRoZXIgdGhhbiBjYWxsaW5nIHRoZSBwYXJlbnQg U0NNIHZhcmlhYmxlCisgICAgICAgIGJlY2F1c2Ugd2hlbiBpbml0aWFsbHkgd2UgbGVmdCBvdXQg dGhlIHBhcmVudCBjb25zdHJ1Y3RvciBkdWUgdG8gdHJ5aW5nIHRvIG92ZXJyaWRlIHRoZSBmYWN0 IHRoYXQgd2UgZG9uJ3QgYWN0dWFsbHkgaGF2ZSBhIFNDTS4KKwogMjAyMC0wMi0yMCAgTWF0dCBM ZXdpcyAgPGpsZXdpczNAYXBwbGUuY29tPgogCiAgICAgICAgIFN0dWIgcmVwb3NpdG9yaWVzIGZh aWwgdG8gdXBsb2FkIHNvbWUgcmVzdWx0cyBkdWUgdG8gbWlzc2luZyBoZWFkIHN2biByZXZpc2lv bgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2Nt L3N0dWJfcmVwb3NpdG9yeS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNr b3V0L3NjbS9zdHViX3JlcG9zaXRvcnkucHkKaW5kZXggODg2NzlhMTA0NjIxMDcwZDk4NzE3ZTY0 YTI5YWMxMjUyOGNiN2JiMS4uM2JiOTFlMmJiN2E3ZGFlZDI3YTBkMmI2Y2Q0ZjFjNTEzZGJjZWRj YSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2Nt L3N0dWJfcmVwb3NpdG9yeS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9j aGVja291dC9zY20vc3R1Yl9yZXBvc2l0b3J5LnB5CkBAIC0zOCw3ICszOCw5IEBAIGNsYXNzIFN0 dWJSZXBvc2l0b3J5KFNDTSk6CiAgICAgX3N0dWJfcmVwb3NpdG9yeV9qc29uID0gJ2NoZWNrb3V0 X2luZm9ybWF0aW9uLmpzb24nCiAKICAgICBkZWYgX19pbml0X18oc2VsZiwgY3dkLCBmaWxlc3lz dGVtLCAqKmt3YXJncyk6CisgICAgICAgICMgV2UgY3JlYXRlIG91ciBvd24gY2hlY2tvdXQgcm9v dCBhbmQgZmlsZXN5c3RlbSBoZXJlIGJlY2F1c2Ugd2UgYXJlIHdvcmtpbmcgYXJvdW5kIHRoZSBm YWN0IHRoYXQgd2UgZG9uJ3QgaGF2ZSBhbmQgYWN0dWFsIFNDTSBzY2hlbWUuCiAgICAgICAgIHNl bGYuX2ZpbGVzeXN0ZW0gPSBmaWxlc3lzdGVtCisgICAgICAgIHNlbGYuY2hlY2tvdXRfcm9vdCA9 IHNlbGYuZmluZF9jaGVja291dF9yb290KGN3ZCkKIAogICAgIEBjbGFzc21ldGhvZAogICAgIGRl ZiBfZmluZF9wYXJlbnRfcGF0aF9tYXRjaGluZ19jYWxsYmFja19jb25kaXRpb24oY2xzLCBwYXRo LCBjYWxsYmFjaywgZmlsZXN5c3RlbT1Ob25lKToK