208210 2020-02-25 10:47:49 -0800 [WinCairo] Fix build after revisions 257357 and 257354 2020-02-25 11:36:15 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead basuke cmarcelo commit-queue ews-watchlist galpeter kondapallykalyan luiz noam webkit-bug-importer oldest_to_newest 1622669 0 don.olmstead 2020-02-25 10:47:49 -0800 Couple compilation issues cropped up due to our EWS being in a bad state. 1622673 1 391669 don.olmstead 2020-02-25 10:49:32 -0800 Created attachment 391669 Patch 1622677 2 391669 basuke 2020-02-25 10:54:03 -0800 Comment on attachment 391669 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391669&action=review > Source/WebCore/platform/network/curl/CookieJarDB.cpp:507 > + auto expires = cookie.expires.valueOr(0.0); Looks good to me 1622692 3 391669 commit-queue 2020-02-25 11:35:20 -0800 Comment on attachment 391669 Patch Clearing flags on attachment: 391669 Committed r257368: <https://trac.webkit.org/changeset/257368> 1622693 4 commit-queue 2020-02-25 11:35:22 -0800 All reviewed patches have been landed. Closing bug. 1622694 5 webkit-bug-importer 2020-02-25 11:36:15 -0800 <rdar://problem/59773138> 391669 2020-02-25 10:49:32 -0800 2020-02-25 11:35:20 -0800 Patch bug-208210.diff text/plain 2845 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYWNjNTlmNWY2NTMuLmNmMmZiY2MzYTg4ZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIwLTAyLTI1ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29u eS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBGaXggYnVpbGQgYWZ0ZXIgcmV2aXNpb25zIDI1 NzM1NyBhbmQgMjU3MzU0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDgyMTAKKworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6bm90aWZ5 Q2hhbmdlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFyREIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Q29va2llSmFyREI6OnNldENvb2tpZSk6CisKIDIwMjAtMDIt MjUgIFNpaHVpIExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CiAKICAgICAgICAgQXNzZXJ0aW9u IGZhaWxlZDogY3VycmVudFNjaGVtYSA9PSBjcmVhdGVWMU9iamVjdFN0b3JlSW5mb1NjaGVtYShv YmplY3RTdG9yZUluZm9UYWJsZU5hbWUpIHx8IGN1cnJlbnRTY2hlbWEgPT0gY3JlYXRlVjFPYmpl Y3RTdG9yZUluZm9TY2hlbWEob2JqZWN0U3RvcmVJbmZvVGFibGVOYW1lQWx0ZXJuYXRlKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNz TGF5ZXJUZXh0dXJlTWFwcGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAKaW5kZXggYjcyNDNlOTk0YzAw Li5iZTY2ZDQ3MDJiMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVy LmNwcApAQCAtNTMsNyArNTMsNyBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpu b3RpZnlDaGFuZ2UoQ2hhbmdlTWFzayBjaGFuZ2VNYXNrKQogICAgIG1fY2hhbmdlTWFzayB8PSBj aGFuZ2VNYXNrOwogCiAgICAgaWYgKGZsdXNoUmVxdWlyZWQpCi0gICAgICAgIGNsaWVudCgpLm5v dGlmeUZsdXNoUmVxdWlyZWQodGhpcyk7CisgICAgICAgIGNsaWVudCgpLm5vdGlmeVJlbmRlcmlu Z1VwZGF0ZVJlcXVpcmVkKHRoaXMpOwogfQogCiBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6 fkdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9Db29raWVKYXJEQi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFyREIuY3BwCmluZGV4IDI1OTJlYmU3NDE3YS4u MDJiMGY2MzM4ODMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvQ29va2llSmFyREIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY3VybC9Db29raWVKYXJEQi5jcHAKQEAgLTUwNCw3ICs1MDQsOCBAQCBib29sIENvb2tpZUph ckRCOjpjYW5BY2NlcHRDb29raWUoY29uc3QgQ29va2llJiBjb29raWUsIGNvbnN0IFVSTCYgZmly c3RQYXJ0eSwgYwogCiBib29sIENvb2tpZUphckRCOjpzZXRDb29raWUoY29uc3QgQ29va2llJiBj b29raWUpCiB7Ci0gICAgaWYgKCFjb29raWUuc2Vzc2lvbiAmJiBNb25vdG9uaWNUaW1lOjpmcm9t UmF3U2Vjb25kcyhjb29raWUuZXhwaXJlcykgPD0gTW9ub3RvbmljVGltZTo6bm93KCkpCisgICAg YXV0byBleHBpcmVzID0gY29va2llLmV4cGlyZXMudmFsdWVPcigwLjApOworICAgIGlmICghY29v a2llLnNlc3Npb24gJiYgTW9ub3RvbmljVGltZTo6ZnJvbVJhd1NlY29uZHMoZXhwaXJlcykgPD0g TW9ub3RvbmljVGltZTo6bm93KCkpCiAgICAgICAgIHJldHVybiBkZWxldGVDb29raWVJbnRlcm5h bChjb29raWUubmFtZSwgY29va2llLmRvbWFpbiwgY29va2llLnBhdGgpOwogCiAgICAgYXV0byYg c3RhdGVtZW50ID0gcHJlcGFyZWRTdGF0ZW1lbnQoU0VUX0NPT0tJRV9TUUwpOwpAQCAtNTE0LDcg KzUxNSw3IEBAIGJvb2wgQ29va2llSmFyREI6OnNldENvb2tpZShjb25zdCBDb29raWUmIGNvb2tp ZSkKICAgICBzdGF0ZW1lbnQuYmluZFRleHQoMiwgY29va2llLnZhbHVlKTsKICAgICBzdGF0ZW1l bnQuYmluZFRleHQoMywgY29va2llLmRvbWFpbik7CiAgICAgc3RhdGVtZW50LmJpbmRUZXh0KDQs IGNvb2tpZS5wYXRoKTsKLSAgICBzdGF0ZW1lbnQuYmluZEludDY0KDUsIGNvb2tpZS5zZXNzaW9u ID8gMCA6IHN0YXRpY19jYXN0PGludDY0X3Q+KGNvb2tpZS5leHBpcmVzKSk7CisgICAgc3RhdGVt ZW50LmJpbmRJbnQ2NCg1LCBjb29raWUuc2Vzc2lvbiA/IDAgOiBzdGF0aWNfY2FzdDxpbnQ2NF90 PihleHBpcmVzKSk7CiAgICAgc3RhdGVtZW50LmJpbmRJbnQoNiwgY29va2llLnZhbHVlLmxlbmd0 aCgpKTsKICAgICBzdGF0ZW1lbnQuYmluZEludCg3LCBjb29raWUuc2Vzc2lvbiA/IDEgOiAwKTsK ICAgICBzdGF0ZW1lbnQuYmluZEludCg4LCBjb29raWUuaHR0cE9ubHkgPyAxIDogMCk7Cg==