208169 2020-02-24 16:39:06 -0800 AX: Support relative frames for isolated trees correctly 2020-02-24 22:22:18 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach webkit-unassigned aboxhall apinheiro commit-queue dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer zalan oldest_to_newest 1622400 0 cfleizach 2020-02-24 16:39:06 -0800 To support relative frames correctly 1) only expose for isolated tree clients 2) we need to support FloatRects in the attribute variants 3) also fix an issue where we weren't reserving capacity before using 1622401 1 webkit-bug-importer 2020-02-24 16:39:19 -0800 <rdar://problem/59746529> 1622409 2 391602 cfleizach 2020-02-24 16:40:39 -0800 Created attachment 391602 patch 1622498 3 391602 commit-queue 2020-02-24 22:22:16 -0800 Comment on attachment 391602 patch Clearing flags on attachment: 391602 Committed r257294: <https://trac.webkit.org/changeset/257294> 1622499 4 commit-queue 2020-02-24 22:22:18 -0800 All reviewed patches have been landed. Closing bug. 391602 2020-02-24 16:40:39 -0800 2020-02-24 22:22:16 -0800 patch file_208169.txt text/plain 4379 cfleizach ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZw0KaW5kZXggZjFhMDhkMWEyYWEuLjI2ZjBhZDE5YzdlIDEwMDY0NA0KLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nDQorKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cNCkBA IC0xLDMgKzEsMjQgQEANCisyMDIwLTAyLTI0ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBh cHBsZS5jb20+DQorDQorICAgICAgICBBWDogU3VwcG9ydCByZWxhdGl2ZSBmcmFtZXMgZm9yIGlz b2xhdGVkIHRyZWVzIGNvcnJlY3RseQ0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwODE2OQ0KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5NzQ2NTI5 Pg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQorDQorICAgICAgICBU byBzdXBwb3J0IHJlbGF0aXZlIGZyYW1lcyBjb3JyZWN0bHkgZm9yIGFjY2Vzc2liaWxpdHksIHdl IHNob3VsZDoNCisgICAgICAgICAgMSkgT25seSBleHBvc2UgZm9yIGlzb2xhdGVkIHRyZWUgY2xp ZW50cy4NCisgICAgICAgICAgMikgU3VwcG9ydCBGbG9hdFJlY3RzIGluIHRoZSBhdHRyaWJ1dGUg dmFyaWFudHMuDQorICAgICAgICAgIA0KKyAgICAgICAgVGhpcyBwYXRjaCBhbHNvIGZpeGVzIGFu IGlzc3VlIHdoZXJlIHdlIHdlcmVuJ3QgcmVzZXJ2aW5nIGNhcGFjaXR5IGJlZm9yZSB1c2luZy4N CisNCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVj dC5jcHA6DQorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZE9iamVjdDo6c2V0T2JqZWN0VmVj dG9yUHJvcGVydHkpOg0KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElz b2xhdGVkT2JqZWN0Lmg6DQorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2li aWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tOg0KKyAgICAgICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXIgYWRkaXRpb25hbEFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVOYW1lc10pOg0KKyAg ICAgICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgQUxMT1dfREVQUkVDQVRFRF9J TVBMRU1FTlRBVElPTlNfRU5EXSk6DQorDQogMjAyMC0wMi0yNCAgWmFsYW4gQnVqdGFzICA8emFs YW5AYXBwbGUuY29tPg0KIA0KICAgICAgICAgW0xGQ11bSUZDXVtGbG9hdHNdIE1vdmUgZmxvYXQg aGFuZGxpbmcgb3V0IG9mIExpbmVCcmVha2VyDQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcA0K aW5kZXggZmVhNzkzMzkwODYuLmMwNGIwNDYxZTY3IDEwMDY0NA0KLS0tIGEvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHANCisrKyBi L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmpl Y3QuY3BwDQpAQCAtNDAyLDcgKzQwMiw5IEBAIHZvaWQgQVhJc29sYXRlZE9iamVjdDo6c2V0T2Jq ZWN0VmVjdG9yUHJvcGVydHkoQVhQcm9wZXJ0eU5hbWUgcHJvcGVydHlOYW1lLCBjb25zDQogICAg IGlmICghY2hpbGRyZW4uc2l6ZSgpKQ0KICAgICAgICAgcmV0dXJuOw0KIA0KLSAgICBWZWN0b3I8 QVhJRD4gY2hpbGRJRHMoY2hpbGRyZW4uc2l6ZSgpKTsNCisgICAgVmVjdG9yPEFYSUQ+IGNoaWxk SURzOw0KKyAgICBjaGlsZElEcy5yZXNlcnZlQ2FwYWNpdHkoY2hpbGRyZW4uc2l6ZSgpKTsNCisN CiAgICAgZm9yIChhdXRvIGNoaWxkIDogY2hpbGRyZW4pDQogICAgICAgICBjaGlsZElEcy51bmNo ZWNrZWRBcHBlbmQoY2hpbGQtPm9iamVjdElEKCkpOw0KIA0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuaCBiL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3Qu aA0KaW5kZXggMTFlMDljMjA0YmMuLmExMmVmMWRjOGYwIDEwMDY0NA0KLS0tIGEvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5oDQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2Jq ZWN0LmgNCkBAIC0zMjksNyArMzI5LDcgQEAgcHJpdmF0ZToNCiAgICAgICAgIFZlY3RvcjxBWElE PiB0ZXh0RWxlbWVudHM7DQogICAgIH07DQogICAgIA0KLSAgICB1c2luZyBBdHRyaWJ1dGVWYWx1 ZVZhcmlhbnQgPSBWYXJpYW50PHN0ZDo6bnVsbHB0cl90LCBTdHJpbmcsIGJvb2wsIGludCwgdW5z aWduZWQsIGRvdWJsZSwgZmxvYXQsIHVpbnQ2NF90LCBDb2xvciwgVVJMLCBMYXlvdXRSZWN0LCBB WElELCBJbnRQb2ludCwgT3B0aW9uU2V0PFNwZWFrQXM+LCBWZWN0b3I8QWNjZXNzaWJpbGl0eUlz b2xhdGVkVHJlZVRleHQ+LCBWZWN0b3I8QVhJRD4sIFZlY3RvcjxBY2Nlc3NpYmlsaXR5SXNvbGF0 ZWRUcmVlTWF0aE11bHRpc2NyaXB0UGFpcj4sIFZlY3RvcjxTdHJpbmc+PjsNCisgICAgdXNpbmcg QXR0cmlidXRlVmFsdWVWYXJpYW50ID0gVmFyaWFudDxzdGQ6Om51bGxwdHJfdCwgU3RyaW5nLCBi b29sLCBpbnQsIHVuc2lnbmVkLCBkb3VibGUsIGZsb2F0LCB1aW50NjRfdCwgQ29sb3IsIFVSTCwg TGF5b3V0UmVjdCwgRmxvYXRSZWN0LCBBWElELCBJbnRQb2ludCwgT3B0aW9uU2V0PFNwZWFrQXM+ LCBWZWN0b3I8QWNjZXNzaWJpbGl0eUlzb2xhdGVkVHJlZVRleHQ+LCBWZWN0b3I8QVhJRD4sIFZl Y3RvcjxBY2Nlc3NpYmlsaXR5SXNvbGF0ZWRUcmVlTWF0aE11bHRpc2NyaXB0UGFpcj4sIFZlY3Rv cjxTdHJpbmc+PjsNCiAgICAgdm9pZCBzZXRQcm9wZXJ0eShBWFByb3BlcnR5TmFtZSwgQXR0cmli dXRlVmFsdWVWYXJpYW50JiYsIGJvb2wgc2hvdWxkUmVtb3ZlID0gZmFsc2UpOw0KICAgICB2b2lk IHNldE9iamVjdFByb3BlcnR5KEFYUHJvcGVydHlOYW1lLCBBWENvcmVPYmplY3QqKTsNCiAgICAg dm9pZCBzZXRPYmplY3RWZWN0b3JQcm9wZXJ0eShBWFByb3BlcnR5TmFtZSwgY29uc3QgQWNjZXNz aWJpbGl0eUNoaWxkcmVuVmVjdG9yJik7DQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0gYi9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ck1hYy5tbQ0KaW5kZXggMDM0YjYwZjZiYjEuLjlmMzljNDY3YTM5IDEwMDY0NA0KLS0tIGEvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBw ZXJNYWMubW0NCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vz c2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tDQpAQCAtMTQ3MSw2ICsxNDcxLDExIEBAIEFMTE9X X0RFUFJFQ0FURURfSU1QTEVNRU5UQVRJT05TX0VORA0KICAgICBpZiAoYmFja2luZ09iamVjdC0+ c3VwcG9ydHNFeHBhbmRlZFRleHRWYWx1ZSgpKQ0KICAgICAgICAgW2FkZGl0aW9uYWwgYWRkT2Jq ZWN0Ok5TQWNjZXNzaWJpbGl0eUV4cGFuZGVkVGV4dFZhbHVlQXR0cmlidXRlXTsNCiANCisjaWYg RU5BQkxFKEFDQ0VTU0lCSUxJVFlfSVNPTEFURURfVFJFRSkNCisgICAgaWYgKF9BWFVJRWxlbWVu dFJlcXVlc3RTZXJ2aWNlZEJ5U2Vjb25kYXJ5QVhUaHJlYWQoKSAmJiBBWE9iamVjdENhY2hlOjpj bGllbnRTdXBwb3J0c0lzb2xhdGVkVHJlZSgpKQ0KKyAgICAgICAgW2FkZGl0aW9uYWwgYWRkT2Jq ZWN0Ok5TQWNjZXNzaWJpbGl0eVJlbGF0aXZlRnJhbWVBdHRyaWJ1dGVdOw0KKyNlbmRpZg0KKyAg ICANCiAgICAgcmV0dXJuIGFkZGl0aW9uYWw7DQogfQ0KIA0KQEAgLTE1NDIsNyArMTU0Nyw2IEBA IEFMTE9XX0RFUFJFQ0FURURfSU1QTEVNRU5UQVRJT05TX0VORA0KICAgICAgICAgICAgIE5TQWNj ZXNzaWJpbGl0eUZvY3VzYWJsZUFuY2VzdG9yQXR0cmlidXRlLA0KICAgICAgICAgICAgIE5TQWNj ZXNzaWJpbGl0eUVkaXRhYmxlQW5jZXN0b3JBdHRyaWJ1dGUsDQogICAgICAgICAgICAgTlNBY2Nl c3NpYmlsaXR5SGlnaGVzdEVkaXRhYmxlQW5jZXN0b3JBdHRyaWJ1dGUsDQotICAgICAgICAgICAg TlNBY2Nlc3NpYmlsaXR5UmVsYXRpdmVGcmFtZUF0dHJpYnV0ZSwNCiAgICAgICAgICAgICBuaWxd Ow0KICAgICB9DQogICAgIGlmIChjb21tb25NZW51QXR0cnMgPT0gbmlsKSB7DQo=