<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>208148</bug_id>
          
          <creation_ts>2020-02-24 11:28:53 -0800</creation_ts>
          <short_desc>spinRunLoop should take a non-zero integer as parameter</short_desc>
          <delta_ts>2020-02-25 10:37:31 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sihui Liu">sihui_liu</reporter>
          <assigned_to name="Sihui Liu">sihui_liu</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1622255</commentid>
    <comment_count>0</comment_count>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2020-02-24 11:28:53 -0800</bug_when>
    <thetext>spinRunLoop(0.1) does not run the runloop.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622256</commentid>
    <comment_count>1</comment_count>
      <attachid>391561</attachid>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2020-02-24 11:30:10 -0800</bug_when>
    <thetext>Created attachment 391561
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622622</commentid>
    <comment_count>2</comment_count>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2020-02-25 08:51:45 -0800</bug_when>
    <thetext>The layout test failure on ios-wk2 is not caused by this patch for sure.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622641</commentid>
    <comment_count>3</comment_count>
      <attachid>391561</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-02-25 09:20:03 -0800</bug_when>
    <thetext>Comment on attachment 391561
Patch

Clearing flags on attachment: 391561

Committed r257359: &lt;https://trac.webkit.org/changeset/257359&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622642</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-02-25 09:20:04 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622643</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-02-25 09:21:15 -0800</bug_when>
    <thetext>&lt;rdar://problem/59766682&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622654</commentid>
    <comment_count>6</comment_count>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2020-02-25 09:53:32 -0800</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622655</commentid>
    <comment_count>7</comment_count>
      <attachid>391664</attachid>
    <who name="Sihui Liu">sihui_liu</who>
    <bug_when>2020-02-25 09:53:33 -0800</bug_when>
    <thetext>Created attachment 391664
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622665</commentid>
    <comment_count>8</comment_count>
      <attachid>391664</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-02-25 10:37:30 -0800</bug_when>
    <thetext>Comment on attachment 391664
Patch for landing

Clearing flags on attachment: 391664

Committed r257362: &lt;https://trac.webkit.org/changeset/257362&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1622666</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-02-25 10:37:31 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>391561</attachid>
            <date>2020-02-24 11:30:10 -0800</date>
            <delta_ts>2020-02-25 09:53:30 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-208148-20200224113009.patch</filename>
            <type>text/plain</type>
            <size>2928</size>
            <attacher name="Sihui Liu">sihui_liu</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MjE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGZlYTlkODk5NTAwMjQxZmQ1MDU4NTJkNDFkMDIwNWJk
NzgxMGExNS4uMDhlNzVhNzZiYzZhMGRhZjA4YTBhYTJjNTNkY2JhM2M5NTc1MDNkMCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1
IEBACisyMDIwLTAyLTI0ICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAg
ICAgIHNwaW5SdW5Mb29wIHNob3VsZCB0YWtlIGEgbm9uLXplcm8gaW50ZWdlciBhcyBwYXJhbWV0
ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODE0
OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVz
dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Qcm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbToK
KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1NlcnZpY2VXb3JrZXJC
YXNpYy5tbToKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL2NvY29hL1V0aWxpdGllc0NvY29hLm1t
OgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VXRpbDo6c3BpblJ1bkxvb3ApOgorCiAyMDIwLTAy
LTI0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAg
ICAgV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5fY29yc0Rpc2FibGluZ1BhdHRlcm5zIHNob3VsZCBh
bHNvIGRpc2FibGUgQ09SUyBmb3Igbm9uLURvY3VtZW50VGhyZWFkYWJsZUxvYWRlciBsb2FkaW5n
CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Byb2Nl
c3NTd2FwT25OYXZpZ2F0aW9uLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD
b2NvYS9Qcm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbQppbmRleCA0YTkzNjZjZGQ4ZGZhOTEwMTBj
ODRkZjgzMThlNzYyOTk0ZWY0MDIwLi45MmIyYTk0NWNmMGZmY2E1ODk3NzAyOWMwYjRiZDcxNzg0
ZWMzOTg4IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h
L1Byb2Nlc3NTd2FwT25OYXZpZ2F0aW9uLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz
dHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5hdmlnYXRpb24ubW0KQEAgLTIzMjEsNyArMjMy
MSw3IEBAIHN0YXRpYyB2b2lkIHJ1blF1aWNrQmFja0ZvcndhcmROYXZpZ2F0aW9uVGVzdChTaG91
bGRFbmFibGVQU09OIHNob3VsZEVuYWJsZVBTT04pCiAgICAgICAgIFt3ZWJWaWV3IGdvQmFja107
CiAgICAgICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnNsZWVwKDAuMSk7CiAgICAgICAgIFt3ZWJW
aWV3IGdvRm9yd2FyZF07Ci0gICAgICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnNwaW5SdW5Mb29w
KDAuMSk7CisgICAgICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnNwaW5SdW5Mb29wKCk7CiAgICAg
fQogCiAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkb25lKTsKZGlmZiAtLWdpdCBhL1Rv
b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvU2VydmljZVdvcmtlckJhc2ljLm1t
IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TZXJ2aWNlV29ya2VyQmFz
aWMubW0KaW5kZXggN2UxZTA0NWFiNzYwZWFkNTNmNjYzOGMwMGZjZTIwMWU3NzMwYzk0Yi4uZmRl
YTUwYWRlZjliYmVkYzBkZjEzNTgwNWE5ZDFkOGY3MGVlMGNlZSAxMDA2NDQKLS0tIGEvVG9vbHMv
VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TZXJ2aWNlV29ya2VyQmFzaWMubW0KKysr
IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TZXJ2aWNlV29ya2VyQmFz
aWMubW0KQEAgLTEzMzMsNyArMTMzMyw3IEBAIFRFU1QoU2VydmljZVdvcmtlcnMsIFNlcnZpY2VX
b3JrZXJBbmRDYWNoZVN0b3JhZ2VEZWZhdWx0RGlyZWN0b3JpZXMpCiAgICAgVGVzdFdlYktpdEFQ
STo6VXRpbDo6cnVuKCZkb25lKTsKICAgICBkb25lID0gZmFsc2U7CiAgICAgd2hpbGUgKCFbW2Nv
bmZpZ3VyYXRpb24gd2Vic2l0ZURhdGFTdG9yZV0gX2hhc1JlZ2lzdGVyZWRTZXJ2aWNlV29ya2Vy
XSkKLSAgICAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6c3BpblJ1bkxvb3AoMC4xKTsKKyAgICAg
ICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6c3BpblJ1bkxvb3AoKTsKIAogICAgIHdlYlZpZXcgPSBh
ZG9wdE5TKFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwg
ODAwLCA2MDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbi5nZXQoKV0pOwogCmRpZmYgLS1n
aXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL2NvY29hL1V0aWxpdGllc0NvY29hLm1tIGIvVG9vbHMv
VGVzdFdlYktpdEFQSS9jb2NvYS9VdGlsaXRpZXNDb2NvYS5tbQppbmRleCAyYzhmOTUyY2U1YTM4
MTc3N2Y0NmEwMTBhNTZmZTk2MDQyMTM0NTBhLi5kZDcxOWE5NzNiOTMwMmM3YTgxOTM1OTExYmQy
Yjc2MzNkZDA1NTcwIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL2NvY29hL1V0aWxp
dGllc0NvY29hLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvY29jb2EvVXRpbGl0aWVzQ29j
b2EubW0KQEAgLTM3LDYgKzM3LDcgQEAgdm9pZCBydW4oYm9vbCogZG9uZSkKIAogdm9pZCBzcGlu
UnVuTG9vcCh1aW50NjRfdCBjb3VudCkKIHsKKyAgICBBU1NFUlQoY291bnQpOwogICAgIGZvciAo
dWludDY0X3QgaSA9IDA7IGkgPCBjb3VudDsgKytpKQogICAgICAgICBbW05TUnVuTG9vcCBjdXJy
ZW50UnVuTG9vcF0gcnVuTW9kZTpOU0RlZmF1bHRSdW5Mb29wTW9kZSBiZWZvcmVEYXRlOltOU0Rh
dGUgZGlzdGFudFBhc3RdXTsKIH0K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>391664</attachid>
            <date>2020-02-25 09:53:33 -0800</date>
            <delta_ts>2020-02-25 10:37:30 -0800</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-208148-20200225095332.patch</filename>
            <type>text/plain</type>
            <size>1227</size>
            <attacher name="Sihui Liu">sihui_liu</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MzYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTBhZTdlZTZiNzk1YmQyN2E4MDk1YTQyMWVkYzBiZDM0
NTNlM2Q5Ny4uZWU3MmY0NTY4MTc3NGYyMmJmZGY0OTQ4ZmYzNjhhNmU0M2JiZjI4NyAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0
IEBACisyMDIwLTAyLTI1ICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAg
ICAgIHNwaW5SdW5Mb29wIHNob3VsZCB0YWtlIGEgbm9uLXplcm8gaW50ZWdlciBhcyBwYXJhbWV0
ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODE0
OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTk3NjY2ODI+CisKKyAgICAgICAgVW5yZXZpZXdl
ZCBpT1MgYnVpbGQgZml4LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9jb2NvYS9VdGlsaXRp
ZXNDb2NvYS5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlV0aWw6OnNwaW5SdW5Mb29wKToK
KwogMjAyMC0wMi0yNSAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAgICAg
ICBzcGluUnVuTG9vcCBzaG91bGQgdGFrZSBhIG5vbi16ZXJvIGludGVnZXIgYXMgcGFyYW1ldGVy
CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL2NvY29hL1V0aWxpdGllc0NvY29hLm1t
IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9jb2NvYS9VdGlsaXRpZXNDb2NvYS5tbQppbmRleCBkZDcx
OWE5NzNiOTMwMmM3YTgxOTM1OTExYmQyYjc2MzNkZDA1NTcwLi4yYzhmOTUyY2U1YTM4MTc3N2Y0
NmEwMTBhNTZmZTk2MDQyMTM0NTBhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL2Nv
Y29hL1V0aWxpdGllc0NvY29hLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvY29jb2EvVXRp
bGl0aWVzQ29jb2EubW0KQEAgLTM3LDcgKzM3LDYgQEAgdm9pZCBydW4oYm9vbCogZG9uZSkKIAog
dm9pZCBzcGluUnVuTG9vcCh1aW50NjRfdCBjb3VudCkKIHsKLSAgICBBU1NFUlQoY291bnQpOwog
ICAgIGZvciAodWludDY0X3QgaSA9IDA7IGkgPCBjb3VudDsgKytpKQogICAgICAgICBbW05TUnVu
TG9vcCBjdXJyZW50UnVuTG9vcF0gcnVuTW9kZTpOU0RlZmF1bHRSdW5Mb29wTW9kZSBiZWZvcmVE
YXRlOltOU0RhdGUgZGlzdGFudFBhc3RdXTsKIH0K
</data>

          </attachment>
      

    </bug>

</bugzilla>