208145 2020-02-24 10:46:01 -0800 Document / DOMWindow objects get leaked on CNN.com due to CSSTransitions 2020-04-10 04:01:36 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 208069 1 cdumez cdumez commit-queue graouts graouts webkit-bug-importer oldest_to_newest 1622231 0 cdumez 2020-02-24 10:46:01 -0800 Document / DOMWindow objects get leaked on CNN.com due to CSSTransitions. 1622232 1 391556 cdumez 2020-02-24 10:47:08 -0800 Created attachment 391556 Patch 1622271 2 391556 commit-queue 2020-02-24 12:28:28 -0800 Comment on attachment 391556 Patch Clearing flags on attachment: 391556 Committed r257235: <https://trac.webkit.org/changeset/257235> 1622272 3 commit-queue 2020-02-24 12:28:30 -0800 All reviewed patches have been landed. Closing bug. 1622273 4 webkit-bug-importer 2020-02-24 12:29:16 -0800 <rdar://problem/59735531> 1640113 5 graouts 2020-04-10 04:01:36 -0700 I'm having second thoughts about the change to WeakPtr<Element> for KeyframeEffect. Consider this code: const effect = new KeyframeEffect(document.createElement("div"), {}); What will hold the assigned target alive? 391556 2020-02-24 10:47:08 -0800 2020-02-24 12:28:28 -0800 Patch bug-208145-20200224104706.patch text/plain 4742 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQyN2Q5NzgwMWU4ZTY2 NzM0OGM3Y2E1MjQ5NTEzYjk0ODgwMWRhMy4uYzNkNGYxZmIzOTM0MjljZWU0M2E1MDViZTUyNDlh YTE3NjU3MGI5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAyLTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRG9jdW1lbnQgLyBET01XaW5k b3cgb2JqZWN0cyBnZXQgbGVha2VkIG9uIENOTi5jb20gZHVlIHRvIENTU1RyYW5zaXRpb25zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgxNDUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCcmVhayByZWZl cmVuY2UgY3ljbGVzIHVzaW5nIFdlYWtQdHIgc28gdGhhdCBDU1NUcmFuc2l0aW9ucyBjYW4gbm8g bG9uZ2VyIGNhdXNlIHdob2xlIGRvY3VtZW50IC8gRE9NIHRyZWVzIHRvCisgICAgICAgIGdldCBs ZWFrZWQuCisKKyAgICAgICAgKiBhbmltYXRpb24vRG9jdW1lbnRUaW1lbGluZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEb2N1bWVudFRpbWVsaW5lOjpEb2N1bWVudFRpbWVsaW5lKToKKyAgICAg ICAgKiBhbmltYXRpb24vRG9jdW1lbnRUaW1lbGluZS5oOgorICAgICAgICAqIGFuaW1hdGlvbi9L ZXlmcmFtZUVmZmVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpLZXlmcmFtZUVmZmVjdDo6S2V5 ZnJhbWVFZmZlY3QpOgorICAgICAgICAoV2ViQ29yZTo6S2V5ZnJhbWVFZmZlY3Q6OnNldFRhcmdl dCk6CisgICAgICAgICogYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0Lmg6CisKIDIwMjAtMDItMjQg IEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBX S1dlYlZpZXdDb25maWd1cmF0aW9uLl9jb3JzRGlzYWJsaW5nUGF0dGVybnMgc2hvdWxkIGFsc28g ZGlzYWJsZSBDT1JTIGZvciBub24tRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyIGxvYWRpbmcKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9Eb2N1bWVudFRpbWVsaW5lLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9Eb2N1bWVudFRpbWVsaW5lLmNwcAppbmRleCAzZjA2 ZDBhYzk3OGEyMWEwMGI0NWZjNzZlMTI0ZGU5MmRkNzg2MmExLi5hMzBkM2YwZWU5NWUxZTliZWE0 ODEyYjA3MWU1NzE5NDcwMzM0MmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRp b24vRG9jdW1lbnRUaW1lbGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0Rv Y3VtZW50VGltZWxpbmUuY3BwCkBAIC02NCwxNSArNjQsMTMgQEAgUmVmPERvY3VtZW50VGltZWxp bmU+IERvY3VtZW50VGltZWxpbmU6OmNyZWF0ZShEb2N1bWVudCYgZG9jdW1lbnQsIERvY3VtZW50 VGltZWwKIERvY3VtZW50VGltZWxpbmU6OkRvY3VtZW50VGltZWxpbmUoRG9jdW1lbnQmIGRvY3Vt ZW50LCBTZWNvbmRzIG9yaWdpblRpbWUpCiAgICAgOiBBbmltYXRpb25UaW1lbGluZSgpCiAgICAg LCBtX3RpY2tTY2hlZHVsZVRpbWVyKCp0aGlzLCAmRG9jdW1lbnRUaW1lbGluZTo6c2NoZWR1bGVB bmltYXRpb25SZXNvbHV0aW9uKQotICAgICwgbV9kb2N1bWVudCgmZG9jdW1lbnQpCisgICAgLCBt X2RvY3VtZW50KG1ha2VXZWFrUHRyKGRvY3VtZW50KSkKICAgICAsIG1fb3JpZ2luVGltZShvcmln aW5UaW1lKQogewotICAgIGlmIChtX2RvY3VtZW50KSB7Ci0gICAgICAgIG1fZG9jdW1lbnQtPmFk ZFRpbWVsaW5lKCp0aGlzKTsKLSAgICAgICAgaWYgKGF1dG8qIHBhZ2UgPSBtX2RvY3VtZW50LT5w YWdlKCkpIHsKLSAgICAgICAgICAgIGlmIChwYWdlLT5zZXR0aW5ncygpLmhpZGRlblBhZ2VDU1NB bmltYXRpb25TdXNwZW5zaW9uRW5hYmxlZCgpICYmICFwYWdlLT5pc1Zpc2libGUoKSkKLSAgICAg ICAgICAgICAgICBzdXNwZW5kQW5pbWF0aW9ucygpOwotICAgICAgICB9CisgICAgZG9jdW1lbnQu YWRkVGltZWxpbmUoKnRoaXMpOworICAgIGlmIChhdXRvKiBwYWdlID0gZG9jdW1lbnQucGFnZSgp KSB7CisgICAgICAgIGlmIChwYWdlLT5zZXR0aW5ncygpLmhpZGRlblBhZ2VDU1NBbmltYXRpb25T dXNwZW5zaW9uRW5hYmxlZCgpICYmICFwYWdlLT5pc1Zpc2libGUoKSkKKyAgICAgICAgICAgIHN1 c3BlbmRBbmltYXRpb25zKCk7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9hbmltYXRpb24vRG9jdW1lbnRUaW1lbGluZS5oIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9u L0RvY3VtZW50VGltZWxpbmUuaAppbmRleCA1OTJhOWQ1NGYyMTk3Mjc3YjQwNzE5YzhiM2EwYTdl YWU3ZWRlYWYzLi5mMTkyZjRiNTA2MzRjMjIxNmY4NGYyYmVhNWFlN2IwZjNlOTkwNzlkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vRG9jdW1lbnRUaW1lbGluZS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9Eb2N1bWVudFRpbWVsaW5lLmgKQEAgLTEwNyw3ICsx MDcsNyBAQCBwcml2YXRlOgogICAgIEhhc2hTZXQ8UmVmUHRyPFdlYkFuaW1hdGlvbj4+IG1fYWNj ZWxlcmF0ZWRBbmltYXRpb25zUGVuZGluZ1J1bm5pbmdTdGF0ZUNoYW5nZTsKICAgICBIYXNoU2V0 PEVsZW1lbnQqPiBtX2VsZW1lbnRzV2l0aFJ1bm5pbmdBY2NlbGVyYXRlZEFuaW1hdGlvbnM7CiAg ICAgVmVjdG9yPFJlZjxBbmltYXRpb25FdmVudEJhc2U+PiBtX3BlbmRpbmdBbmltYXRpb25FdmVu dHM7Ci0gICAgUmVmUHRyPERvY3VtZW50PiBtX2RvY3VtZW50OworICAgIFdlYWtQdHI8RG9jdW1l bnQ+IG1fZG9jdW1lbnQ7CiAgICAgTWFya2FibGU8U2Vjb25kcywgU2Vjb25kczo6TWFya2FibGVU cmFpdHM+IG1fY2FjaGVkQ3VycmVudFRpbWU7CiAgICAgU2Vjb25kcyBtX29yaWdpblRpbWU7CiAg ICAgdW5zaWduZWQgbV9udW1iZXJPZkFuaW1hdGlvblRpbWVsaW5lSW52YWxpZGF0aW9uc0ZvclRl c3RpbmcgeyAwIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vS2V5ZnJh bWVFZmZlY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0LmNw cAppbmRleCAwOWVjZDdhNjJhYTEwZTBhNWYyYjBmYjM1YmM0ODZiNWRlMzIxMTdjLi5kY2U1Mjcz NjZiNmEzY2NiZjk0ZmZjZmE1NWNmMjI2MDQ1YTg4NjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Fu aW1hdGlvbi9LZXlmcmFtZUVmZmVjdC5jcHAKQEAgLTUyMSw3ICs1MjEsNyBAQCBSZWY8S2V5ZnJh bWVFZmZlY3Q+IEtleWZyYW1lRWZmZWN0OjpjcmVhdGUoY29uc3QgRWxlbWVudCYgdGFyZ2V0KQog fQogCiBLZXlmcmFtZUVmZmVjdDo6S2V5ZnJhbWVFZmZlY3QoRWxlbWVudCogdGFyZ2V0KQotICAg IDogbV90YXJnZXQodGFyZ2V0KQorICAgIDogbV90YXJnZXQobWFrZVdlYWtQdHIodGFyZ2V0KSkK IHsKIH0KIApAQCAtMTA2NSwxMCArMTA2NSwxMCBAQCB2b2lkIEtleWZyYW1lRWZmZWN0OjpzZXRB bmltYXRpb24oV2ViQW5pbWF0aW9uKiBhbmltYXRpb24pCiAKIHZvaWQgS2V5ZnJhbWVFZmZlY3Q6 OnNldFRhcmdldChSZWZQdHI8RWxlbWVudD4mJiBuZXdUYXJnZXQpCiB7Ci0gICAgaWYgKG1fdGFy Z2V0ID09IG5ld1RhcmdldCkKKyAgICBpZiAobV90YXJnZXQuZ2V0KCkgPT0gbmV3VGFyZ2V0Lmdl dCgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBhdXRvIHByZXZpb3VzVGFyZ2V0ID0gc3RkOjpl eGNoYW5nZShtX3RhcmdldCwgV1RGTW92ZShuZXdUYXJnZXQpKTsKKyAgICBhdXRvIHByZXZpb3Vz VGFyZ2V0ID0gc3RkOjpleGNoYW5nZShtX3RhcmdldCwgbWFrZVdlYWtQdHIobmV3VGFyZ2V0Lmdl dCgpKSk7CiAKICAgICBpZiAoYXV0byogZWZmZWN0QW5pbWF0aW9uID0gYW5pbWF0aW9uKCkpCiAg ICAgICAgIGVmZmVjdEFuaW1hdGlvbi0+ZWZmZWN0VGFyZ2V0RGlkQ2hhbmdlKHByZXZpb3VzVGFy Z2V0LmdldCgpLCBtX3RhcmdldC5nZXQoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9h bmltYXRpb24vS2V5ZnJhbWVFZmZlY3QuaCBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9LZXlm cmFtZUVmZmVjdC5oCmluZGV4IGIyODU1OGFjNGI0MmFmNzRkNTkxOTI5YmVkOWJmNWNlNzZiNzBh ZTkuLjU3YTE3NzQ5ZDA4MzQwZTk3YTQwZGE2OTA5ZmE0NTAxMjI2MGYyZjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdC5oCkBAIC0xOTEsNyArMTkxLDcgQEAgcHJp dmF0ZToKICAgICBLZXlmcmFtZUxpc3QgbV9ibGVuZGluZ0tleWZyYW1lcyB7IGVtcHR5U3RyaW5n KCkgfTsKICAgICBWZWN0b3I8UGFyc2VkS2V5ZnJhbWU+IG1fcGFyc2VkS2V5ZnJhbWVzOwogICAg IFZlY3RvcjxBY2NlbGVyYXRlZEFjdGlvbj4gbV9wZW5kaW5nQWNjZWxlcmF0ZWRBY3Rpb25zOwot ICAgIFJlZlB0cjxFbGVtZW50PiBtX3RhcmdldDsKKyAgICBXZWFrUHRyPEVsZW1lbnQ+IG1fdGFy Z2V0OwogCiAgICAgc3RkOjp1bmlxdWVfcHRyPGNvbnN0IFJlbmRlclN0eWxlPiBtX3VuYW5pbWF0 ZWRTdHlsZTsKIAo=