208144 2020-02-24 10:43:47 -0800 Assertion failed: currentSchema == createV1ObjectStoreInfoSchema(objectStoreInfoTableName) || currentSchema == createV1ObjectStoreInfoSchema(objectStoreInfoTableNameAlternate) 2020-02-25 15:28:33 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen alecflett beidson cdumez commit-queue ews-watchlist jsbell rniwa webkit-bug-importer oldest_to_newest 1622229 0 sihui_liu 2020-02-24 10:43:47 -0800 Replace the release assertion to release logging to gather information about the bug. Crashing network process for failing to open a database seems too aggressive. 1622230 1 sihui_liu 2020-02-24 10:44:20 -0800 <rdar://problem/59687897> 1622234 2 391557 sihui_liu 2020-02-24 10:51:14 -0800 Created attachment 391557 Patch 1622482 3 391557 rniwa 2020-02-24 19:11:54 -0800 Comment on attachment 391557 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391557&action=review > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:692 > - RELEASE_ASSERT(currentSchema == createV1ObjectStoreInfoSchema(objectStoreInfoTableName) || currentSchema == createV1ObjectStoreInfoSchema(objectStoreInfoTableNameAlternate)); > + if (currentSchema != createV1ObjectStoreInfoSchema(objectStoreInfoTableName) && currentSchema != createV1ObjectStoreInfoSchema(objectStoreInfoTableNameAlternate)) { Don't we also want to log objectStoreInfoTableName and objectStoreInfoTableNameAlternate? 1622625 4 sihui_liu 2020-02-25 08:53:36 -0800 (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 391557 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391557&action=review > > > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:692 > > - RELEASE_ASSERT(currentSchema == createV1ObjectStoreInfoSchema(objectStoreInfoTableName) || currentSchema == createV1ObjectStoreInfoSchema(objectStoreInfoTableNameAlternate)); > > + if (currentSchema != createV1ObjectStoreInfoSchema(objectStoreInfoTableName) && currentSchema != createV1ObjectStoreInfoSchema(objectStoreInfoTableNameAlternate)) { > > Don't we also want to log objectStoreInfoTableName and > objectStoreInfoTableNameAlternate? objectStoreInfoTableName and objectStoreInfoTableNameAlternate are constants. 1622650 5 391557 commit-queue 2020-02-25 09:37:58 -0800 Comment on attachment 391557 Patch Clearing flags on attachment: 391557 Committed r257361: <https://trac.webkit.org/changeset/257361> 1622651 6 commit-queue 2020-02-25 09:38:00 -0800 All reviewed patches have been landed. Closing bug. 1622783 7 rniwa 2020-02-25 15:28:33 -0800 (In reply to Sihui Liu from comment #4) > (In reply to Ryosuke Niwa from comment #3) > > Comment on attachment 391557 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=391557&action=review > > > > > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:692 > > > - RELEASE_ASSERT(currentSchema == createV1ObjectStoreInfoSchema(objectStoreInfoTableName) || currentSchema == createV1ObjectStoreInfoSchema(objectStoreInfoTableNameAlternate)); > > > + if (currentSchema != createV1ObjectStoreInfoSchema(objectStoreInfoTableName) && currentSchema != createV1ObjectStoreInfoSchema(objectStoreInfoTableNameAlternate)) { > > > > Don't we also want to log objectStoreInfoTableName and > > objectStoreInfoTableNameAlternate? > > objectStoreInfoTableName and objectStoreInfoTableNameAlternate are constants. Ah, ok. 391557 2020-02-24 10:51:14 -0800 2020-02-25 09:37:58 -0800 Patch bug-208144-20200224105113.patch text/plain 2369 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjFhMDhkMWEyYWE4NjNl MTcxYmFlNjFiMjk0MmVhYzBkOTczZTViOS4uNzI2MWY0YmUzYzM5OTdjM2UwZWQ0ZWFjNmMyNGQw MzczNjYxYzcyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAyLTI0ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEFzc2VydGlvbiBmYWlsZWQ6 IGN1cnJlbnRTY2hlbWEgPT0gY3JlYXRlVjFPYmplY3RTdG9yZUluZm9TY2hlbWEob2JqZWN0U3Rv cmVJbmZvVGFibGVOYW1lKSB8fCBjdXJyZW50U2NoZW1hID09IGNyZWF0ZVYxT2JqZWN0U3RvcmVJ bmZvU2NoZW1hKG9iamVjdFN0b3JlSW5mb1RhYmxlTmFtZUFsdGVybmF0ZSkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODE0NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSBhIHJlbGVhc2UgYXNz ZXJ0aW9uIHRvIHJlbGVhc2UgZXJyb3IgbG9nIHRvIGdhdGhlciBpbmZvcm1hdGlvbiBhYm91dCBi dWcuIFRoaXMgaXMgYWxzbyB0aGUgcGF0dGVybiBvZiAKKyAgICAgICAgaGFuZGxpbmcgZXJyb3Ig ZHVyaW5nIHNjaGVtYSB1cGRhdGUgaW4gU1FMaXRlSURCQmFja2luZ1N0b3JlLiAgCisKKyAgICAg ICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFja2luZ1N0b3JlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OklEQlNlcnZlcjo6U1FMaXRlSURCQmFja2luZ1N0b3JlOjplbnN1 cmVWYWxpZE9iamVjdFN0b3JlSW5mb1RhYmxlKToKKwogMjAyMC0wMi0yNCAgWmFsYW4gQnVqdGFz ICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ11bRmxvYXRzXSBNb3ZlIGZs b2F0IGhhbmRsaW5nIG91dCBvZiBMaW5lQnJlYWtlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1NRTGl0ZUlEQkJhY2tpbmdTdG9yZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFja2luZ1N0 b3JlLmNwcAppbmRleCAzNDA4OGI0ZTU5YjMwMDA0ZGM4MDFkOWIxZDljZjU3YThkM2JjMTFmLi40 NjEzYTgwYmI1ODExZjhkOWEwMjViNTZjYzZhMmU2NGIxMjQwOWJhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFja2luZ1N0b3Jl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRl SURCQmFja2luZ1N0b3JlLmNwcApAQCAtNjg5LDcgKzY4OSwxMCBAQCBPcHRpb25hbDxJc1NjaGVt YVVwZ3JhZGVkPiBTUUxpdGVJREJCYWNraW5nU3RvcmU6OmVuc3VyZVZhbGlkT2JqZWN0U3RvcmVJ bmZvVGFibAogICAgIGlmIChjdXJyZW50U2NoZW1hID09IHYyT2JqZWN0U3RvcmVJbmZvU2NoZW1h IHx8IGN1cnJlbnRTY2hlbWEgPT0gY3JlYXRlVjJPYmplY3RTdG9yZUluZm9TY2hlbWEob2JqZWN0 U3RvcmVJbmZvVGFibGVOYW1lQWx0ZXJuYXRlKSkKICAgICAgICAgcmV0dXJuIHsgSXNTY2hlbWFV cGdyYWRlZDo6Tm8gfTsKIAotICAgIFJFTEVBU0VfQVNTRVJUKGN1cnJlbnRTY2hlbWEgPT0gY3Jl YXRlVjFPYmplY3RTdG9yZUluZm9TY2hlbWEob2JqZWN0U3RvcmVJbmZvVGFibGVOYW1lKSB8fCBj dXJyZW50U2NoZW1hID09IGNyZWF0ZVYxT2JqZWN0U3RvcmVJbmZvU2NoZW1hKG9iamVjdFN0b3Jl SW5mb1RhYmxlTmFtZUFsdGVybmF0ZSkpOworICAgIGlmIChjdXJyZW50U2NoZW1hICE9IGNyZWF0 ZVYxT2JqZWN0U3RvcmVJbmZvU2NoZW1hKG9iamVjdFN0b3JlSW5mb1RhYmxlTmFtZSkgJiYgY3Vy cmVudFNjaGVtYSAhPSBjcmVhdGVWMU9iamVjdFN0b3JlSW5mb1NjaGVtYShvYmplY3RTdG9yZUlu Zm9UYWJsZU5hbWVBbHRlcm5hdGUpKSB7CisgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SKEluZGV4 ZWREQiwgIiVwIC0gU1FMaXRlSURCQmFja2luZ1N0b3JlOjplbnN1cmVWYWxpZE9iamVjdFN0b3Jl SW5mb1RhYmxlOiBzY2hlbWEgaXMgaW52YWxpZCAtICVzIiwgdGhpcywgY3VycmVudFNjaGVtYS51 dGY4KCkuZGF0YSgpKTsKKyAgICAgICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKKyAgICB9CiAKICAg ICAvLyBEcm9wIGNvbHVtbiBtYXhJbmRleElEIGZyb20gdGFibGUuCiAgICAgU1FMaXRlVHJhbnNh Y3Rpb24gdHJhbnNhY3Rpb24oKm1fc3FsaXRlREIpOwo=