208127 2020-02-24 02:21:30 -0800 Protect from null session in NetworkDataTaskCocoa::restrictRequestReferrerToOriginIfNeeded 2020-02-24 08:42:24 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson cdumez commit-queue webkit-bug-importer oldest_to_newest 1622090 0 youennf 2020-02-24 02:21:30 -0800 Protect from null session in NetworkDataTaskCocoa::restrictRequestReferrerToOriginIfNeeded 1622092 1 youennf 2020-02-24 02:30:29 -0800 <rdar://problem/57937917> 1622093 2 391520 youennf 2020-02-24 02:31:27 -0800 Created attachment 391520 Patch 1622094 3 youennf 2020-02-24 02:44:22 -0800 It seems that we should fail all NetworkResourceLoader when the corresponding session goes away. For now, protecting NetworkDataTask seems fine. 1622180 4 commit-queue 2020-02-24 08:41:48 -0800 The commit-queue encountered the following flaky tests while processing attachment 391520: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1622181 5 391520 commit-queue 2020-02-24 08:42:23 -0800 Comment on attachment 391520 Patch Clearing flags on attachment: 391520 Committed r257209: <https://trac.webkit.org/changeset/257209> 1622182 6 commit-queue 2020-02-24 08:42:24 -0800 All reviewed patches have been landed. Closing bug. 391520 2020-02-24 02:31:27 -0800 2020-02-24 08:42:23 -0800 Patch bug-208127-20200224113123.patch text/plain 1797 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2OTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVhMzQyYjVmZDBmMDA0MTU5 OTY5MDZiZTJlZDhlNTQ5NGMwNGNiOGEuLjNhNTQwYWQ2NjIyNmVhZmM3ZDQ1ZjcwMzNhMTgzZTBj NWVmOWExZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDItMjQgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFByb3RlY3QgZnJvbSBudWxsIHNl c3Npb24gaW4gTmV0d29ya0RhdGFUYXNrQ29jb2E6OnJlc3RyaWN0UmVxdWVzdFJlZmVycmVyVG9P cmlnaW5JZk5lZWRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjA4MTI3CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzU3OTM3OTE3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gY2FzZSBvZiBhIGRhdGEg dGFzayB3aG9zZSBzZXNzaW9uIGlzIGRlc3Ryb3llZCwgZG8gbm90IGZvbGxvdyByZWRpcmVjdGlv biBlYXJseSBvbi4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRh VGFza0NvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrRGF0YVRhc2tDb2NvYTo6d2ls bFBlcmZvcm1IVFRQUmVkaXJlY3Rpb24pOgorCiAyMDIwLTAyLTE5ICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgQXVkaW9TZXNzaW9u IGhhbmRsaW5nIGluIEdQVVByb2Nlc3MgZm9yIGNhcHR1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0gYi9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tCmlu ZGV4IDU5ZjU2ZjRiNzNiYWYwZjYzZTZiZTQ1MDdiYzU4N2ZiM2RkZGEyNjguLmQ1YjFlOTY3NTM5 MDhiMjM4NDNkOTJiMDg3YmE2Y2UzZjc2OTMyMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0KKysrIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQpAQCAt NDQ3LDcgKzQ0Nyw3IEBAIHZvaWQgTmV0d29ya0RhdGFUYXNrQ29jb2E6OndpbGxQZXJmb3JtSFRU UFJlZGlyZWN0aW9uKFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmCiAKICAgICBpZiAobV9jbGll bnQpCiAgICAgICAgIG1fY2xpZW50LT53aWxsUGVyZm9ybUhUVFBSZWRpcmVjdGlvbihXVEZNb3Zl KHJlZGlyZWN0UmVzcG9uc2UpLCBXVEZNb3ZlKHJlcXVlc3QpLCBbY29tcGxldGlvbkhhbmRsZXIg PSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSwgdGhpcywgd2Vha1RoaXMgPSBtYWtlV2Vha1B0 cigqdGhpcyldIChhdXRvJiYgcmVxdWVzdCkgbXV0YWJsZSB7Ci0gICAgICAgICAgICBpZiAoIXdl YWtUaGlzKQorICAgICAgICAgICAgaWYgKCF3ZWFrVGhpcyB8fCAhbV9zZXNzaW9uKQogICAgICAg ICAgICAgICAgIHJldHVybiBjb21wbGV0aW9uSGFuZGxlcih7IH0pOwogICAgICAgICAgICAgaWYg KCFyZXF1ZXN0LmlzTnVsbCgpKQogICAgICAgICAgICAgICAgIHJlc3RyaWN0UmVxdWVzdFJlZmVy cmVyVG9PcmlnaW5JZk5lZWRlZChyZXF1ZXN0KTsK