208107 2020-02-23 10:59:23 -0800 [LFC][IFC][Floats] Move float handling out of LineBreaker 2020-02-24 08:12:59 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1622007 0 zalan 2020-02-23 10:59:23 -0800 LineBreaker should only deal with inline content. 1622008 1 webkit-bug-importer 2020-02-23 10:59:39 -0800 <rdar://problem/59708575> 1622009 2 391493 zalan 2020-02-23 11:01:17 -0800 Created attachment 391493 Patch 1622169 3 391493 commit-queue 2020-02-24 08:12:57 -0800 Comment on attachment 391493 Patch Clearing flags on attachment: 391493 Committed r257208: <https://trac.webkit.org/changeset/257208> 1622170 4 commit-queue 2020-02-24 08:12:59 -0800 All reviewed patches have been landed. Closing bug. 391493 2020-02-23 11:01:17 -0800 2020-02-24 08:12:57 -0800 Patch bug-208107-20200223110116.patch text/plain 3833 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjcwMTRlZWQxMzYwMTA0 ZWYwZjcwYjM3NmVkNGFlMTNkZDcxMzdjZC4uNjExNmI0OGJkMTA5MzY2M2QzMmFlMTk2OWYzZDNk ZmExYWRkNTYzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAyLTIzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXVtGbG9hdHNd IE1vdmUgZmxvYXQgaGFuZGxpbmcgb3V0IG9mIExpbmVCcmVha2VyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgxMDcKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzU5NzA4NTc1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIExpbmVCcmVha2VyIHNob3VsZCBvbmx5IGRlYWwgd2l0aCBpbmxpbmUgY29udGVu dC4KKworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCcmVha2Vy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZUJyZWFrZXI6OnNob3VsZFdyYXBG bG9hdEJveCk6IERlbGV0ZWQuCisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5s aW5lTGluZUJyZWFrZXIuaDoKKyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9MaW5l TGF5b3V0Q29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVMYXlvdXRD b250ZXh0Ojp0cnlBZGRpbmdGbG9hdEl0ZW0pOgorCiAyMDIwLTAyLTIyICBEYXJpbiBBZGxlciAg PGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggSFRNTERhdGFMaXN0RWxlbWVudC5vcHRp b25zIHRvIGluY2x1ZGUgZXZlbiBvcHRpb25zIHRoYXQgYXJlIG5vdCBzdWdnZXN0aW9ucwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGlu ZUJyZWFrZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5s aW5lTGluZUJyZWFrZXIuY3BwCmluZGV4IDllOGMyYzlhYmJiNTIwYmE2OTJjYWQwMWNmZTZlYzlk YjcxZjg4ZmUuLjA2MWY0YjAxNmM3NGYwZWE3ODhjOTk4NzE2NGM3Y2QxZGRlODg5M2IgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVC cmVha2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9J bmxpbmVMaW5lQnJlYWtlci5jcHAKQEAgLTIxMywxMSArMjEzLDYgQEAgTGluZUJyZWFrZXI6OlJl c3VsdCBMaW5lQnJlYWtlcjo6dHJ5V3JhcHBpbmdJbmxpbmVDb250ZW50KGNvbnN0IFJ1bkxpc3Qm IGNhbmRpZGEKICAgICByZXR1cm4geyBSZXN1bHQ6OkFjdGlvbjo6S2VlcCwgSXNFbmRPZkxpbmU6 Ok5vIH07CiB9CiAKLWJvb2wgTGluZUJyZWFrZXI6OnNob3VsZFdyYXBGbG9hdEJveChJbmxpbmVM YXlvdXRVbml0IGZsb2F0TG9naWNhbFdpZHRoLCBJbmxpbmVMYXlvdXRVbml0IGF2YWlsYWJsZVdp ZHRoLCBib29sIGxpbmVJc0VtcHR5KQotewotICAgIHJldHVybiAhbGluZUlzRW1wdHkgJiYgZmxv YXRMb2dpY2FsV2lkdGggPiBhdmFpbGFibGVXaWR0aDsKLX0KLQogT3B0aW9uYWw8V3JhcHBlZFRl eHRDb250ZW50PiBMaW5lQnJlYWtlcjo6d3JhcFRleHRDb250ZW50KGNvbnN0IFJ1bkxpc3QmIHJ1 bnMsIGNvbnN0IExpbmVTdGF0dXMmIGxpbmVTdGF0dXMpIGNvbnN0CiB7CiAgICAgYXV0byBpc0Nv bnRlbnRTcGxpdEFsbG93ZWQgPSBbXSAoYXV0byYgcnVuKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnJlYWtlci5oIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJyZWFrZXIuaApp bmRleCBmZDMyMTA5MjQ3NmIxY2IzMjIzN2IxMTEyZGVjYzI0ZDEwZmEyNmNjLi5jOGYzMjY1ZTg4 NTY2ZTkzZWI4YThkZTkwY2JhZmI0NzA1NGU4NzFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnJlYWtlci5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCcmVha2VyLmgKQEAg LTgzLDcgKzgzLDYgQEAgcHVibGljOgogICAgICAgICBib29sIGxpbmVJc0VtcHR5IHsgdHJ1ZSB9 OwogICAgIH07CiAgICAgUmVzdWx0IHNob3VsZFdyYXBJbmxpbmVDb250ZW50KGNvbnN0IFJ1bkxp c3QmIGNhbmRpZGF0ZVJ1bnMsIElubGluZUxheW91dFVuaXQgY2FuZGlkYXRlQ29udGVudExvZ2lj YWxXaWR0aCwgY29uc3QgTGluZVN0YXR1cyYpOwotICAgIGJvb2wgc2hvdWxkV3JhcEZsb2F0Qm94 KElubGluZUxheW91dFVuaXQgZmxvYXRMb2dpY2FsV2lkdGgsIElubGluZUxheW91dFVuaXQgYXZh aWxhYmxlV2lkdGgsIGJvb2wgbGluZUlzRW1wdHkpOwogCiAgICAgdm9pZCBzZXRIeXBoZW5hdGlv bkRpc2FibGVkKCkgeyBuX2h5cGhlbmF0aW9uSXNEaXNhYmxlZCA9IHRydWU7IH0KIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvTGluZUxheW91dENv bnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvTGluZUxh eW91dENvbnRleHQuY3BwCmluZGV4IDhjMTY1YzYxMjdiNmJiNGJmNDNjN2MzMTE2MTUwMGU4MzUy MDBhMzMuLjQwZDE2MmI5Zjg1Y2Q5MDRiODM0MDE1MzkyNmM0YTFkODc0ZmZiNzcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0xpbmVMYXlvdXRDb250 ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9MaW5l TGF5b3V0Q29udGV4dC5jcHAKQEAgLTM4OCw5ICszODgsMTAgQEAgdm9pZCBMaW5lTGF5b3V0Q29u dGV4dDo6bmV4dENvbnRlbnRGb3JMaW5lKExpbmVDYW5kaWRhdGUmIGxpbmVDYW5kaWRhdGUsIHVu c2lnbmUKIExpbmVMYXlvdXRDb250ZXh0OjpSZXN1bHQgTGluZUxheW91dENvbnRleHQ6OnRyeUFk ZGluZ0Zsb2F0SXRlbShMaW5lQnVpbGRlciYgbGluZSwgY29uc3QgSW5saW5lSXRlbSYgZmxvYXRJ dGVtKQogewogICAgIGF1dG8gbG9naWNhbFdpZHRoID0gaW5saW5lSXRlbVdpZHRoKGZsb2F0SXRl bSwgeyB9KTsKLQorICAgIGF1dG8gYXZhaWxhYmxlV2lkdGggPSBsaW5lLmF2YWlsYWJsZVdpZHRo KCkgKyBsaW5lLnRyaW1tYWJsZVRyYWlsaW5nV2lkdGgoKTsKICAgICBhdXRvIGxpbmVJc0NvbnNp ZGVyZWRFbXB0eSA9IGxpbmUuaXNWaXN1YWxseUVtcHR5KCkgJiYgIWxpbmUuaGFzSW50cnVzaXZl RmxvYXQoKTsKLSAgICBpZiAoTGluZUJyZWFrZXIoKS5zaG91bGRXcmFwRmxvYXRCb3gobG9naWNh bFdpZHRoLCBsaW5lLmF2YWlsYWJsZVdpZHRoKCkgKyBsaW5lLnRyaW1tYWJsZVRyYWlsaW5nV2lk dGgoKSwgbGluZUlzQ29uc2lkZXJlZEVtcHR5KSkKKworICAgIGlmIChsb2dpY2FsV2lkdGggPiBh dmFpbGFibGVXaWR0aCAmJiAhbGluZUlzQ29uc2lkZXJlZEVtcHR5KQogICAgICAgICByZXR1cm4g eyBMaW5lQnJlYWtlcjo6SXNFbmRPZkxpbmU6OlllcyB9OwogICAgIC8vIFRoaXMgZmxvYXQgY2Fu IHNpdCBvbiB0aGUgY3VycmVudCBsaW5lLgogICAgIGF1dG8mIGZsb2F0Qm94ID0gZmxvYXRJdGVt LmxheW91dEJveCgpOwo=