208091 2020-02-22 05:42:46 -0800 [GTK] Page is not drawn with PSON, hardware acceleration and address typed in URL bar 2020-04-12 02:27:47 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210287 P2 Normal --- 1 guillaume.webkit webkit-unassigned bfulgham bugs-noreply cgarcia mcatanzaro simon.fraser zalan oldest_to_newest 1621870 0 guillaume.webkit 2020-02-22 05:42:46 -0800 Pages are not drawn when: - hardware acceleration is enabled (it works without), - PSON is enabled (it works in Epiphany 3.35.2 without PSON), - an URL is given in the URL bar (it often works when the page is drawn at startup or when I click on a link). When the cursor is moved on the page, we can see that links are where they are supposed to be on the new page: new page’s layout is done, but the old one is drawn instead. The bug had been reported on Epiphany’s bug tracker, but they said that it’s probably a bug in WebKitGTK. It can be reproduced with Epiphany 3.35.3+ by enabling hardware acceleration and visiting a website using the URL bar. https://gitlab.gnome.org/GNOME/epiphany/issues/1109 1621998 1 mcatanzaro 2020-02-23 08:59:24 -0800 (In reply to Guilaume Ayoub from comment #0) > Pages are not drawn when: > > - hardware acceleration is enabled (it works without), Specifically, when hardware acceleration policy is always, right? The bug doesn't occur for on-demand? 1621999 2 guillaume.webkit 2020-02-23 09:00:37 -0800 > Specifically, when hardware acceleration policy is always, right? The bug > doesn't occur for on-demand? Exactly. 1639852 3 guillaume.webkit 2020-04-09 13:52:50 -0700 Disabling PSON in WebKitGTK with the patch provided in https://bugs.webkit.org/show_bug.cgi?id=210287 fixes the problem. (Using "always" for hardware acceleration gives really impressive results on my computer ♥.) 1639921 4 mcatanzaro 2020-04-09 15:34:13 -0700 Are you building with -DWPE_RENDERER=OFF? Or do you have libwpe etc. installed? 1639922 5 mcatanzaro 2020-04-09 15:35:28 -0700 Er I guess if my patch fixed the issue for you, then it's because you have it OFF. AC mode is totally busted right now unless WPE_RENDERER is enabled. These bugs are the same underlying issue; we just need to remember to test both issues to ensure they're both fixed by whatever final patch we come up with. 1640045 6 guillaume.webkit 2020-04-09 22:52:23 -0700 (In reply to Michael Catanzaro from comment #4) > Are you building with -DWPE_RENDERER=OFF? Or do you have libwpe etc. > installed? I do. > Er I guess if my patch fixed the issue for you, then it's because you have it OFF. Of course. > AC mode is totally busted right now unless WPE_RENDERER is enabled. These bugs are the same underlying issue; we just need to remember to test both issues to ensure they're both fixed by whatever final patch we come up with. I won’t forget ;). 1640146 7 396077 cgarcia 2020-04-10 06:27:23 -0700 Created attachment 396077 Patch 1640353 8 396077 mcatanzaro 2020-04-10 14:11:28 -0700 Comment on attachment 396077 Patch Nice! 1640535 9 guillaume.webkit 2020-04-11 07:37:20 -0700 It works well for me, thank you! 1640658 10 cgarcia 2020-04-12 02:27:47 -0700 Committed r259943: <https://trac.webkit.org/changeset/259943> 396077 2020-04-10 06:27:23 -0700 2020-04-10 14:11:28 -0700 Patch wk2-ac-always-pson.diff text/plain 1969 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYjAxOThhM2I3ZWYwLi5kMGJmNzc4YmU2MDYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTcgQEAKKzIwMjAtMDQtMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIFBhZ2UgaXMgbm90IGRyYXduIHdpdGggUFNPTiwgaGFy ZHdhcmUgYWNjZWxlcmF0aW9uIGFuZCBhZGRyZXNzIHR5cGVkIGluIFVSTCBiYXIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODA5MQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaGFwcGVucyBvbmx5 IHdoZW4gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgbW9kZSBwb2xpY3kgaXMgc2V0IHRvIGFsd2F5 cy4gSW4gdGhpcyBjYXNlLCB0aGUKKyAgICAgICAgYmluZFN1cmZhY2VUb1dlYlBhZ2Ugd2F5bGFu ZCBtZXNzYWdlIGlzIHJlY2VpdmVkIGJlZm9yZSB0aGUgV2ViUGFnZVByb3h5IGhhcyB1cGRhdGVk IHRoZSB3ZWIgcGFnZSBpZGVudGlmaWVyLiBXZQorICAgICAgICBzaG91bGQgYWx3YXlzIGNoZWNr IGlmIHRoZXJlJ3MgYSBwcm92aXNpb25hbCBwYWdlIGFuZCBnZXQgaXRzIHdlYiBwYWdlIGlkZW50 aWZpZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1dheWxhbmRDb21wb3NpdG9yLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2F5bGFuZENvbXBvc2l0b3I6OmJpbmRTdXJmYWNlVG9XZWJQYWdl KToKKwogMjAyMC0wNC0xMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS11bUFNPTl0gQ3Jhc2ggaW4gV2F5bGFuZENvbXBvc2l0b3I6OlN1 cmZhY2UgZGVzdHJ1Y3RvciB3aXRoIFVTRV9XUEVfUkVOREVSRVIgZGlzYWJsZWQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9XYXlsYW5kQ29tcG9zaXRvci5jcHAgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsvV2F5bGFuZENvbXBvc2l0b3IuY3BwCmluZGV4IDE4 ZmQ1YmE1OTMyYS4uYjM0ZDEzYjg2NWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9ndGsvV2F5bGFuZENvbXBvc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2d0ay9XYXlsYW5kQ29tcG9zaXRvci5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKIAogI2lmIFBM QVRGT1JNKFdBWUxBTkQpICYmIFVTRShFR0wpICYmICFVU0UoV1BFX1JFTkRFUkVSKQogCisjaW5j bHVkZSAiUHJvdmlzaW9uYWxQYWdlUHJveHkuaCIKICNpbmNsdWRlICJXZWJLaXRXYXlsYW5kU2Vy dmVyUHJvdG9jb2wuaCIKICNpbmNsdWRlIDxFR0wvZWdsLmg+CiAjaW5jbHVkZSA8RUdML2VnbGV4 dC5oPgpAQCAtNTU4LDcgKzU1OSw5IEBAIHZvaWQgV2F5bGFuZENvbXBvc2l0b3I6OmJpbmRTdXJm YWNlVG9XZWJQYWdlKFdheWxhbmRDb21wb3NpdG9yOjpTdXJmYWNlKiBzdXJmYWNlCiB7CiAgICAg V2ViUGFnZVByb3h5KiB3ZWJQYWdlID0gbnVsbHB0cjsKICAgICBmb3IgKGF1dG8qIHBhZ2UgOiBt X3BhZ2VNYXAua2V5cygpKSB7Ci0gICAgICAgIGlmIChwYWdlLT53ZWJQYWdlSUQoKSA9PSBwYWdl SUQpIHsKKyAgICAgICAgYXV0byogcHJvdmlzaW9uYWxQYWdlID0gcGFnZS0+cHJvdmlzaW9uYWxQ YWdlUHJveHkoKTsKKyAgICAgICAgYXV0byB3ZWJQYWdlSUQgPSBwcm92aXNpb25hbFBhZ2UgPyBw cm92aXNpb25hbFBhZ2UtPndlYlBhZ2VJRCgpIDogcGFnZS0+d2ViUGFnZUlEKCk7CisgICAgICAg IGlmICh3ZWJQYWdlSUQgPT0gcGFnZUlEKSB7CiAgICAgICAgICAgICB3ZWJQYWdlID0gcGFnZTsK ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9Cg==