208064 2020-02-21 10:36:00 -0800 [ews] Add build step to Validate ChangeLog for commit-queue 2020-03-19 15:07:18 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1621702 0 aakash_jain 2020-02-21 10:36:00 -0800 Add build step to Validate ChangeLog. This step would be required for commit-queue, to validate whether the ChangeLog looks fine (i.e. doesn't contains OOPS, the reviewer name in 'Reviewed by XYZ' is a valid reviewer). 1621705 1 391409 aakash_jain 2020-02-21 10:40:03 -0800 Created attachment 391409 Patch 1621706 2 aakash_jain 2020-02-21 10:41:05 -0800 Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/698 1621741 3 jbedard 2020-02-21 11:59:30 -0800 (In reply to Aakash Jain from comment #2) > Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/698 Do you have a successful example? 1621746 4 aakash_jain 2020-02-21 12:14:39 -0800 (In reply to Jonathan Bedard from comment #3) > Do you have a successful example? https://ews-build.webkit-uat.org/#/builders/26/builds/735 1621764 5 aakash_jain 2020-02-21 13:12:06 -0800 Committed r257157: <https://trac.webkit.org/changeset/257157> 1621765 6 webkit-bug-importer 2020-02-21 13:13:15 -0800 <rdar://problem/59679885> 1631864 7 aakash_jain 2020-03-19 15:07:18 -0700 This change seems to be working fine. e.g.: ChangeLog missing Unreviewed/Reviewed-by text: https://ews-build.webkit.org/#/builders/28/builds/64 ChangeLog containing OOPS: https://ews-build.webkit.org/#/builders/28/builds/52 391409 2020-02-21 10:40:03 -0800 2020-02-21 11:59:37 -0800 Patch bug-208064-20200221134002.patch text/plain 3131 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NzE0NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAyLTIxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBBZGQgYnVpbGQgc3RlcCB0byBWYWxpZGF0ZSBDaGFuZ2VMb2cg Zm9yIGNvbW1pdC1xdWV1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA4MDY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAg IChWYWxpZGF0ZUNoYW5nZUxvZ0FuZFJldmlld2VyKTogQnVpbGQgc3RlcCB0byB2YWxpZGF0ZSBD aGFuZ2VMb2cuCisgICAgICAgIChWYWxpZGF0ZUNoYW5nZUxvZ0FuZFJldmlld2VyLnN0YXJ0KToK KyAgICAgICAgKFZhbGlkYXRlQ2hhbmdlTG9nQW5kUmV2aWV3ZXIuZXZhbHVhdGVDb21tYW5kKTog SWYgdGhlIHZhbGlkYXRpb24gZmFpbHMsIGNvbW1lbnQgb24gYnVnIGFuZCBtYXJrIHBhdGNoIGFz IGNxLS4KKyAgICAgICAgKFNldENvbW1pdFF1ZXVlTWludXNGbGFnT25QYXRjaC5zdGFydCk6IEVu ZCB0aGUgYnVpbGQgKGFmdGVyIG1hcmtpbmcgdGhlIHBhdGNoIGNxLSkgaWYgYnVpbGRfZmluaXNo X3N1bW1hcnkgcHJvcGVydHkgaXMgc2V0LgorCiAyMDIwLTAyLTIxICBBYWthc2ggSmFpbiAgPGFh a2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzXSBBZGQgYnVpbGQgc3RlcCB0byBz ZXQgY3EtIGZsYWcgb24gYnVnemlsbGEgcGF0Y2gKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI1NzE0NykKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtNTgzLDEz ICs1ODMsNDcgQEAgY2xhc3MgVmFsaWRhdGVQYXRjaChidWlsZHN0ZXAuQnVpbGRTdGVwLAogICAg ICAgICByZXR1cm4gTm9uZQogCiAKK2NsYXNzIFZhbGlkYXRlQ2hhbmdlTG9nQW5kUmV2aWV3ZXIo c2hlbGwuU2hlbGxDb21tYW5kKToKKyAgICBuYW1lID0gJ3ZhbGlkYXRlLWNoYW5nZWxvZy1hbmQt cmV2aWV3ZXInCisgICAgZGVzY3JpcHRpb25Eb25lID0gWydWYWxpZGF0ZWQgQ2hhbmdlTG9nIGFu ZCBSZXZpZXdlciddCisgICAgY29tbWFuZCA9IFsncHl0aG9uJywgJ1Rvb2xzL1NjcmlwdHMvd2Vi a2l0LXBhdGNoJywgJ3ZhbGlkYXRlLWNoYW5nZWxvZycsICctLWNoZWNrLW9vcHMnLCAnLS1ub24t aW50ZXJhY3RpdmUnXQorICAgIGhhbHRPbkZhaWx1cmUgPSBGYWxzZQorICAgIGZsdW5rT25GYWls dXJlID0gVHJ1ZQorCisgICAgZGVmIF9faW5pdF9fKHNlbGYsICoqa3dhcmdzKToKKyAgICAgICAg c2hlbGwuU2hlbGxDb21tYW5kLl9faW5pdF9fKHNlbGYsIHRpbWVvdXQ9MyAqIDYwLCBsb2dFbnZp cm9uPUZhbHNlLCAqKmt3YXJncykKKworICAgIGRlZiBzdGFydChzZWxmKToKKyAgICAgICAgc2Vs Zi5sb2dfb2JzZXJ2ZXIgPSBsb2dvYnNlcnZlci5CdWZmZXJMb2dPYnNlcnZlcih3YW50U3RkZXJy PVRydWUpCisgICAgICAgIHNlbGYuYWRkTG9nT2JzZXJ2ZXIoJ3N0ZGlvJywgc2VsZi5sb2dfb2Jz ZXJ2ZXIpCisgICAgICAgIHJldHVybiBzaGVsbC5TaGVsbENvbW1hbmQuc3RhcnQoc2VsZikKKwor ICAgIGRlZiBnZXRSZXN1bHRTdW1tYXJ5KHNlbGYpOgorICAgICAgICBpZiBzZWxmLnJlc3VsdHMg IT0gU1VDQ0VTUzoKKyAgICAgICAgICAgIHJldHVybiB7dSdzdGVwJzogdSdDaGFuZ2VMb2cgdmFs aWRhdGlvbiBmYWlsZWQnfQorICAgICAgICByZXR1cm4gc2hlbGwuU2hlbGxDb21tYW5kLmdldFJl c3VsdFN1bW1hcnkoc2VsZikKKworICAgIGRlZiBldmFsdWF0ZUNvbW1hbmQoc2VsZiwgY21kKToK KyAgICAgICAgcmMgPSBzaGVsbC5TaGVsbENvbW1hbmQuZXZhbHVhdGVDb21tYW5kKHNlbGYsIGNt ZCkKKyAgICAgICAgaWYgcmMgPT0gRkFJTFVSRToKKyAgICAgICAgICAgIGxvZ190ZXh0ID0gc2Vs Zi5sb2dfb2JzZXJ2ZXIuZ2V0U3Rkb3V0KCkgKyBzZWxmLmxvZ19vYnNlcnZlci5nZXRTdGRlcnIo KQorICAgICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVnemlsbGFfY29tbWVudF90ZXh0Jywg bG9nX3RleHQpCisgICAgICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdidWlsZF9maW5pc2hfc3Vt bWFyeScsICdDaGFuZ2VMb2cgdmFsaWRhdGlvbiBmYWlsZWQnKQorICAgICAgICAgICAgc2VsZi5i dWlsZC5hZGRTdGVwc0FmdGVyQ3VycmVudFN0ZXAoW0NvbW1lbnRPbkJ1ZygpLCBTZXRDb21taXRR dWV1ZU1pbnVzRmxhZ09uUGF0Y2goKV0pCisgICAgICAgIHJldHVybiByYworCisKIGNsYXNzIFNl dENvbW1pdFF1ZXVlTWludXNGbGFnT25QYXRjaChidWlsZHN0ZXAuQnVpbGRTdGVwLCBCdWd6aWxs YU1peGluKToKICAgICBuYW1lID0gJ3NldC1jcS1taW51cy1mbGFnLW9uLXBhdGNoJwogCiAgICAg ZGVmIHN0YXJ0KHNlbGYpOgogICAgICAgICBwYXRjaF9pZCA9IHNlbGYuZ2V0UHJvcGVydHkoJ3Bh dGNoX2lkJywgJycpCisgICAgICAgIGJ1aWxkX2ZpbmlzaF9zdW1tYXJ5ID0gc2VsZi5nZXRQcm9w ZXJ0eSgnYnVpbGRfZmluaXNoX3N1bW1hcnknLCBOb25lKQorCiAgICAgICAgIHJjID0gc2VsZi5z ZXRfY3FfbWludXNfZmxhZ19vbl9wYXRjaChwYXRjaF9pZCkKICAgICAgICAgc2VsZi5maW5pc2hl ZChyYykKKyAgICAgICAgaWYgYnVpbGRfZmluaXNoX3N1bW1hcnk6CisgICAgICAgICAgICBzZWxm LmJ1aWxkLmJ1aWxkRmluaXNoZWQoW2J1aWxkX2ZpbmlzaF9zdW1tYXJ5XSwgRkFJTFVSRSkKICAg ICAgICAgcmV0dXJuIE5vbmUKIAogICAgIGRlZiBnZXRSZXN1bHRTdW1tYXJ5KHNlbGYpOgo=