208055 2020-02-21 07:49:37 -0800 REGRESSION (r257126): fast/frames/flattening/iframe-tiny.html is flaky failing 2020-02-24 16:40:20 -0800 1 1 1 Unclassified WebKit Frames WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jacob_uphoff zalan commit-queue simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer zalan oldest_to_newest 1621642 0 jacob_uphoff 2020-02-21 07:49:37 -0800 fast/frames/flattening/iframe-tiny.html This test started to flaky fail and was first seen on commit r256129. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fframes%2Fflattening%2Fiframe-tiny.html Diff: --- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/frames/flattening/iframe-tiny-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/frames/flattening/iframe-tiny-actual.txt @@ -13,8 +13,8 @@ PASS getComputedStyle(frame, 0).width is '7px' PASS getComputedStyle(frame, 0).height is '7px' testFrame3 -PASS getComputedStyle(frame, 0).width is '400px' -PASS getComputedStyle(frame, 0).height is '400px' +FAIL getComputedStyle(frame, 0).width should be 400px. Was 16px. +FAIL getComputedStyle(frame, 0).height should be 400px. Was 8px. testFrame4 PASS getComputedStyle(frame, 0).width is '0px' PASS getComputedStyle(frame, 0).height is '100px' @@ -34,11 +34,11 @@ PASS getComputedStyle(frame, 0).width is '300px' PASS getComputedStyle(frame, 0).height is '2px' testFrame10 -PASS getComputedStyle(frame, 0).width is '400px' -PASS getComputedStyle(frame, 0).height is '400px' +FAIL getComputedStyle(frame, 0).width should be 400px. Was 16px. +FAIL getComputedStyle(frame, 0).height should be 400px. Was 150px. testFrame11 -PASS getComputedStyle(frame, 0).width is '400px' -PASS getComputedStyle(frame, 0).height is '400px' +FAIL getComputedStyle(frame, 0).width should be 400px. Was 300px. +FAIL getComputedStyle(frame, 0).height should be 400px. Was 8px. PASS successfullyParsed is true TEST COMPLETE 1621643 1 webkit-bug-importer 2020-02-21 07:51:40 -0800 <rdar://problem/59668089> 1621911 2 ap 2020-02-22 16:50:38 -0800 Jacob's revision has a typo. The first time this happened was r257127, so this is almost certainly http://trac.webkit.org/r257126. Also, this is happening 100% on the GuardMalloc bot. 1621913 3 zalan 2020-02-22 16:54:22 -0800 Ok. It looks like some timing issue. Most likely it's missing some forced layout (since the test seemed to rely on an optional layout). 1622282 4 391569 zalan 2020-02-24 12:53:36 -0800 Created attachment 391569 Patch 1622370 5 391589 zalan 2020-02-24 15:49:38 -0800 Created attachment 391589 Patch 1622404 6 commit-queue 2020-02-24 16:39:45 -0800 The commit-queue encountered the following flaky tests while processing attachment 391589: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1622407 7 391589 commit-queue 2020-02-24 16:40:19 -0800 Comment on attachment 391589 Patch Clearing flags on attachment: 391589 Committed r257280: <https://trac.webkit.org/changeset/257280> 1622408 8 commit-queue 2020-02-24 16:40:20 -0800 All reviewed patches have been landed. Closing bug. 391569 2020-02-24 12:53:36 -0800 2020-02-24 15:49:36 -0800 Patch bug-208055-20200224125335.patch text/plain 1408 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MjM1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDY5YjcyYTg2Y2RlOTcyMDU3Zjgw ODVjZDFlOTgzOWFlODIzNDJlOC4uZWY2NzFlNDI5Y2ZkMTVmOGNiNmZjYWUxMzRjZGI2MjY3ZTk5 ZDYyMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAyLTI0ICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI1NzEyNik6IGZhc3QvZnJh bWVzL2ZsYXR0ZW5pbmcvaWZyYW1lLXRpbnkuaHRtbCBpcyBmbGFreSBmYWlsaW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgwNTUKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzU5NjY4MDg5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorICAgIAorICAgICAgICBUaGlzIHRlc3QgcmVsaWVzIG9uIGEgMG1zIHRpbWVvdXQg YW5kIGZhaWxzIHdoZW4gbGF5b3V0IGlzIGRlbGF5ZWQuCisKKyAgICAgICAgKiBmYXN0L2ZyYW1l cy9mbGF0dGVuaW5nL2lmcmFtZS10aW55Lmh0bWw6CisKIDIwMjAtMDItMjQgIFdlbnNvbiBIc2ll aCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgZmFzdC9mb3Jtcy9pb3MvY2xp Y2stc2hvdWxkLW5vdC1zdXBwcmVzcy1taXNzcGVsbGluZy5odG1sIGZhaWxzIG9uIGlPUyAxMy40 IGJldGEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZsYXR0ZW5pbmcvaWZy YW1lLXRpbnkuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZsYXR0ZW5pbmcvaWZyYW1l LXRpbnkuaHRtbAppbmRleCA4OTZiZDlmZTgxMGMxMmVkN2E1MjVmYjUxMDQ2MjJlMmUwZmM3MzAw Li4zZDkzNjhiZWVjNTIyNjVlYTVkNGFlOTI1ZDJiNDc4MzEzYTdkZTk0IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9mbGF0dGVuaW5nL2lmcmFtZS10aW55Lmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZmxhdHRlbmluZy9pZnJhbWUtdGlueS5odG1sCkBAIC0x OCw2ICsxOCw3IEBAIGZ1bmN0aW9uIGNoZWNrUmVzdWx0KGZyYW1lTmFtZSwgZXhwZWN0ZWRXaWR0 aCwgZXhwZWN0ZWRIZWlnaHQpCiAKIGZ1bmN0aW9uIHRlc3QoKQogeworICAgIGRvY3VtZW50LmJv ZHkub2Zmc2V0SGVpZ2h0OwogICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CiAgICAgICAgIGNo ZWNrUmVzdWx0KCJ0ZXN0RnJhbWUwIiwgIicwcHgnIiwgIicwcHgnIik7CiAgICAgICAgIGNoZWNr UmVzdWx0KCJ0ZXN0RnJhbWUxIiwgIicxcHgnIiwgIicxcHgnIik7Cg== 391589 2020-02-24 15:49:38 -0800 2020-02-24 16:40:19 -0800 Patch bug-208055-20200224154937.patch text/plain 2153 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MjM1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDY5YjcyYTg2Y2RlOTcyMDU3Zjgw ODVjZDFlOTgzOWFlODIzNDJlOC4uODBhMjg3NWFkOTE1MmMxOGUyMmMzMTRjZmJiOTkwOGZmYzg3 NzU1NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAyLTI0ICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI1NzEyNik6IGZhc3QvZnJh bWVzL2ZsYXR0ZW5pbmcvaWZyYW1lLXRpbnkuaHRtbCBpcyBmbGFreSBmYWlsaW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgwNTUKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzU5NjY4MDg5PgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZy YXNlci4KKworICAgICAgICBJbiB0aGUgZnJhbWUgZmxhdHRlbmluZyBjb250ZXh0IHdoZW4gb3B0 aW9uYWwgbGF5b3V0IGlzIGRlbGF5ZWQsIGdldENvbXB1dGVkU3R5bGUoKSBtaWdodCByZXR1cm4K KyAgICAgICAgdGhlIHVuLWZsYXR0ZW5lZCBnZW9tZXRyeSB1bmxlc3MgdGhlIGlmcmFtZSBlbGVt ZW50IGlzIGZvcmNlZCB0byBnZXQgbGFpZCBvdXQuCisgICAgICAgIDEuIG1haW4gZnJhbWUgY29u dGVudCBpcyBsb2FkZWQgYW5kIGxhaWQgb3V0IC0+IGlmIHRoZSBpZnJhbWUgY29udGVudCBpcyBu b3QgcmVhZHkgeWV0LCB3ZSBkb24ndCBpbml0aWF0ZSBpZnJhbWUgZmxhdHRlbmluZy4KKyAgICAg ICAgMi4gaWZyYW1lIGNvbnRlbnQgaXMgcmVhZHkgLT4gbGF5b3V0IGlzIHNjaGVkdWxlZC4KKyAg ICAgICAgMy4gZ2V0Q29tcHV0ZWRTdHlsZSgpIGlzIGNhbGxlZCB3aGljaCBpbml0aWF0ZXMgYSBz dHlsZSB1cGRhdGUvbGF5b3V0IG9uIHRoZSBtYWluIGZyYW1lLAorICAgICAgICAgICBidXQgb25s eSBkaXJ0eSBib3hlcyB0cmlnZ2VyIGxheW91dCAodGhlIGlmcmFtZSByZW5kZXJlciBpdHNlbGYg aXMgbm90IGRpcnR5IDwtIHRoaXMgaXMgd2hlcmUgZnJhbWUgZmxhdHRlbmluZyBmYWlsczogd2Vi a2l0Lm9yZy9iLzIwODE2MSkKKyAgICAgICAgNC4gZ2V0Q29tcHV0ZWRTdHlsZSgpIHJldHVybnMg d2l0aCB0aGUgInN0YWxlIiBnZW9tZXRyeS4KKworICAgICAgICAqIGZhc3QvZnJhbWVzL2ZsYXR0 ZW5pbmcvaWZyYW1lLXRpbnkuaHRtbDoKKwogMjAyMC0wMi0yNCAgV2Vuc29uIEhzaWVoICA8d2Vu c29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBmYXN0L2Zvcm1zL2lvcy9jbGljay1zaG91 bGQtbm90LXN1cHByZXNzLW1pc3NwZWxsaW5nLmh0bWwgZmFpbHMgb24gaU9TIDEzLjQgYmV0YQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZmxhdHRlbmluZy9pZnJhbWUtdGlu eS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZmxhdHRlbmluZy9pZnJhbWUtdGlueS5o dG1sCmluZGV4IDg5NmJkOWZlODEwYzEyZWQ3YTUyNWZiNTEwNDYyMmUyZTBmYzczMDAuLjg4ZWUx NGNjNmIwMmIxMDZlMmYxM2E0OGU2YmEzNjRiOWFmYTk0ZjEgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2Zhc3QvZnJhbWVzL2ZsYXR0ZW5pbmcvaWZyYW1lLXRpbnkuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2ZyYW1lcy9mbGF0dGVuaW5nL2lmcmFtZS10aW55Lmh0bWwKQEAgLTEyLDYgKzEy LDggQEAgZnVuY3Rpb24gY2hlY2tSZXN1bHQoZnJhbWVOYW1lLCBleHBlY3RlZFdpZHRoLCBleHBl Y3RlZEhlaWdodCkKIHsKICAgICBmcmFtZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKGZyYW1l TmFtZSk7CiAgICAgZGVidWcoZnJhbWVOYW1lKTsKKyAgICAvLyBGb3JjZSBsYXlvdXQgb24gdGhl IHN1YmZyYW1lLiBTZWUgd2Via2l0Lm9yZy9iLzIwODE2MS4KKyAgICBmcmFtZS5zdHlsZS53aGl0 ZVNwYWNlID0gInByZS1saW5lIjsKICAgICBzaG91bGRCZSgiZ2V0Q29tcHV0ZWRTdHlsZShmcmFt ZSwgMCkud2lkdGgiLCBleHBlY3RlZFdpZHRoKTsKICAgICBzaG91bGRCZSgiZ2V0Q29tcHV0ZWRT dHlsZShmcmFtZSwgMCkuaGVpZ2h0IiwgZXhwZWN0ZWRIZWlnaHQpOwogfQo=