208027 2020-02-20 13:02:54 -0800 WebIDBServer resume should return early if suspend does not happen 2020-02-20 16:20:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen beidson cdumez commit-queue ggaren webkit-bug-importer oldest_to_newest 1621373 0 sihui_liu 2020-02-20 13:02:54 -0800 <rdar://problem/59617654> 1621380 1 391323 sihui_liu 2020-02-20 13:06:20 -0800 Created attachment 391323 Patch 1621442 2 391323 ggaren 2020-02-20 15:17:53 -0800 Comment on attachment 391323 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391323&action=review r=me > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp:106 > + // Lock is not held by suspend. I'm not sure this comment adds information. I guess this change was motivated by a crash unlocking. But it will always be true that we do not want to resume if we did not suspend, regardless of what logic or behavior follows this check; the check is not particular to the lock. 1621448 3 391342 sihui_liu 2020-02-20 15:32:56 -0800 Created attachment 391342 Patch for landing 1621476 4 391342 commit-queue 2020-02-20 16:20:16 -0800 Comment on attachment 391342 Patch for landing Clearing flags on attachment: 391342 Committed r257103: <https://trac.webkit.org/changeset/257103> 1621477 5 commit-queue 2020-02-20 16:20:17 -0800 All reviewed patches have been landed. Closing bug. 391323 2020-02-20 13:06:20 -0800 2020-02-20 15:32:54 -0800 Patch bug-208027-20200220130619.patch text/plain 1495 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2ODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIyYzJjMjI0MDkxYjAxOTg4 MTZiZjg1MzI4NWUzZTA1NTlkMzViOTEuLjBhYmI4YjhjNGM1MmUzMzE2ZTY1MTFiY2VjZjAwZDJj MDNmOGEyNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDItMjAgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViSURCU2VydmVyIHJlc3VtZSBz aG91bGQgcmV0dXJuIGVhcmx5IGlmIHN1c3BlbmQgZG9lcyBub3QgaGFwcGVuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgwMjcKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzU5NjE3NjU0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlIHNob3VsZCBub3QgdHJ5IHJlbGVhc2luZyBhIGxvY2sgdGhhdCBp cyBub3QgaGVsZC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL0luZGV4ZWREQi9XZWJJREJT ZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJTZXJ2ZXI6OnJlc3VtZSk6CisKIDIw MjAtMDItMTggIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAg IE1vdmUgW1VJRGV2aWNlIGN1cnJlbnREZXZpY2VdIGNhbGxzIHRvIFVJIHByb2Nlc3MKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvSW5kZXhlZERCL1dlYklEQlNlcnZl ci5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0luZGV4ZWREQi9XZWJJREJTZXJ2 ZXIuY3BwCmluZGV4IDVmM2QzMDVkMWNkOTg5NDdlMGRkNDVkZjU5NGQ1OWQ3NDEwOGUwNGUuLjVh MzJjMTcyMWY5ODU3OTJmMTZmNGY4ZTMyYjEyOWQxYjIzZTYxZjAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvSW5kZXhlZERCL1dlYklEQlNlcnZlci5jcHAKKysrIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9JbmRleGVkREIvV2ViSURCU2VydmVyLmNwcApA QCAtMTAyLDggKzEwMiwxMCBAQCB2b2lkIFdlYklEQlNlcnZlcjo6c3VzcGVuZChTaG91bGRGb3Jj ZVN0b3Agc2hvdWxkRm9yY2VTdG9wKQogdm9pZCBXZWJJREJTZXJ2ZXI6OnJlc3VtZSgpCiB7CiAg ICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKLSAgICBBU1NFUlQobV9pc1N1c3BlbmRlZCk7 Ci0gICAgQVNTRVJUKG1fc2VydmVyLT5sb2NrKCkuaXNIZWxkKCkpOworCisgICAgLy8gTG9jayBp cyBub3QgaGVsZCBieSBzdXNwZW5kLgorICAgIGlmICghbV9pc1N1c3BlbmRlZCkKKyAgICAgICAg cmV0dXJuOwogCiAgICAgbV9pc1N1c3BlbmRlZCA9IGZhbHNlOwogICAgIG1fc2VydmVyLT5sb2Nr KCkudW5sb2NrKCk7Cg== 391342 2020-02-20 15:32:56 -0800 2020-02-20 16:20:16 -0800 Patch for landing bug-208027-20200220153255.patch text/plain 1457 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2ODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIyYzJjMjI0MDkxYjAxOTg4 MTZiZjg1MzI4NWUzZTA1NTlkMzViOTEuLmJkNmVlNGJiNDJmODgzNDYyNTUyYmFlZGYxNjhiNTVh ZTU2ZmJhOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDItMjAgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViSURCU2VydmVyIHJlc3VtZSBz aG91bGQgcmV0dXJuIGVhcmx5IGlmIHN1c3BlbmQgZG9lcyBub3QgaGFwcGVuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgwMjcKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzU5NjE3NjU0PgorCisgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdh cmVuLgorCisgICAgICAgIFdlIHNob3VsZCBub3QgdHJ5IHJlbGVhc2luZyBhIGxvY2sgdGhhdCBp cyBub3QgaGVsZC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL0luZGV4ZWREQi9XZWJJREJT ZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJTZXJ2ZXI6OnJlc3VtZSk6CisKIDIw MjAtMDItMTggIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAg IE1vdmUgW1VJRGV2aWNlIGN1cnJlbnREZXZpY2VdIGNhbGxzIHRvIFVJIHByb2Nlc3MKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvSW5kZXhlZERCL1dlYklEQlNlcnZl ci5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0luZGV4ZWREQi9XZWJJREJTZXJ2 ZXIuY3BwCmluZGV4IDVmM2QzMDVkMWNkOTg5NDdlMGRkNDVkZjU5NGQ1OWQ3NDEwOGUwNGUuLmM5 ZmM3N2Q0ZDlhMzIzODQ5YzE1Njg5OWZiN2FlMDhmMWY1ZGRmODMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvSW5kZXhlZERCL1dlYklEQlNlcnZlci5jcHAKKysrIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9JbmRleGVkREIvV2ViSURCU2VydmVyLmNwcApA QCAtMTAyLDggKzEwMiw5IEBAIHZvaWQgV2ViSURCU2VydmVyOjpzdXNwZW5kKFNob3VsZEZvcmNl U3RvcCBzaG91bGRGb3JjZVN0b3ApCiB2b2lkIFdlYklEQlNlcnZlcjo6cmVzdW1lKCkKIHsKICAg ICBBU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOwotICAgIEFTU0VSVChtX2lzU3VzcGVuZGVkKTsK LSAgICBBU1NFUlQobV9zZXJ2ZXItPmxvY2soKS5pc0hlbGQoKSk7CisKKyAgICBpZiAoIW1faXNT dXNwZW5kZWQpCisgICAgICAgIHJldHVybjsKIAogICAgIG1faXNTdXNwZW5kZWQgPSBmYWxzZTsK ICAgICBtX3NlcnZlci0+bG9jaygpLnVubG9jaygpOwo=